August 2008 - Wine-devel - list.winehq.org

Re: [3/9] WineD3D: Beware of the frontbuffer coordinate system difference
by H. Verbeet 03 Aug '08

03 Aug '08

2008/8/3 Stefan Dösinger <stefan(a)codeweavers.com>: > + src_rect->x1 -= offset.x; dst_rect->x2 -=offset.x; Why are you modifying dst_rect here?

2 1

Re: fusion: Use proper function pointer
by James Hawkins 03 Aug '08

03 Aug '08

On Sat, Aug 2, 2008 at 4:09 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > fusion: Use proper function pointer. > > diff --git a/dlls/fusion/fusion.c b/dlls/fusion/fusion.c > index ac01cf4..637346c 100644 > --- a/dlls/fusion/fusion.c > +++ b/dlls/fusion/fusion.c > @@ -32,6 +32,9 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(fusion); > > +typedef HRESULT (WINAPI *PFNGETCORVERSION)(LPWSTR pbuffer, DWORD cchBuffer, > + DWORD *dwLength); > + > /****************************************************************** > * ClearDownloadCache (FUSION.@) > */ > @@ -89,20 +92,18 @@ HRESULT WINAPI GetAssemblyIdentityFromFile(LPCWSTR pwzFilePath, REFIID riid, > return E_NOTIMPL; > } > > -static HRESULT (WINAPI *pGetCORVersion)(LPWSTR pbuffer, DWORD cchBuffer, > - DWORD *dwLength); > - There's nothing wrong with this. We use this type of function pointer all over the code base. -- James Hawkins

3 2

Re: msxml3: off-by-one fix for Qname allocation
by Piotr Caban 03 Aug '08

03 Aug '08

Hi Joris, SysAllocStringLen allocates additional space for NULL byte. It's not needed to change string size. On the other hand QNames should be created differently. I will send patches changing it soon. Regards, Piotr

1 0

re: xinput implementation
by Dan Kegel 03 Aug '08

03 Aug '08

chourmovs wrote: > I'd like to participate to wine improvement instead of > always requesting for new features > > ... xinput support lack for new games and its > implementation is maybe not the hardest thing to do Please start by writing conformance tests. See http://www.winehq.org/site/docs/winedev-guide/testing - Dan

3 2

Re: ntdll: import dll from dir of referring dll if not found instandard locations
by Dmitry Timoshkov 03 Aug '08

03 Aug '08

"Hongbo Ni" <hongbo(a)njstar.com> wrote: > This patch fixes bug 14699. It should fix all failed applications > which try to load a dll from specific folder, and the dll is link > another dll in the same folder. Please add a test case for this behaviour to confirm that your patch is doing a correct thing. -- Dmitry.

2 1

Re: [2/2] mlang/tests: add test for fnIMLangFontLink_GetCharCodePages
by Dmitry Timoshkov 03 Aug '08

03 Aug '08

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > + /* Tests for GetCharCodePages */ > + /* Latin 1 */ > + ok(IMLangFontLink_GetCharCodePages(iMLFL, 'd', &dwCodePages) == S_OK, > + "IMLangFontLink_GetCharCodePages failed\n"); > + ok(dwCodePages == 2032127, "Incorrect CodePages returned (%i)\n", dwCodePages); > + > + /* Cyrillic (Japanese, Simplified Chinese and Korean are also > + include these symbols) */ > + ok(IMLangFontLink_GetCharCodePages(iMLFL, 0x0436, &dwCodePages) == S_OK, > + "IMLangFontLink_GetCharCodePages failed\n"); > + ok(dwCodePages == 917508, "Incorrect CodePages returned (%i)\n", dwCodePages); > + > + /* Japanese */ > + ok(IMLangFontLink_GetCharCodePages(iMLFL, 0xff6f, &dwCodePages) == S_OK, > + "IMLangFontLink_GetCharCodePages failed\n"); > + ok(dwCodePages == 131072, "Incorrect CodePages returned (%i)\n", dwCodePages); Please use symbolic names for code pages bit field. -- Dmitry.

1 0

rsaenh: Test and correct the maximum allowable salt length
by Louis. Lenders 02 Aug '08

02 Aug '08

Usually i don't feel the need to respond to messages on wine-devel, but now i do: > What in the hell does this patch do? Why is it needed? What does it > fix/implement? Doees this change affect any Bugzilla issues? Where is > the Changelog? > This is what I have been trying to get you to do. I have no idea what > you are up to and I have NO access to IRC or other alternate forms of > messaging/communications other than this mailing list. I haven't got a clue what the patch is all about either, but if i'd wanted to know i would just drop a friendly note, asking some more info. As long as i've followed wine's development i've seen Juan as very helpful and main contributor to wine, so i'm a bit surprised about your unfriendly reaction to this patch.... __________________________________________________________ Not happy with your email address?. Get the one you really want - millions of new email addresses available now at Yahoo! http://uk.docs.yahoo.com/ymail/new.html

1 0

World of Warcraft's Current Perforamnce Rating
by Jarred Sumner 02 Aug '08

02 Aug '08

Dear Wine Dev's, It seems that as of wine 1.1.0 and later, Almost Every Game's performance that I play on linux has vastly improved. Those games are: - World of Warcraft - City of Heroes - Command & Conquer 3 Tiberium Wars World of Warcraft's Performance has reached higher levels than Windows XP Professional Service Pack 3. It runs 85 FPS whereas on Windows it runs 75fps averagely City of Heroes runs the same on Windows as on Linux Command & Conquer 3 Tiberium Wars Runs a little better due to the fact that there is no anti-aliasing (With the patches provided on the appdb) Great Job with this wine development team! I have tested these games on the following distrobutions: Arch CORE Ubuntu 8.04.1 & 8.04 Slackware 12.1 Thank You for making gaming on Linux Playable! Sincerely, Jarrhed

1 0

Re: rsaenh: Test and correct the maximum allowable salt length
by James McKenzie 02 Aug '08

02 Aug '08

Juan Lang wrote: > Inspired by a patch by Karsten Elfenbein. > Who is this and why is this so important? > --Juan > Per: http://winehq.org/site/sending_patches What in the hell does this patch do? Why is it needed? What does it fix/implement? Doees this change affect any Bugzilla issues? Where is the Changelog? This is what I have been trying to get you to do. I have no idea what you are up to and I have NO access to IRC or other alternate forms of messaging/communications other than this mailing list. Let's try to do things better in the future. James McKenzie

2 1

Re: kernal32: change if...if to if...'else if' in get_module_path_end()
by Jacek Caban 02 Aug '08

02 Aug '08

Hongbo Ni wrote: > If '\\' is found, there is no point to find '/'. > There is, think about path like c:\dir1\dir2/file.dll Jacek

1 0