August 2008 - Wine-devel - list.winehq.org

Re: [Gdiplus] Try harder to get a monospace font
by Vitaly Lipatov 01 Aug '08

01 Aug '08

В сообщении от 1 августа 2008 Adam Petaccia написал(a): > + * If Courier New is not found, the replacement font Liberation Mono is > used. */ Why do not use font replacement rules in the registry? I think it is more common way to subst Liberation fonts instead proprietary one. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: crypt32(1/3): Use ReadFile rather than a memory-mapped file to check the type of a file
by Alexandre Julliard 01 Aug '08

01 Aug '08

"Juan Lang" <juan.lang(a)gmail.com> writes: > From 064365f26630c76546a6c8bedc1e99d47b74563d Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Thu, 31 Jul 2008 09:08:09 -0700 > Subject: [PATCH] Use ReadFile rather than a memory-mapped file to check the type of a file This doesn't work here: ../../../tools/runtest -q -P wine -M wintrust.dll -T ../../.. -p wintrust_test.exe.so softpub.c && touch softpub.ok softpub.c:449: Test failed: expected TRUST_E_NOSIGNATURE, got 800b0003 make: *** [softpub.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] shell32: Add a test for FindExecutableA.
by Alexandre Julliard 01 Aug '08

01 Aug '08

"Lei Zhang" <thestig(a)google.com> writes: > + { > + char expand[MAX_PATH]; > + strcpy(command, "foobar"); > + strcpy(filename, "foo.msi"); > + file = CreateFileA(filename, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); > + ok(file != INVALID_HANDLE_VALUE, "Failure to open file %s\n", filename); > + CloseHandle(file); > + > + ok(ExpandEnvironmentStringsA("\%systemroot\%\\system32\\msiexec.exe", expand, MAX_PATH) != 0, "ExpandEnvironmentStringsA failed\n"); Again, please don't hardcode system32, use GetSystemDirectory instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9: Implementation of D3DXGetPixelShaderProfile 1/2 try 3
by Alexandre Julliard 01 Aug '08

01 Aug '08

Luis Busquets <luis.busquets(a)ilidium.com> writes: > + case D3DPS_VERSION(2, 0): > + if ((caps.PS20Caps.NumTemps>=22) && > + (caps.PS20Caps.Caps&D3DPS20CAPS_ARBITRARYSWIZZLE) && > + (caps.PS20Caps.Caps&D3DPS20CAPS_GRADIENTINSTRUCTIONS) && > + (caps.PS20Caps.Caps&D3DPS20CAPS_PREDICATION) && > + (caps.PS20Caps.Caps&D3DPS20CAPS_NODEPENDENTREADLIMIT) && > + (caps.PS20Caps.Caps&D3DPS20CAPS_NOTEXINSTRUCTIONLIMIT)) > + { > + return "ps_2_a"; > + } > + if ((caps.PS20Caps.NumTemps>=32) && > + (caps.PS20Caps.Caps&D3DPS20CAPS_NOTEXINSTRUCTIONLIMIT)) > + { > + return "ps_2_b"; > + } > + return "ps_2_0"; I'm usually tolerant of strange identation styles, but that's not even indentation at all. Can you please fix this to use a more commonly accepted format? -- Alexandre Julliard julliard(a)winehq.org

1 0