September 2008 - Wine-devel

Re: imm: Don't crash in ImmConfigureIME when dwMode is IME_CONFIG_REGISTERWORD and lpData is NULL (resend)
by Aric Stewart 18 Sep '08

18 Sep '08

Humm, according to MSDN: "If dwMode is set to IME_CONFIG_REGISTERWORD, this parameter must indicate a REGISTERWORD structure." If windows does not crash in this case, then maybe it would involve checking for the non-presence of the parameter and returning the correct error. So it looks like your fix is not quite correct. -aric Juan Lang wrote: > Hi, > anything wrong with this one? > --Juan > > > ------------------------------------------------------------------------ > >

2 1

Patchwatcher problems
by Andrew Fenn 18 Sep '08

18 Sep '08

Hi, I just submitted a patch to wine patches (Started implementing the xinput library for xbox 360 joystick support ) and I believe patch watcher failed for a few reasons. 1) Although it applied my patch it didn't build it as ./tools/make_makefiles isn't called so it isn't built? 2) Patch watcher seems to fail because of another patch, perhaps the latest known good build should be tested if the patch fails and then compared with the first failed attempt? Regards, Andrew

1 0

Re: PrintDlgEx [4/7]: Implement hDevMode and hDevNames on output.
by Juan Lang 18 Sep '08

18 Sep '08

Hi Gal, + WORD locks; + if ((locks = (GlobalFlags(lppd->hDevMode) & GMEM_LOCKCOUNT))) { + WARN("hDevMode has %d locks on it. Unlocking it now\n", locks); + while(locks--) { + GlobalUnlock(lppd->hDevMode); + TRACE("Now got %d locks\n", locks); This looks funny. The loop may have a race condition if someone else is locking/unlocking it. The following would be simpler, and more importantly, more likely to be correct: WORD locks; while ((locks = (GlobalFlags(lppd->hDevMode) & GMEM_LOCKCOUNT))) { GlobalUnlock(lppd->hDevMode); TRACE("Now got %d locks\n", locks); } The same comment applies to unlocking hDevNames. --Juan

1 0

Re: d3dx9: Add d3dx9effect.h
by Henri Verbeet 18 Sep '08

18 Sep '08

2008/9/18 David Adam <david.adam.cnrs(a)gmail.com>: > Hello, > > > + // Pool > > C++ comment is forbidden > 2008/9/18 Busquets Pérez Luis C. <luiscar2001(a)yahoo.es>: > + // Selecting and setting a technique ... > + // Using current technique ... > + // Managing D3D Device ... > + // Logging device calls ... > + // Parameter blocks ... > + // Cloning ... > + // Fast path for setting variables directly in ID3DXEffect Actually, you shouldn't copy those from the Microsoft header in the first place. > +DEFINE_GUID( IID_ID3DXEffect, > +0xb589b04a, 0x293d, 0x4516, 0xaf, 0xb, 0x3d, 0x7d, 0xbc, 0xf5, 0xac, 0x54); That's interesting though, my headers have "0xf6ceb4b3, 0x4e4c, 0x40dd, 0xb8, 0x83, 0x8d, 0x8d, 0xe5, 0xea, 0xc, 0xd5" as the GUID for IID_ID3DXEffect.

1 0

howto fix bug 13462
by Louis. Lenders 18 Sep '08

18 Sep '08

Hi, we've been discussing in bug 13462 howto fix that bug, but in short i think we lack knowledge of how this should properly be fixed, and Erich suggested to take this to wine-devel. I did some testing and this is a major bug, preventing the following apps from working: CDBurner XP, XML Notepad2007, Nasa WorldWind, FX_Composer(nvidia), Ninja Trader and probably a lot more .net applications. I fixed up a patch here http://bugs.winehq.org/attachment.cgi?id=15775, that lets the applications start fine, but i haven't got a clue if it's correct, and Erich said it probably isn't correct, so my question is: Does anyone of the developers (on ole32) have suggestions how to fix this bug properly? More info at http://bugs.winehq.org/show_bug.cgi?id=13462

3 4

Re: ntoskrnl: Implement server side of get_device
by Vitaliy Margolen 18 Sep '08

18 Sep '08

Peter Dons Tychsen wrote: > Implement server side of get_device to complete the > IoGetDeviceObjectPointer() function. > > /pedro My first question: what will you do with that pointer if that driver is loaded in the separate instance of ntoskrnl? Driver that calls IoGetDeviceObjectPointer will most likely try to dereference the pointer it got back. > +/* locate a device */ > +DECL_HANDLER(get_device) > +{ > + struct unicode_str name; > + get_req_unicode_str( &name ); > + > + /* lookup the device */ > + struct device *device = open_object_dir(NULL, &name, 0, &device_ops); > + if(!device) > + { > + return; > + } > + > + /* fill reply */ > + reply->handle = alloc_handle(current->process, device, req->access, 0);.... > + reply->user_ptr = device->user_ptr; > + You leaking reference to device here. Need release_object( device ); In your patch please include changes to server/protocol.def only and not any other automatically generated files. Make it a separate commit in your tree and just don't send it to wine-patches. Vitaliy

2 3

Re: user32: Stub for LockWorkStation (try 3)
by James Mckenzie 18 Sep '08

18 Sep '08

Paul: I'm glad you removed this 'feature' as it would not work at all with Wine on a Mac system. James Mckenzie -----Original Message----- >From: Paul Chitescu <paulc(a)voip.null.ro> >Sent: Sep 17, 2008 8:12 AM >To: Wine Patches <wine-patches(a)winehq.org> >Subject: user32: Stub for LockWorkStation (try 3) > >Changelog: > user32: Stub for LockWorkStation > >Please do not ask for an implementation based on xdg-screensaver as Alexandre >will not accept it. Sorry, Steven.

2 1

Re: d3dx9: Add d3dx9effect.h
by Henri Verbeet 17 Sep '08

17 Sep '08

2008/9/17 Busquets Pérez Luis C. <luiscar2001(a)yahoo.es>: > b0VIM 7.1....... > ÿeÑH..M.áL..root > ................ > ................ > ....localhost.lo > caldomain....... > ............/win > e-git/0001--modi > fied-include-d3d > x9.h.patch...... > ................ That's probably not what you meant to attach. Also, it's bad practice to work as root.

1 0

Re: [1/5] wined3d: Clarify a comment
by Henri Verbeet 17 Sep '08

17 Sep '08

Ignore this set, I missed an issue with volumes between the 2nd and 3rd patch.

1 0

wineserver assertion failure
by Dan Kegel 17 Sep '08

17 Sep '08

Hrm. Saw this after trying the 'nytimes' crash on Google Chrome with yesterday's wine: wineserver: object.c:277: release_object: Assertion `obj->refcount' failed. If it happens again, I'll report more...

2 1