September 2008 - Wine-devel

Patchwatcher should ignore AppDB patches
by Alexander Nicolaysen Sørnes 15 Sep '08

15 Sep '08

I just sent a patch for the AppDB, and was told it didn't apply to Wine. That was never the intention, of course. Perhaps it can ignore mails with [AppDB] in the subject line, or patches containing .php files? Alexander N. Sørnes

5 5

Re: kernel32: Implemented GetSystemTimes
by Rob Shearman 15 Sep '08

15 Sep '08

2008/9/14 Martin Bailey <martin(a)pcalpha.com>: > +VOID WINAPI GetSystemTimes( > + LPFILETIME lpIdleTime, > + LPFILETIME lpKernelTime, > + LPFILETIME lpUserTime) > +{ > + struct tms tms; > + times(&tms); > + /* FIXME: Calculate based on Idle process time > + if (lpIdleTime) > + TIME_ClockTimeToFileTime(tms.tms_utime+tms.tms_stime,lpIdleTime); > + */ You still have to set lpIdleTime to something, even if it isn't implemented yet, as applications will expect the value to be initialised. -- Rob Shearman

1 0

Re: winemenubuilder: eliminate wineshelllink (try 4)
by Alexandre Julliard 15 Sep '08

15 Sep '08

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > + char dir_file_name[MAX_PATH]; > + struct stat st; > + name[i] = 0; > + fprintf(tempfile, " <Menu>\n"); > + fprintf(tempfile, " <Name>%s%s</Name>\n", count ? "" : "wine-", name); > + fprintf(tempfile, " <Directory>%s%s.directory</Directory>\n", count ? "" : "wine-", name); > + snprintf(dir_file_name, sizeof(dir_file_name), "%s/desktop-directories/%s%s.directory", > + xdg_data_dir, count ? "" : "wine-", name); You still have a MAX_PATH buffer here for a Unix file name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32[3/3]: VT_USERDEFINED records are passed by value (with testcase, fixes bug #14639)
by Alexandre Julliard 15 Sep '08

15 Sep '08

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > +const MYSTRUCT MYSTRUCT_BYVAL = {0x12345678, 0xdeadbeef98765432ULL}; > +const MYSTRUCT MYSTRUCT_BYPTR = {0x91827364, 0x8877665544332211ULL}; > +const MYSTRUCT MYSTRUCT_ARRAY[5] = { > + {0x1a1b1c1d, 0x1e1f101112131415ULL}, > + {0x2a2b2c2d, 0x2e2f202122232425ULL}, > + {0x3a3b3c3d, 0x3e3f303132333435ULL}, > + {0x4a4b4c4d, 0x4e4f404142434445ULL}, > + {0x5a5b5c5d, 0x5e5f505152535455ULL}, > +}; long long constants are not portable, please avoid them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shlwapi: Implement SHSendMessageBroadcastW
by Dmitry Timoshkov 15 Sep '08

15 Sep '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > inetcpl crash, when setting a new Homepage. > (need URLSubRegQueryA and ParseURLFromOutsideSourceW) > > MSDN documented SHSendMessageBroadcast to be the same as > SendMessage(HWND_BROADCAST,...) Why not implement SHSendMessageBroadcastA at the same time? -- Dmitry.

1 0

comctl32: Fix a failing test for some platforms
by Nicolas Le Cam 15 Sep '08

15 Sep '08

Hi James, This monthcal test fails on my win2k box (w2k-sp4-fr) before and after your patch. I did search other similar failure where WM_QUERYNEWPALETTE comes right after the WM_CREATE message but can't find one. So I assume your patch was to fix the failure on my box. But in my case the WM_QUERYNEWPALETTE comes between the two WM_WINDOWPOSCHANGING message. I was just about to send a patch to fix this just moving your new line a little bit down in the sequence but I prefer to be sure. If there is platforms where WM_QUERYNEWPALETTE comes just after the WM_CREATE message I can leave it here and add a new optional one between the two WM_WINDOWPOSCHANGING messages, it won't hurt. regards, Nicolas

2 4

Re: kernel32: fix PROFILE_Load to handle mac line endings (try 2)
by Paul Vriens 14 Sep '08

14 Sep '08

Erik Inge Bolsø wrote: > Fixes bug 15281. With testcase. > diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c > index 8a3e83b..1cc963c 100644 > --- a/dlls/kernel32/tests/profile.c > +++ b/dlls/kernel32/tests/profile.c > @@ -694,6 +694,273 @@ static void test_GetPrivateProfileString(void) > DeleteFileA(filename); > } > > +/* as above, but cr-only terminated lines */ > +static void test_cr(void) > +{ As you've stated this is exactly the same code (260 or so lines) with only the content struct being different. I think it's better to rewrite the current test_GetPrivateProfileString to take content as a parameter and call it with both types of content. -- Cheers, Paul.

1 0

Re: kernel32: fix PROFILE_Load to handle mac line endings
by Michael Karcher 14 Sep '08

14 Sep '08

Am Sonntag, den 14.09.2008, 14:48 +0200 schrieb Erik Inge Bolsø: > Fixes bug 15281. With testcase. > @@ -407,6 +407,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > { > szLineStart = next_line; > next_line = memchrW(szLineStart, '\n', szEnd - szLineStart); > + if (!next_line) next_line = memchrW(szLineStart, '\r', szEnd - szLineStart); > if (!next_line) next_line = szEnd; > else next_line++; > szLineEnd = next_line; This fails on files with mixed line endings. Alas, there is no mempbrk or memcspn to help you scanning for both endings at the same time. > @@ -415,7 +416,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > > /* get rid of white space */ > while (szLineStart < szLineEnd && PROFILE_isspaceW(*szLineStart)) szLineStart++; > - while ((szLineEnd > szLineStart) && ((szLineEnd[-1] == '\n') || PROFILE_isspaceW(szLineEnd[-1]))) szLineEnd--; > + while ((szLineEnd > szLineStart) && ((szLineEnd[-1] == '\n') || (szLineEnd[-1] == '\r') || PROFILE_isspaceW(szLineEnd[-1]))) szLineEnd--; > > if (szLineStart >= szLineEnd) continue; This hunk is unneded. PROFILE_isspaceW already checks for \n and \r. The already present check for '\n' could be removed, but that should be a separate patch. I will send it (together with a cleanup in PROFILE_isspaceW) after testing. > @@ -694,6 +694,273 @@ static void test_GetPrivateProfileString(void) > DeleteFileA(filename); > } > > +/* as above, but cr-only terminated lines */ > +static void test_cr(void) > +{ [...] Wouldn't it be sensible to factor out the common testing code, and just pass the string that gets written to the file as parameter? (I didn't check line-by-line that it matches, but the comment seems to implicate it.) If you refactor, you could also add a test that uses mixed endings (some \r, some \n, some \r\n). Regards, Michael Karcher

2 1

Fwd: Testcase - a windows run, please?
by Nicolas Le Cam 14 Sep '08

14 Sep '08

(resent as I didn't cc to wine-devel) Tested on win2k sp4 : X:\>kernel32_crosstest.exe profile profile: 202 tests executed (0 marked as todo, 0 failures), 0 skipped. 2008/9/14 Erik Inge Bolsø <knan-wine(a)anduin.net> > Could someone run this testcase on native windows for me, please? :) >

1 0

Praise of sorts for Wine re Softmaker Office 2008
by Dan Kegel 14 Sep '08

14 Sep '08

http://forum.ubuntuusers.de/topic/softmaker-office-2008--eine-alternative--… has a review of an office suite named Softmaker Office 2008, available for Windows and now also Linux. The review says in part "Irritiert hat uns, daß die Windows-Version von Office 2008, die von Stick gestartet werden kann, unter Wine besser, schneller und stabiler läuft, wie die native Office 2008 für Linux. Wer also die Windows-Version legal erworben hat, kann hier Geld sparen." ("It irritated us that the Windows version runs better on Wine than the native Linux version. If you have the Windows version already, save your money and run it on Wine.") That's praise of sorts... although I hope it doesn't dissuade other vendors from doing native ports. - Dan

14 20