September 2008 - Wine-devel

Re: [2/3] mshtml: Add tests for get_scrollLeft
by Dan Kegel 10 Sep '08

10 Sep '08

Did you forget a todo_wine? ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so dom.c ... fixme:mshtml:HTMLTextContainer_get_scrollLeft (0x15371b8)->(0x32fd34) dom.c:1077: Test failed: IHTMLTextContainer::get_scrollLeft failed: -1 dom.c:1078: Test failed: unexpected left -1, expected 0 ... make[2]: *** [dom.ok] Error 2 On Tue, Sep 9, 2008 at 8:48 PM, Patchwatcher <patchwatcher(a)kegel.com> wrote: > Hi! This is the experimental automated wine patchwatcher thingy. > The latest git sources were built and tested with your patch > "[2/3] mshtml: Add tests for get_scrollLeft" > Result: the patch failed regression tests. > > You can retrieve the full build results at > http://kegel.com/wine/patchwatcher/results/1347.log > and see the patch as parsed at > http://kegel.com/wine/patchwatcher/results/1347.txt > See > http://kegel.com/wine/patchwatcher/results > for more info. > >

1 0

Re: user32/test Added test about window sizes
by Florian Köberle 10 Sep '08

10 Sep '08

Hi Please don't apply this patch. I will commit an updated version with a fix soon. Thanks, Florian Koeberle

1 0

Re: include: Define sigset_t in pthread.h if HAVE_SIGSET_T isn't defined.
by Paul Vriens 10 Sep '08

10 Sep '08

Rob Shearman wrote: > --- > include/wine/pthread.h | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Rob, MingW has it's own definition of sigset_t (include/sys/types.h) which conflicts with this. Do we need to guard the definition in pthread.h with a "!defined(__MINGW32__)" or is this something that needs to be fixed on the MingW side. (Maybe change our configure?) -- Cheers, Paul.

2 2

Re: typelib: Implement LoadTypeLib16
by Alexandre Julliard 10 Sep '08

10 Sep '08

Detlef Riekenberg <wine.dev(a)web.de> writes: > +HRESULT WINAPI LoadTypeLib16(LPSTR szFile, ITypeLib** pptLib) > { > - FIXME("(%s,%p): stub\n",debugstr_a(szFile),pptLib); > + LPWSTR nameW = NULL; > + HRESULT hr; > + DWORD len; > > - if (pptLib!=0) > - *pptLib=0; > + TRACE("(%s, %p)\n", debugstr_a(szFile), pptLib); > + > + if (szFile) { > + len = MultiByteToWideChar(CP_ACP, 0, szFile, -1, NULL, 0); > + nameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, szFile, -1, nameW, len); > + } > > - return E_FAIL; > + hr = LoadTypeLib(nameW, pptLib); > + HeapFree(GetProcessHeap(), 0, nameW); > + return hr; Most likely you need to return a 16-bit interface here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] kernel32/test: Test import entries of a core windows DLL (riched20.dll) (Revision)
by Alexandre Julliard 10 Sep '08

10 Sep '08

Roy Shea <royshea(a)gmail.com> writes: > This revision adds copyright information, removes todo_wine statements > to reflect the current wine head, and fixes an implicit typecast > warning. > --- > dlls/kernel32/tests/Makefile.in | 1 + > dlls/kernel32/tests/loader_image.c | 98 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 99 insertions(+), 0 deletions(-) > create mode 100644 dlls/kernel32/tests/loader_image.c Please merge that into the other loader tests, no need to create a new file. Also you should test this on kernel32.dll, there's no reason to create a dependency on richedit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] mshtml: Implement HTMLElement2 get_scrollLeft (try 2)
by Alexandre Julliard 10 Sep '08

10 Sep '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + nsres = nsIDOMHTMLElement_QueryInterface(This->nselem, &IID_nsIDOMNSHTMLElement, (void**)&nselem); > + if(NS_SUCCEEDED(nsres)) > + { > + nsres = nsIDOMNSHTMLElement_GetScrollLeft(nselem, &left); > + nsIDOMNSHTMLElement_Release(nselem); > + if(NS_FAILED(nsres)) > + left = 0; > + } > + else > + { > + ERR("Could not get nsIDOMNSHTMLElement interface: %08x\n", nsres); > + } This ERR obviously needs the same treatment as the other one. Also please fix your tab size. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: coverity ... new run finally
by Dan Kegel 10 Sep '08

10 Sep '08

Marcus wrote: > A new Coverity run (274) was done finally, so > we can restart looking at issues ;) > > Still a lot of NULL ptr migration issues which suck > to fix, but well. Yay! Here are the new errors introduced since the end of May, sorted by source file. There are only 23 not in test code: 725 NULL_RETURNS Context_CopyProperties crypt32/context.c 715 FORWARD_NULL CryptMsgGetAndVerifySigner crypt32/msg.c 709 DEADCODE DEVENUM_ReadPinTypes devenum/createdevenum.c 717 FORWARD_NULL DEVENUM_ReadPinTypes devenum/createdevenum.c 726 OVERRUN_STATIC test_EnumGroupsInGroup dplayx/tests/dplayx.c 718 FORWARD_NULL MSI_GetUserInfo msi/msi.c 747 REVERSE_INULL ILockBytes_RemoteReadAt_Stub ole32/ole32_objidl_p.c 748 REVERSE_INULL ILockBytes_RemoteReadAt_Stub ole32/ole32_objidl_p.c 749 REVERSE_INULL ISequentialStream_RemoteRead_Stub ole32/ole32_objidl_p.c 750 REVERSE_INULL ISequentialStream_RemoteRead_Stub ole32/ole32_objidl_p.c 751 REVERSE_INULL IEnumOLEVERB_RemoteNext_Stub ole32/ole32_oleidl_p.c 752 REVERSE_INULL IEnumOLEVERB_RemoteNext_Stub ole32/ole32_oleidl_p.c 373 REVERSE_INULL IDispatch_GetIDsOfNames_Stub oleaut32/oleaut32_oaidl_p.c 753 REVERSE_INULL ITypeLib_RemoteFindName_Stub oleaut32/oleaut32_oaidl_p.c 754 REVERSE_INULL IEnumConnectionPoints_RemoteNext_Stub oleaut32/oleaut32_ocidl_p.c 755 REVERSE_INULL IEnumConnections_RemoteNext_Stub oleaut32/oleaut32_ocidl_p.c 714 FORWARD_NULL MediaSeekingImpl_SetPositions quartz/control.c 713 FORWARD_NULL TestFilter_Create quartz/tests/filtergraph.c 719 FORWARD_NULL ME_FindPixelPos riched20/caret.c 708 DEADCODE array_compute_and_size_conformance rpcrt4/ndr_marshall.c 720 FORWARD_NULL CreateContext wined3d/context.c 721 FORWARD_NULL CreateContext wined3d/context.c 722 FORWARD_NULL test_OpenRequest winhttp/tests/winhttp.c 723 FORWARD_NULL test_SendRequest winhttp/tests/winhttp.c 724 FORWARD_NULL test_WinHttpAddHeaders winhttp/tests/winhttp.c 716 FORWARD_NULL InternetCrackUrlW wininet/internet.c 712 FORWARD_NULL test_mmioOpen winmm/tests/mmio.c 710 FORWARD_NULL ldap_parse_sort_controlW wldap32/parse.c 711 FORWARD_NULL ldap_parse_vlv_controlW wldap32/parse.c Sure would be nice if Coverity could identify the cl which introduced each problem :-) - Dan

6 8

Re: [2/3] mshtml: Add tests for get_scrollLeft
by Alistair Leslie-Hughes 10 Sep '08

10 Sep '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:48C65494.2010204(a)hotmail.com... > Hi, > > Changelog: > mshtml: Add tests for get_scrollLeft > > Best Regards > Alistair Leslie-Hughes Hi, Swap the order of patch 2 and 3 and everything all tests will pass ok. Best Regards Alistair Leslie-Hughes

1 0

re: Debugging applications running on wine
by Dan Kegel 09 Sep '08

09 Sep '08

Kevin K wrote: > Is winedbg the only method of debugging applications being > developed for Windows on Wine? > > For instance, assume a program developed with Visual Studio > in C or C++, and I needed to debug it on Linux? If winedbg doesn't work for you, we should fix it. Same goes for other debuggers. For instance, ollydbg seems to work http://appdb.winehq.org/objectManager.php?sClass=application&iId=2619 Visual C++ 6's debugger seems to work at least a little, too: http://appdb.winehq.org/objectManager.php?sClass=version&iId=31 Please file bugs for any problems you run into. - Dan

6 6

Re: msi: Uninitialized variable fix (Coverity)
by James Hawkins 09 Sep '08

09 Sep '08

On Tue, Sep 9, 2008 at 3:54 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Fix for Coverity error CID: 762. > > --- > Changelog: > msi: Uninitialized variable fix (Coverity). > > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index 8a8efe7..48557f0 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -3838,7 +3838,7 @@ static UINT ACTION_PublishFeatures(MSIPACKAGE *package) > MSIFEATURE *feature; > UINT rc; > HKEY hkey; > - HKEY userdata; > + HKEY userdata = NULL; > > if (!msi_check_publish(package)) > return ERROR_SUCCESS; > @@ -3952,7 +3952,7 @@ static UINT ACTION_PublishFeatures(MSIPACKAGE *package) > > end: > RegCloseKey(hkey); > - RegCloseKey(userdata); > + if (userdata) RegCloseKey(userdata); > return rc; Please don't add another NULL-before-free check. -- James Hawkins

3 4