September 2008 - Wine-devel

OT: linux market share trend data
by Dan Kegel 11 Sep '08

11 Sep '08

I finally threw together a summary of four sources of linux market share data, see http://kegel.com/linux/marketshare.html

1 0

Re: richedit: Avoid acting on control words in skipped RTF groups (Bug 15227)
by Dylan Smith 11 Sep '08

11 Sep '08

I noticed that this introduced a glitch, because I didn't have a destination callback for the \nesttableprops control word. This led to it being ignored, so nested tables would take on default properties. I will update this patch to fix this glitch and then resend it. On Wed, Sep 10, 2008 at 10:54 PM, Dylan Smith <dylan.ah.smith(a)gmail.com>wrote: > Previously the control words in skipped groups were being processed by > the read hook on the RTF parser. By moving this code into the class > callbacks for the parser, the skipped groups actually remain skipped. > > An example of a skipped group is a optional destination that isn't > recognized by the parser. The RTF specifications say to ignore these > groups, and native richedit controls act accordingly. > > This patch fixes bug 15227 which was caused by the \itap4 control word > in a destination which caused an unterminated table, since this control > word changes the nesting level by starting nested tables to reach that > nesting level. > --- > dlls/riched20/editor.c | 28 ++++++---------------------- > dlls/riched20/editor.h | 6 ++++++ > dlls/riched20/reader.c | 8 ++++++++ > 3 files changed, 20 insertions(+), 22 deletions(-) >

1 0

Re: winex11.drv: Add support for _NET_WORKAREA
by Alexandre Julliard 11 Sep '08

11 Sep '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > SetRect( &rect, 0, 0, width, height ); > + rc_work = rect; > > - if (root_window != DefaultRootWindow( gdi_display ) || !query_screens()) > + if (!XGetWindowProperty( gdi_display, DefaultRootWindow(gdi_display), x11drv_atom(_NET_WORKAREA), 0, > + ~0, False, XA_CARDINAL, &type, &format, &count, > + &remaining, (unsigned char **)&work_area )) > { > - default_monitor.rcWork = default_monitor.rcMonitor = rect; > + if (type == XA_CARDINAL && format == 32 && count >= 4) > + { > + SetRect( &rc_work, work_area[0], work_area[1], > + work_area[0] + work_area[2], work_area[1] + work_area[3] ); > + } > + XFree( work_area ); > + } > + > + if (root_window != DefaultRootWindow( gdi_display ) || !query_screens( &rc_work )) > + { > + default_monitor.rcMonitor = rect; > + default_monitor.rcWork = rc_work; That won't do the right thing in desktop mode. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemenubuilder: eliminate wineshelllink (try 3)
by Alexandre Julliard 11 Sep '08

11 Sep '08

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > + /* winemenubuilder_semaphore ensures mutual exclusion for the temp file */ > + tempfilename = heap_printf("%s/next-wine-menu.temp", xdg_config_dir); That's not good enough, the config dir is global to all Wine instances. You really need safe temp file creation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 02/14] inetcomm: Add a stub MimeInternational object.
by Alexandre Julliard 11 Sep '08

11 Sep '08

Huw Davies <huw(a)codeweavers.com> writes: > @@ -8,6 +8,7 @@ IMPORTS = uuid ole32 ws2_32 user32 advapi32 kernel32 > > C_SRCS = \ > inetcomm_main.c \ > + internat.c \ > internettransport.c \ > mimeole.c \ > regsvr.c I find that abbreviating 'international' as 'internat' is a bit confusing, especially in a dll that also uses 'internet' in various places. Would you mind changing it to mimeintl.c or something like that? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32: Fix a failing test in win9x
by Paul Vriens 11 Sep '08

11 Sep '08

James Hawkins wrote: > Hi, > > Changelog: > * Fix a failing test in win9x. > > dlls/crypt32/tests/ctl.c | 15 +++++++++++---- > 1 files changed, 11 insertions(+), 4 deletions(-) > > > > ------------------------------------------------------------------------ > > The !ret in: + else + { + ok(!ret && GetLastError() == CRYPT_E_EXISTS, + "expected CRYPT_E_EXISTS, got %d %08x\n", ret, GetLastError()); + } is superfluous. -- Cheers, Paul.

2 2

Re: [setupapi/tests] Fix a failure on Windows 2000
by James Hawkins 11 Sep '08

11 Sep '08

On Wed, Sep 10, 2008 at 10:03 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > W2K doesn't fail with ERROR_INVALID_NAME but with ERROR_GENERAL_SYNTAX > (setupapi > error). > That error was added for a reason; it was seen on a win2k box. Please don't remove it. -- James Hawkins

2 2

Re: [PATCH 1/2] kernel32/test: Test import entries of a core windowsDLLs (Revision 2)
by Dmitry Timoshkov 11 Sep '08

11 Sep '08

"Roy Shea" <royshea(a)gmail.com> wrote: > This revision places the new test with the other loader tests in > loader.c, and for testing loads kernel32.dll rather than riched20.dll Please move an existing and new tests to their own bodies, and use GetModuleHandle instead of LoadLibrary. -- Dmitry.

1 0

Re: devenum: Fix order of operations bug (Coverity id 709)
by Chris Robinson 10 Sep '08

10 Sep '08

On Wednesday 10 September 2008 11:34:03 am Juan Lang wrote: > dwMediaTypeSize + (dwMediaTypeSize < 2 ? 1 : dwMediaTypeSize / 2) I'm pretty sure this would come out as: dwMediaTypeSize + (dwMediaTypeSize < (2 ? 1 : dwMediaTypeSize) / 2) But even if it doesn't, I don't think it'd hurt to be more explicit: dwMediaTypeSize + ((dwMediaTypeSize < 2) ? 1 : (dwMediaTypeSize/2))

3 3

Re: [PATCH] static buffer overflow checking
by Michael Karcher 10 Sep '08

10 Sep '08

Am Mittwoch, den 10.09.2008, 22:12 +0200 schrieb Marcus Meissner: > This approach will not work with -O0, which might be a problem. If I were to decide, that would kill the patch. I really like to recompile the dlls I am currently debugging with -O0, as that makes following the code flow much easier. Having MultiByteToWideChar calls fail in that case seems to make recompilation of most DLLs (that export A and W functions) with -O0 impossible. Regards, Michael Karcher

3 3