September 2008 - Wine-devel

Re: [5/6] WineD3D: Remove some #ifdefs
by H. Verbeet 08 Oct '08

08 Oct '08

Right now it's simply broken of course. The extension being defined in the header is no guarantee the driver actually supports it.

3 3

Re: howto fix bug 13462
by Louis. Lenders 02 Oct '08

02 Oct '08

Rob Shearman <robertshearman <at> gmail.com> writes: Hi Rob, i think i got the test ready now, i'll send it when the defenitions are in place in ctxtcall.idl. Now still strugling how to fix the bug. I fixed up the patch below, also by looking how things are done in similar places in wine-code. With patch applied I can see that ContextCallback_ContextCallback and ContextCallback_Release are called from the application (tested with NASA WorldWind), and the simple stubs are enough to let the app continue fine. But i'm not sure if everything is 100% ok. Is this what you more or less meant in your first comment? diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index 37907ec..a1f41fd 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -55,6 +55,7 @@ #include "objbase.h" #include "ole2.h" #include "ole2ver.h" +#include "ctxtcall.h" #include "compobj_private.h" @@ -3615,25 +3616,39 @@ HRESULT WINAPI CoRegisterChannelHook(REFGUID guidExtension, IChannelHook *pChann typedef struct Context { const IComThreadingInfoVtbl *lpVtbl; + const IContextCallback *lpVtblIContextCallback; LONG refs; APTTYPE apttype; } Context; +static inline Context *impl_from_Context(IComThreadingInfo *iface) +{ + return (Context *)((char*)iface - FIELD_OFFSET(Context, lpVtbl)); +} + static HRESULT WINAPI Context_QueryInterface(IComThreadingInfo *iface, REFIID riid, LPVOID *ppv) { + Context* This=impl_from_Context((IComThreadingInfo*) iface); *ppv = NULL; if (IsEqualIID(riid, &IID_IComThreadingInfo) || IsEqualIID(riid, &IID_IUnknown)) { *ppv = iface; - IUnknown_AddRef(iface); - return S_OK; } + else if(IsEqualIID(riid, &IID_IContextCallback)) + { + *ppv = &This->lpVtblIContextCallback; + } + else + { + FIXME("interface not implemented %s\n", debugstr_guid(riid)); + return E_NOINTERFACE; + } - FIXME("interface not implemented %s\n", debugstr_guid(riid)); - return E_NOINTERFACE; -} + IUnknown_AddRef(iface); + return S_OK; +} static ULONG WINAPI Context_AddRef(IComThreadingInfo *iface) { @@ -3691,6 +3706,31 @@ static HRESULT WINAPI Context_SetCurrentLogicalThreadId(IComThreadingInfo *iface return E_NOTIMPL; } + +static HRESULT WINAPI ContextCallback_QueryInterface(IContextCallback *iface, REFIID riid, LPVOID *ppv) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static ULONG WINAPI ContextCallback_AddRef(IContextCallback *iface) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static ULONG WINAPI ContextCallback_Release(IContextCallback *iface) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ContextCallback_ContextCallback(IContextCallback *iface, PFNCONTEXTCALL pfnCallback, ComCallData* pParam, REFIID riid, int iMethod, IUnknown* pUnk) +{ + FIXME("not implemented yet\n"); + return E_NOTIMPL; +} + static const IComThreadingInfoVtbl Context_Threading_Vtbl = { Context_QueryInterface, @@ -3702,6 +3742,14 @@ static const IComThreadingInfoVtbl Context_Threading_Vtbl = Context_SetCurrentLogicalThreadId }; +static const IContextCallbackVtbl Context_Callback_Vtbl = +{ + ContextCallback_QueryInterface, + ContextCallback_AddRef, + ContextCallback_Release, + ContextCallback_ContextCallback +}; + /*********************************************************************** * CoGetObjectContext [OLE32.@] * @@ -3735,6 +3783,7 @@ HRESULT WINAPI CoGetObjectContext(REFIID riid, void **ppv) return E_OUTOFMEMORY; context->lpVtbl = &Context_Threading_Vtbl; + context->lpVtblIContextCallback=(IContextCallback*)&Context_Callback_Vtbl; context->refs = 1; if (apt->multi_threaded) context->apttype = APTTYPE_MTA;

3 2

Detecting Wine
by Mark Wagner 02 Oct '08

02 Oct '08

What's the best way for an application to detect that it's running under Wine? As part of the installation process, under Windows our program does a full-disk search of all local hard drives, but ignoring network drives and removable media. Under Wine, this doesn't work too well, as there's not a one-to-one mapping between disks and drive letters, and there's usually at least one way to access the entire *nix filesystem. If someone's got a few network drives mounted, the installer could spend hours searching them. -- Mark Wagner

10 17

Discussion of bug versions
by Jeremy White 01 Oct '08

01 Oct '08

We discussed bugzilla versions at Wineconf, re: http://bugs.winehq.org/show_bug.cgi?id=12728 There were several points of consensus. First, it would be helpful if we could reduce the number of versions visible in the drop down box when entering a new bug. That would seem to require a bugzilla code change, though. Anyone know of an easy way to accomplish this? Second, we'd like new bug reporters to not be able to use the 'CVS/GIT' version choice, but to instead be encouraged to report the current version. (wine --version reports something that is easy to match up to the choices). Obviously, it seems that it would be really nice if, when we did that, it was a lot easier to find 1.1.5... Cheers, Jeremy

10 10

WineConf 2008 Keynote Video
by Jeremy Newman 30 Sep '08

30 Sep '08

http://www.winehq.org/site/wineconf/media -Newman

1 0

Re: OpenGL child windows
by Florian Köberle 30 Sep '08

30 Sep '08

Hello Chris Robinson, A long time ago you wrote in http://www.winehq.org/pipermail/wine-devel/2007-October/059550.html that you got my example program running: "If I force offscreen rendering and add the flag, the demo works." Could you have a look at the following bug report and may explain how to "force offscreen rendering"? http://bugs.winehq.org/show_bug.cgi?id=15232 Best regards, Florian Köberle

2 1

RE: IWineD3DResourceImpl_GetPriority/SetPriority
by Stefan Dösinger 30 Sep '08

30 Sep '08

Can you add a test for the default priority? From: wine-patches-bounces(a)winehq.org [mailto:wine-patches-bounces(a)winehq.org] On Behalf Of Kjell Rune Skaaraas Sent: Tuesday, September 30, 2008 11:18 AM To: wine-patches(a)winehq.org Subject: Re: IWineD3DResourceImpl_GetPriority/SetPriority Hello, Please don't use the previously attached patch since it makes changes to exception.c that should never have been part of the patch. Corrected patch is attached to this mail. Regards, Kjell Rune _____ Alt i ett. Få Yahoo! <http://no.mail.yahoo.com> Mail med adressekartotek, kalender og notisblokk.

1 0

make test .. monthcal new failure
by Marcus Meissner 30 Sep '08

30 Sep '08

Hi, I get these new errors after todays git update: monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test failed: Expected 65542, got 65536 err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp=00000000 lp=00000000 err:monthcal:MONTHCAL_WindowProc unknown msg 2005 wp=00000001 lp=00000000 err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp=00000000 lp=00000000 err:monthcal:MONTHCAL_WindowProc unknown msg 2005 wp=00000000 lp=00000000 err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp=00000000 lp=00000000 err:monthcal:MONTHCAL_WindowProc unknown msg 2005 wp=00000001 lp=00000000 monthcal.c:956: Tests skipped: cannot perform today link test make: *** [monthcal.ok] Fehler 5 Ciao, Marcus

2 2

Re: d3d8: Fix incorrect ordering of brackets in IDirect3DVertexShader8Impl_GetDevice.
by Henri Verbeet 30 Sep '08

30 Sep '08

2008/9/30 Rob Shearman <robertshearman(a)gmail.com>: > The comparison should be (D3D_OK == hr && myDevice), not (D3D_OK == > (hr && myDevice)). > d3d8 and d3d9 are pretty bad at stuff like this, unfortunately. Strictly speaking we should also compare to WINED3D_OK instead of D3D_OK here, but they have the same values.

2 1

Bad patch, what's the procedure?
by Kjell Rune Skaaraas 30 Sep '08

30 Sep '08

Hello,I've submitted a patch to wine-patches for IWineD3DResourceImpl_GetPriority/SetPriority that's incorrect (it makes changes to exception.c which shouldn't be there, they were just part of me trying to debug something). Is there anything like a cancel procedure I should do, or should I just fix up the patch and submit it again? Oh yeah and this will teach me to read the diff more thoroughly next time...Regards,Kjell Rune _________________________________________________________ Alt i ett. Få Yahoo! Mail med adressekartotek, kalender og notisblokk. http://no.mail.yahoo.com

2 1