September 2008 - Wine-devel

RFC: Adding annotations to function declarations to improve static analysis
by Rob Shearman 28 Sep '08

28 Sep '08

Hi all, This will be talked about in more detail at WineConf tomorrow, but I just thought I'd throw this out there as a bit of background to any discussions. Adding annotations to function declarations allows Prefast to pick up certain classes of bugs with varying degrees of false positives. In particular, with patches like the attached applied byte-count/element-count mismatches can be detected with no false positives and relatively few false positives for off-by-one errors and other buffer overruns. Whilst this could be maintained outside of the main Wine tree it would be more convenient in terms of automation of Prefast runs if a vanilla Wine tree can be used (i.e. the annotation patches are in the official tree). -- Rob Shearman

3 3

Re: [WineHQ] Remove google adds box
by Tom Wickline 28 Sep '08

28 Sep '08

Can I object the removal? There will be a WineConf next year right? On Sat, Sep 27, 2008 at 2:28 PM, Zachary Goldberg <zgold(a)bluesata.com> wrote: > Was for sponsoring WineConf. > > > > -- http://www.wine-reviews.net/

2 1

Re: mlang: test, make sure UNICODE->1252 is convertable before failing when we cannot convert. (this fixes the tests on japanese windows installs)
by Aric Stewart 27 Sep '08

27 Sep '08

Sorry all, this patch is clearly incorrect. I am continuing to try to find out why these test fail on my windows 2000 japanese vm. -aric Aric Stewart wrote: > --- > dlls/mlang/tests/mlang.c | 100 > +++++++++++++++++++++++++++++----------------- > 1 files changed, 63 insertions(+), 37 deletions(-) > > > > ------------------------------------------------------------------------ > >

1 0

Re: mlang: tests update IMultiLanguage2_GetRfc1766FromLcid can return S_FALSE on partial name matching so deal with this properly
by Rob Shearman 27 Sep '08

27 Sep '08

2008/9/27 Aric Stewart <aric(a)codeweavers.com>: > + if (hr != S_FALSE) > + /* > + * this happens when 'kok' instead matches to a different Rfc1766 name > + * for example 'ko' so it is not a falure but does not give us what "falure" -> spelling mistake > + * we are looking for > + */ > + { Slight style issue - comment between if statement and open block character doesn't look very nice. -- Rob Shearman

1 0

re: Compiling WINE from source - Documentation needs to be updated?
by Dan Kegel 27 Sep '08

27 Sep '08

And while we're on the subject, is "make depend" really needed anymore? I thought it happened automatically.

3 3

WineConf
by Zachary Goldberg 27 Sep '08

27 Sep '08

If you're reading this now at Wineconf, shame on you.

2 1

Size of SUBHEAP in heap.c
by Martin Profittlich 27 Sep '08

27 Sep '08

Hello, when trying to fix an issue with Guitar Rig 3 on Wine (Bug 10129, "Guitar Rig 3 crashes"), I found out something odd: The crash is affected by the size of the SUBHEAP structure in dlls/ntdll/heap.c. Just by adding 8 unused bytes to SUBHEAP, GR3 does not crash anymore. Add another 8 bytes, GR3 crashes again, yet another 8 bytes - no crash and so on. The bug surfaced with this commit: [1d063ae18d990343fc077dcbf650add797924018] ntdll: Remove assumptions that the subheap is at the beginning of the memory block. I don't think the commit is the cause of the problem. It merely changed the size of SUBHEAP to a problematic value. I don't really understand the inner workings of heap.c. Does anyone have an idea what the cause might be, or where to look for more information? Cheers, Martin P.S. Link to the bug: http://bugs.winehq.org/show_bug.cgi?id=10129 -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

5 8

Compiling WINE from source - Documentation needs to be updated?
by chengas123 26 Sep '08

26 Sep '08

I see different advice on the best way to compile in various places. The http://www.winehq.org/site/docs/wineusr-guide/installing-wine-source user guide says to run: $ ./configure $ make depend $ make $ make install The README in the root of the source directory says to run: ./tools/wineinstall Which is the preferred method? Is there any difference? I'm thinking the docs in one of those two places probably needs to be updated. -- View this message in context: http://www.nabble.com/Compiling-WINE-from-source---Documentation-needs-to-b… Sent from the Wine - Devel mailing list archive at Nabble.com.

1 0

Re: LookupAccountNameW() use ACCOUNT_SIDS domain and name_use fields for well known SIDs
by Rob Shearman 26 Sep '08

26 Sep '08

2008/9/26 Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk>: > @@ -2532,11 +2532,30 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR > lpSystemName, LPCWSTR lpAccountName, PSI > { > if (!strcmpW(lpAccountName, ACCOUNT_SIDS[i].account)) > { > - if (*cchReferencedDomainName) > - *ReferencedDomainName = '\0'; > - *cchReferencedDomainName = 0; > - *peUse = SidTypeWellKnownGroup; > - return CreateWellKnownSid(ACCOUNT_SIDS[i].type, NULL, Sid, > cbSid); > + ret = CreateWellKnownSid(ACCOUNT_SIDS[i].type, NULL, Sid, > cbSid); > + > + domainName = ACCOUNT_SIDS[i].domain; > + nameLen = strlenW(domainName); > + > + if (*cchReferencedDomainName <= nameLen && > ReferencedDomainName) > + { > + SetLastError(ERROR_INSUFFICIENT_BUFFER); > + nameLen += 1; > + ret = FALSE; > + } > + else if (ReferencedDomainName && domainName) > + { > + strcpyW(ReferencedDomainName, domainName); > + } > + > + *cchReferencedDomainName = nameLen; > + > + if (ret) > + { > + *peUse = ACCOUNT_SIDS[i].name_use; You could move this into the else block above. > + } > + > + return ret; > } > } -- Rob Shearman

1 0

Re: LookupAccountNameW() any account but first user rejected
by Rob Shearman 26 Sep '08

26 Sep '08

2008/9/26 Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk>: > + if (!ADVAPI_IsLocalComputer(lpSystemName)) > + { > + /*FIXME("Only local computer supported!\n");*/ > + SetLastError(ERROR_NONE_MAPPED); > + return FALSE; > + } There's no need to comment this FIXME out. > @@ -2546,7 +2553,6 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR lpSystemName, > LPCWSTR lpAccountName, PSI > if (!strcmpW(lpAccountName, ACCOUNT_SIDS[i].account)) > { > char sidBuffer [SECURITY_MAX_SID_SIZE]; > - > size_t sidLen = SECURITY_MAX_SID_SIZE; You should combine this whitespace change into the patch that introduces the whitespace. > > ret = CreateWellKnownSid(ACCOUNT_SIDS[i].type, NULL, sidBuffer, > &sidLen); > @@ -2583,6 +2589,26 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR lpSystemName, > LPCWSTR lpAccountName, PSI > } > } > > + > + { > + WCHAR userName [UNLEN + 1]; > + size_t nameLen = UNLEN + 1; Don't create a block for no reason. Please make sure you're not using excessive stack space in this function with all of these buffers on the stack. Also, nameLen should be of type DWORD instead of size_t, which is platform dependent and might not match the type of DWORD and cause warnings when passing the address of the parameter to the function below. > + > + ret = GetUserNameW(userName, &nameLen); > + > + if (ret && strcmpW(lpAccountName, userName) != 0) > + { > + /* FIXME("Only first user account supported!\n"); */ > + SetLastError(ERROR_NONE_MAPPED); > + ret = FALSE; > + } > + > + if (!ret) > + { > + return ret; > + } > + } > + -- Rob Shearman

1 0