September 2008 - Wine-devel

user32:input.c fails only when run from make?!
by Dan Kegel 24 Sep '08

24 Sep '08

Here's an odd one. On my Levnovo x60 running Hardy, with or without metacity-2.23.8 built from source, the user32 test input.c fails when run from make nearly all of the time, but doesn't fail if run standalone. The problem persists even with a trivial makefile, e.g. foo.ok: env WINETEST_DEBUG=1 WINETEST_PLATFORM=wine ~/wine-git/wine user32_test.exe.so input.c && touch foo.ok This usually fails with input.c:648: Test failed: 49: a1 from 00 -> 00 instead of 00 -> 80 or

1 1

Re: msi: add stub for MsiDetermineApplicablePatchesW
by James Hawkins 24 Sep '08

24 Sep '08

On Wed, Sep 24, 2008 at 1:12 PM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > This is the 2nd stub needed to let .net 2.0 SP1 installer finish fine. I'll > resend the first one (corrected) > The vast majority of this file does not put spaces around parenthesis, so can you resend with that fixed? +UINT WINAPI MsiDetermineApplicablePatchesW( LPCWSTR szProductPackagePath, + DWORD cPatchInfo, PMSIPATCHSEQUENCEINFOW pPatchInfo) Also, why don't you add MsiDetermineApplicablePatchesA at the same time? -- James Hawkins

1 0

Re: secur32: Fix a failing test in win95
by Paul Vriens 24 Sep '08

24 Sep '08

On Wed, Sep 24, 2008 at 10:06 AM, James Hawkins <jhawkins(a)codeweavers.com> wrote: > Hi, > > Changelog: > * Fix a failing test in win95. > > dlls/secur32/tests/main.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > -- > James Hawkins > But if the result is SEC_E_UNSUPPORTED_FUNCTION it's not broken is it? Shouldn't we use some kind of skip here? (The end result will be the same, as we should use win_skip, it just doesn't look correct). Cheers, Paul.

2 3

Re: d3dx9: Add d3dx9effect.h
by Alexandre Julliard 24 Sep '08

24 Sep '08

Busquets Pérez Luis C. <luiscar2001(a)yahoo.es> writes: > +typedef struct D3DXEFFECT_DESC { > + LPCSTR Creator; > + UINT Parameters; > + UINT Techniques; > + UINT Functions; > +} D3DXEFFECT_DESC, *LPD3DXEFFECT_DESC; > + > +typedef struct D3DXPARAMETER_DESC { > + LPCSTR Name; > + LPCSTR Semantic; > + D3DXPARAMETER_CLASS Class; > + D3DXPARAMETER_TYPE Type; > + UINT Rows; > + UINT Columns; > + UINT Elements; > + UINT Annotations; > + UINT StructMembers; > + DWORD Flags; > + UINT Bytes; > +} D3DXPARAMETER_DESC, *LPD3DXPARAMETER_DESC; > + > +typedef struct D3DXTECHNIQUE_DESC { > + LPCSTR Name; > + UINT Passes; > + UINT Annotations; > +} D3DXTECHNIQUE_DESC, *LPD3DXTECHNIQUE_DESC; > + > +typedef struct D3DXPASS_DESC { > + LPCSTR Name; > + UINT Annotations; > + CONST DWORD * pVertexShaderFunction; > + CONST DWORD * pPixelShaderFunction; > +} D3DXPASS_DESC, *LPD3DXPASS_DESC; > + > +typedef struct D3DXFUNCTION_DESC { > + LPCSTR Name; > + UINT Annotations; > +} D3DXFUNCTION_DESC, *LPD3DXFUNCTION_DESC; > + > +typedef interface ID3DXInclude *LPD3DXINCLUDE; A lot of these LP* types don't seem to exist in the PSDK. > +#define INTERFACE ID3DXEffect > +DECLARE_INTERFACE_(ID3DXEffect, ID3DXBaseEffect) If you derive from ID3DXBaseEffect you have to define that one first. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Patchwatcher problems
by Dan Kegel 24 Sep '08

24 Sep '08

Andrew Fenn wrote: > I just submitted a patch to wine patches (Started implementing the > xinput library for xbox 360 joystick support ) and I believe patch > watcher failed for a few reasons. > >1) Although it applied my patch it didn't build it as >./tools/make_makefiles isn't called so it isn't built? I think make_makefiles is called: http://code.google.com/p/winezeug/source/browse/trunk/patchwatcher/patchwat… Maybe I should make the log more verbose... > 2) Patch watcher seems to fail because of another patch, perhaps the > latest known good build should be tested if the patch fails and then > compared with the first failed attempt? We don't accumulate patches. There was no other patch active when yours was tested. This was probably just a rare failure of a slightly flaky test. When I verify that tests are flaky, I add them to a blacklist. You just got unlucky, I think. Once you figure out why your patch didn't trigger your stuff to be built, resubmit... - Dan

3 3

Re: secur32: Fix compilation with GNU TLS 1.0.16.
by Henri Verbeet 24 Sep '08

24 Sep '08

2008/9/24 Francois Gouget <fgouget(a)free.fr>: > --- > > On my system I have libgnutls11-dev 1.0.16-14+b1 which has > gnutls_certificate_credentials but not the corresponding ..._t type. So > this patch lets it compile on my system. Hopefully it will still work > with the newer headers (otherwise we'll have to introduce a configure > check :-( ) > I don't think that'll work, this is what newer versions of gnutls have: struct gnutls_certificate_credentials_st; typedef struct gnutls_certificate_credentials_st *gnutls_certificate_credentials_t; typedef gnutls_certificate_credentials_t gnutls_certificate_server_credentials; typedef gnutls_certificate_credentials_t gnutls_certificate_client_credentials; gnutls_certificate_client_credentials and gnutls_certificate_server_credentials should be available in both versions though. Considering we're only setting client credentials anyway for the moment, just using gnutls_certificate_client_credentials would probably be fine.

1 1

Re: Call SetLastError() in ParseStringAclToAcl() to correct Conformance Test failure
by James Hawkins 24 Sep '08

24 Sep '08

On Wed, Sep 24, 2008 at 1:19 AM, Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> wrote: > From 2f6d33f2d66e252bbd6ad3bc0f3e93a1fb780485 Mon Sep 17 00:00:00 2001 > From: Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> > Date: Wed, 24 Sep 2008 06:57:33 +0100 > Subject: Call SetLastError() in ParseStringAclToAcl() to correct > Conformance Test failure > > --- > dlls/advapi32/security.c | 7 ++++++- > dlls/advapi32/tests/security.c | 1 - > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c > index ef9ce6e..83bb08e 100644 > --- a/dlls/advapi32/security.c > +++ b/dlls/advapi32/security.c > @@ -3735,7 +3735,11 @@ static BOOL ParseStringAclToAcl(LPCWSTR > StringAcl, LPDWORD lpdwFlags, > TRACE("%s\n", debugstr_w(StringAcl)); > > if (!StringAcl) > - return FALSE; > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + TRACE("StringAcl is NULL, returning FALSE\n"); > + return FALSE; > + } > You've added a change (above) that is not verified by a test. Please add one before making such a change. Also, that TRACE is highly superfluous; please remove it from the patch. -- James Hawkins

1 0

Re: secur32: Add kerberos tests. (try 3)
by Kai Blin 24 Sep '08

24 Sep '08

On Wednesday 24 September 2008 06:24:15 Kai Blin wrote: This breaks on Win2k3 and newer. It worked on XP, dammit. I'll have to poke this some more tomorrow. Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: secur32: Add kerberos tests. (try 2)
by Kai Blin 24 Sep '08

24 Sep '08

On Wednesday 24 September 2008 05:32:20 Kai Blin wrote: Aw, coding while being jet-lagged sucks. I'll resend a version without warnings and memory leaks. Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: secur32: Add kerberos tests.
by Kai Blin 24 Sep '08

24 Sep '08

On Wednesday 24 September 2008 04:18:42 Kai Blin wrote: Actually, never mind this one. I just realized one of the tests doesn't run on windows after all. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0