January 2009 - Wine-devel - list.winehq.org

Re: msxml3: Implement IXMLDOMDocument2 IPersistStream_Save
by Nikolay Sivov 22 Jan '09

22 Jan '09

Alistair Leslie-Hughes wrote: > Hi, > Helps http://bugs.winehq.org/show_bug.cgi?id=9012 > > > Changelog: > msxml3: Implement IXMLDOMDocument2 IPersistStream_Save > > Best Regards > Alistair Leslie-Hughes > > > > > > No patch here.

1 0

Only 28 more uninspected coverity warnings left!
by Dan Kegel 21 Jan '09

21 Jan '09

Hey, looks like our Coverity elves have been busy; there are only 28 more coverity warnings left to be evaluated. Maybe if we finish triaging all the warnings, they'll get motivated to scan us more often... For more info, see http://scan.coverity.com Here are the error types, files, and functions as of Oct 27th (they haven't done a run since then): FORWARD_NULL dlls/comdlg32/filedlg16.c FileOpenDlgProc16 dlls/comdlg32/filedlg16.c FileSaveDlgProc16 dlls/dbghelp/dwarf.c dwarf2_read_one_debug_info dlls/dbghelp/module.c SymLoadModuleExW dlls/dbghelp/msc.c codeview_process_info dlls/dbghelp/source.c source_new dlls/dmime/segtriggertrack.c IDirectMusicSegTriggerTrack_IPersistStream_ParseSegment dlls/dmloader/container.c IDirectMusicContainerImpl_IDirectMusicContainer_EnumObject dlls/dmstyle/style.c IDirectMusicStyle8Impl_IPersistStream_ParsePartRefList dlls/dsound/tests/ds3d.c test_secondary dlls/msxml3/tests/domdoc.c test_domnode dlls/oleaut32/typelib.c SLTG_ProcessAlias dlls/quartz/filtermapper.c FM2_ReadFilterData dlls/shell32/shlexec.c SHELL_ArgifyW dlls/user32/dde_misc.c WDML_RemoveAllLinks dlls/user32/dde_misc.c WDML_RemoveConv dlls/user32/dde_misc.c WDML_RemoveServer dlls/user32/edit.c EDIT_EM_ReplaceSel dlls/winex11.drv/bitblt.c BITBLT_InternalStretchBlt dlls/winex11.drv/palette.c X11DRV_PALETTE_ToPhysical dlls/winmm/mmsystem.c mmioOpen16 programs/winedbg/gdbproxy.c packet_write_register programs/winedbg/gdbproxy.c packet_write_registers programs/winedbg/symbol.c fill_sym_lvalue programs/winhlp32/winhelp.c WINHELP_GetWindowInfo RESOURCE_LEAK tools/wrc/readres.c read_res32 REVERSE_INULL dlls/msxml3/tests/domdoc.c test_domnode dlls/uxtheme/draw.c get_image_part_size

1 0

Ole32: le32toh/le16toh conflict in storage32.h's endian macros
by Austin English 21 Jan '09

21 Jan '09

In file included from storage32.c:50: storage32.h:406:1: warning: "le32toh" redefined In file included from /usr/include/machine/endian.h:3, from /usr/include/sys/types.h:98, from /usr/include/stdlib.h:41, from storage32.c:36: /usr/include/sys/endian.h:178:1: warning: this is the location of the previous definition There are a four of these warnings. Apparently Wine defines these in storage32.h: /********************************************************* * Endian conversion macros */ #ifdef WORDS_BIGENDIAN #define htole32(x) RtlUlongByteSwap(x) #define htole16(x) RtlUshortByteSwap(x) #define le32toh(x) RtlUlongByteSwap(x) #define le16toh(x) RtlUshortByteSwap(x) #else #define htole32(x) (x) #define htole16(x) (x) #define le32toh(x) (x) #define le16toh(x) (x) #endif And on NetBSD: #if BYTE_ORDER == BIG_ENDIAN #define htole16(x) bswap16((uint16_t)(x)) #define htole32(x) bswap32((uint32_t)(x)) #define htole64(x) bswap64((uint64_t)(x)) ... #define HTOLE16(x) (x) = bswap16((uint16_t)(x)) #define HTOLE32(x) (x) = bswap32((uint32_t)(x)) #define HTOLE64(x) (x) = bswap64((uint64_t)(x)) ... #else /* LITTLE_ENDIAN */ ... #define htole16(x) (x) #define htole32(x) (x) #define htole64(x) (x) ... #define HTOLE16(x) (void) (x) #define HTOLE32(x) (void) (x) #define HTOLE64(x) (void) (x) I started to send a patch to #ifdef,#undef, but I'm not sure that's right...which definition should we be using here, NetBSD's or Wine's? Furthermore, do we need to add le64toh/htole64? -- -Austin

2 1

Debian packages of Wine
by Ben Klein 21 Jan '09

21 Jan '09

Hi Maurilio, I see you've taken over building Lenny packages of Wine. Good work; at least now there are *some* updated packages available. I talked to Scott a while ago about taking over from him for all Debian package building. I have an automated build environment that builds packages for all variations from etch/i386 to sid/amd64 (even the very annoying-to-bulid-Wine-for etch/amd64). The one thing that was stopping me from fully taking over from Scott was I don't have the resources to host the packages. So I'm wondering the following: 1) Do you think it's worth supporting Etch? (I argue yes, because it's still stable) 2) Are you interested in hosting my Etch and Sid packages? 3) I'm clueless as to how to correctly set up a repository, so all I have at the moment are the raw packages. Would you or Scott be able to help out with this? Thanks, Ben

3 8

Re: Problems with configure on Mac
by James Mckenzie 21 Jan '09

21 Jan '09

Cesar Izurieta <cesar(a)ecuarock.net> wrote: >Sent: Jan 21, 2009 7:49 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Development Mailing List <wine-devel(a)winehq.org> >Subject: Re: Problems with configure on Mac > >Try something like: > >LDFLAGS="-L/opt/local/lib" CPPFLAGS="-I/opt/local/include/" ./configure > >You need to specify both the library dirs and the include dirs. This is >using macports. For fink I guess the libraries are located somewhere under >/sw IIRC. I'll find them and use them this evening after reviewing the log file. James McKenzie

1 0

Dead code in winedbg
by Francois Gouget 21 Jan '09

21 Jan '09

Hi, I have noticed that expr_alloc_uconstant() is unused in winedbg. Is that normal? It causes all of the code in the attached patch to essentially be dead code since expr.type is never set to EXPR_TYPE_U_CONST. Should we just remove all that code? Just the expr_alloc_uconstant() function? Or is this unused just because of a bug? Or maybe it will be used 'soon'? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

3 3

RE: [4/5] ddraw: Get rid of ICOM_INTERFACE.
by Stefan Dösinger 21 Jan '09

21 Jan '09

> -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Henri Verbeet > Sent: Wednesday, January 21, 2009 10:01 AM > To: wine-patches(a)winehq.org > Subject: [4/5] ddraw: Get rid of ICOM_INTERFACE. > > - *obj = ICOM_INTERFACE(This, IDirect3DDevice3); > + *obj = &This->IDirect3DDevice3_vtbl; > - *obj = ICOM_INTERFACE(This, IDirect3DDevice7); > + *obj = This; > - return IDirect3DDevice7_AddRef(ICOM_INTERFACE(This, IDirect3DDevice7)); > + return IDirect3DDevice7_AddRef((IDirect3DDevice7 *)This); I think it would be better to access IDirect3DDevice7 via explicit specifying the vtable, or an inline function for consistency and to avoid hardwiring the assumption that the IDirect3DDevice7 vtable is the first member of the object

3 5

Re: rpcrt4: Add a stub implementation of NdrGetUserMarshalInfo.
by Rob Shearman 21 Jan '09

21 Jan '09

2009/1/21 Hans Leidekker <hans(a)codeweavers.com>: > > diff --git a/dlls/rpcrt4/rpcrt4.spec b/dlls/rpcrt4/rpcrt4.spec > index 2c86e68..56a55f6 100644 > --- a/dlls/rpcrt4/rpcrt4.spec > +++ b/dlls/rpcrt4/rpcrt4.spec > @@ -203,7 +203,7 @@ > @ stub NdrGetSimpleTypeBufferSize # wxp > @ stub NdrGetSimpleTypeMemorySize # wxp > @ stub NdrGetTypeFlags # wxp > -@ stub NdrGetUserMarshallInfo > +@ stdcall NdrGetUserMarshalInfo(ptr long ptr) > @ stub NdrHardStructBufferSize #(ptr ptr ptr) > @ stub NdrHardStructFree #(ptr ptr ptr) > @ stub NdrHardStructMarshall #(ptr ptr ptr) > diff --git a/dlls/rpcrt4/rpcrt4_main.c b/dlls/rpcrt4/rpcrt4_main.c > index 537a005..1a6b61d 100644 > --- a/dlls/rpcrt4/rpcrt4_main.c > +++ b/dlls/rpcrt4/rpcrt4_main.c > @@ -1016,3 +1016,9 @@ RPC_STATUS RPC_ENTRY RpcCancelThreadEx(void* ThreadHandle, LONG Timeout) > else > return rpc_cancel_thread(target_tid); > } > + > +RPC_STATUS RPC_ENTRY NdrGetUserMarshalInfo(ULONG *flags, ULONG level, NDR_USER_MARSHAL_INFO *mi) > +{ > + FIXME("(%p, %u, %p)\n", flags, level, mi); > + return RPC_X_INVALID_BUFFER; > +} Since this function has the prefix Ndr it should go in an ndr_*.c file in rpcrt4, not one of the others (I would suggest ndr_marshall.c next to the user marshal functions, which initialise the data structure that it operates on). It also lacking a winapi comment. -- Rob Shearman

1 0

Problems with configure on Mac
by James Mckenzie 21 Jan '09

21 Jan '09

All: When I run the configure script for 1.1.13 on my Mac, at the end it states that the jpeg and png development libraries could not be found and thus support for these two file types will not be incorporated. I checked my system and the libraries are there and I added symlinks to /usr/lib from the Fink installation directories. What do I need to do in order to get this to work? Also I noticed that a program called conftest is called using otool. How do I disable the deletion of this program so that I can manually run this program? If that is not possible, how do I build this program? Reading through the configure script is a little difficult, but not impossible.... James McKenzie

2 1

Re: Adjust dlls/iphlpapi/ipstats.c to FreeBSD 8
by Francois Gouget 21 Jan '09

21 Jan '09

On Thu, 1 Jan 2009, Gerald Pfeifer wrote: [...] > ChangeLog: > Only use RTF_LLINFO if #defined, fixing FreeBSD 8 after the arp-v2 > rewrite. [...] > #if defined(HAVE_SYS_SYSCTL_H) && defined(NET_RT_DUMP) > - int mib[] = {CTL_NET, PF_ROUTE, 0, AF_INET, NET_RT_FLAGS, RTF_LLINFO}; > + int mib[] = {CTL_NET, PF_ROUTE, 0, AF_INET, NET_RT_FLAGS, > +#ifdef RTF_LLINFO > + RTF_LLINFO > +#else > + 0 > +#endif > + }; Is there a way to do it so the same binary can run and work on FreeBSD 7.x and 8.0? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

3 3