January 2009 - Wine-devel - list.winehq.org

Re: shell32: initial stub for SHGetImageList
by Nikolay Sivov 20 Jan '09

20 Jan '09

Aric Stewart wrote: > --- > dlls/shell32/shell32.spec | 1 + > dlls/shell32/shellord.c | 6 ++++++ > 2 files changed, 7 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Should be -noname.

2 2

Today's git does not compile
by Susan Cragin 20 Jan '09

20 Jan '09

At least, it doesn't for me... O2 -o wowthunk.o wowthunk.c ../../tools/winebuild/winebuild -D_REENTRANT -fPIC --as-cmd "as" -o relay16asm.o --relay16 ../../tools/wmc/wmc -i -U -H /dev/null -o nls/winerr_deu.mc.rc nls/winerr_deu.mc ../../tools/wmc/wmc -i -U -H /dev/null -o nls/winerr_enu.mc.rc nls/winerr_enu.mc ../../tools/wmc/wmc -i -U -H /dev/null -o nls/winerr_fra.mc.rc nls/winerr_fra.mc ../../tools/wmc/wmc -i -U -H /dev/null -o nls/winerr_kor.mc.rc nls/winerr_kor.mc ../../tools/wmc/wmc -i -U -H /dev/null -o nls/winerr_nor.mc.rc nls/winerr_nor.mc ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -D_KERNEL32_ -fokernel.res kernel.rc Source: �̤� a2 cc a4 eb Unicode: 5341 6708 Back: �Q�� a4 51 a4 eb nls/cht.nls:84:16: Error: String �̤� does not convert identically to Unicode and back in codepage 950. Try using a Unicode string instead make[2]: *** [kernel.res] Error 1 make[2]: Leaving directory `/home/susan/wine/dlls/kernel32' make[1]: *** [kernel32] Error 2 make[1]: Leaving directory `/home/susan/wine/dlls' make: *** [dlls] Error 2 susan(a)ubuntu:~/wine$

2 1

CVS/GIT removal
by Austin English 20 Jan '09

20 Jan '09

All CVS/GIT versions have been moved. Whoever's got bugzilla admin privileges, please delete that version. -- -Austin

1 0

Re: [5/9] Add support of WDM drivers for USB devices.
by Alexandre Julliard 20 Jan '09

20 Jan '09

Alexander Morozov <amorozov(a)etersoft.ru> writes: > From ed6e12ca39e194829ad8d6be4fbd91d9f276d435 Mon Sep 17 00:00:00 2001 > From: Alexander Morozov <amorozov(a)etersoft.ru> > Date: Fri, 3 Oct 2008 17:57:00 +0400 > Subject: [PATCH] Add support of WDM drivers for USB devices. > > --- > configure.ac | 14 ++ > dlls/wineusbhub/Makefile.in | 15 ++ > dlls/wineusbhub/wineusbhub.c | 291 +++++++++++++++++++++++++++++++++++++++ > dlls/wineusbhub/wineusbhub.spec | 7 + > programs/winedevice/Makefile.in | 2 +- > programs/winedevice/device.c | 79 +++++++++++- > programs/wineusb/Makefile.in | 15 ++ > programs/wineusb/main.c | 224 ++++++++++++++++++++++++++++++ > server/device.c | 111 +++++++++++++++ > server/protocol.def | 16 ++ > tools/wine.inf.in | 10 ++ > 11 files changed, 782 insertions(+), 2 deletions(-) Your design needs a lot more thought. You can't add all these Wine-specific modules, or make winedevice special-case usb devices, or poll the server for the add_device request like you do. All this needs to be properly integrated in the existing infrastructure. -- Alexandre Julliard julliard(a)winehq.org

2 1

How to distinct different behavior of IE versions
by Thomas Heckel 20 Jan '09

20 Jan '09

Hi, I'm new to the wine development and interested in some bug hunting to gain better compatibility on windows. Just for starts I looked a little bit onto test.winehq.org and there especially why wininet:http was passing on some windows systems and on some failing with "http.c:1837: Test failed: got 12150 expected ERROR_IO_PENDING". 12150 is defined in include/winhttp.h as ERROR_WINHTTP_HEADER_NOT_FOUND. The occurence is dependent on the version of the wininet.dll. If it is 6.xxx the test fails. If the dll is 7.xxx the test passes. The relevant test case "static void test_HttpSendRequestW(int port)" checked in 3 days ago from Hans Leidekker as commit 667e48286e25c56bca98a135db62d723b74ef89e looks for the HTTP header "UA-CPU: x86". But this string is only supported from IE 7 up. It makes sense that this test has to fail on machines with no IE 7+ installed. But how to tackle such things in a test case? Take care of different windows versions is used in various test cases. Can the IE version be found out with a similar mechanism? Or should a test case just ignore such nuances from internet explorer? Thanks in advance Thomas

3 2

Re: [1/5] richedit: Implemented ITextHost for windowed richedit controls.
by Austin English 20 Jan '09

20 Jan '09

On Tue, Jan 20, 2009 at 12:41 AM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > I plan on implementing windowless richedit controls by refactoring out > the references the richedit controls hWnd into an ITextHost > implementation. This way windowless richedit controls can be > implemented using the same code by using the ITextHost implementation > provided to the CreateTextServices function. > > This patch mostly aims to provide an implementation of ITextHost that > can be created and used in the windowed richedit control. Later patches > will use the ITextHost interface to avoid using the richedit controls > hWnd. Once the existing code is able to properly handle to the case > where hWnd is NULL by using ITextHost, then ITextServices can be > implemented using the existing richedit code. > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/editor.c | 71 +++-- > dlls/riched20/editor.h | 49 +++ > dlls/riched20/editstr.h | 7 + > dlls/riched20/txthost.c | 726 +++++++++++++++++++++++++++++++++++++++++++++ > include/textserv.h | 40 --- > 6 files changed, 830 insertions(+), 64 deletions(-) > create mode 100644 dlls/riched20/txthost.c > > > > I just wanted to thank Dylan for all his work on riched, and also for his explanation on his work when submitting patches. While I don't always know what he's fixing, it makes it easier to get an idea what it is he's doing because of his clear explanations on each patchset. -- -Austin

1 0

Re: fix commit 3fe5d80512ec5dbfbb2ee7dbb426be7d582e262e
by Francois Gouget 20 Jan '09

20 Jan '09

On Sat, 17 Jan 2009, Shunichi Fuji wrote: > >http://source.winehq.org/git/wine.git/?a=commit;h=3fe5d80512ec5dbfbb2ee7dbb… > >configure: Check for ESound, FreeType, GPhoto2 and SANE even if their 'xxx-config' tool is missing. [...] if test "x$with_sane" != "xno" then ac_save_CPPFLAGS="$CPPFLAGS" + ac_sane_libs="-lsane" We don't need -lsane here because we're using WINE_CHECK_SONAME() which will add it itself (see LIBS="-l$1 $5... on line 42 or aclocal.m4) and because we're not exporting ac_sane_libs. Having it twice would not hurt but it's less correct. By the way, sane.ds will do a dlopen("libsane.so") to load SANE. That was justified when the dlopen() was done by twain_32.dll, but is it still justified now? Maybe sane.ds should simply link to libsane? That would also 'solve' the 'issue of the extra libraries' that we may have to load before loading libsane (though my understanding is that if libsane requires extra libs and does not link with them that's very much a libsane bug). If we change that then it would be a different matter. if test "x$with_gphoto" != "xno" then ac_save_CPPFLAGS="$CPPFLAGS" + ac_gphoto2_libs="-lgphoto2" AC_CHECK_PROG(gphoto2_devel,gphoto2-config,gphoto2-config,no) This one is right because we export ac_gphoto2_libs in GPHOTO2LIBS. However, I think it would be clearer to do it in the else branch of the test for teh xxx-config tool. So something like this: if test "$gphoto2_devel" != "no" -a "$gphoto2port_devel" != "no" then ... else ac_gphoto2_libs="-lgphoto2" fi ... dnl **** Check for FreeType 2 **** if test "x$with_freetype" != "xno" then + ac_freetype_libs="-lfreetype" AC_CHECK_PROGS(ft_devel,[freetype-config freetype2-config],no) if test "$ft_devel" != "no" then This one looks correct, but again I think it would be clearer to have it in the else branch (even if it's one extra line): if test "$ft_devel" != "no" then ... else ac_freetype_libs="-lfreetype" fi if test "x$with_esd" != xno then save_CFLAGS="$CFLAGS" + ac_esd_libs="-lesd" AC_PATH_PROG(ESDCONFIG, esd-config, no) if test "x$ESDCONFIG" != "xno" then Same here. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

2 1

OpenAL back-end: repost for reconsideration
by FeepingCreature 20 Jan '09

20 Jan '09

After STALKER: Clear Sky failed to generate viable sound output using the existing drivers (in GIT head as of a few days back), I started looking for solutions and stumbled over this thread: http://www.nabble.com/RFC:-OpenAL-Winmm-driver-and-OpenAL32.dll-thunk-was-R… I brought the patch up to speed with current Wine to the best of my knowledge and pasted it here: http://pastebin.com/f2a559a22 It appears to make sound work flawlessly in at least one OpenAL-based game, and I suspect there may be more. In case this driver adds too much of a support/code overhead, would it be possible to add it as a band-aid, until the problem that prevents the other back-ends from working with Clear Sky is fixed? Thanks for your comments. --feep PS: No I'm not running Pulseaudio :) ___________________________________________________________ Der frühe Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: http://mail.yahoo.de

5 4

Re: widl: fix a compiler error
by Rob Shearman 19 Jan '09

19 Jan '09

2009/1/19 Austin English <austinenglish(a)gmail.com>: > diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h > index e6b0369..0851d2b 100644 > --- a/tools/widl/widltypes.h > +++ b/tools/widl/widltypes.h > @@ -539,6 +539,7 @@ static inline enum type_type type_get_type_detect_alias(const type_t *type) > default: > assert(0); > } > + return 0; > } > > #define STATEMENTS_FOR_EACH_FUNC(stmt, stmts) \ Please put the return statement in the default case. -- Rob Shearman

1 0

Re: msi/tests: Make tests pass for Windows Installer 3.0 [2/3]
by James Hawkins 19 Jan '09

19 Jan '09

On Sun, Jan 18, 2009 at 3:38 PM, Ge van Geldorp <ge(a)gse.nl> wrote: > I see different estimated size values for Windows Installer 2.x and 3.0 > compared to 3.1 and later. > Please don't remove the check. It is set, and that's what we're testing. If the value is different on different platforms, then do like we do for other tests and add them to the check. -- James Hawkins

3 3