January 2009 - Wine-devel - list.winehq.org

RE: Wine being targeted for adware
by Eduardo Menezes 16 Jan '09

16 Jan '09

I think a "isolate prefix" option in winecfg (or even winetricks) would be very useful. Undoing symlinks and editing the registry to take out the reference to the root is boring (and I'm not sure only doing this is entirely safe) and this kind of option would make it possible to run untrusted software without worrying. I even ran some malwares in isolated wine prefixes and used diff to see what it did. Learned a lot from this. Anyway, a "nice to have" feature. Best wishes and thanks for this amazing software, 2009/1/14 <wine-devel-request(a)winehq.org> > Date: Wed, 14 Jan 2009 15:07:06 -0500 > From: Nicholas LaRoche <nlaroche(a)vt.edu> > Subject: Re: Wine being targeted for adware > To: Stefan D?singer <stefan(a)codeweavers.com> > Cc: wine-devel(a)winehq.org > Message-ID: <496E45EA.9060603(a)vt.edu> > Content-Type: text/plain; charset=windows-1252; format=flowed > > Stefan D?singer wrote: > >> As long as the facilities exist for keeping an entire wine bottle > >> isolated from other bottles (and ~/) I don't see this being a major > >> issue. > > They don't. > > > > Even if you don't have a drive link pointing out of a bottle, a Windows > app > > running in Wine can still call Linux syscalls(int 0x80). This is > > possible/needed because Windows apps run as a regular Linux process that > > links in Linux libraries which perform linux syscalls. > > > > So any Windows malware can break out of the Wine "sandbox"(which isn't a > > sandbox really) by simply using linux syscalls. > > > > > > > > On more recent distros (FC9/10) SELinux is enabled by default. Rolling a > policy specifically for an untrusted bottle would severely limit the > damage it could do. It could restrict all unnecessary read/write/execute > access outside of the ~/.wine folder for wineserver and the program. > > I see your point though, since none of the aforementioned security > precautions are commonplace or specifically targeted to wine. > > -- Eduardo "Toda Revolução é IMPOSSÍVEL até que se torne INEVITÁVEL!!!" (Leon Trotsky)

4 6

RFC: fd.o file type association integration
by Damjan Jovanovic 16 Jan '09

16 Jan '09

Hi I've hacked together a little program (attached) that creates freedesktop file type associations (eg. open .dev files with Dev-C++ when you double-click them in a file manager) from what Windows programs do in the registry (#13597). Currently it works well, but has to be run explicitly to refresh the associations. Ideally we'd have something in Wine that automatically refreshes the associations when they change, but since they are done in the registry, what's the way to go here? Do it on every wineboot, or in some permanently running process (explorer?) that monitors the registry for changes? Also what is a good way to invent a MIME type for an extension? Currently for a .ext extension I'm just using application/x-wine-ext. Comments much appreciated. Damjan

3 3

WMF Support
by Erich Hoover 16 Jan '09

16 Jan '09

I ran into an issue with WMF files in helping someone get an application to work (Athena Visual Studio) and I worked around it by pre-rendering the application's vector WMF files. I don't currently have the time to resolve the issue, but for when I do I'm curious whether there is a reason that OleLoadPicture* has been implemented manually. It seems that the LGPL "libwmf" has excellent support for both bitmap and vector WMF files (it at least worked for converting the files I had trouble with!), so it seems to me like it would make sense to use this library rather than spinning a separate implementation. Any comments are appreciated. Erich Hoover ehoover(a)mines.edu

4 3

Download Link at budgetdedicated.com not working
by James McKenzie 16 Jan '09

16 Jan '09

Jeremy Newman: Looks like the download-deb page on winehq.org has gone missing again. James McKenzie

5 5

Re: [3/5] user32: Resend: Move character conversion logic to dde_server.d & remove todo's
by Hans Leidekker 16 Jan '09

16 Jan '09

On Wednesday 14 January 2009 08:29:33 Jeff Latimer wrote: > I have tested this a number of ways and I can not see a mechanism that > DDE can determine whether data passed is UNICODE (pData is of type > LPBYTE). In my tests, the case of the server uses a UNICODE window it > is immaterial as to the type of window the client uses but is dependent > on the type of data passed. This has been discussed before, we cannot rely on IsTextUnicode since it's just a heuristic. MSDN mentions that the character set depends on whether the client called DdeInitializeA or DdeInitializeW, and it can be overridden by setting iCodePage in the CONVCONTEXT structure. This suggests to me that we'll need some form of IPC. -Hans

3 4

Re: mshtml: Implement IHTMLDocument5 createComment (resend)
by Alistair Leslie-Hughes 15 Jan '09

15 Jan '09

Hi, Can I get some feedback on this please? Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:496D1EBF.2000800(a)hotmail.com... > Hi, > > Changelog: > mshtml: Implement IHTMLDocument5 createComment > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From 98f08b3836336d2f129413beada591fb8f2f1094 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Tue, 16 Dec 2008 21:49:25 +1100 > Subject: [PATCH] Implement IHTMLDocument5 createComment > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/htmldoc5.c | 28 ++++++++++++++++++++++++++-- > dlls/mshtml/tests/dom.c | 11 +++++++++++ > 2 files changed, 37 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmldoc5.c b/dlls/mshtml/htmldoc5.c > index 34dc4e0..8fdfb68 100644 > --- a/dlls/mshtml/htmldoc5.c > +++ b/dlls/mshtml/htmldoc5.c > @@ -124,8 +124,32 @@ static HRESULT WINAPI > HTMLDocument5_createComment(IHTMLDocument5 *iface, BSTR bs > IHTMLDOMNode **ppRetNode) > { > HTMLDocument *This = HTMLDOC5_THIS(iface); > - FIXME("(%p)->(%s %p)\n", This, debugstr_w(bstrdata), ppRetNode); > - return E_NOTIMPL; > + nsIDOMComment *nsComment; > + HTMLDOMNode *node; > + nsAString str; > + nsresult nsres; > + > + TRACE("(%p)->(%s %p)\n", This, debugstr_w(bstrdata), ppRetNode); > + > + if(!This->nsdoc) { > + WARN("NULL nsdoc\n"); > + return E_UNEXPECTED; > + } > + > + nsAString_Init(&str, bstrdata); > + nsres = nsIDOMHTMLDocument_CreateComment(This->nsdoc, &str, > &nsComment); > + nsAString_Finish(&str); > + if(NS_FAILED(nsres)) { > + ERR("CreateTextNode failed: %08x\n", nsres); > + return E_FAIL; > + } > + > + node = &HTMLCommentElement_Create(This, > (nsIDOMNode*)nsComment)->node; > + nsIDOMElement_Release(nsComment); > + > + *ppRetNode = HTMLDOMNODE(node); > + IHTMLDOMNode_AddRef(HTMLDOMNODE(node)); > + return S_OK; > } > > static HRESULT WINAPI HTMLDocument5_put_onfocusin(IHTMLDocument5 *iface, > VARIANT v) > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 3decd4b..400f83b 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -410,7 +410,9 @@ static IHTMLDocument2 *create_document(void) > { > IHTMLDocument2 *doc; > IHTMLDocument5 *doc5; > + IHTMLDOMNode *comment; > HRESULT hres; > + BSTR str; > > hres = CoCreateInstance(&CLSID_HTMLDocument, NULL, > CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > &IID_IHTMLDocument2, (void**)&doc); > @@ -423,6 +425,15 @@ static IHTMLDocument2 *create_document(void) > return NULL; > } > > + str = a2bstr("testing"); > + hres = IHTMLDocument5_createComment(doc5, str, &comment); > + SysFreeString(str); > + ok(hres == S_OK, "createComment failed: %08x\n", hres); > + if(hres == S_OK) > + { > + IHTMLDOMNode_Release(comment); > + } > + > IHTMLDocument5_Release(doc5); > return doc; > } > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

2 1

Re: user32: Check for bad scroll value and fix return values inEDIT_EM_Scroll
by Alistair Leslie-Hughes 15 Jan '09

15 Jan '09

Hi, Can I get some feedback on this please? Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:496DB2F4.2020505(a)hotmail.com... > Hi, > > Based on a patch by David Hedberg and later Austin English. > Fixes bug 1517. > Corrected test and corrected tab/space issues. > > > Changelog: > user32: Check for bad scroll value and fix return values in EDIT_EM_Scroll > > Best Regards > Alistair Leslie-Hughes > > > > > > -------------------------------------------------------------------------------- > From 398cc9b765070ee10dd429b55f6c3b0cdb5bcc46 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 14 Jan 2009 20:33:08 +1100 > Subject: [PATCH] Check for bad scroll value and fix return values in > EDIT_EM_Scroll > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/user32/edit.c | 18 +++++++++++--- > dlls/user32/tests/edit.c | 55 > ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 4 deletions(-) > > diff --git a/dlls/user32/edit.c b/dlls/user32/edit.c > index 6914906..4cd1497 100644 > --- a/dlls/user32/edit.c > +++ b/dlls/user32/edit.c > @@ -3430,13 +3430,23 @@ static LRESULT EDIT_EM_Scroll(EDITSTATE *es, INT > action) > INT vlc = get_vertical_line_count(es); > /* check if we are going to move too far */ > if(es->y_offset + dy > es->line_count - vlc) > - dy = es->line_count - vlc - es->y_offset; > + { > + dy = es->line_count - vlc - es->y_offset; > + > + /* Make sure we're not trying to scroll backwards here */ > + if(es->y_offset + dy < 0) > + dy = 0; > + } > > - /* Notification is done in EDIT_EM_LineScroll */ > - if(dy) > + /* Notification is done in EDIT_EM_LineScroll */ > + if(dy) > EDIT_EM_LineScroll(es, 0, dy); > } > - return MAKELONG((INT16)dy, (BOOL16)TRUE); > + > + if(dy) > + return MAKELONG((INT16)dy, (BOOL16)TRUE); > + else > + return (LRESULT)FALSE; > } > > > diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c > index b1a9820..ec4759e 100644 > --- a/dlls/user32/tests/edit.c > +++ b/dlls/user32/tests/edit.c > @@ -1205,6 +1205,60 @@ static void test_edit_control_5(void) > DestroyWindow(hWnd); > } > > +static void test_edit_control_6(void) > +{ > + HWND hwEdit; > + LONG r; > + > + static const char *single_line_str = "a"; > + static const char *multiline_str = "Test\nText"; > + > + /* Check the return value when EM_SCROLL doesn't actually scroll > anything. */ > + > + hwEdit = CreateWindow( > + "EDIT", > + single_line_str, > + WS_VSCROLL | ES_MULTILINE, > + 1, 1, 35, 35, > + NULL, NULL, hinst, NULL); > + > + assert(hwEdit); > + > + trace("EDIT: Scrolling down one page \n"); > + r = SendMessage(hwEdit, EM_SCROLL, SB_PAGEDOWN, 0); > + ok(!r, "Returned %x\n", r); > + > + trace("EDIT: Scrolling up one page \n"); > + r = SendMessage(hwEdit, EM_SCROLL, SB_PAGEUP, 0); > + ok(!r, "Returned %x\n", r); > + > + trace("EDIT: Scrolling up one line\n"); > + r = SendMessage(hwEdit, EM_SCROLL, SB_LINEUP, 0); > + ok(!r, "Returned %x\n", r); > + > + trace("EDIT: Scrolling down one line\n"); > + r = SendMessage(hwEdit, EM_SCROLL, SB_LINEDOWN, 0); > + ok(!r, "Returned %x\n", r); > + > + DestroyWindow (hwEdit); > + > + /* Check for bug in wine where sending SB_PAGEDOWN causes > + EDIT_EM_Scroll to return a negative amount of scrolled lines. */ > + > + hwEdit = CreateWindow( > + "EDIT", > + multiline_str, > + ES_MULTILINE, > + 0, 0, 50, 1000, > + NULL, NULL, hinst, NULL); > + assert(hwEdit); > + > + r = SendMessage(hwEdit, EM_SCROLL, SB_PAGEDOWN, 0); > + ok(!r, "Returned %x\n", r); > + > + DestroyWindow (hwEdit); > +} > + > static void test_edit_control_limittext(void) > { > HWND hwEdit; > @@ -2058,6 +2112,7 @@ START_TEST(edit) > test_edit_control_3(); > test_edit_control_4(); > test_edit_control_5(); > + test_edit_control_6(); > test_edit_control_limittext(); > test_margins(); > test_margins_font_change(); > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Wine being targeted for adware
by Jeff Zaroyko 15 Jan '09

15 Jan '09

http://philosecurity.org/2009/01/12/interview-with-an-adware-author In an interesting interview, former adware author Matt Knox mentions that he was able to run his adware client on Wine: S: In your professional opinion, how can people avoid adware? M: Um, run UNIX. S: [ laughs] M: We did actually get the ad client working under Wine on Linux. S: That seems like a bit of a stretch! M: That was a pretty limited market, I'd say.

7 12

Re: iphplpai/ipstats.c: only use RTF_MULTICAST if available (try 2)
by James Hawkins 15 Jan '09

15 Jan '09

On Thu, Jan 15, 2009 at 12:48 PM, Austin English <austinenglish(a)gmail.com> wrote: > RTF_MULTICAST isn't available on NetBSD/OpenBSD (possibly others) > > Changelog: > Moved to a #define 0 at the top of the file to get rid of ugly ifdef's > Forgot the patch. -- James Hawkins

1 0

Re: Wine runs IE7!
by James Mckenzie 15 Jan '09

15 Jan '09

Austin English <austinenglish(a)gmail.com> wrote: >Sent: Jan 15, 2009 1:04 PM >To: Michael Stefaniuc <mstefani(a)redhat.com> >Cc: James Mckenzie <jjmckenzie51(a)earthlink.net>, wine-devel(a)winehq.org >Subject: Re: Wine runs IE7! > >On Thu, Jan 15, 2009 at 1:53 PM, Michael Stefaniuc <mstefani(a)redhat.com> wrote: >> James Mckenzie wrote: >>> Hans Leidekker <hans(a)codeweavers.com> >>>> Sent: Jan 15, 2009 10:45 AM >>>> To: wine-devel(a)winehq.org >>>> Subject: Wine runs IE7! >>>> >>>> >>>> Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet >>>> that I had to implement, stub and override my way past before it would >>>> render a page, but finally, here's the obligatory screenshot. >>> >>> Good work. Now where are those patches....;-) >> You know you can look it up yourself? >> git log --author="Hans Leidekker" origin/master >> > >Correct me if I'm wrong, but I don't think all the patches are in yet: >http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Hans+Lei… > >Looking through the first couple pages, I don't see any comctl32 patches. > Boy, talk about folks taking a joke the wrong way. The wink should have been a hint. I'm happy that Hans got IE 7 working and installed. I also think there is more work to be done before it can be fully used and then there should be patches submitted to implement this either in Wine Gecko or to allow installation of this product in Wine. Again, good job Hans and thank you for the screen shot showing IE7 can work with Wine. James McKenzie

1 0