January 2009 - Wine-devel - list.winehq.org

Re: [setupapi/tests] Fix some test failures on win9x
by Alexandre Julliard 14 Jan '09

14 Jan '09

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > Win9x returns the system directory instead of system32. Decided against using > broken() for this but could be convinced otherwise ;). GetSystemDirectory is probably better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Functions that should be static
by Francois Gouget 14 Jan '09

14 Jan '09

I have attached a script that identifies functions that should be made static (among other things). There are approximately 450 of them, there should be pretty efw false positives, and I will look into them eventually. But if someone beats me to it I sure won't complain <g>. So if you do try to tackle them you are likely to find that they fall into one of the following categories: 1) Unused debug functions. For instance for dumping the contents of a structure to stderr. Although these are unused we probably want to keep them. Let me know about these and I will put them in an exception list. 2) Functions that should be exported by a spec file It happens. Sometimes the developer implementing a function just forgets to add it to the spec file! 3) Generated functions This typically happens with widl: it generates a bunch of functions for the client / server and proxy cases, but these functions may be unused. I have special code to not warn about these, but there may be other cases. For instance in the list below you will find a number of yy*() functions generated by lex. Either we can tell lex to make them static or to not generate them, or I should make another special case. If you find some of these, let me know. 4) Assembly functions I believe there should not be any of these in the list below. So if you find one let me know. 5) Functions declared in a private header file but implemented and used from a single C file. I'm in favor of removing these functions from the private header and making them static. 6) All the others should be pretty clear-cut. dlls/advapi32/advapi32.dll.so: CRYPT_DESkey8to7 dlls/browseui/tests/browseui_test.exe.so: strdup_AtoW dlls/browseui/tests/browseui_test.exe.so: TestACL_ACList_AddRef dlls/browseui/tests/browseui_test.exe.so: TestACL_ACList_QueryInterface dlls/browseui/tests/browseui_test.exe.so: TestACL_ACList_Release dlls/browseui/tests/browseui_test.exe.so: TestACL_AddRef dlls/browseui/tests/browseui_test.exe.so: TestACL_Clone dlls/browseui/tests/browseui_test.exe.so: TestACL_Expand dlls/browseui/tests/browseui_test.exe.so: TestACL_Next dlls/browseui/tests/browseui_test.exe.so: TestACL_QueryInterface dlls/browseui/tests/browseui_test.exe.so: TestACL_Release dlls/browseui/tests/browseui_test.exe.so: TestACL_Reset dlls/browseui/tests/browseui_test.exe.so: TestACL_Skip dlls/cabinet/cabinet.dll.so: checksum dlls/cabinet/cabinet.dll.so: make_decode_table dlls/cabinet/cabinet.dll.so: QTMupdatemodel dlls/comctl32/tests/comctl32_test.exe.so: flush_sequence dlls/comdlg32/comdlg32.dll.so: CC_WMCommand dlls/crypt32/crypt32.dll.so: ContextList_Empty dlls/dbghelp/dbghelp.dll.so: hash_table_find dlls/dbghelp/dbghelp.dll.so: hash_table_hash dlls/dbghelp/dbghelp.dll.so: module_find_by_name dlls/dbghelp/dbghelp.dll.so: module_get_container dlls/dinput/dinput.dll.so: DIEnumDevicesCallbackAtoW dlls/dmime/dmime.dll.so: DMUSIC_CreateDirectMusicobjImpl dlls/dmime/dmime.dll.so: DMUSIC_CreateDirectMusicPatternTrackImpl dlls/dmusic/dmusic.dll.so: DMUSIC_CreateDirectMusicBufferImpl dlls/dmusic/dmusic.dll.so: DMUSIC_CreateDirectMusicDownloadedInstrumentImpl dlls/dmusic/dmusic.dll.so: DMUSIC_CreateDirectMusicDownloadImpl dlls/dnsapi/dnsapi.dll.so: dns_ns_name_pton dlls/dplayx/dplayx.dll.so: cbDeleteGroupsElem dlls/dplayx/dplayx.dll.so: cbDeletePlayerElem dlls/dplayx/dplayx.dll.so: DPLAYX_DestroyLobbyApplication dlls/dplayx/dplayx.dll.so: DPLAYX_SetLocalSession dlls/dplayx/dplayx.dll.so: NS_GetOtherMagic dlls/dplayx/dplayx.dll.so: NS_SetRemoteComputerAsNameServer dlls/dsound/dsound.dll.so: DirectSoundCaptureDevice_AddRef dlls/fusion/fusion.dll.so: assembly_get_architecture dlls/fusion/fusion.dll.so: CompareAssemblyIdentity dlls/fusion/fusion.dll.so: GetAssemblyIdentityFromFile dlls/inetcomm/inetcomm.dll.so: InternetTransport_Read dlls/iphlpapi/iphlpapi.dll.so: getInterfaceEntryByIndex dlls/iphlpapi/iphlpapi.dll.so: getInterfacePhysicalByName dlls/itss/itss.dll.so: chm_enumerate dlls/jscript/jscript.dll.so: jsdisp_call dlls/jscript/jscript.dll.so: parser_parse dlls/mountmgr.sys/mountmgr.sys.so: DriverEntry dlls/msacm32/msacm32.dll.so: MSACM_UnregisterLocalDriver dlls/mshtml/mshtml.dll.so: HTMLElementCollection_Create dlls/msi/msi.dll.so: cond_parse dlls/msi/msi.dll.so: ControlEvent_UnSubscribeToEvent dlls/msi/msi.dll.so: db_get_raw_stream dlls/msi/msi.dll.so: encode_streamname dlls/msi/msi.dll.so: find_published_source dlls/msi/msi.dll.so: MSI_DatabaseExport dlls/msi/msi.dll.so: MSI_DatabaseImport dlls/msi/msi.dll.so: msi_dialog_register_class dlls/msi/msi.dll.so: MSI_EnableUIPreview dlls/msi/msi.dll.so: msi_id2stringA dlls/msi/msi.dll.so: msi_id2stringW dlls/msi/msi.dll.so: msi_load_media_info dlls/msi/msi.dll.so: MSI_PreviewDialogW dlls/msi/msi.dll.so: MSI_RecordDataSize dlls/msi/msi.dll.so: MSI_RecordSetStream dlls/msi/msi.dll.so: MSI_RecordSetStringA dlls/msi/msi.dll.so: MSIREG_OpenInstallerFeaturesKey dlls/msi/msi.dll.so: msi_strcmp dlls/msi/msi.dll.so: msi_string2idA dlls/msi/msi.dll.so: msi_ui_error dlls/msi/msi.dll.so: msi_version_dword_to_str dlls/msi/msi.dll.so: reduce_to_shortfilename dlls/msi/msi.dll.so: sql_parse dlls/msxml3/msxml3.dll.so: httprequest_Release dlls/msxml3/msxml3.dll.so: XMLElementCollection_create dlls/netapi32/netapi32.dll.so: NBNameCacheUpdateNBName dlls/ole32/ole32.dll.so: IMalloc16_Constructor dlls/qcap/qcap.dll.so: FreeMediaType dlls/qcap/qcap.dll.so: IPinImpl_QueryInternalConnections dlls/quartz/quartz.dll.so: MemInputPin_AddRef dlls/quartz/quartz.dll.so: MemInputPin_GetAllocator dlls/quartz/quartz.dll.so: MemInputPin_GetAllocatorRequirements dlls/quartz/quartz.dll.so: MemInputPin_NotifyAllocator dlls/quartz/quartz.dll.so: MemInputPin_QueryInterface dlls/quartz/quartz.dll.so: MemInputPin_Receive dlls/quartz/quartz.dll.so: MemInputPin_ReceiveCanBlock dlls/quartz/quartz.dll.so: MemInputPin_ReceiveMultiple dlls/quartz/quartz.dll.so: MemInputPin_Release dlls/quartz/quartz.dll.so: OutputPin_DeliverNewSegment dlls/riched20/riched20.dll.so: ME_ConcatString dlls/riched20/riched20.dll.so: ME_CopyToCF2W dlls/riched20/riched20.dll.so: ME_DestroyEditor dlls/riched20/riched20.dll.so: ME_DITypesEqual dlls/riched20/riched20.dll.so: ME_DrawParagraph dlls/riched20/riched20.dll.so: ME_FindItemFwdOrHere dlls/riched20/riched20.dll.so: ME_FindNextURLCandidate dlls/riched20/riched20.dll.so: ME_FindRowStart dlls/riched20/riched20.dll.so: ME_GetOptimalBuffer dlls/riched20/riched20.dll.so: ME_GetParaFormat dlls/riched20/riched20.dll.so: ME_GetYScrollVisible dlls/riched20/riched20.dll.so: ME_InvalidateFromOfs dlls/riched20/riched20.dll.so: ME_IsCandidateAnURL dlls/riched20/riched20.dll.so: ME_LinkNotify dlls/riched20/riched20.dll.so: ME_MakeEditor dlls/riched20/riched20.dll.so: ME_MakeStringB dlls/riched20/riched20.dll.so: ME_MarkForWrapping dlls/riched20/riched20.dll.so: ME_QueueInvalidateFromCursor dlls/riched20/riched20.dll.so: ME_Scroll dlls/riched20/riched20.dll.so: ME_SelectByType dlls/riched20/riched20.dll.so: ME_SetParaFormat dlls/riched20/riched20.dll.so: ME_ToCFAny dlls/riched20/riched20.dll.so: ME_UpdateLinkAttribute dlls/riched20/riched20.dll.so: ME_UpdateSelection dlls/riched20/riched20.dll.so: ME_UpdateSelectionLinkAttribute dlls/riched20/riched20.dll.so: REComboWndProc dlls/riched20/riched20.dll.so: REListWndProc dlls/riched20/riched20.dll.so: RTFExpandStyle dlls/riched20/riched20.dll.so: RTFGetClassCallback dlls/riched20/riched20.dll.so: RTFGetDestinationCallback dlls/riched20/riched20.dll.so: RTFGetInputName dlls/riched20/riched20.dll.so: RTFGetOutputName dlls/riched20/riched20.dll.so: RTFGetReadHook dlls/riched20/riched20.dll.so: RTFGetStyle dlls/riched20/riched20.dll.so: RTFHexToChar dlls/riched20/riched20.dll.so: RTFPeekToken dlls/riched20/riched20.dll.so: RTFSetClassCallback dlls/riched20/riched20.dll.so: RTFSetInputName dlls/riched20/riched20.dll.so: RTFSetOutputName dlls/riched20/riched20.dll.so: RTFSetToken dlls/riched20/riched20.dll.so: RTFUngetToken dlls/rpcrt4/rpcrt4.dll.so: NCA2RPC_STATUS dlls/rpcrt4/rpcrt4.dll.so: NdrByteCountPointerMemorySize dlls/rpcrt4/rpcrt4.dll.so: NdrRangeBufferSize dlls/rpcrt4/rpcrt4.dll.so: NdrRangeFree dlls/rpcrt4/rpcrt4.dll.so: NdrRangeMarshall dlls/rpcrt4/rpcrt4.dll.so: NdrRangeMemorySize dlls/rpcrt4/rpcrt4.dll.so: RPCRT4_receive_fragment dlls/rpcrt4/rpcrt4.dll.so: RPCRT4_SpawnConnection dlls/rpcrt4/rpcrt4.dll.so: RPCRT4_ValidateCommonHeader dlls/rsaenh/rsaenh.dll.so: alloc_handle_table dlls/rsaenh/rsaenh.dll.so: mp_2expt dlls/rsaenh/rsaenh.dll.so: mp_abs dlls/rsaenh/rsaenh.dll.so: mp_add_d dlls/rsaenh/rsaenh.dll.so: mp_clamp dlls/rsaenh/rsaenh.dll.so: mp_clear dlls/rsaenh/rsaenh.dll.so: mp_cmp_mag dlls/rsaenh/rsaenh.dll.so: mp_cnt_lsb dlls/rsaenh/rsaenh.dll.so: mp_div dlls/rsaenh/rsaenh.dll.so: mp_div_2 dlls/rsaenh/rsaenh.dll.so: mp_div_2d dlls/rsaenh/rsaenh.dll.so: mp_div_d dlls/rsaenh/rsaenh.dll.so: mp_dr_reduce dlls/rsaenh/rsaenh.dll.so: mp_dr_setup dlls/rsaenh/rsaenh.dll.so: mp_exch dlls/rsaenh/rsaenh.dll.so: mp_grow dlls/rsaenh/rsaenh.dll.so: mp_init dlls/rsaenh/rsaenh.dll.so: mp_init_size dlls/rsaenh/rsaenh.dll.so: mp_lshd dlls/rsaenh/rsaenh.dll.so: mp_mod_2d dlls/rsaenh/rsaenh.dll.so: mp_mod_d dlls/rsaenh/rsaenh.dll.so: mp_montgomery_calc_normalization dlls/rsaenh/rsaenh.dll.so: mp_montgomery_reduce dlls/rsaenh/rsaenh.dll.so: mp_montgomery_setup dlls/rsaenh/rsaenh.dll.so: mp_mul_2 dlls/rsaenh/rsaenh.dll.so: mp_mul_2d dlls/rsaenh/rsaenh.dll.so: mp_mul_d dlls/rsaenh/rsaenh.dll.so: mp_prime_is_divisible dlls/rsaenh/rsaenh.dll.so: mp_prime_is_prime dlls/rsaenh/rsaenh.dll.so: mp_prime_miller_rabin dlls/rsaenh/rsaenh.dll.so: mp_reduce dlls/rsaenh/rsaenh.dll.so: mp_reduce_2k dlls/rsaenh/rsaenh.dll.so: mp_reduce_2k_setup dlls/rsaenh/rsaenh.dll.so: mp_reduce_setup dlls/rsaenh/rsaenh.dll.so: mp_rshd dlls/rsaenh/rsaenh.dll.so: mp_set dlls/rsaenh/rsaenh.dll.so: mp_signed_bin_size dlls/rsaenh/rsaenh.dll.so: mp_sqr dlls/rsaenh/rsaenh.dll.so: mp_sqrmod dlls/rsaenh/rsaenh.dll.so: mp_zero dlls/rsaenh/rsaenh.dll.so: release_handle_table dlls/sane.ds/sane.ds.so: SANE_AutomaticCaptureDirectory dlls/sane.ds/sane.ds.so: SANE_FileSystemCopy dlls/sane.ds/sane.ds.so: SANE_PendingXfersStopFeeder dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2Get dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2GetDefault dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2Reset dlls/sane.ds/sane.ds.so: SANE_SetupFileXfer2Set dlls/secur32/secur32.dll.so: SECUR32_initNegotiateSP dlls/secur32/secur32.dll.so: SECUR32_strdupW dlls/setupapi/setupapi.dll.so: PARSER_string_substW dlls/setupapi/setupapi.dll.so: VcpEnumFiles dlls/setupapi/setupapi.dll.so: VcpFlush16 dlls/setupapi/setupapi.dll.so: vsmStringCompare16 dlls/setupapi/setupapi.dll.so: vsmStringFind16 dlls/shell32/shell32.dll.so: HCR_GetDefaultIconFromGUIDW dlls/shell32/shell32.dll.so: ILGetDisplayNameExA dlls/shell32/shell32.dll.so: _ILGetSTextPointer dlls/shell32/shell32.dll.so: _ILGetTextPointerW dlls/shell32/shell32.dll.so: RenderFILECONTENTS dlls/shell32/shell32.dll.so: RenderFILEDESCRIPTOR dlls/shell32/shell32.dll.so: RenderPREFEREDDROPEFFECT dlls/shell32/shell32.dll.so: RenderSHELLIDLISTOFFSET dlls/shell32/shell32.dll.so: SHILCreateFromPathA dlls/shell32/shell32.dll.so: TRASH_DisposeElement dlls/shell32/shell32.dll.so: XDG_GetPath dlls/user32/user32.dll.so: EditWndProcW dlls/user32/user32.dll.so: LookupIconIdFromDirectory16 dlls/uxtheme/uxtheme.dll.so: UXINI_ResetINI dlls/w32skrnl/w32skrnl.dll.so: _GetThunkBuff dlls/winealsa.drv/winealsa.drv.so: ALSA_PeekRingMessage dlls/winealsa.drv/winealsa.drv.so: wodSetVolume dlls/winedos/winedos.dll.so: DOSDEV_Console dlls/winedos/winedos.dll.so: DOSDEV_FindCharDevice dlls/winedos/winedos.dll.so: DOSDEV_IoctlRead dlls/winedos/winedos.dll.so: DOSDEV_IoctlWrite dlls/winedos/winedos.dll.so: DOSDEV_Peek dlls/winedos/winedos.dll.so: DOSDEV_Read dlls/winedos/winedos.dll.so: DOSDEV_Write dlls/winedos/winedos.dll.so: DOSVM_AllocCodeUMB dlls/winedos/winedos.dll.so: DOSVM_AllocUMB dlls/winedos/winedos.dll.so: DPMI_FreeInternalRMCB dlls/winedos/winedos.dll.so: VGA_SetQuadPalette dlls/winedos/winedos.dll.so: VGA_SetTextAttribute dlls/wineps.drv/wineps.drv.so: PSDRV_CmpColor dlls/wineps.drv/wineps.drv.so: PSDRV_WriteArrayGet dlls/wineps.drv/wineps.drv.so: PSDRV_WriteInitClip dlls/wineps.drv/wineps.drv.so: PSDRV_WriteRRectangle dlls/winex11.drv/winex11.drv.so: X11DRV_get_client_window dlls/winex11.drv/winex11.drv.so: X11DRV_SetupGCForPen dlls/winex11.drv/winex11.drv.so: X11DRV_window_to_X_rect dlls/winex11.drv/winex11.drv.so: X11DRV_XF86VM_SetExclusiveMode dlls/winex11.drv/winex11.drv.so: X11DRV_XRandR_Cleanup dlls/winhttp/winhttp.dll.so: netconn_set_timeout dlls/wininet/wininet.dll.so: HTTP_FinishedReading dlls/wininet/wininet.dll.so: HTTP_GetHeader dlls/wininet/wininet.dll.so: HTTP_HttpOpenRequestW dlls/wininet/wininet.dll.so: HTTP_HttpSendRequestW dlls/winmm/winmm.dll.so: MCI_DefYieldProc dlls/winmm/winmm.dll.so: MCI_GetDriverFromString dlls/winmm/winmm.dll.so: MCI_SendCommandFrom16 dlls/winmm/winmm.dll.so: MCI_SendCommandFrom32 dlls/winmm/winmm.dll.so: MCI_WriteString dlls/wintrust/wintrust.dll.so: CRYPT_AsnEncodeInt dlls/wintrust/wintrust.dll.so: WINTRUST_ReAlloc dlls/wnaspi32/wnaspi32.dll.so: ASPI_SendASPICommand dlls/wnaspi32/wnaspi32.dll.so: SCSI_GetDeviceName dlls/wuapi/wuapi.dll.so: AutomaticUpdates_create programs/cmd/cmd.exe.so: handleExpansion programs/cmd/cmd.exe.so: WCMD_addCommand programs/cmd/cmd.exe.so: WCMD_ask_confirm programs/cmd/cmd.exe.so: WCMD_dir_sort programs/cmd/cmd.exe.so: WCMD_filesize64 programs/cmd/cmd.exe.so: WCMD_opt_s_strip_quotes programs/cmd/cmd.exe.so: WCMD_parse programs/cmd/cmd.exe.so: WCMD_show_prompt programs/cmd/cmd.exe.so: WCMD_strrev programs/cmd/cmd.exe.so: WCMD_strtrim_trailing_spaces programs/oleview/oleview.exe.so: AddToStrW programs/oleview/oleview.exe.so: AddToTLDataStrW programs/oleview/oleview.exe.so: AddToTLDataStrWithTabsW programs/oleview/oleview.exe.so: CreateInstOnProc programs/oleview/oleview.exe.so: DetailsProc programs/oleview/oleview.exe.so: InterfaceViewerProc programs/oleview/oleview.exe.so: PaneProc programs/oleview/oleview.exe.so: SysConfProc programs/oleview/oleview.exe.so: TreeProc programs/oleview/oleview.exe.so: TypeLibProc programs/oleview/oleview.exe.so: WndProc programs/progman/progman.exe.so: DIALOG_Symbol programs/regedit/regedit.exe.so: GetMultiByteStringN programs/regedit/regedit.exe.so: GetRootKeyName programs/regedit/regedit.exe.so: GetWideStringN programs/regedit/regedit.exe.so: HexEdit_Unregister programs/regedit/regedit.exe.so: processRegLinesA programs/regedit/regedit.exe.so: processRegLinesW programs/taskmgr/taskmgr.exe.so: Draw3dRect programs/taskmgr/taskmgr.exe.so: Draw3dRect2 programs/taskmgr/taskmgr.exe.so: FillSolidRect2 programs/taskmgr/taskmgr.exe.so: GraphCtrl_DrawPoint programs/taskmgr/taskmgr.exe.so: GraphCtrl_InvalidateCtrl programs/taskmgr/taskmgr.exe.so: GraphCtrl_Paint programs/taskmgr/taskmgr.exe.so: GraphCtrl_Resize programs/taskmgr/taskmgr.exe.so: TrayIcon_GetProcessorUsageIcon programs/taskmgr/taskmgr.exe.so: UpdateApplicationListControlViewSetting programs/view/view.exe.so: FileIsPlaceable programs/view/view.exe.so: GetPlaceableMetaFile programs/winecfg/winecfg.exe.so: enumerate_valuesW programs/wineconsole/wineconsole.exe.so: WCUSER_AreFontsEqual programs/wineconsole/wineconsole.exe.so: WINECON_FetchCells programs/wineconsole/wineconsole.exe.so: WINECON_GetHistoryMode programs/wineconsole/wineconsole.exe.so: WINECON_SetHistoryMode programs/wineconsole/wineconsole.exe.so: WINECON_SetHistorySize programs/winedbg/winedbg.exe.so: be_cpu_build_addr programs/winedbg/winedbg.exe.so: be_cpu_linearize programs/winedbg/winedbg.exe.so: dbg_alloc programs/winedbg/winedbg.exe.so: dbg__create_buffer programs/winedbg/winedbg.exe.so: dbg__delete_buffer programs/winedbg/winedbg.exe.so: dbg__flush_buffer programs/winedbg/winedbg.exe.so: dbg_free programs/winedbg/winedbg.exe.so: dbg_get_debug programs/winedbg/winedbg.exe.so: dbg_get_in programs/winedbg/winedbg.exe.so: dbg_get_leng programs/winedbg/winedbg.exe.so: dbg_get_lineno programs/winedbg/winedbg.exe.so: dbg_get_out programs/winedbg/winedbg.exe.so: dbg_get_text programs/winedbg/winedbg.exe.so: dbg_lex_destroy programs/winedbg/winedbg.exe.so: dbg_outputA programs/winedbg/winedbg.exe.so: dbg_parse programs/winedbg/winedbg.exe.so: dbg_pop_buffer_state programs/winedbg/winedbg.exe.so: dbg_push_buffer_state programs/winedbg/winedbg.exe.so: dbg_realloc programs/winedbg/winedbg.exe.so: dbg_restart programs/winedbg/winedbg.exe.so: dbg__scan_buffer programs/winedbg/winedbg.exe.so: dbg__scan_bytes programs/winedbg/winedbg.exe.so: dbg__scan_string programs/winedbg/winedbg.exe.so: dbg_set_debug programs/winedbg/winedbg.exe.so: dbg_set_in programs/winedbg/winedbg.exe.so: dbg_set_lineno programs/winedbg/winedbg.exe.so: dbg_set_out programs/winedbg/winedbg.exe.so: dbg__switch_to_buffer programs/winedbg/winedbg.exe.so: dbg_wrap programs/winedbg/winedbg.exe.so: expr_alloc_uconstant programs/winedbg/winedbg.exe.so: lexeme_alloc programs/winedbg/winedbg.exe.so: parser programs/winedbg/winedbg.exe.so: validate_file programs/winemine/winemine.exe.so: AboutDlgProc programs/winemine/winemine.exe.so: AddFlag programs/winemine/winemine.exe.so: CompleteBox programs/winemine/winemine.exe.so: CompleteBoxes programs/winemine/winemine.exe.so: CreateBoard programs/winemine/winemine.exe.so: DestroyBoard programs/winemine/winemine.exe.so: DrawBoard programs/winemine/winemine.exe.so: DrawFace programs/winemine/winemine.exe.so: DrawLeds programs/winemine/winemine.exe.so: DrawMine programs/winemine/winemine.exe.so: DrawMines programs/winemine/winemine.exe.so: InitBoard programs/winemine/winemine.exe.so: LoadBoard programs/winemine/winemine.exe.so: MainProc programs/winemine/winemine.exe.so: PlaceMines programs/winemine/winemine.exe.so: PressBox programs/winemine/winemine.exe.so: PressBoxes programs/winemine/winemine.exe.so: SaveBoard programs/winemine/winemine.exe.so: SetDifficulty programs/winemine/winemine.exe.so: TestBoard programs/winemine/winemine.exe.so: TestFace programs/winemine/winemine.exe.so: TestMines programs/winemine/winemine.exe.so: UnpressBox programs/winemine/winemine.exe.so: UnpressBoxes programs/winhlp32/winhlp32.exe.so: HLPFILE_BPTreeSearch programs/winhlp32/winhlp32.exe.so: HLPFILE_Contents programs/winhlp32/winhlp32.exe.so: HLPFILE_HalfPointsToTwips programs/winhlp32/winhlp32.exe.so: MACRO_AddAccelerator programs/winhlp32/winhlp32.exe.so: MACRO_ALink programs/winhlp32/winhlp32.exe.so: MACRO_AppendItem programs/winhlp32/winhlp32.exe.so: MACRO_Back programs/winhlp32/winhlp32.exe.so: MACRO_BackFlush programs/winhlp32/winhlp32.exe.so: MACRO_BookmarkMore programs/winhlp32/winhlp32.exe.so: MACRO_BrowseButtons programs/winhlp32/winhlp32.exe.so: MACRO_ChangeButtonBinding programs/winhlp32/winhlp32.exe.so: MACRO_ChangeEnable programs/winhlp32/winhlp32.exe.so: MACRO_ChangeItemBinding programs/winhlp32/winhlp32.exe.so: MACRO_CheckItem programs/winhlp32/winhlp32.exe.so: MACRO_CloseSecondarys programs/winhlp32/winhlp32.exe.so: MACRO_CloseWindow programs/winhlp32/winhlp32.exe.so: MACRO_Compare programs/winhlp32/winhlp32.exe.so: MACRO_Contents programs/winhlp32/winhlp32.exe.so: MACRO_ControlPanel programs/winhlp32/winhlp32.exe.so: MACRO_CopyTopic programs/winhlp32/winhlp32.exe.so: MACRO_DeleteItem programs/winhlp32/winhlp32.exe.so: MACRO_DeleteMark programs/winhlp32/winhlp32.exe.so: MACRO_DestroyButton programs/winhlp32/winhlp32.exe.so: MACRO_DisableItem programs/winhlp32/winhlp32.exe.so: MACRO_EnableButton programs/winhlp32/winhlp32.exe.so: MACRO_EnableItem programs/winhlp32/winhlp32.exe.so: MACRO_EndMPrint programs/winhlp32/winhlp32.exe.so: MACRO_ExecFile programs/winhlp32/winhlp32.exe.so: MACRO_ExecProgram programs/winhlp32/winhlp32.exe.so: MACRO_ExtAbleItem programs/winhlp32/winhlp32.exe.so: MACRO_ExtInsertItem programs/winhlp32/winhlp32.exe.so: MACRO_ExtInsertMenu programs/winhlp32/winhlp32.exe.so: MACRO_FileExist programs/winhlp32/winhlp32.exe.so: MACRO_Find programs/winhlp32/winhlp32.exe.so: MACRO_Finder programs/winhlp32/winhlp32.exe.so: MACRO_FloatingMenu programs/winhlp32/winhlp32.exe.so: MACRO_Flush programs/winhlp32/winhlp32.exe.so: MACRO_FocusWindow programs/winhlp32/winhlp32.exe.so: MACRO_Generate programs/winhlp32/winhlp32.exe.so: MACRO_GotoMark programs/winhlp32/winhlp32.exe.so: MACRO_IfThen programs/winhlp32/winhlp32.exe.so: MACRO_IfThenElse programs/winhlp32/winhlp32.exe.so: MACRO_InitMPrint programs/winhlp32/winhlp32.exe.so: MACRO_InsertItem programs/winhlp32/winhlp32.exe.so: MACRO_InsertMenu programs/winhlp32/winhlp32.exe.so: MACRO_IsBook programs/winhlp32/winhlp32.exe.so: MACRO_IsMark programs/winhlp32/winhlp32.exe.so: MACRO_IsNotMark programs/winhlp32/winhlp32.exe.so: MACRO_JumpHelpOn programs/winhlp32/winhlp32.exe.so: MACRO_JumpID programs/winhlp32/winhlp32.exe.so: MACRO_JumpKeyword programs/winhlp32/winhlp32.exe.so: MACRO_KLink programs/winhlp32/winhlp32.exe.so: MACRO_Menu programs/winhlp32/winhlp32.exe.so: MACRO_MPrintHash programs/winhlp32/winhlp32.exe.so: MACRO_MPrintID programs/winhlp32/winhlp32.exe.so: MACRO_Next programs/winhlp32/winhlp32.exe.so: MACRO_NoShow programs/winhlp32/winhlp32.exe.so: MACRO_PopupHash programs/winhlp32/winhlp32.exe.so: MACRO_PopupId programs/winhlp32/winhlp32.exe.so: MACRO_PositionWindow programs/winhlp32/winhlp32.exe.so: MACRO_Prev programs/winhlp32/winhlp32.exe.so: MACRO_RegisterRoutine programs/winhlp32/winhlp32.exe.so: MACRO_RemoveAccelerator programs/winhlp32/winhlp32.exe.so: MACRO_ResetMenu programs/winhlp32/winhlp32.exe.so: MACRO_SaveMark programs/winhlp32/winhlp32.exe.so: MACRO_Search programs/winhlp32/winhlp32.exe.so: MACRO_SetHelpOnFile programs/winhlp32/winhlp32.exe.so: MACRO_SetPopupColor programs/winhlp32/winhlp32.exe.so: MACRO_ShellExecute programs/winhlp32/winhlp32.exe.so: MACRO_ShortCut programs/winhlp32/winhlp32.exe.so: MACRO_TCard programs/winhlp32/winhlp32.exe.so: MACRO_Test programs/winhlp32/winhlp32.exe.so: MACRO_TestALink programs/winhlp32/winhlp32.exe.so: MACRO_TestKLink programs/winhlp32/winhlp32.exe.so: MACRO_UncheckItem programs/winhlp32/winhlp32.exe.so: MACRO_UpdateWindow programs/winhlp32/winhlp32.exe.so: WINHELP_IndexDlgProc programs/winhlp32/winhlp32.exe.so: WINHELP_MessageBoxIDS_s programs/winhlp32/winhlp32.exe.so: WINHELP_SearchDlgProc programs/winhlp32/winhlp32.exe.so: yyalloc programs/winhlp32/winhlp32.exe.so: yy_create_buffer programs/winhlp32/winhlp32.exe.so: yy_delete_buffer programs/winhlp32/winhlp32.exe.so: yy_flush_buffer programs/winhlp32/winhlp32.exe.so: yyfree programs/winhlp32/winhlp32.exe.so: yyget_debug programs/winhlp32/winhlp32.exe.so: yyget_in programs/winhlp32/winhlp32.exe.so: yyget_leng programs/winhlp32/winhlp32.exe.so: yyget_lineno programs/winhlp32/winhlp32.exe.so: yyget_out programs/winhlp32/winhlp32.exe.so: yyget_text programs/winhlp32/winhlp32.exe.so: yylex programs/winhlp32/winhlp32.exe.so: yylex_destroy programs/winhlp32/winhlp32.exe.so: yypop_buffer_state programs/winhlp32/winhlp32.exe.so: yypush_buffer_state programs/winhlp32/winhlp32.exe.so: yyrealloc programs/winhlp32/winhlp32.exe.so: yyrestart programs/winhlp32/winhlp32.exe.so: yy_scan_buffer programs/winhlp32/winhlp32.exe.so: yy_scan_bytes programs/winhlp32/winhlp32.exe.so: yy_scan_string programs/winhlp32/winhlp32.exe.so: yyset_debug programs/winhlp32/winhlp32.exe.so: yyset_in programs/winhlp32/winhlp32.exe.so: yyset_lineno programs/winhlp32/winhlp32.exe.so: yyset_out programs/winhlp32/winhlp32.exe.so: yy_switch_to_buffer programs/winhlp32/winhlp32.exe.so: yywrap -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

5 13

RE: [2/5] wined3d: Remove AddDirtyBox() from the public interface.
by Stefan Dösinger 14 Jan '09

14 Jan '09

I realized that you just removed the calls from surface and volume, where they don't exist in the public d3d9 API. However, textures have such a call in the public d3d9 API - do you know what it is supposed to do, and if this has any implications on this change? > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Henri Verbeet > Sent: Wednesday, January 14, 2009 10:05 AM > To: wine-patches(a)winehq.org > Subject: [2/5] wined3d: Remove AddDirtyBox() from the public interface. >

2 1

Re: setupapi: Add the Romanian translation.
by Paul Vriens 14 Jan '09

14 Jan '09

Michael Stefaniuc wrote: > +/* > + * English resources for SETUPAPI > + * I guess that should be Romanian resources. -- Cheers, Paul.

2 1

Re: ole32: add a test for OleInitialize
by Paul Vriens 14 Jan '09

14 Jan '09

Austin English wrote: > Pointed out by Anastasius in bug 13011. Tested on XP SP2 & 2K SP4 (and > Wine, of course). > > > > ------------------------------------------------------------------------ > > Hi Austin, The test case that is pointed out in bug 13011 is different though: hr = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); ok(hr == S_OK, "CoInitializeEx failed with error 0x%08x\n", hr); hr = OleInitialize(NULL); ok(hr == S_OK, "OleInitialize failed with error 0x%08x\n", hr); The above succeeds on W2K3 but fails on Wine. -- Cheers, Paul.

4 9

Re: [5/5] d3d9: Use D3DFOG_* constants instead of plain integers
by Henri Verbeet 13 Jan '09

13 Jan '09

I think this change is ok, but note that the ok() line for this test will still just print the numeric value.

2 1

Wineaudioio driver
by Francois Gouget 13 Jan '09

13 Jan '09

Does anyone know how to get the libaudioio.h and libaudioio.so files needed by the wineaudioio driver? This driver is supposed to specifically be for Solaris but I could not find either files on the Solaris 10u5 DVD, nor on the 200807 Solaris 10 companion CD. Has audioio been replaced by something else? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

3 3

Re: [2/5] WineD3D: Get rid of last_was_foggy_shader & friends
by Alexandre Julliard 13 Jan '09

13 Jan '09

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This patch "breaks" a set of fog tests, so they're marked as todo. The tests > aren't really working correctly right now anyway, they depend on undefined > default values in opengl. A later patch will make the vertex shader select > the result.fogcoord(and glsl equivalent) depending on the fog settings, thus > really fixing this test. The added todo doesn't fail here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:8746: Tests skipped: D3DFMT_G16R16F textures not supported visual.c:8746: Tests skipped: D3DFMT_G32R32F textures not supported visual.c:7536: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:1540: Test succeeded inside todo block: fog vs1 ps0 fvm0 ftm0 0: got color 0000ff00, expected 0000ff00 +-5%(todo) visual.c:8607: Tests skipped: Only 1 simultaneous render target supported, skipping MRT test make[2]: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wcmd: Fix redirecting a pipe to another pipe
by Andrew Nguyen 13 Jan '09

13 Jan '09

On Sun, Jan 11, 2009 at 12:52 PM, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > Fix a problem with Wine's cmd.exe that causes redirecting a pipe to > another pipe to fail. Can be tested by executing 'echo "test" 2>&1' > in cmd.exe. Without the patch the redirect will fail, with the patch > the redirect is properly handled by existing code. > Changelog: > wcmd: Fix redirecting a pipe to another pipe Please set your real e-mail address in your Git configuration; see http://wiki.winehq.org/GitWine#head-8631765a8d71509690613c9191ed2094c7775722 for directions.

3 2

Re: [2/2] setupapi: Fix resolving target path when given a section. Default to the system directory.
by Alexandre Julliard 13 Jan '09

13 Jan '09

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -68,6 +68,20 @@ static const char inf_data2[] = > "sp1qfe\\winhttp.dll=3EC6F518114606CA59D4160322077437,000500010A280615,331776,SP1QFE\n" > "sp1qfe\\xpob2res.dll=DB83156B9F496F20D1EA70E4ABEC0166,000500010A280622,158720,SP1QFE\n"; > > +static const char inf_data3[] = > + "[Version]\n" > + "Signature = \"$Windows NT$\"\n" > + "[DestinationDirs]\n" > + "CopyAlways.System32.files = 11\n" > + "[CopyAlways.System32.Files]\n" > + "WindowsCodecs.dll\n"; > + > +static const char inf_data4[] = > + "[Version]\n" > + "Signature = \"$Windows NT$\"\n" > + "[CopyAlways.System32.Files]\n" > + "WindowsCodecs.dll\n"; It would be better to use a different directory in the first test so that you can make sure there's a difference. Also you should try setting DefaultDestDir to see how this changes the behavior. -- Alexandre Julliard julliard(a)winehq.org

1 0