January 2009 - Wine-devel - list.winehq.org

cmd.exe AppDB page
by Erich Hoover 12 Jan '09

12 Jan '09

Is there a reason that the cmd.exe AppDB page is locked (http://appdb.winehq.org/objectManager.php?sClass=application&iId=1196)? Erich Hoover ehoover(a)mines.edu

4 10

Re: [1/4] mshtml: Implement IHTMLStyle get/put borderRightStyle
by Jacek Caban 12 Jan '09

12 Jan '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle get/put borderRightStyle > +static BOOL IsValidBorderStyle(BSTR v) - Please use the same name convention as other functions in this file - There is no test proving that the style is validated - You didn't include get_borderRightStyle, which makes put_borderRightStyle almost useless static HRESULT WINAPI HTMLStyle_get_borderLeftStyle(IHTMLStyle *iface, BSTR *p) That's not what changelog says. Jacek

2 2

re:cmd.exe AppDB page
by nn 11 Jan '09

11 Jan '09

Eric, I have created a new AppDB page for cmd.exe as the existing one would not accept new test reports: new AppDB page is: http://appdb.winehq.org/objectManager.php?sClass=application&iId=8995 Submit a test and I will delete the fake report. Nat Stay connected to the people that matter most with a smarter inbox. Take a look http://au.docs.yahoo.com/mail/smarterinbox

1 0

Re: wcmd: Fix redirecting a pipe to another pipe
by Reece Dunn 11 Jan '09

11 Jan '09

2009/1/11 Erich Hoover <ehoover(a)mines.edu>: + /* If a redirect is immediately followed by '&' (ie. 2>&1) then + do nor process that ampersand as an AND operator */ Shouldn't that be "do *not* process that ampersand"? - Reece

3 3

setupapi:parser - suspicious test results
by Rico Schüller 11 Jan '09

11 Jan '09

Hi, concerning to http://test.winehq.org/data/tests/setupapi:parser.html there are some suspicious results for the test from 6-10. January. On my system (F10-x86_64) the setupapi:parser test (setupapi_test.exe) from the test site has 15 additional failures (17 failures) on wine. I checked it with my own build (setupapi_crosstest.exe) which has only 2 failures). Both tests executables succeeded on my windows machine without any failures. Attached is the log from both runs on wine. I have no glue where the difference come from. I guess it has something todo with this commit http://source.winehq.org/git/wine.git/?a=blobdiff;f=dlls/setupapi/tests/par… , which introduced the failing tests. But I couldn't run a regression test because my own compiled version didn't trigger the failures. Any suggestions? Cheers Rico [Ricola(a)ricola build]$ ./wine ~/Desktop/setupapi_test.exe parser parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=1 parser.c:154: Test failed: file 1: Bad error 3758096384/3758096640 parser.c:156: Test failed: file 1: Bad error line 1/0 parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=5 parser.c:148: hinf=FFFFFFFF err=0xe0000002 line=3 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=1 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=3 parser.c:148: hinf=00127410 err=0x0 line=-559038737 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=-1 err=0xe0000101 parser.c:233: hinf=00127410 ret=-1 err=0xe0000101 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:233: hinf=00127410 ret=0 err=0x0 parser.c:277: Test failed: wrong len 0 parser.c:284: Test failed: wrong len 0 parser.c:289: Test failed: wrong len 0 parser.c:277: Test failed: wrong len 0 parser.c:284: Test failed: wrong len 0 parser.c:289: Test failed: wrong len 0 parser.c:277: Test failed: wrong len 0 parser.c:284: Test failed: wrong len 0 parser.c:289: Test failed: wrong len 0 parser.c:277: Test failed: wrong len 0 parser.c:284: Test failed: wrong len 0 parser.c:289: Test failed: wrong len 0 parser.c:277: Test failed: wrong len 0 parser.c:284: Test failed: wrong len 0 parser.c:289: Test failed: wrong len 0 parser: 843 tests executed (0 marked as todo, 17 failures), 0 skipped. [Ricola(a)ricola build]$ ./wine ~/Desktop/setupapi_crosstest.exe parser parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=1 parser.c:154: Test failed: file 1: Bad error 3758096384/3758096640 parser.c:156: Test failed: file 1: Bad error line 1/0 parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=FFFFFFFF err=0xe0000100 line=0 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=5 parser.c:148: hinf=FFFFFFFF err=0xe0000002 line=3 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=1 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000000 line=3 parser.c:148: hinf=00127340 err=0x0 line=-559038737 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:148: hinf=FFFFFFFF err=0xe0000001 line=3 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=-1 err=0xe0000101 parser.c:233: hinf=00127340 ret=-1 err=0xe0000101 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser.c:233: hinf=00127340 ret=0 err=0x0 parser: 843 tests executed (0 marked as todo, 2 failures), 0 skipped. [Ricola(a)ricola build]$

3 4

Re: richedit: Added tests to show that options are stored internally.
by Detlef Riekenberg 11 Jan '09

11 Jan '09

On So, 2009-01-11 at 02:58 -0500, Dylan Smith wrote: Hi Dylan. First of all, thanks for working on riched* > + /* EM_SETOPTIONS changes the window style, but changing the > + * window style does not change the options. */ > + dwStyle = GetWindowLongW(hwndRichEdit, GWL_STYLE); Almost all UNICODE functions do not work on Win9x > + ok(dwStyle & ES_READONLY, "Readonly style not set by > EM_SETOPTIONS\n"); > + SetWindowLongW(hwndRichEdit, GWL_STYLE, dwStyle & ~ES_READONLY); This also does not work on Win9x. > + options = SendMessage(hwndRichEdit, EM_GETOPTIONS, 0, 0); > + todo_wine ok(options & ES_READONLY, "Readonly option set by > SetWindowLong\n"); I tested your patch on win98se. As expected from reading the patch, you introduced a failure. -- By by ... Detlef

1 0

Re: richedit: Added tests for autoscrolling options based on WS_V/HSCROLL.
by Paul Vriens 11 Jan '09

11 Jan '09

Dylan Smith wrote: > It seems as if the autoscrolling options can be set based on whether > WS_VSCROLL or WS_HSCROLL styles are used to create the window, but this > is done differently between version 1.0 and 3.0 of the richedit control. > > I noticed this indirectly before because wordwrap is initially set only > if the auto-horizontal scrolling is initially enabled. > --- > dlls/riched20/tests/editor.c | 30 ++++++++++++++++++++++++++++-- > dlls/riched32/tests/editor.c | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 60 insertions(+), 2 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Dylan, Same remark about the W-calls. -- Cheers, Paul.

1 0

Re: richedit: Added tests to show that options are stored internally.
by Paul Vriens 11 Jan '09

11 Jan '09

Dylan Smith wrote: > Wine is currently getting the window styles and using them directly, but > the tests I added show that an internal copy is being stored by native > richedit controls. > --- > dlls/riched20/tests/editor.c | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Dylan, Care to change the GetWindowLongW and SetWindowLongW to use the A-version (or remove the W)? These tests will not work on Win9x I guess. -- Cheers, Paul.

1 0

[6/8] widl: Null-check pointers with [size_is]
by Michael Karcher 10 Jan '09

10 Jan '09

This matches midl behaviour. In void test1([out,size_is(x)] char str[], [in] int x); void test2([size_is(x), out] char* str, [in] int x); the parameter to test1 is not NULL-checked, but the one to test2 is. --- tools/widl/client.c | 2 +- tools/widl/proxy.c | 15 ++++++++++----- tools/widl/widltypes.h | 1 + 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/tools/widl/client.c b/tools/widl/client.c index a23e298..0b10eb6 100644 --- a/tools/widl/client.c +++ b/tools/widl/client.c @@ -59,7 +59,7 @@ static void check_pointers(const var_t *func) LIST_FOR_EACH_ENTRY( var, type_get_function_args(func->type), const var_t, entry ) { - if (is_var_ptr(var) && cant_be_null(var)) + if (is_var_declptr(var) && cant_be_null(var)) { print_client("if (!%s)\n", var->name); print_client("{\n"); diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c index bb16b72..ce07ddc 100644 --- a/tools/widl/proxy.c +++ b/tools/widl/proxy.c @@ -150,6 +150,11 @@ int is_var_ptr(const var_t *v) return is_ptr(v->type); } +int is_var_declptr(const var_t *v) +{ + return is_declptr(v->type); +} + int cant_be_null(const var_t *v) { /* Search backwards for the most recent pointer attribute. */ @@ -164,10 +169,10 @@ int cant_be_null(const var_t *v) if (is_user_type(type)) return 0; - if (!attrs && is_ptr(type)) + if (!attrs && is_declptr(type)) { attrs = type->attrs; - type = type_pointer_get_ref(type); + type = get_deref_type(type); } while (attrs) @@ -180,7 +185,7 @@ int cant_be_null(const var_t *v) if (t == RPC_FC_RP) return 1; - if (is_ptr(type)) + if (is_declptr(type)) { if (type->type == RPC_FC_FP || type->type == RPC_FC_OP || @@ -188,7 +193,7 @@ int cant_be_null(const var_t *v) return 0; attrs = type->attrs; - type = type_pointer_get_ref(type); + type = get_deref_type(type); } else attrs = NULL; @@ -229,7 +234,7 @@ static void proxy_check_pointers( const var_list_t *args ) if (!args) return; LIST_FOR_EACH_ENTRY( arg, args, const var_t, entry ) { - if (is_var_ptr(arg) && cant_be_null(arg)) { + if (is_var_declptr(arg) && cant_be_null(arg)) { print_proxy( "if(!%s)\n", arg->name ); indent++; print_proxy( "RpcRaiseException(RPC_X_NULL_REF_POINTER);\n"); diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h index fe8c250..6a770c3 100644 --- a/tools/widl/widltypes.h +++ b/tools/widl/widltypes.h @@ -445,6 +445,7 @@ void clear_all_offsets(void); int is_ptr(const type_t *t); int is_array(const type_t *t); int is_var_ptr(const var_t *v); +int is_var_declptr(const var_t *v); int cant_be_null(const var_t *v); int is_struct(unsigned char tc); int is_union(unsigned char tc); -- 1.5.6.5

2 2

[5/8] widl: dereference operator in expr work on any declared pointer
by Michael Karcher 10 Jan '09

10 Jan '09

If we take MIDL 6.00.0366 as reference, the following method type is legal: void frobnicate([size_is(x),in,out] int * bar1, [size_is(*bar1),out] int * bar2, [in] int x); Without this patch, size_is(*bar1) would be rejected. --- tools/widl/expr.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/widl/expr.c b/tools/widl/expr.c index 7f0e26d..e943062 100644 --- a/tools/widl/expr.c +++ b/tools/widl/expr.c @@ -468,8 +468,8 @@ static struct expression_type resolve_expression(const struct expr_loc *expr_loc break; case EXPR_PPTR: result = resolve_expression(expr_loc, cont_type, e->ref); - if (result.type && is_ptr(result.type)) - result.type = type_pointer_get_ref(result.type); + if (result.type && is_declptr(result.type)) + result.type = get_deref_type(result.type); else error_loc_info(&expr_loc->v->loc_info, "dereference operator applied to non-pointer type in expression%s%s\n", expr_loc->attr ? " for attribute " : "", -- 1.5.6.5

2 2