January 2009 - Wine-devel - list.winehq.org

install-wine-deps.sh can now handle 32 bit wine on 64 bit systems
by Dan Kegel 04 Jan '09

04 Jan '09

I just improved http://code.google.com/p/winezeug/source/browse/trunk/install-wine-deps.sh so it does all the futzing needed to build 32 bit wine on 64 bit systems (although at the moment it only does this for Ubuntu Intrepid). Because it puts the missing .so files in /usr/lib32, there's no need to futz with LDPATH. For example, after running the script, you can do either ./configure make to build 64 bit wine, or ./configure --target=i686-unknown-gnu-linux make to build 32 bit wine. Easy beans! - Dan

2 2

long in IDL files?
by Michael Stefaniuc 04 Jan '09

04 Jan '09

Hello guys, i guess that we need to change long to LONG in IDL files too, right? Or would that be something that widl could/should do automatically? bye michael

3 3

Linus Torvalds on Wine back in 1998
by Dan Kegel 04 Jan '09

04 Jan '09

http://fringe.davesource.com/Fringe/Computers/Linux/Manifesto.txt It's taken longer than he expected... --- snip --- WINE (the Linux emulator for Windows) works to a fairly surprising degree. You can run real Windows programs with it, but some of them don't look right, and some of them just crash. But it has been making big progress in the last year, and now you can actually run Word for Windows. It doesn't work for everybody and there are known bugs, but it's almost becoming usable. I doubt people will wake up and say, "Hey, let's get rid of the shackles of Microsoft and switch to Linux and WINE." But there are going to be more and more people who discover they really want the networking abilities of Linux, or who run a web server on it. WINE slowly expands the group of people who would find Linux or some other operating system acceptable because they really don't care about Microsoft per se; they care about a few programs. In a few years WINE will be good enough that you can actually consider running Linux instead of Windows. It won't take over 100% of the market, but that's OK, too, because when you don't have one major entity that owns most of the market, it's a much saner, competitive environment. I think that'll happen, regardless of Linux. --- snip ---

1 0

Re: Build wine with gcc-4.3 and ssp
by Stefan Reimer 04 Jan '09

04 Jan '09

> On Sat, Jan 03, 2009 at 07:52:10PM +0100, Stefan Reimer wrote: >> > On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: >> I am using gentoo hardened: >> >> gcc (Gentoo Hardened 4.3.2-r7 p1.5, ssp, fortify, pie-10.2.0) 4.3.2 glibc 2.8 >> >> Using gcc -v gives: >> >> /usr/libexec/gcc/x86_64-pc-linux-gnu/4.3.2/cc1 -quiet -v -I. -I. >> -I../include -I../include -imultilib 32 preloader.c -D_FORTIFY_SOURCE=2 -fPIE -fstack-protector -fstack-protector-all -fno-strict-overflow -quiet >> -dumpbase preloader.c -m32 -march=athlon64 -auxbase-strip preloader.o -O2 >> -Wall -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -version -fno-strict-aliasing -o - | >> /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.2/../../../../x86_64-pc-linux-gnu/bin/as -V -Qy --32 -o preloader.o - >> >> The hardened gcc specs brings in -fPIE, which is similiar to -fPIC. >> >> So YES I do ;-) >> >> Is this a problem ? > > -fPIE is a bit useless for the preloader (wine-preloader is actually loaded at a fixed > address), but it should not fail to build I guess. > > Does Wine still work afterwards? > > I don't see the patch hurting anything though. > > Ciao, Marcus > Hi, -fPIE is introduced by using the gentoo hardened profile and is applied everywhere possible. I think wine should be able to be build with -fPIE, despite not improving security be any means. Wine works like a charm btw. Sry for the double postings! Cyas Stefan

1 0

Re: shell32: add explorer toolbar bitmaps
by Juan Lang 04 Jan '09

04 Jan '09

> so I just cutted icons from other toolbars' bitmaps; Which other toolbars, specifically? You can't grab copyrighted work, you know. --Juan

6 12

Re: libs/wine/debug.c: enlcosed a 'write' function with 'if' to prevent gcc warnings. 'if' does nothing cause program exits right after the statement anyway. (bug # 16413)
by Alexandre Julliard 04 Jan '09

04 Jan '09

titon barua <titanix88(a)gmail.com> writes: > @@ -177,7 +177,8 @@ static void debug_usage(void) > "Example: WINEDEBUG=+all,warn-heap\n" > " turns on all messages except warning heap messages\n" > "Available message classes: err, warn, fixme, trace\n"; > - write( 2, usage, sizeof(usage) - 1 ); > + /* enclosed in 'if' statement to prevent gcc warnings */ > + if (write( 2, usage, sizeof(usage) - 1 )); Please don't do that sort of thing. That's much worse than the warning. -- Alexandre Julliard julliard(a)winehq.org

1 0

Use of "patch" keyword in Bugzilla
by Vitaliy Margolen 04 Jan '09

04 Jan '09

Moving this conversation to wine-devel. > What |Removed |Added > ---------------------------------------------------------------------------- > Keywords|patch | > > ------- Comment #7 From Vitaliy Margolen 2009-01-03 19:47:16 [reply] ------- > > Patch keyword is for patches attached to bugs only and not sent to > wine-patches. > > ------- Comment #8 From Austin English 2009-01-03 20:01:55 [reply] ------- > > (In reply to comment #7) >> Patch keyword is for patches attached to bugs only and not sent to >> wine-patches. >> > > It's still useful, e.g., if patch is not accepted. No it's not. The intension of that keyword was to fish all the patches out of buzilla and resubmit them to wine-patches. Or serve as a base for someone to improve upon. With mixing the two you make it nearly useless as most bugs will have it eventually. Especially all fixed ones. IMHO not even outright hacks should have "patch" keyword set. Yes they give an idea of where the problem is. But they are nothing more then investigation into the cause of the problem. Vitaliy.

2 1

Re: include: Change RPC_STATUS from long to LONG for Win64 compatibility.
by James Hawkins 04 Jan '09

04 Jan '09

On Sat, Jan 3, 2009 at 4:49 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > Also fix the compiler warnings introduced by this change. > > diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c > index 5d0b15e..8ef0a5f 100644 > --- a/dlls/advapi32/crypt.c > +++ b/dlls/advapi32/crypt.c > @@ -305,7 +305,7 @@ static void CRYPT_CreateMachineGuid(void) > '%','0','2','x','%','0','2','x', > '%','0','2','x',0 }; > > - pUuidCreate = GetProcAddress(lib, "UuidCreate"); > + pUuidCreate = (void *)GetProcAddress(lib, "UuidCreate"); > rs = pUuidCreate(&uuid); > if (rs == S_OK) > { Inadvertent change? -- James Hawkins

2 1

Re: widl: fix handling of [local] functions without [call_as]
by Rob Shearman 04 Jan '09

04 Jan '09

2009/1/3 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > @@ -548,8 +548,9 @@ static int write_proxy_methods(type_t *iface, int skip) > if (iface->funcs) LIST_FOR_EACH_ENTRY( cur, iface->funcs, const func_t, entry ) { > var_t *def = cur->def; > if (!is_callas(def->attrs)) { > + if (i != cur->idx ) error("widl internal error: method index mismatch"); > if (i) fprintf(proxy, ",\n"); > - if (skip) print_proxy( "0 /* %s_%s_Proxy */", iface->name, get_name(def)); > + if (skip || is_local(def->attrs)) print_proxy( "0 /* %s_%s_Proxy */", iface->name, get_name(def)); > else print_proxy( "%s_%s_Proxy", iface->name, get_name(def)); > i++; > } This will now cause methods with the [local] attribute and with a matching [call_as] method to no longer be included in the function table, which isn't what you want. -- Rob Shearman

2 1

Patch implementing riched20 : EM_PASTESPECIAL -- critique?
by Arren Lex 04 Jan '09

04 Jan '09

Hello, all; Attached is a patch that implements the EM_PASTESPECIAL riched20 message, which pastes with a specified clipboard format -- http://msdn.microsoft.com/en-us/library/bb774214(VS.85).aspx Because there is (apparently) no ANSI clipboard implemented, the CF_TEXT clipboard format pastes garbage, so I have put in a workaround which treats a CF_TEXT as a CF_UNICODETEXT call. It prints a fixme when it does this, and when the ANSI clipboard is implemented the "if" block can simply be taken out to start using it. This patch was written to fix bug 14530 -- http://bugs.winehq.org/show_bug.cgi?id=14530 It is made against git commit bf25837eb7c08dc7faf13b886f6aed79a02506b8 (the tagging of 1.1.12) which is the latest at the time of writing. This is my first ever patch, and I am not familiar with wine or riched20 at all, so I would love to have some feedback about it before I submit it to the patches list. Can anyone suggest improvements? Thank you, - Alexander Dorokhine

1 1