January 2009 - Wine-devel - list.winehq.org

Re: winedbg: add a crash dialog for --auto mode (3rd try)
by Mikołaj Zalewski 03 Jan '09

03 Jan '09

Is there something wrong with this patch?

1 0

Re: richedit: Mask window id on WM_COMMAND notifications.
by Dmitry Timoshkov 03 Jan '09

03 Jan '09

"Dylan Smith" <dylan.ah.smith(a)gmail.com> wrote: > - SendMessageA(GetParent(hWnd), WM_COMMAND, (nCode<<16)|GetWindowLongW(hWnd, GWLP_ID), (LPARAM)hWnd); > + SendMessageA(GetParent(hWnd), WM_COMMAND, (nCode<<16)|(0xffff & GetWindowLongW(hWnd, GWLP_ID)), (LPARAM)hWnd); MAKEWPARAM and LOWORD are supposed to be used here. Also, have you tested what happens if real window id is larger than a 16-bit value, or just a negative 16-bit one? -- Dmitry.

2 1

Re: start.exe: don't use the NO_UI flag when invoked with /unix
by Austin English 03 Jan '09

03 Jan '09

On Fri, Jan 2, 2009 at 6:30 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > This makes it possible to get feedback when something goes wrong starting a non-exe file through a Linux gui. > > > You forgot the patch ;-). -- -Austin

1 0

Re: start.exe: don't use the NO_UI flag when invoked with /unix
by James Hawkins 03 Jan '09

03 Jan '09

On Fri, Jan 2, 2009 at 4:30 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > This makes it possible to get feedback when something goes wrong starting a non-exe file through a Linux gui. > Forgot the patch. -- James Hawkins

1 0

Status of dxdiagn?
by Dan Kegel 03 Jan '09

03 Jan '09

Hi Markus, what's the status of dxdiagn these days? I see a number of games that say they need a native copy: http://www.google.com/search?q=dxdiagn+site%3Aappdb.winehq.org Do you know what needs doing before we can get native dxdiag working, http://bugs.winehq.org/show_bug.cgi?id=1429 ? Also, how about your dxdiagn conformance test? http://www.winehq.org/pipermail/wine-patches/2008-May/055355.html I know it didn't do much, maybe you could have it check a few required properties? I ask because I'm looking around for a student project, and implementing dxdiag.exe came to mind; looking around a bit, I saw dxdiagn, and figured it might be nice to tie up some loose ends there, too. - Dan

2 6

Re: [PATCH] oleaut32: PICTYPE_ICON returns EFAIL for get_hPal (try 2)
by Robert Reif 03 Jan '09

03 Jan '09

Jon Griffiths wrote: > Hi, > > Smaller patch with properly static-ified icon data. > > Cheers > Jon > > > > ------------------------------------------------------------------------ > > Did this patch get dropped for a reason?

1 0

Re: [shell32 5/6] include: Add remotable stubs for non-default-marshallable shobjidl calls.
by Rob Shearman 02 Jan '09

02 Jan '09

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/include/shobjidl.idl b/include/shobjidl.idl > index a647798..c36f4ce 100644 > --- a/include/shobjidl.idl > +++ b/include/shobjidl.idl > @@ -452,6 +452,9 @@ interface IShellView : IOleWindow > [in] LPFNSVADDPROPSHEETPAGE pfn, > [in] LPARAM lparam); > > + [call_as(AddPropertySheetPages)] > + HRESULT RemoteAddPropertySheetPages(); > + > HRESULT SaveViewState(); > HRESULT SelectItem( > [in] LPCITEMIDLIST pidlItem, > @@ -582,6 +585,9 @@ cpp_quote("#endif") > [in] LPARAM lParam, > [in] LRESULT *pret); > > + [call_as(SendControlMsg)] > + HRESULT RemoteSendControlMsg(); > + > HRESULT QueryActiveShellView( [out] IShellView **ppshv ); > HRESULT OnViewWindowActive( [in] IShellView *pshv ); > > @@ -590,6 +596,8 @@ cpp_quote("#endif") > [in] LPTBBUTTONSB lpButtons, > [in] UINT nButtons, > [in] UINT uFlags); > + [call_as(SetToolbarItems)] > + HRESULT RemoteSetToolbarItems(); These shouldn't be necessary. What is it that you're trying to fix? > } > > > @@ -1441,9 +1449,12 @@ interface IAutoCompleteDropDown : IUnknown > { > cpp_quote("#define ACDD_VISIBLE 0x0001") > > - HRESULT GetDropDownStatus( > + [local] HRESULT GetDropDownStatus( > [out] DWORD *pdwFlags, > - [out, string] LPWSTR *ppwszString); > + [out] LPWSTR *ppwszString); > + > + [call_as(GetDropDownStatus)] > + HRESULT RemoteGetDropDownStatus(); This isn't correct. IAutoCompleteDropDown::GetDropDownStatus should be remoted as is. > > HRESULT ResetEnumerator(); > } -- Rob Shearman

2 4

Re: Implemented retrieval of szDeviceIdentifier property in dxdiagn
by Vitaliy Margolen 02 Jan '09

02 Jan '09

Markus wrote: Few problems with your patch: > + IDirect3D9 *(WINAPI *pDirect3DCreate9)(UINT) = NULL; > + IDirect3D9 *pD3d = NULL; No need to initialize something you'll assign to anyway. > + d3d9_handle = LoadLibraryA( "d3d9.dll" ); You need to unload it when you done. > + memset(&adapter_ident, 0, sizeof(adapter_ident)); No need to clear this structure. > + StringFromGUID2(&adapter_ident.DeviceIdentifier, adapter_ident_str, 39); Why don't you put it directly into szIdentifierBuffer? > + memcpy( szIdentifierBuffer, adapter_ident_str, sizeof(adapter_ident_str) * sizeof(WCHAR) ); sizeof() gives size in bytes. You don't need to multiply it by sizeof(WCHAR). > + WCHAR deviceIdentBuffer[256]; First why 256 if all you need is 39? Second, why do you need it at all? There is already "buffer" which is big enough. > + DXDiag_GetDisplayDeviceIdentifier( &deviceIdentBuffer ); You don't need to take a reference from array. It's already a pointer (remove "&"). Any time you pass array like that you should also pass it's size. Vitaliy.

1 0

Re: [4/5] wined3d: Convert some BOOLs to bitfields in struct IWineD3DDeviceImpl.
by Rob Shearman 02 Jan '09

02 Jan '09

2008/12/30 Henri Verbeet <hverbeet(a)codeweavers.com>: > > > From f6e4f88407491db8bb53d22d526f69b9ff761aaf Mon Sep 17 00:00:00 2001 > From: Henri Verbeet <hverbeet(a)codeweavers.com> > Date: Tue, 30 Dec 2008 14:56:49 +0100 > Subject: wined3d: Convert some BOOLs to bitfields in struct > IWineD3DDeviceImpl. > > Also fills a 3 byte hole. > --- > dlls/wined3d/device.c | 17 +++++---------- > dlls/wined3d/nvidia_texture_shader.c | 2 +- > dlls/wined3d/state.c | 4 +- > dlls/wined3d/wined3d_private.h | 36 > ++++++++++++++++----------------- > 4 files changed, 26 insertions(+), 33 deletions(-) How many instances of this structure are likely to be in a process at any one time? It seems to me as though as any memory savings gained by making the BOOLs into bitfields will be taken up by increased code size. There is also the risk that there will be a small performance penalty for this and the other similar changes too. These kinds of optimisations need to be backed up by benchmarks, for both memory and performance. -- Rob Shearman

2 1

Ubuntu popcon trivia
by Dan Kegel 02 Jan '09

02 Jan '09

Did you know that almost as many people have Wine installed as have Sun's Java 6 installed? wget http://popcon.ubuntu.com/by_inst.gz gunzip by_inst.gz awk '/wine |sun-java6-jre/' by_inst | head rank name inst vote old recent old-files 1208 sun-java6-jre 390519 68179 313376 7354 1610 (Matthias Klose) 1321 wine 338377 42513 282338 13460 66 (Scott Ritchie) The highest 'inst' value in the file is 871814, so it looks like about 39% of machines subscribed to popcon have wine installed.

2 1