October 2009 - Wine-devel - list.winehq.org

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing
by Dmitry Timoshkov 01 Oct '09

01 Oct '09

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)hbm); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ICON, (LPARAM)hicon); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETICON, (WPARAM)hicon, 0); > + todo_wine ok_sequence(WmSetIconErrStaticSeq, "STM_SETICON on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ENHMETAFILE, (LPARAM)hemf); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); You should use SendMessageA instead of SendMessageW to make the test run under Win9x as well. Testing the return value of SendMessage would be also helpful. -- Dmitry.

3 3

Re: Owen Rudge : comctl32: Implement highlighting (marquee) selection support in listview.
by Nikolay Sivov 01 Oct '09

01 Oct '09

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 69b76a18fb19bd4a6c83f4f05eb942513af970fd > URL: http://source.winehq.org/git/wine.git/?a=commit;h=69b76a18fb19bd4a6c83f4f05… > > Author: Owen Rudge <orudge(a)codeweavers.com> > Date: Wed Sep 30 16:41:23 2009 +0100 > > comctl32: Implement highlighting (marquee) selection support in listview. > > --- > Hi, Owen. Didn't test it much yet, but few issues from a start: - when control doesn't have focus rectangle is visible, but it doesn't select anything; - during resizing rectangle and moving pointer outside client area rectangle gets stuck, on native it still moves; - after mouse released outside client area rectangle should be cleared, now it stays as it is. Do you plan to work on this?

2 1

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime
by Paul Vriens 01 Oct '09

01 Oct '09

On 09/29/2009 12:36 PM, Nikolay Sivov wrote: > Changelog: > - be sure we have a single view calendar for hittesting > > > ------------------------------------------------------------------------ > > Hi Nikolay, This one introduces a test failure on several platforms: monthcal.c:1002: Test failed: Expected 10000, got 10002 I fixed it on my NT4 box by checking the point more to the left (see attached). I somehow doubt it's the correct fix though. Aren't these tests with more-or-less fixed points error-prone (aka, locale/font/dpi dependent)? -- Cheers, Paul.

2 5

Re: Peter Dons Tychsen : user32: Add exception handling for timer callbacks.
by Peter Dons Tychsen 01 Oct '09

01 Oct '09

On Thu, 2009-10-01 at 12:33 +0200, Alexandre Julliard wrote: > Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > > > Just out of interest: You changed this to a write. Fine. > > But why the volatile? Can GCC assume predetermined results when writing > > to NULL? I don't see any reason to use volatile unless someone else is > > also read/writing from NULL (which is impossible). It might just > > generate more code in some cases. > > It's just to make sure no compiler tries to be too smart. For a single > access it probably doesn't make a difference; it could change if for > instance we try to trigger a second crash and the compiler optimizes out > the first write. > Ah,OK. Thanks for the info. /pedro

1 0

Re: [comctl32/tests] Fix some test failures
by Paul Vriens 01 Oct '09

01 Oct '09

On 10/01/2009 12:29 PM, Paul Vriens wrote: > Hi, > > Instead of checking fixed points in the title we now check for the order > of items only. > > I didn't cater for locale differences on Windows (as I don't have a way > to test), so I'm going to rely on test.winehq.org after this patch has > been applied (if, of course). > > The test could be easily extended if we know for a fact that items > should be at a fixed place (or by calculating text width, button width > an such). > > Changelog > Fix some test failures > FWIW, changing the regional settings on a Windows box does change the title of the calendar. Setting it to Portuguese shows that the name of the month is longer than expected and hence the hittests don't work as it was before. This patch also succeeds on the Portuguese settings (tested on W2K3). -- Cheers, Paul.

2 10

Re: [2/5] WineD3D: SetRenderTarget doesn't change the viewport in d3d7
by Alexandre Julliard 01 Oct '09

01 Oct '09

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > Patches 2, 3 and 4 fix bug 19365. In the long run we want to get rid > of the dxVersion parameter that is used in this patch, but we haven't > agreed on a way to do this so far, so lets fix the bug first. It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so visual.c && touch visual.ok visual.c:600: Test failed: Offscreen failed: Got color 0x00ff00ff, expected 0x00ffffff. visual.c:788: Test failed: SRCALPHA on texture returned color 0x007f0080, expected 0x00bf4000 make: *** [visual.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet(3/4): Set callbacks needed by OpenSSL for multithreaded use
by Alexandre Julliard 01 Oct '09

01 Oct '09

Juan Lang <juan.lang(a)gmail.com> writes: > +static HANDLE *ssl_locks; > + > +static unsigned long ssl_thread_id(void) > +{ > + return GetThreadId(GetCurrentThread()); > +} You want GetCurrentThreadId(); > +static void ssl_lock_callback(int mode, int type, const char *file, int line) > +{ > + if (mode & CRYPTO_LOCK) > + WaitForSingleObject(ssl_locks[type], INFINITE); > + else > + ReleaseMutex(ssl_locks[type]); > +} You should use critical sections instead, it will be faster. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/9] include: Add MAPI_USE_DEFAULT and MDB_NO_DIALOG definitions to mapix.h
by Alexandre Julliard 01 Oct '09

01 Oct '09

Owen Rudge <orudge(a)codeweavers.com> writes: > @@ -51,6 +51,9 @@ typedef ULONG FLAGS; > #ifndef MAPI_EXTENDED > #define MAPI_EXTENDED 0x00000020 > #endif > +#ifndef MAPI_USE_DEFAULT > +#define MAPI_USE_DEFAULT 0x00000040 > +#endif > #ifndef MAPI_FORCE_DOWNLOAD > #define MAPI_FORCE_DOWNLOAD 0x00001000 > #endif > @@ -65,6 +68,9 @@ typedef ULONG FLAGS; > #define MAPI_SIMPLE_DEFAULT (MAPI_LOGON_UI|MAPI_ALLOW_OTHERS|MAPI_FORCE_DOWNLOAD) > #define MAPI_SIMPLE_EXPLICIT (MAPI_NEW_SESSION|MAPI_EXPLICIT_PROFILE|MAPI_FORCE_DOWNLOAD) > > +/* IMAPISession::OpenMessageStore() flags */ > +#define MDB_NO_DIALOG 0x00000001 > + These things apparently belong to mapidefs.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dwmapi: Add a stub for DwmGetGraphicsStreamTransformHint.
by Alexandre Julliard 01 Oct '09

01 Oct '09

Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com> writes: > --- > dlls/dwmapi/dwmapi.spec | 2 +- > dlls/dwmapi/dwmapi_main.c | 9 +++++++++ > 2 files changed, 10 insertions(+), 1 deletions(-) Please build a proper numbered series, where each patch is relative to the previous one. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tools/winebuild: add FreeBSD support (1/2) (RESEND) (fwd)
by Alexandre Julliard 01 Oct '09

01 Oct '09

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > [ I'd like to ping this after three weeks. This fixes a real bug > that has reported by a user. Any chance to get it in, or do you > need to see this changed somehow? ] Looks ok but the patch doesn't apply. When resubmitting a patch you have to rebase on current git first. -- Alexandre Julliard julliard(a)winehq.org

1 0