October 2009 - Wine-devel - list.winehq.org

Re: dinput/tests: Add acceptable error code for Win7 mouse test (Resend)
by Alexandre Julliard 06 Oct '09

06 Oct '09

Ge van Geldorp <ggeldorp(a)vmware.com> writes: > http://www.winehq.org/pipermail/wine-patches/2009-September/078113.html got > sucked into the wine-patches black hole. > > Changelog: > dinput/tests: Add acceptable error code for Win7 mouse test That's not an acceptable error for that test. Why does it fail? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [user32/tests] Fix some test failures with 9x/Me on VMware (Resend)
by Alexandre Julliard 06 Oct '09

06 Oct '09

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > Hi, > > Resending as I didn't receive any comments. > > Apparently most Win9x and WinMe boxes running under VMware have this issue. > > Changelog > Fix some test failures with 9x/Me on VMware That makes the test essentially useless. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll/tests: Fix exception test failure on Win7 (Resend)
by Alexandre Julliard 06 Oct '09

06 Oct '09

Ge van Geldorp <ggeldorp(a)vmware.com> writes: > Changelog: > ntdll/tests: Fix exception test failure on Win7 That's way overkill for a single failure. You should figure out what's going on in this specific case and adapt the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Check expected last error before calling lstrcmpA() since it may reset GLE (Resend)
by Alexandre Julliard 06 Oct '09

06 Oct '09

Ge van Geldorp <ggeldorp(a)vmware.com> writes: > Changelog: > kernel32/tests: Check expected last error before calling lstrcmpA() since it may reset GLE Then it doesn't make sense to print it either. You should split the check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Add acceptable error codes for Win7 resource test (Resend)
by Alexandre Julliard 06 Oct '09

06 Oct '09

Ge van Geldorp <ggeldorp(a)vmware.com> writes: > Changelog: > kernel32/tests: Add acceptable error codes for Win7 resource test That defeats the purpose of the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

DLL Hell 2.0
by Austin English 05 Oct '09

05 Oct '09

http://developers.slashdot.org/story/09/10/04/1956225/Side-By-Side-Assembli… Interesting read... -- -Austin

1 0

Re: [PATCH 4/7] comctl32/monthcal: Remove today rectangle and focus drawing code from loops
by Michael Stefaniuc 05 Oct '09

05 Oct '09

Hello Nikolay, On 10/05/2009 09:12 PM, Nikolay Sivov wrote: > Fixes corrupted drawing on multiselection mode > > Changelog: > - remove today rectangle and focus drawing code from loops > > @@ -482,11 +485,7 @@ static BOOL MONTHCAL_SetDayFocus(MONTHCAL_INFO *infoPtr, const SYSTEMTIME *st) > infoPtr->focusedSel.wMonth, &r); > > if(!st & MONTHCAL_ValidateDate(&infoPtr->focusedSel)) ^^^ Is that correct or shouldn't that be a '&&'. The compiler complained about that and I wanted to send a patch to fix it but I see it will conflict with this patch. > - { > - static const SYSTEMTIME st_null; > - > infoPtr->focusedSel = st_null; > - } bye michael

2 1

CPPCheck run for today October 5,09
by chris ahrendt 05 Oct '09

05 Oct '09

[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd [/home/cahrendt/wine-git/libs/wine/mmap.c:288]: (error) Invalid number of character ({). Can't process file. I think the last is a bug in CPPCheck and will report it to them.... chris

1 0

Image List tests for comctl32 v6
by Joel Holdsworth 05 Oct '09

05 Oct '09

Hi All, I'm working on some tests to demonstrate some alpha-channel behaviour in comctl32 ImageLists. The problem is that this behaviour is only present in comctl32 v6, which of course you usually activate with an xml manifest. For the wine test suite we have a helper function, load_v6_module, that dynamically creates a manifest resource entry in the module, which seems to activate v6 behaviour. However, while this seems to activate v6 behaviour for controls, it seems not to for image lists - my tests work if I link a manifest into the test suite, but don't work via load_v6_module. Does anyone have any thoughts about what might be going on here, and what I should do with my tests? Thanks Joel

6 14

Re: Owen Rudge : comctl32: Capture the mouse when performing a listview marquee selection.
by Nikolay Sivov 05 Oct '09

05 Oct '09

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: b63c1cb219bf1fd3a62c39799a0f248eaa4a979f > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b63c1cb219bf1fd3a62c39799… > > Author: Owen Rudge <orudge(a)codeweavers.com> > Date: Fri Oct 2 16:13:26 2009 +0100 > > comctl32: Capture the mouse when performing a listview marquee selection. > > --- > New bugs here: - open regedit and select any branch from tree - list will display a single item. Then start marquee selection after selecting an item move pointer somewhere outside the list - try to left and up. It crashes after that for me in ListView code: --- listview.c:1487: LISTVIEW_GetColumnInfo: Assertion `nSubItem >= 0 && nSubItem < (*(INT*)(infoPtr->hdpaColumns))' failed. --- - selection rectangle should be limited to client area, now it goes left from left bound (maybe it's a cause of previous assertion); - list should be scrolled with selection rectangle; - with regedit again - select something from tree and don't click in list, just start marquee. You'll see that item isn't selected at all.

2 2