October 2009 - Wine-devel - list.winehq.org

Re: [1/2] extrac32: Add command-line parsing
by Ilya Shpigor 27 Oct '09

27 Oct '09

Hi, What about this group of two patches? Is this correct or there are mistakes? -- Best regards, Ilya Shpigor.

1 0

New valgrind results for Oct 26, 2009
by Dan Kegel 27 Oct '09

27 Oct '09

http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/ has current results. I've tweaked the diff-* files to be brutally minimalist, so if there's a diff- file, it's more likely to be interesting. On the downside, you have to look at the non-diff file to see line numbers. One of these days I've got to make these clickable... Highlights: "New" errors: http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-d3d10_effect.txt has a new warning, see http://www.winehq.org/pipermail/wine-devel/2009-October/079467.html http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-mshtml_htmllocati… shows a bunch of "new" warnings, see http://bugs.winehq.org/show_bug.cgi?id=20485 Fixed: http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-gdiplus_image.txt shows that Kirill's patch did the trick http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-oleaut32_tmarshal… shows that Jeremy's patch helped http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-urlmon_url.txt and http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-wininet_http.txt seem to show benefits from Hans' patch Thanks to everyone who fixed memory problems so far. There's lots more to do, check out your favorite module and see what dirt valgrind has on it!

1 0

Re: [PATCH 1] winmm/tests: Add MCI waveaudio tests.
by Alexandre Julliard 27 Oct '09

27 Oct '09

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > Hi, > > please excuse the cheap way of avoiding dead code, but I was afraid > that git rebase would cause me too many failures with my 30 subsequent > patches. The minor change of turning #if FULL_TEST into /* already cost > me 4 hours with git rebase fixing and assessing make; make mci.ok of every single patch. Code is just as dead within /* */ than within #ifdef, so I'm afraid it's not better. You'd probably have less trouble if you did this in smaller chunks, there's no need to add all the tests in a single patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 0/3] Use "__asm__" keyword instead of "asm"
by Yann Droneaud 27 Oct '09

27 Oct '09

Le lundi 26 octobre 2009 à 15:33 +0100, Yann Droneaud a écrit : > When using GCC in ansi/c99 mode, "asm" is not defined, one have > to use "__asm__" instead. > "__asm__" is already used in wine source code except in some > files. > I'm now thinking that configure should search which keyword to use depending on compile/flags used. Then declare a define, for example __ASM__, to be used in source code. For example: #define __ASM__(code) asm(code) else #define __ASM__(code) __asm__(code) Keywords asm/__asm__/__asm could be used as-is in compiler dependent code. Regards. -- Yann Droneaud

1 0

Re: kernel32: add more tests for FormatMessage{A,W}
by Dmitry Timoshkov 27 Oct '09

27 Oct '09

"Louis Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > The attached tests show that this is true for "non-special" language-id's, > but not for the special ones: > (LANG_NEUTRAL, SUBLANG_NEUTRAL), (LANG_NEUTRAL, SUBLANG_DEFAULT),(LANG_NEUTRAL, > SUBLANG_SYS_DEFAULT), and (DWORD)MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US) > > In the latter case the error is set to ERROR_MR_MID_NOT_FOUND A couple of suggestions: 1. There is no point in testing last error if an API didn't fail 2. It would be helpful to simultaneously test return values and last error for FindResource, which should have similar behaviour (and the bug) to FormatMessage, and drop FormatMessageW tests. -- Dmitry.

1 0

DirectX 10 status, do simple programs work yet?
by Warren Dumortier 26 Oct '09

26 Oct '09

I've searched and didn't found any recent topic concerning DirectX 10 in Wine. So i would like to know if there's already something running concerning DirectX 10? Like making very basic applications? The fact i would like to know that is because i'm curious what has alread been done! ;) Thanks, kind regards.

3 2

Re: appwiz: ignore Apps without title in the list(try 2)
by Vitaliy Margolen 26 Oct '09

26 Oct '09

André Hentschel wrote: > Also fixes Bug 20417 > Sorry, little blackout after vacation in try1... > --- > @@ -347,6 +347,12 @@ static void AddApplicationsToList(HWND hWnd, HIMAGELIST hList) > > while (iter) > { > + if(!strlenW(iter->title)) This is the same as "if (!iter->title[0])". Please don't use strlen to check for zero length strings. It's expensive if string isn't empty. Vitaliy.

2 1

Re: programs/extrac32: The debug channel is not used, remove it.
by Andrey Turkin 26 Oct '09

26 Oct '09

Don't do this please, initial part was just submitted, the channel will be used once other parts are in place. Francois Gouget wrote: > --- > programs/extrac32/extrac32.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/programs/extrac32/extrac32.c b/programs/extrac32/extrac32.c > index 7e8fbed..4e53af9 100644 > --- a/programs/extrac32/extrac32.c > +++ b/programs/extrac32/extrac32.c > @@ -21,9 +21,7 @@ > #include <windows.h> > > #include "wine/unicode.h" > -#include "wine/debug.h" > > -WINE_DEFAULT_DEBUG_CHANNEL(extrac32); > > int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show) > { >

2 2

tmarshal patch for consideration
by Jeremy White 25 Oct '09

25 Oct '09

On route to trying to fix the +heap warning, I actually fixed it first by using the attached patch. I believe this patch is correct; it makes any error in the marshaling process sufficient to prevent an actual invocation. However, it's a fairly fundamental behavior change, and I don't know this code, so I thought I'd see if anyone objected before I submitted it. As far as I can tell, the behavior currently is that if we can't demarshal a particular argument in a typelib, we go ahead and call the function anyway. This could conceivably have 'good' side effects if the arguments we can't demarshall aren't used by the caller. The new behavior would be to fail anytime we don't understand a parameter in the typelib. That seems better to me, but again, I'm really new to this code, so kibitzing appreciated. Cheers, Jeremy

1 0

Re: [oleaut32] StructArg tests cannot rely on an unpacked structure memcmp.
by Austin English 25 Oct '09

25 Oct '09

On Sat, Oct 24, 2009 at 5:13 PM, Jeremy White <jwhite(a)codeweavers.com> wrote: > Has the side effect of preventing a test failure which occurs only when running with +heap. Woohoo! Should fix: http://bugs.winehq.org/show_bug.cgi?id=14078 http://bugs.winehq.org/show_bug.cgi?id=17412 -- -Austin

2 1