October 2009 - Wine-devel - list.winehq.org

Winetricks gdiplus no longer working?
by Scott Ritchie 22 Oct '09

22 Oct '09

Heard a report that the gdiplus verb no longer works because the files to be downloaded have been moved. Thanks, Scott Ritchie

2 1

Re: crypt32(4/5): Add tests for key usage in the base policy
by Paul Vriens 22 Oct '09

22 Oct '09

On 10/21/2009 03:28 AM, Juan Lang wrote: > --Juan > Hi Juan, This one introduces some failures on some boxes. Are they indeed missing the needed Verisign root certificate as stated in the logs? Which certificate is that btw? The tests fail on my NT4 box where I see several Verisign root certificates. -- Cheers, Paul.

2 3

Re: [TRY 2] [2/3] extrac32: Add command-line parsing
by Alexandre Julliard 22 Oct '09

22 Oct '09

Ilya Shpigor <shpigor(a)etersoft.ru> writes: > + /* Parse options */ > + for(i = 0; i < argc; i++) > + { > + if (argv[i][0] == '/') > + { > + for(j = 0; j < sizeof(sFlags) / sizeof(sFlags[0]); j++) > + if (!strcmpiW(argv[i], sFlags[j].wFlag)) > + { > + comp |= sFlags[j].nFlag; > + goto next; > + } > + } > + next: > + continue; > + } > + > + if ((comp & CMD_FLAGS) == EFLAGC) /* copy file */ > + { > + WINE_FIXME("/C not implemented\n"); > + } else if ((comp & CMD_FLAGS) == EFLAGD) /* display CAB archive */ > + { > + WINE_FIXME("/D not implemented\n"); > + } else if ((comp & CMD_FLAGS) == EFLAGE) /* extract CAB archive */ > + { > + WINE_FIXME("/E not implemented\n"); > + } else if ((comp & CMD_FLAGS) == 0) /* expand mode */ > + { > + WINE_FIXME("Expand mode not implemented\n"); > + } That parsing approach is not really appropriate here, the options are not just a bunch of flags, there are options with arguments, mutually exclusive modes, etc. Some sort of switch() statement would be more natural. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: New valgrind results for Oct 21, 2009
by Dan Kegel 22 Oct '09

22 Oct '09

It varies. I got a leakfix in yesterday, for instance. On Oct 22, 2009 5:51 AM, "Ben Klein" <shacklein(a)gmail.com> wrote: 2009/10/22 Dan Kegel <dank(a)kegel.com>: > 2) Fixing leaks in test code is usually pretty safe, and > it's easier to get Alexandre to accept ... I thought AJ didn't like leak fixes in the tests.

1 0

Re: user.exe: Forward WNetGetUser16 to WNetGetUserA of mpr.dll, based on a patch from Andrew Nguyen (2nd resend)
by Alexandre Julliard 22 Oct '09

22 Oct '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > --- wine-git/dlls/user32/Makefile.in 2009-07-03 22:00:44.000000000 +0200 > +++ wine-build/dlls/user32/Makefile.in 2009-10-04 10:53:16.000000000 +0200 Don't resend the same patch every day, that will only get you ignored. Anyway this should wait until user is properly separated so that user32 doesn't need to import mpr. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [TRY 2] [1/3] programs: initial add extrac32 utility
by Nikolay Sivov 22 Oct '09

22 Oct '09

Ilya Shpigor wrote: > ------------------------------------------------------------------------ > > Hi, Ilya. You need to include patched configure.ac as well with new WINE_CONFIG_MAKEFILE entry.

3 4

New winetricks 20091022: new verbs glsl-disable, glsl-enable, physx, mingw, mingw-gdb, cmake, dotnet11sdk, dotnet20sdk, vc2003toolkit, vc2005sp1, vc2008sp1
by Dan Kegel 22 Oct '09

22 Oct '09

Another fortnight, another winetricks. Eleven new verbs and spices, and a few bugfixes. Updates since 20091015: * Fix vc2005express verb (interactive mode) to work on windows * Add mingw and mingw-gdb (hey, we support cygwin. Equal time!) * Add cmake. Based on a patch by Mathieu Malaterre * Update gdiplus download link * Added a draft vc2008sp1 verb; works on Windows Vista. * Trim CR from output of cygpath, which screwed up bash strangely on windows. Updates since 20091007: * Added draft vc2008trial verb. Mostly debugged on Windows, not yet tested on Wine. * Add glsl-disable and glsl-enable verbs. Patch by Erik Inge Bolsø. * In dotnet20, be sure to sha1sum l_intl.nls, otherwise it may fail in weird ways * Add Nvidia physx (e.g. for Steam games). Patch by Erik Inge Bolsø. * Added dotnet11sdk, dotnet20sdk, and vc2003toolkit. Based on a change by mathieu.malaterre. * Add vc2005sp1 verb * Cygwin's download server seems to be compress now, so decompress any gzip-compressed .exe's upon download. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Thanks to Austin English, Mathieu Malaterre, and especially Erik Inge Bolsø.

1 0

RFC: ntdll: Implement CDROM_GetInterfaceInfo() on Mac OS (try 2)
by Charles Davis 22 Oct '09

22 Oct '09

Hi, Here's a new version of my patch that's slightly less complicated. I didn't get a response last time, so I'm sending it again. Please, someone review my patch. I won't send it to wine-patches until I know I have this right (yes, I am a bit of a perfectionist). To reiterate what I said about this patch last time, this patch will implement the CDROM_GetInterfaceInfo() function on Mac OS, which allows clients to, among other things, get a SCSI address to do whatever with. (If this is over your head, you can stop reading now. :) I'd like to re-emphasize that if I thought this would get in, I'd send it to wine-patches. But I don't, so I'm asking for your help. I understand if you have better things to do (and, to be honest, I know most of you do), but I'd really appreciate some input here. Please don't disappoint me this time. Thanks. Chip --- dlls/ntdll/cdrom.c | 354 +++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 353 insertions(+), 1 deletions(-)

2 1

Re: [2/2] mshtml: Add HTMLImageElementFactory::value for constructing IHTMLImgElement objects
by Jacek Caban 21 Oct '09

21 Oct '09

Hi Andrew, Andrew Eikum wrote: > --- > dlls/mshtml/htmlimg.c | 46 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 45 insertions(+), 1 deletions(-) > > > + if(params->cArgs >= 2) { + width = params->rgvarg; + height = params->rgvarg + 1; + }else if(params->cArgs == 1) { + width = params->rgvarg; + height = ∅ + }else { + width = ∅ + height = ∅ + } Note that DISPPARAMS stores arguments in right to left order so you swap arguments here. Also you have to skip named args that are stored in first cNamedArgs of rgvarg table. How about: argc = params->cArgs - params->cNamedArgs; width = argc >= 2 ? params->rgvarg+argc-1 : ∅ height = argc >= 1 ? params->rgvarg+argc-2 : ∅ Also: + IHTMLImgElement_QueryInterface(img, &IID_IDispatch, (void**)&disp); IHTMLImgElement is a child interface of IDispatch, so you can use C cast here instead of QueryInterface here. Jacek

2 3

uninitialized memory errors in JScriptParse_ParseScriptText ?
by Dan Kegel 21 Oct '09

21 Oct '09

Hi Jacek! Please have a look at http://kegel.com/wine/valgrind/logs/2009-10-20-01.09/vg-jscript_run.txt There are a few interesting errors there. The first one (with a little context from http://kegel.com/wine/valgrind/logs/2009-10-20-01.09.log) is: valgrind ... wine jscript_test.exe.so run.c ... run.c:367: Test failed: lang.js: L"2.5*3.5 !== 8.75" ... Use of uninitialised value of size 4 at get_char_typeW (unicode.h:141) by isdigitW (unicode.h:165) by String_replace (string.c:968) by invoke_prop_func (dispex.c:257) by jsdisp_call (dispex.c:868) by disp_call (dispex.c:897) by call_expression_eval (engine.c:1604) by expr_eval (engine.c:42) by assign_expression_eval (engine.c:3108) by expr_eval (engine.c:42) by expression_statement_eval (engine.c:678) by stat_eval (engine.c:37) by exec_source (engine.c:472) by exec_global_code (jscript.c:106) by JScriptParse_ParseScriptText (jscript.c:715) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:187) by RtlAllocateHeap (heap.c:1429) by SysAllocStringLen (oleaut.c:233) by SysAllocString (oleaut.c:157) by to_string (jsutils.c:558) by String_replace (string.c:882) by invoke_prop_func (dispex.c:257) by jsdisp_call (dispex.c:868) by disp_call (dispex.c:897) by call_expression_eval (engine.c:1604) by expr_eval (engine.c:42) by assign_expression_eval (engine.c:3108) by expr_eval (engine.c:42) by expression_statement_eval (engine.c:678) by stat_eval (engine.c:37) by exec_source (engine.c:472) by exec_global_code (jscript.c:106) by JScriptParse_ParseScriptText (jscript.c:715) Removing the common bits, the core of that warning is Use of uninitialised value of size 4 at get_char_typeW (unicode.h:141) by isdigitW (unicode.h:165) by String_replace (string.c:968) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:187) by RtlAllocateHeap (heap.c:1429) by SysAllocStringLen (oleaut.c:233) by SysAllocString (oleaut.c:157) by to_string (jsutils.c:558) by String_replace (string.c:882) Thanks! - Dan

2 1