November 2009 - Wine-devel - list.winehq.org

Comment request: wineconsole: Fix Alt+F10 sent when F10 pressed.
by Erich Hoover 04 Nov '09

04 Nov '09

I thought this patch was pretty straightforward, comments? http://www.winehq.org/pipermail/wine-patches/2009-October/080779.html Erich Hoover ehoover(a)mines.edu

1 0

Re: mshtml/tests: Fix events test when pointer is on a corner.
by Jacek Caban 04 Nov '09

04 Nov '09

Hi Nicolas, Nicolas Le Cam wrote: > Hi, > > Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having > errors on events tests. > > I just found that it only fails if pointer is on any corner. As I'm > always putting it on upper right corner when running winetest it was > always failing for me. > > Minimizing the test window fixed it for me. > Tested on Win2k SP4 and WinXP SP2 (both with IE6). > Minimizing window changes what we test and will break test interactive mode. We should change tests to accept cursor in left corner. Thanks, Jacek

2 4

Please write audio tests (was: Playing ULAW sample correctly?)
by Joerg-Cyril.Hoehle＠t-systems.com 04 Nov '09

04 Nov '09

Hi, >1. generate a PCM sine wave tone (like winmm/tests/wave.c); Actually any repetitive signal may not be good enough for general purpose, sine or square. Perhaps add some change in volume? For instance, there currently is a bug somewhere that causes Wine to repeat the first second of an intro animation's sound (bug #18182, comment #3) instead of continuing. This would probably not be detected. Also, the µ-law speech sample I fed to the MCI produces stuttering. Perhaps that would not be heard with a sine wave, if the periods match. Still it's better to have a test than currently no test at all! >It is also quite simple to generate sine waves without any trig. Code for sine is already in winmm/tests/wave.c No need to reinvent. Regards, Jörg Höhle

2 1

Re: winmm/tests: Add MCI waveaudio tests.
by Alexandre Julliard 04 Nov '09

04 Nov '09

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > +START_TEST(mci) > +{ > + HWND hwnd; > + hwnd = CreateWindowExA(0, "static", "winmm test", WS_POPUP, 0,0,100,100, > + 0, 0, 0, NULL); > + test_openCloseWAVE(hwnd); > + test_recordWAVE(hwnd); > + test_playWAVE(hwnd); > + test_asyncWAVE(hwnd); > + test_AutoOpenWAVE(hwnd); > + if(1) DeleteFile("tempfile.wav"); This fails to delete the file, probably because it's still open somewhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

how to install a windows service in wine?
by Zhaohui Wang 04 Nov '09

04 Nov '09

Hi all I am using wine 1.1.32, can anyone tell me how to install a windows service(say NETBIOS) in wine? I saw there is a services.exe running, but I didn't find any document on winehq saying how to add new wine services. I appreciate your help Best Regards Zhao Wang

2 2

Re: mciwave: Eliminate superfluous logs.
by Alexandre Julliard 04 Nov '09

04 Nov '09

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > - WARN after ExitThread is superfluous (and not present in most other code) Most likely the ExitThread should be removed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mciwave: Use volatile on slot modified from recorder thread.
by Alexandre Julliard 04 Nov '09

04 Nov '09

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > From b45e51940a42016e25a5c3a144968d81248927ed Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?J=C3=B6rg=20H=C3=B6hle?= <hoehle(a)users.sourceforge.net> > Date: Mon, 2 Nov 2009 23:49:42 +0100 > Subject: [PATCH] mciwave: Use volatile on slot modified from recorder thread. That's wrong. If there is proper synchronization you don't need volatile, and if there isn't volatile won't magically fix it. -- Alexandre Julliard julliard(a)winehq.org

1 0

msi: Initialize string pointer to NULL
by Kirill K. Smirnov 04 Nov '09

04 Nov '09

Hi Nathan, >+ haystack_table_name = NULL; > r = table->ops->get_column_info( table, i, &col_name, NULL, > NULL, &haystack_table_name ); > if( r != ERROR_SUCCESS ) I'm afraid, but this patch silences valgrind only, but does not solves the problem. It seems to me, that if table->ops->get_column_info() succeeds, it initializes haystack_table_name, and if it fails, we do not use haystack_table_name at all (we immediately return from this function). Thus, the problem lies somewhere in get_column_info(). So it is useless (and harmful, because it confuses valgrind) to initialize it like this. -- Kirill

2 1

Re: crypt32: Implement CertAddEncodedCertificateToSystemStoreA/W
by Stefan Leichter 03 Nov '09

03 Nov '09

Am Tuesday 03 November 2009 23:32:42 schrieb Juan Lang: > These were too easy to pass up. > --Juan +BOOL WINAPI CertAddEncodedCertificateToSystemStoreW(LPCWSTR pszCertStoreName, + const BYTE *pbCertEncoded, DWORD cbCertEncoded) +{ [snip] + store = CertOpenSystemStoreA(0, pszCertStoreName); This looks wrong to me ... Bye Stefan

2 1

Playing ULAW sample correctly?
by Joerg-Cyril.Hoehle＠t-systems.com 03 Nov '09

03 Nov '09

Hi, Using the MCI, I've successfully played an ADPCM sample from Wikipedia, except at the very end of IMA ADPCM play: fixme:wavemap:wodWrite Not all src buffer has been written, expect bogus sound After play status length increased from 13813 to 13826! How comes? However, playing an ULAW sample, the same message occurs constantly (apparently once for each wavehdr played) and the sound is awfully chopped. The error could be anywhere (MCI, WAVE_MAPPER, gsm711 ACM, waveaudio ...). Are there audio tests in Wine beside winmm/wave.c? How is ulaw / how are the msacm/gsm711/gsm722/gsm602 tested? Does anybody know whether ULAW works in Wine? (Any app that uses it outside of MCI?) Thanks, Jörg Höhle

5 7