November 2009 - Wine-devel - list.winehq.org

Infinite loop with translation DLL
by Uwe Bonnes 10 Nov '09

10 Nov '09

Hello, around July 2009, I implemented a translation dll, allowing to run Win32 programms using ftd2xx.dll with Wine translating the calls to linux-libftd2xx. It was done while looking at dll/glu32. I was able to run mprog.exe (www.ftdichip.org) some time ago. Reapplying now, I hit an infinite loop with the first translated call. I short, ftd2xx.spec contains: @ stdcall FT_ListDevices(ptr ptr long) FTD2XX_FT_ListDevices and ftd2xx_main.c: extern FT_STATUS FT_ListDevices(PVOID, PVOID, DWORD); FT_STATUS WINAPI FTD2XX_FT_ListDevices( PVOID pArg1, PVOID pArg2, DWORD Flags ) { FT_STATUS res = FT_ListDevices(pArg1, pArg2, Flags); TRACE("res %s\n", res2string(res)); return res; } and dlls/ftd2xx/Makefile.in contains: EXTRALIBS = @FTD2XXLIBS@ with EXTRALIBS detected in configure.ac. MProig.exe calls FT_ListDevices(), which is resolves as FTD2XX_FT_ListDevices(). Then FTD2XX_FT_ListDevices() is entered and FT_ListDevices() resolves again to FTD2XX_FT_ListDevices(), resulting in an infinite loop. Can anybody help with the flaw in my implementation? Or did anything change in wine? The patches still linger on the mailing-list as "Stub implementation for ftd2xx.dll" Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 3

Re: [PATCH] server, ntoskrnl: Implement support for IRP_MJ_CREATE requests.
by Vitaliy Margolen 10 Nov '09

10 Nov '09

Charles Davis wrote: > Also, add stub handlers in mountmgr. > > This patch fixes an issue with the previous one where wine would hang if > ntoskrnl got a STATUS_BUFFER_OVERFLOW back from thes server. > --- > +int suspend_thread( struct thread *thread ); > +int resume_thread( struct thread *thread ); > +static void complete_open( struct open_call *open, unsigned int status ) > +{ ... > + resume_thread( open->call.thread ); > This static struct object *device_open_file( struct object *obj, unsigned int access, > unsigned int sharing, unsigned int options ) > { ... > + suspend_thread( current ); Looks like a hack to me. You shouldn't be suspending/resuming threads directly like this. They should block on open operation. Vitaliy.

2 1

Re: mciwave: Rework MCI notification system.
by Paul Vriens 10 Nov '09

10 Nov '09

On 11/10/2009 12:56 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > same patch as yesterday, with more spaces and volatile and mciSave fix thrown out. > > I was about to resend > [PATCH 2] winmm: MCI Close all causes one notification per open driver. > which I rebased as well when I realised that it's independent on the code here > (but should logically follow the present patch as #2). So I'm not resending that anew. > Please include it as well. > > Likewise, yesterday's > PATCH mciwave: Stop must not reset current position. > is completely independent on the notification stuff, so I'm not resubmitting it, > even though I sent it in third position. > > Well, I'll wait and see what feedback I get and what appears in git. > > Regards, > Jörg Höhle > Hi Jörg, Please resend all patches you want to have committed in a series with the proper numbering. If they can be applied independently then numbering is (strictly speeking) not needed but it does show where you're going. I'm not sure if it's only me but I have a hard time keeping tracking of all the patches you sent and what (or not) to apply in what order. -- Cheers, Paul.

1 0

Cpp Check Nov. 7th
by chris ahrendt 10 Nov '09

10 Nov '09

Well its been a few since I ran CPP Check and so I ran it today and got the following: New CPP Check Errors for the Wine Code: [/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error) Uninitialized variable: bmi_buf [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szText [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szTitle [/home/cahrendt/wine-git/dlls/shell32/shellpath.c:1360]: (error) Uninitialized variable: InfoBuffer [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd [/home/cahrendt/wine-git/server/mapping.c:118]: (error) Uninitialized variable: page_size Chris

2 1

Re: [PATCH 4] mciwave: Rework MCI notification system.
by Vitaliy Margolen 10 Nov '09

10 Nov '09

Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > + * Notifications in MCI work like a 1-element queue. > + * Each new notification request supersedes the previous one. > + volatile HANDLE hCallback; /* Callback handle for pending notification */ You do not need volatile here as AJ already explained. > + HANDLE old = InterlockedExchangePointer(&wmw->hCallback, NULL); > + if (old) mciDriverNotify(old,wDevID,MCI_NOTIFY_SUPERSEDED); > + mciDriverNotify(HWND_32(LOWORD(hWndCallBack)),wDevID,wStatus); Here and everywhere else in your patches, please add space before commas. > + if (wmw->hFile == 0)<----->return MCIERR_INTERNAL; /* FIXME: Save must work even after Open new. */ > . > - if (dwFlags & MCI_WAIT) > - { > - <->FIXME("MCI_WAIT not implemented\n"); > - } > - WAVE_mciStop(wDevID, 0, NULL); > + WAVE_mciStop(wDevID, MCI_WAIT, NULL); This looks like an unrelated change. Vitaliy.

1 1

Re: ntdll: fix memory leak in GetDiskFreeSpaceW
by Vitaliy Margolen 10 Nov '09

10 Nov '09

Dan Kegel wrote: > Found while valgrinding chromium's app_unittests. > > + done: > + RtlFreeHeap(GetProcessHeap(), 0, val.Buffer); > + You should us RtlFreeUnicodeString( &val ); instead. Vitaliy.

1 0

re: Question on using winedbg when program does not crash, just becomes unresponsive
by Dan Kegel 10 Nov '09

10 Nov '09

Susan asked: > [What can you do to get a backtrace of a hung app that won't hang when you run it in winedbg?] I ran into this last week and added a note to http://wiki.winehq.org/Backtraces "Alternately, instad of info process / attach, you can do 'bt all' to get backtraces of all threads in all running processes. This is handy when debugging hangs." That's not a very clear explanation, but what it means is: start winedbg without any app say 'bt all' in winedbg Voila, you now have backtraces for every process, including the hung one. It's your job to get that into a text file and remove the uninteresting ones...

3 3

The user32/win test crashes X on Intel cards
by Joerg-Cyril.Hoehle＠t-systems.com 09 Nov '09

09 Nov '09

Hi, >Marcus got the same issue and he had an Intel card too Charles Davis wrote: >This happens on Mac OS X, too. Check out >http://xquartz.macosforge.org/trac/ticket/293 Charles forgot to mention that it affects NVidia on the Mac, which I did not explicitly write in the above bug report (the Mac people will have guessed it from the "early 2009 Mac mini" comment). More precisely SetWindowPos(hwnd, 0, -32769, -40000, -32769, -90000, SWP_NOMOVE); #if 0 SetWindowPos(hwnd, 0, 32768, 40000, 32768, 40000, SWP_NOMOVE); #endif SetWindowPos(hwnd, 0, -32769, -40000, -32769, -90000, SWP_NOSIZE); SetWindowPos(hwnd, 0, 32768, 40000, 32768, 40000, SWP_NOSIZE); is enough to let the tests succeed with Version: 2.3.3.2 (2.3.3) Build Info: X11server-480700~6 OS Version: Mac OS X 10.5.7 (9J61) This hints that the bug is in the X server, not the individual drivers? Regards, Jörg Höhle

2 1

Re: To error out or to skip tests?
by Greg Geldorp 09 Nov '09

09 Nov '09

Hi Jörg > Failure to flag an error in such cases has known drawbacks: > - For several month, Austin did not notice that his BSD boxes had lost > sound. wave.ok simply reports "5 tests ok, 1 skipped" in joyfull > green, whereas it executed many tests half a year ago. > > - All those vmware boxes configured without sound and thus skipping > all but 5 wave.ok tests have for monthes *not* provided valuable > feedback to Wine. So they were actually *not* executing tests, when > they could have. > It's only when Paul tested one of my tests that he realized that > sound was not configured on one of his vmware boxes, promptly > configured the sound device, and the tests passed. > > The picture on test.winehq.org is a disaster: None of the w95, w98, nt4, > 2k, 2k3, Vista, 2k8, w7 machines have performed winmm:wave tests! > They all have no sound configured. Mostly useless. A lot of those VMware boxes are mine. They come in two flavors. Some of them (starting with esx-) are ESX VMs, ESX is VMware's data center product, which simply doesn't support sound. The others (starting with gvg-) are Server VMs, which do support sound. The reason I didn't configure sound on them is because I'm simply not interested in sound. I'll consider enabling sound, but to be honest I'm a bit put off by your aggressive tone. Anyway, the end result is that there will always be ESX VMs that can't run sound tests. Best regards, Ge.

5 12

Question on using winedbg when program does not crash, just becomes unresponsive
by Susan Cragin 09 Nov '09

09 Nov '09

There is some sort of memory leak in Dragon NaturallySpeaking that makes the program become unresponsive (but not crash) after some minutes of using the Dictation Box. I have tried winedbg, SetOnFirstBreak but the program never actually crashes. Without SOFB, of course, winedbg goes for the first unhandled exception, which is harmless. I can't start winedbg right before the program crashes, because I don't know when it will do so. It just sort of wears down. There is nothing I do to make it become unresponsive. Any ideas?

1 0