December 2009 - Wine-devel - list.winehq.org

Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.
by Nikolay Sivov 28 Dec '09

28 Dec '09

On 12/28/2009 22:18, David Quintana (gigaherz) wrote: > Issue was caused by VK_F4 having the same exact code as a lowercase 's'. > So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed > the wrong piece of code which was meant to be ONLY for WM_KEYDOWN. > > Patch is attached. > > > > Please resubmit without cpp style comments.

1 0

Re: [PATCH 3/5] wined3d: Introduce "context_apply_state()" to setup a context for a specific usage.
by Stefan Dösinger 28 Dec '09

28 Dec '09

Am 27.12.2009 um 19:57 schrieb Henri Verbeet: > +/* Context activation is done by the caller. */ > +static void context_apply_state(struct wined3d_context *context, IWineD3DDeviceImpl *device, enum ContextUsage usage) The patch looks ok to me, but out of curiosity: Do you intend to make this function available to other wined3d code like context_acquire is, or is the main motivation of the patch to tidy up the context_acquire() function?

2 2

Remove Macintosh platform
by Austin English 28 Dec '09

28 Dec '09

I just moved the last macintosh platforms to ppc32/x86, so can someone with the appropriate permissions remove that option. Thanks! -Austin

2 3

Re: [PATCH 1/3] wininet: Test also InternetCrackUrlW in test_crack_url.
by Paul Vriens 28 Dec '09

28 Dec '09

On 12/27/2009 01:27 AM, Jacek Caban wrote: > --- > dlls/wininet/tests/url.c | 77 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 77 insertions(+), 0 deletions(-) > Hi Jacek, Looks like these tests need at least IE7 to succeed. Could you have a look? -- Cheers, Paul.

1 0

Defining missing DirectInput constants
by Javier Kohen 28 Dec '09

28 Dec '09

Hi, I'm implementing DInput's SetActionFormat call. I need to add the DInput Action Mapping Constants to Wine's dinput.h so I can map between the user requested action and the DIJOFS_* Joystick Device Constants. Is it OK to copy constant definitions from Microsoft's SDK? If not, can somebody help me or give some pointers on how to figure them out? This API call is needed at least for the Overlord game, which now works with my XBox 360 gamepad, but all action mappings are currently wrong. Thanks,

2 1

Re: [PATCH 2/3] wininet: Always set lpszUrlPath in InternetCrackUrlW.
by Alexandre Julliard 28 Dec '09

28 Dec '09

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/internet.c | 38 +++++++++++++------------------------- > 1 files changed, 13 insertions(+), 25 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so internet.c && touch internet.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x68699521 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x68699521). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68699521 ESP:0032d180 EBP:0032d1f8 EFLAGS:00010297( R- -- I S -A-P-C) EAX:cbcd24a4 EBX:686b1894 ECX:3432db62 EDX:6865b6c4 ESI:00000000 EDI:00000000 Stack dump: 0x0032d180: 00000000 00000000 00000000 00000000 0x0032d190: 00000000 00000000 00000000 00000000 0x0032d1a0: 00000000 00000000 00000000 0000000c 0x0032d1b0: 00000000 00000000 6865b6b8 00000000 0x0032d1c0: 00000006 00000000 00000000 00000000 0x0032d1d0: 00000000 00000000 00000000 00000000 Backtrace: =>0 0x68699521 InternetCrackUrlW+0x3c1(lpszUrl_orig=0x6865b6b8, dwUrlLength_orig=6, dwFlags=0, lpUC=0x32fb44) [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet (0x0032d1f8) 1 0x6869cd2c INTERNET_InternetOpenUrlW+0xec(hIC=0x148d18, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2846] in wininet (0x0032fb98) 2 0x6869d34e InternetOpenUrlW+0x10e(hInternet=0x1, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2990] in wininet (0x0032fbf8) 3 0x6864d4f3 test_null+0x3f3() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:400] in wininet_test (0x0032fca8) 4 0x6864f71b func_internet+0xbab() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:850] in wininet_test (0x0032fd98) 5 0x686560c0 run_test+0x130(name="internet.c") [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:537] in wininet_test (0x0032fdd8) 6 0x686562ae main+0x11e(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:586] in wininet_test (0x0032fe88) 7 0x68656d34 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in wininet_test (0x0032feb8) 8 0x7b8769d5 start_process+0x55(peb=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1038] in kernel32 (0x0032fee8) 9 0x7bc6f9e4 call_thread_func+0xc() in ntdll (0x0032fef8) 10 0x7bc6fbc0 call_thread_entry_point+0x70(entry=0x7b876980, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2391] in ntdll (0x0032ffc8) 11 0x7bc4cd5a in ntdll (+0x3cd5a) (0x0032ffe8) 0x68699521 InternetCrackUrlW+0x3c1 [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet: cmpw $10,0x0(%edi) 311 for (end = ptr + n; ptr < end; ptr++) if (*ptr == ch) return (WCHAR *)(ULONG_PTR)ptr; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [TRY 2] extrac32: Create directory tree before extraction
by Ilya Shpigor 28 Dec '09

28 Dec '09

Hi, Why this patch don't have been commited? There are mistakes? I really want to make extrac32 better, but I don't know what to do if nobody answer me. -- Best regards, Ilya Shpigor.

1 0

Re: Remove cpp_quote hackery from wined3d.idl (was: tools/widl: Split expr_int_const off from expr)
by Henri Verbeet 28 Dec '09

28 Dec '09

2009/12/24 Gerald Pfeifer <gerald(a)pfeifer.com>: > On Mon, 21 Dec 2009, Henri Verbeet wrote: >>> How shall we best tackle this? >> At least for the wined3d ones, we might as well just add them to the >> enum, the macros aren't strictly necessary. > > Done thusly. We just need to move WINEMAKEFOURCC to a local header, > the rest of the cpp_quote can go and we lose a couple of dozen warning > messages (rightfully) issued by GCC 4.5 snapshots. > I already sent pretty much the same patch, http://source.winehq.org/git/wine.git/?a=commitdiff;h=3288911ae3e3cbd7124ed…

2 2

Re: msvcrt: add some demangle features
by Eric Pouech 28 Dec '09

28 Dec '09

André Hentschel a écrit : > - > + if (*sym->current == 'A') sym->current++; > I don't understand how this would be necessary? Are you sure it's needed ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Re: wined3d: adjust glPolygonOffset size
by Henri Verbeet 27 Dec '09

27 Dec '09

2009/12/27 Austin English <austinenglish(a)gmail.com>: > See bug 18993. Original author is credited in patch ( Dorek Biglari ). > This doesn't look right from my understanding of the d3d9 depth bias behaviour. Afaik D3DRS_SLOPESCALEDEPTHBIAS is a multiplication factor for the maximum depth slope (i.e. difference in z-value over distance for a polygon's vertices), just like in OpenGL. I attached an alternative patch to the bug.

1 0