December 2009 - Wine-devel - list.winehq.org

Re: winefile - replace Run/Execute dialog with standard Shell32 RunFileDlg
by Paul Vriens 23 Dec '09

23 Dec '09

On 12/23/2009 07:08 PM, Steven Edwards wrote: > + hShell32 = LoadLibraryW(wszShell32); Isn't shell32 already available (it's imported, see Makefile.in)? If so a GetModuleHandleW() would suffice. -- Cheers, Paul.

2 1

trivial cmd test suite
by Dan Kegel 23 Dec '09

23 Dec '09

http://kegel.com/wine/sweng/2010/#tests now points to a trivial test suite for cmd that is currently driven by a shell script (so on windows you need to install cygwin). Later I'll replace the shell script with a C program that bundles the test data into the executable to allow its use in WineTestBot and winetest. (I'm away from my office, so I haven't tested it on Wine yet.) Austin also has a small test for cmd in http://code.google.com/p/winezeug/source/browse/trunk/appinstall/scripts/cm… The main difference between the two is that people writing tests have to do lots of escaping in Austin's (because his test data is inline in the script) but not in mine (because test data is stored in external files during authoring; it will be packed into the executable later when I translate this into C). - Dan

1 0

Patch for mmdevapi/tests/dependency.c
by Paul Vriens 23 Dec '09

23 Dec '09

Hi Maarten, Your patch to fix the test failure for boxes with no soundcard was not committed (yet?). Would the following patch be ok? It also includes more cleanup. -- Cheers, Paul.

1 0

Parser for cmd language?
by Dan Kegel 23 Dec '09

23 Dec '09

There are lots of bugs filed for little (or big) problems in wine's cmd that involve parsing the command language: 21047 cmd does not handle for %%a in ('command') 21046 cmd does not handle all operators in 'if' command 20161 cmd can't handle echo commands containing quotes and redirection 19784 cmd doesn't handle ( ) scoping; breaks firefox build 18712 cmd: "if defined ... " command crashes. 18407 cmd.exe: set command seems broken 18346 cmd does not support the "^" escape character 18057 cmd.exe: mishandled quoted built-in commands with parameters (programs/cmd/wcmdmain.c: has_space==1 && opt_s==0) 15359 cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build. The existing parser in cmd is pretty weak. I wonder if it might not be time to write a new parser -- either using some parser generator tool, or more likely, a plain old recursive descent parser -- that can handle the language better. Also, some of the builtins need to be split out into separate executables, see e.g. 18059 - Unity Indie Trial exits because attrib.exe is missing (which might relax the requirements on the parser inside cmd slightly)

5 21

Re: [1/5] WineD3D: Revert the GL usage confusion
by Roderick Colenbrander 23 Dec '09

23 Dec '09

On Tue, Dec 22, 2009 at 4:51 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > We had a discussion in wine-devel a few days ago about which GL usage is better. The red book also agrees with the GL wiki, but the GL 3.0 spec uses the confusing language the extension used. > > In my performance testing there is no difference, which suggests that this is a rather academic issue, unless you happen to run a game that is exactly hitting your card's bus transfer limits and/or video memory limits, but not the CPU and GPU ALU performance limits. > I'm not convinced the code should be changed back. All docs mention to use DYNAMIC_DRAW. On some implementations there might be a difference. I don't see a reason to change it. Did you get a response on the question you submitted to opengl.org? From what I understood the main difference between STREAM_DRAW and DYNAMIC_DRAW is that in case of dynamic, system memory which can be accessed using DMA is used and else this guarantee isn't given. I would keep it at the value which is correct as indicated by all documentation. If you want to change it, tests should be carried out on different drivers and GPUs OR wait for the feedback from opengl.org/ Roderick

2 2

Re: [2/5] WineD3D: Use unload instead of duplicating buffer remove code
by Henri Verbeet 23 Dec '09

23 Dec '09

2009/12/22 Stefan Dösinger <stefan(a)codeweavers.com>: > - HeapFree(GetProcessHeap(), 0, This->conversion_shift); > + IWineD3DBuffer_UnLoad(iface); > + This->flags &= ~WINED3D_BUFFER_CREATEBO; UnLoad() doesn't free "conversion_shift".

2 1

Status check for patches 56770/56772
by Nathan Gallaher 22 Dec '09

22 Dec '09

Seeing if there was anything I can do to help either of these patches move along. Don't want them to get lost. ~Nate

2 1

Re: gdiplus: Implement GdipGet/SetStringFormatMeasurableCharacterRanges.
by Vincent Povirk 22 Dec '09

22 Dec '09

> + format->character_ranges = GdipAlloc(rangeCount * sizeof(CharacterRange)); > + if (!format->character_ranges) > + return OutOfMemory; > > - return NotImplemented; > + memcpy(format->character_ranges, ranges, sizeof(CharacterRange) * rangeCount); > + format->range_count = rangeCount; > + > + return Ok; > } Won't this leak memory if I set it twice? -- Vincent Povirk

1 0

Re: [2/4] imagehlp/tests: Add tests for adding/removing multiple certificates
by Paul Vriens 22 Dec '09

22 Dec '09

On 12/04/2009 05:11 PM, Owen Rudge wrote: > --- > dlls/imagehlp/tests/integrity.c | 68 > +++++++++++++++++++++++++++++++-------- > 1 files changed, 54 insertions(+), 14 deletions(-) > > Hi Owen, This test fails on Win95 but only because the size of the dll is not aligned on a 16byte boundary. Using a different dll on XP for this test (my XP box has 36,921 for imeshare.dll for example) also throws up an error. Would something like this be ok: file_size_orig = get_file_size(); + if (file_size_orig % 16 != 0) + { + trace("We need to adjust the file size\n"); + file_size_orig = ((file_size_orig / 16) + 1) * 16; + } Does anybody know if '16' is indeed the alignment needed? -- Cheers, Paul.

2 3

Re: advapi32/tests: Fix test crash in Wine
by Nikolay Sivov 22 Dec '09

22 Dec '09

On 12/22/2009 20:09, Vladimir Pankratov wrote: > Hello all. > > Fixed test crash in Wine. > > changed files: > dlls/advapi32/tests/eventlog.c > > Thanks. Looks like you're hiding a real problem. BTW, I don't see any crashes on Wine in test page. How did you test it?

2 1