February 2009 - Wine-devel - list.winehq.org

Re: oleaut32: Fix SAFEARRAY marshalling on 64-bit platforms.
by Alexandre Julliard 09 Feb '09

09 Feb '09

Rob Shearman <robertshearman(a)gmail.com> writes: > @@ -874,8 +874,8 @@ unsigned char * WINAPI LPSAFEARRAY_UserMarshal(ULONG *pFlags, unsigned char *Buf > > *(ULONG *)Buffer = ulCellCount; > Buffer += sizeof(ULONG); > - *(ULONG_PTR *)Buffer = (ULONG_PTR)psa->pvData; > - Buffer += sizeof(ULONG_PTR); > + *(ULONG *)Buffer = (ULONG)(ULONG_PTR)psa->pvData; > + Buffer += sizeof(ULONG); Wouldn't this break if the pointer happens to be 4Gb-aligned? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 09 Feb '09

09 Feb '09

Alexandre Julliard <julliard(a)winehq.org> >Sent: Feb 9, 2009 5:56 AM >To: Austin English <austinenglish(a)gmail.com> >Cc: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >Austin English <austinenglish(a)gmail.com> writes: > >> Didn't receive any feedback on this one last time. Been seeing this a >> bit recently in the forums, so adding a warning. No actual >> functionality lost. > >We've been through this before. There are legitimate reasons for running >as root, and we don't want to have any sort of warning or message box >getting in the way. > First, I respect the fact that AJ does not "want a box getting in the way". but I feel that clicking through a box as an experienced user is nothing but an additional mouse click. Second, the problem is that newbies, figuring that their favorite program will not run as an ordinary user, gets a wiff that root has more privileges, will attempt run as root totally hosing their Wine directory. This then starts the 'you should not run Wine as root' mantra on Wine-Users. This then causes the newbie to question why did I go to Linux/Wine when I had a perfectly running Windows system? Third, I agree that we need a warning for running as root, selectable to be disabled for those of us who are knowledgible enough to know what to do if we hose up our user space Wine directory. This satisfies the 'don't do this unless you are really sure what you are doing' cases and leaves the experts to do what we need to do. Austin, can you send me, via private mail, a .plan to implement this functionality for testing. AJ, unless you want to scare off newbies, we need this functionality. I understand that we don't want to upset the apple cart with experts, but the newbies running root is getting very old. We need the newbies to try things, but running as root has been tested throughly and we all know that this busts Wine. Newbies don't need to be exposed to this. James McKenzie

3 2

Re: EVE online losing its Linux Client
by James Mckenzie 09 Feb '09

09 Feb '09

François Guerraz <kubrick(a)fgv6.net> wrote: >Sent: Feb 9, 2009 1:32 AM >To: Chris Robinson <chris.kcat(a)gmail.com> >Cc: wine-devel(a)winehq.org >Subject: Re: EVE online losing its Linux Client > >On 9/02/09 3:55, Chris Robinson wrote: >> On Sunday 08 February 2009 6:17:38 pm Zachary Goldberg wrote: >> >A great thing would be that they officially support Wine. > >Also, if the Mac Wine would have worked better (I know it's Apple crappy >X11 fault and native Mac's API drivers cocoa language's fault... but >users don't care), it's very likely that they dropped their mac "native" >client. Since there is not a great Wine audience for the Mac, the Eve Online Mac client should not be abandoned just for that reason. The real reason may be that there is not a great deal of demand for an on-line game interface for the Mac. Most Mac users loath having to use X11 for any purpose, and a game tops the list. James McKenzie

1 0

OFC and MFC and Winelib
by King InuYasha 09 Feb '09

09 Feb '09

Hello, I was doing my random web browsing when I stumbled on an issue with source code with MSVC++ 2005 Express, and I was searching for a solution. I think I found one, but it hasn't been maintained for years from what I can gather. Since you guys do have winelib for the purpose of building Win32 source code, I thought that I could suggest that the people that do maintain Winelib could take over this project and import it into Wine's git repository. The project is called the Open Foundation Classes, and it aims to be "100% compatible with the MFC and will be improved in various ways. All not compatible parts are signed with a prefix." The link for OFC is: https://sourceforge.net/projects/ofc/ It has a CVS (blech) repository which is obviously linked in the SF project page.

2 1

Re: [1/2] d3dxof: Cleanup IDirectXFileImpl_CreateEnumObject a bit
by Alexandre Julliard 09 Feb '09

09 Feb '09

Christian Costa <titan.costa(a)wanadoo.fr> writes: > commit a9d8c3f6e21439bb638e958674f9da6a648661b2 > Author: Christian Costa <titan.costa(a)wanadoo.fr> > Date: Sun Feb 8 13:25:45 2009 +0100 > > Cleanup IDirectXFileImpl_CreateEnumObject a bit. This doesn't work here: ../../../tools/runtest -q -P wine -M d3dxof.dll -T ../../.. -p d3dxof_test.exe.so d3dxof.c && touch d3dxof.ok d3dxof.c:113: Test failed: IDirectXFileEnumObject_GetNextDataObject: 88760362 wine: Unhandled page fault on read access to 0x3839c385 at address 0x6016fd1e (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

ntdll: add a warning about running wine as root (resend)
by Austin English 09 Feb '09

09 Feb '09

Didn't receive any feedback on this one last time. Been seeing this a bit recently in the forums, so adding a warning. No actual functionality lost. -- -Austin

2 1

RE: First complete test run passing on a Windows platform
by Ge van Geldorp 09 Feb '09

09 Feb '09

> From: Reece Dunn <msclrhd(a)googlemail.com> > > The Wine tests are now passing on a Windows XP machine > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group _XP). Actually, that was not the first time. On 20 Jan an XP machine passed: http://test.winehq.org/data/e9d8c9f572998054b1f9c386ea81a3570c65f2d2/#group_ XP And on 27 Jan a 2003 machine: http://test.winehq.org/data/8f829034f3fe4da3e7adce2f4685e10ba2e2fe82/#group_ 2003 > Two of the other four only have 2 or 3 failures. > > The 2003 group has 3 machines with 1 failure each > (urlmon:protocol on one, user32:menu on the others). I've sent a patch for the user32:menu failure a couple of weeks back but it got blackholed http://www.winehq.org/pipermail/wine-patches/2009-January/067483.html I won't be submitting test results next week but don't worry, I'll be back... Ge.

5 11

Re: shell32: Make ILGetDisplayNameExA() static and fix its documentation.
by Francois Gouget 09 Feb '09

09 Feb '09

Please don't apply. I should have removed the WINAPI when making the function static. I'll resend a patch. > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index 5f26265..2792bc6 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -75,7 +75,7 @@ static LPWSTR _ILGetTextPointerW(LPCITEMIDLIST pidl); > * RETURNS > * True if the display name could be retrieved successfully, False otherwise > */ > -BOOL WINAPI ILGetDisplayNameExA(LPSHELLFOLDER psf, LPCITEMIDLIST pidl, LPSTR path, DWORD type) > +static BOOL WINAPI ILGetDisplayNameExA(LPSHELLFOLDER psf, LPCITEMIDLIST pidl, LPSTR path, DWORD type) > { > BOOL ret = FALSE; > WCHAR wPath[MAX_PATH]; -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

1 0

Re: wininet: print better stubs for the internet options ie7 uses
by Dmitry Timoshkov 09 Feb '09

09 Feb '09

"Aric Stewart" <aric(a)codeweavers.com> wrote: > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 363f7a4..7db635d 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -2367,8 +2367,35 @@ BOOL WINAPI InternetSetOptionW(HINTERNET hInternet, DWORD dwOption, > case INTERNET_OPTION_DISABLE_AUTODIAL: > FIXME("Option INTERNET_OPTION_DISABLE_AUTODIAL; STUB\n"); > break; > - case 86: > - FIXME("86\n"); > + case 65: > + FIXME("INTERNET_OPTION_HTTP_DECODING; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case INTERNET_OPTION_COOKIES_3RD_PARTY: > + FIXME("INTERNET_OPTION_COOKIES_3RD_PARTY; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case INTERNET_OPTION_SEND_UTF8_SERVERNAME_TO_PROXY: > + FIXME("INTERNET_OPTION_SEND_UTF8_SERVERNAME_TO_PROXY; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case 100: > + FIXME("INTERNET_OPTION_CODEPAGE_PATH; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case 101: > + FIXME("INTERNET_OPTION_CODEPAGE_EXTRA; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case 102: > + FIXME("INTERNET_OPTION_IDN; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > break; All the numeric values above should be defined and constants in wininet.h. -- Dmitry.

1 0

ioports.c change -> buffer overflow ... bug?
by Marcus Meissner 09 Feb '09

09 Feb '09

Hi Florian, You are calling get_timer_val(3) in ioports.c (if (chan == 3) ... going down to get_timer_val(chan)) Howver, tmr_8253 is just a 3 element array, so [3] will run over the end, Is your code right? The change comes from this commit: commit edbd4885542e4545439906df950a68dc48e70839 Author: Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> Date: Tue Feb 3 18:26:04 2009 +0100 winedos: Improve PIT emulation. Ciao, Marcus

2 1