February 2009 - Wine-devel - list.winehq.org

Re: crypt32(1/4): Add chain debugging channel for debugging certificate chaining errors
by Alexandre Julliard 11 Feb '09

11 Feb '09

Juan Lang <juan.lang(a)gmail.com> writes: > +static void dump_element(PCCERT_CONTEXT cert) > +{ > + LPWSTR name = NULL; > + DWORD len, i; > + > + TRACE_(chain)("%p\n", cert); > + len = CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, > + CERT_NAME_ISSUER_FLAG, NULL, NULL, 0); > + name = CryptMemAlloc(len * sizeof(WCHAR)); > + if (name) > + { > + CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, > + CERT_NAME_ISSUER_FLAG, NULL, name, len); > + TRACE_(chain)("issued by %s\n", debugstr_w(name)); > + CryptMemFree(name); > + } > + len = CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, 0, NULL, > + NULL, 0); > + name = CryptMemAlloc(len * sizeof(WCHAR)); > + if (name) > + { > + CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, 0, NULL, > + name, len); > + TRACE_(chain)("issued to %s\n", debugstr_w(name)); > + CryptMemFree(name); > + } You probably don't want to do all this work unless tracing is enabled. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdiplus: add a drawing test for GdipFillRectangleI
by Nikolay Sivov 10 Feb '09

10 Feb '09

Vincent Povirk wrote: > This is a very simple drawing test that I've created to establish a precedent for drawing tests in gdiplus. > > Gdiplus currently has no tests that draw things and then check what was drawn. I've added some functions that should make this easy. It's important to get this right the first time so any feedback will be most appreciated. > As for me I'm not against it if it'll work stably, but will this really help? It's much easier to check this visually, comparing with native output. These pixel-by-pixel tests should use current bpp depth for 'relaxation' when we start draw gradients for example...That's will add another complexity. Maybe it makes sense to add an antialiasing drawing tests to find out a closer algorithm for line drawing with different SmoothingModes...

2 3

Re: imagicos
by James Mckenzie 10 Feb '09

10 Feb '09

Jeremy White <jwhite(a)winehq.org> wrote: > >EA Durbin wrote: >> I just saw this linux distribution on distrowatch. They claim to be able >> to run all microsoft products. Interesting. > >Just for the record, these folks are customers of ours. > Thank you for the clarification of your relationship with this company. > >It is my belief that their distribution of CrossOver complies with all >of the terms of the LGPL; we try to make sure of that for our customers. > I even believe that money they make as a result of their windows >compatibility will, albeit fairly indirectly, support Wine development. > This is very true. Hopefully, the legal folks have taken a look at how they are utilizing your product. I, for one, don't like to see one company's efforts usurped by another. > >Obviously, I like it when folks can celebrate the contributions of >everyone to Wine, and to all the FOSS products that go into something >like a Linux distribution. But Free Software means that folks are also >free to market as they see fit :-/. > I have warned folks against 'Free' software due to support concerns. I use Crossover because CodeWeavers is an ongoing concern. I advise folks to work with Wine, with the cavet that it is FOSS and that support is only available through the Wine Forums or Wine Mailing Lists. I also warn them that a problem they encounter may or may not be corrected. The same is true of most commercial software, but there is available telephone support (if you pay for it.) Again, I like where Wine is moving and the advances in just the last year. Also, I do support those companies that attempt to commercialize products, like RedHat and CodeWeavers. Please continue to do the great things that will move Wine forward. James McKenzie

1 0

Re: Fixing AppDB once and for all
by James Mckenzie 10 Feb '09

10 Feb '09

Zachary Goldberg <zgold(a)bluesata.com> >Sent: Feb 3, 2009 10:44 AM >To: Wine Devel <wine-devel(a)winehq.org> >Cc: Jeremy Newman <jnewman(a)codeweavers.com> >Subject: Fixing AppDB once and for all > >All, >Lets (arbitrarily) set a time for the chat at: > >When: 11PM UTC (6PM EST) 2/6/09 (Friday) >Where: #winehackers > This would be too early for people on the West Coast of the United States by about three hours. No time will be satisfactory for all people who work on this project. What I feel is necessary at this point is to collect who lives in what time zone so that we incovience as few people as possible. Since this would be Saturday in Asia, this time may work for the majority of the people on this list. Also, will there be a transcript of the discussion and where will it be placed since this has a major impact on the functionality of the Applications Database. James McKenzie

9 15

imagicos
by EA Durbin 10 Feb '09

10 Feb '09

I just saw this linux distribution on distrowatch. They claim to be able to run all microsoft products. Interesting. http://www.imagicos.com/ http://www.imagicos.com/microsoft.html _________________________________________________________________ Windows Live™: E-mail. Chat. Share. Get more ways to connect. http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t2_allup_explore_022009

13 21

Re: [PATCH] gdi32: handle failure in __wine_make_gdi_object_system (Coverity)
by Alexandre Julliard 10 Feb '09

10 Feb '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > @@ -445,6 +445,11 @@ static const struct DefaultFontInfo default_fonts[] = > void CDECL __wine_make_gdi_object_system( HGDIOBJ handle, BOOL set) > { > GDIOBJHDR *ptr = GDI_GetObjPtr( handle, 0 ); > + > + if (!ptr) { > + ERR("System object for handle %p not found.\n", handle); > + return; > + } That shouldn't happen, it's an internal function and the caller is supposed to pass a valid handle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml/tests: Better check for installed Gecko.
by Alexandre Julliard 10 Feb '09

10 Feb '09

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -4199,9 +4199,8 @@ static void run_domtest(const char *str, domtest_t test) > } > > hres = IHTMLDocument2_get_body(doc, &body); > - ok(hres == S_OK, "get_body failed: %08x\n", hres); > - > - if(body) { > + if(hres != E_UNEXPECTED) { > + ok(hres == S_OK, "get_body failed: %08x\n", hres); > IHTMLElement_Release(body); We've been through this before, there needs to be at least one failure if mshtml is non-functional because Gecko is missing. I'd suggest to remove the Gecko install workaround and have the test force the install in all cases, it's not useful to run the tests without Gecko anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: spoolss: Implement EnumPorts [try 2]
by Alexandre Julliard 10 Feb '09

10 Feb '09

Detlef Riekenberg <wine.dev(a)web.de> writes: > Synced to current git. It doesn't work here: ../../../tools/runtest -q -P wine -M winspool.drv -T ../../.. -p winspool.drv_test.exe.so info.c && touch info.ok info.c:505: Test failed: got 1 with 127 (expected '0' with ERROR_INVALID_PARAMETER) make: *** [info.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winegcc: Free the temporary string arrays (Coverity)
by Alexandre Julliard 10 Feb '09

10 Feb '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > This fixes CID 883, 882, 881, 880, 879, 878, 877, > which are all basically missing strarray_free(arr)s. winegcc is a short-lived program, there's no reason to care about memory leaks. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [try2] dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path
by Ben Klein 10 Feb '09

10 Feb '09

2009/2/10 Vincent Pelletier <plr.vincent(a)gmail.com>: > On Tue, Feb 10, 2009 at 8:51 AM, Ben Klein <shacklein(a)gmail.com> wrote: >> You're taking out the strcpy into device, and replacing it with a >> strcpy into instance_name. What value will the device field hold? > > Err... strcpy from instance_name to the other struct. It's strcpy(out, in). > It's wine which is providing the windows program with names. OK, disregard everything I said ... ever ;) Well, at least about the strcpy. Sorry, must be my dyslexia playing tricks on me again. Oh, and can you try to hit "Reply to all" so it goes back to the mailing list too?

1 0