March 2009 - Wine-devel - list.winehq.org

re: makedep: let umask decide mode for Makefiles
by Dan Kegel 05 Mar '09

05 Mar '09

Paul Bryan Roberts write: > The code as it stands creates makefiles with a mode of 600. This may be > benign on most (e.g. personal workstation) installations but not all. > >An example is where the wine git repository is located on an NFS >volume. Here security settings may mean that root:root is treated as >nobody:nogroup. Installation from the repository is not possible as >root (whether via su or sudo) cannot even read the makefiles Where I work, NFS is set up so root cannot access any NFS volumes, period, because you really can't trust remote systems that much with NFS.

2 1

Fwd: [Wine] COMPLIMENT TO WINE STAFF
by Austin English 04 Mar '09

04 Mar '09

So y'all can have a warm fuzzy feeling today: ---------- Forwarded message ---------- From: lodewig <wineforum-user(a)winehq.org> Date: Wed, Mar 4, 2009 at 4:28 PM Subject: [Wine] COMPLIMENT TO WINE STAFF To: wine-users(a)winehq.org Installed Metatrader 4 under Wine 1.1.16 , Ubuntu 8.10 , no any problem . Used it for hours no any problem , Fast and stable . I am impressed . My compliments to all Wine Staff , a really great incredible work ! -- -Austin

1 0

Re: [shell32/tests] Don't crash on Win95
by Paul Vriens 04 Mar '09

04 Mar '09

On Wed, Mar 4, 2009 at 5:45 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > For whatever reason Win95 was always failing this test with i greater than 5 > and > now it's less than 5 (since yesterday!). This will crash as the rest of the > tests rely on that exact number (we have 5 files/directories in our > testdir). > > Changelog > Don't crash on Win95 > > -- Please ignore this one. I'll will sent some patches that fix the underlying issue on Win95. -- Cheers, Paul.

1 0

Re: iphlpapi: fix a compiler warning on non-Linux (try 2)
by Alexandre Julliard 04 Mar '09

04 Mar '09

Austin English <austinenglish(a)gmail.com> writes: > AJ's recent work in this area caused a warning on non-Linux OS's, > where this function is not used. That's on purpose, the function is supposed to be used on other platforms too. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: iphlpapi: fix a compiler warning on non-Linux (try 2)
by Francois Gouget 04 Mar '09

04 Mar '09

On Tue, 3 Mar 2009, Austin English wrote: > AJ's recent work in this area caused a warning on non-Linux OS's, > where this function is not used. > > Resending with a proper extension. Why does your patch modify dlls/ntdll/virtual.c? It seems to me that this should be separate. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.

2 1

Re: [3/3] kernel32/tests: add named pipe test using i/o completion ports
by Austin English 04 Mar '09

04 Mar '09

On Thu, Feb 26, 2009 at 1:43 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > This has passed for me on all the NT systems I tested (NT4, 2000, XP, and Vista). 9x systems skip all named pipe tests. > > It does not pass on Wine. The exact nature of the failure is theoretically too unpredictable to properly mark it as todo. It can't be committed until Wine is fixed. (The test always failed the same way for me, but I believe on Wine there are races and accesses to uninitialized memory.) It seems AJ put in some other fixes before this, then committed your patch...however, I'm now getting failures on my (previously nearly pristine) box. Looks like Michael Stefaniuc is affected as well. Would you mind taking a look? http://test.winehq.org/data/566cb8c7a32f6128ae7d05f7fab30db08ba64ea4/#group… -- -Austin

2 1

Re: msacm32: acmFormatEnum - implementing ACM_FORMATENUMF_SUGGEST (2nd try)
by Stefano Guidoni 04 Mar '09

04 Mar '09

The fact is that the email service of my service provider is prone to screw up everything that seems plain text. I'll look for a solution. S. G.

1 0

Re: winemaker: fix 32-bit compiling and winresrc.h is the right name
by Francois Gouget 04 Mar '09

04 Mar '09

The two changes are independent so they should be in separate patches. About afxres.h vs. winres.h vs. winresrc.h, I believe it's mostly IDC_STATIC that was needed from winres.h. Unfortunately it's not being defined anywhere these days. In fact, all the Microsoft samples define it themselves. How did your tests with Programming Windows 98 go? If it worked with that, then the patch can be considered good enough. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.

1 0

Re: New test failures (out of the blue?)
by Reece Dunn 04 Mar '09

04 Mar '09

2009/3/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > We suddenly have a new test failure on NT4 and above for advapi32:security : > > security.c:1202: Test failed: GetTokenInformation failed with error 998 998 = ERROR_NOACCESS -- "Invalid access to memory location." Google (http://www.google.co.uk/search?q=ERROR_NOACCESS+GetTokenInformation&btnG=Se…) found http://www.cygwin.com/ml/cygwin-apps/2008-04/msg00222.html: "For whatever reason, GetTokenInformation was failing and returning ERROR_NOACCESS when passed a 1024 byte buffer. I changed the code to first call it with NULL to get the desired size, and that seems to have satisfied it. I cannot explain why it would object to a 1024 byte buffer, maybe you have some idea." That thread seems to suggest that this is an alignment issue -- the GetTokenInformation wants the buffer to be aligned properly. Corinna Vinschen suggests using PTOKEN_GROUPS groups = (PTOKEN_GROUPS) alloca (size); as alloca aligns correctly in cygwin's case. The buffer used in the test (line 1199) is allocated on the stack as a standard array and is thus not guaranteed to have the correct alignment. > And now also the rpcrt4:server test on W2K3 crashes (which it didn't before) > although that crash is not shown on test.winehq.org (child process > crashing?) but you will see 13 failures for this test (0 before). > > I haven't found the variable yet. I'm running VMware but I also see the > advapi32 failure on a real box. My VMware image for W2K3 hasn't been updated > since last week. No idea for this one. Have you done a bisect? - Reece

3 3

Re: D3D: Implement vertex blending in drawStridedSlow
by David Adam 04 Mar '09

04 Mar '09

2009/1/25 Claudio Ciccani <klan(a)users.sf.net> > > The patch implements a software fallback for vertex blending in > drawStridedSlow, fixing Bug #6955. > Although vertex blending is an old and outdated extension, there are > still many applications(games) relying on it nowadays. This because the > extension is generally supported by Direct3D, either directly in > hardware (using vertex programs) or in software. > This patch makes NOLF2 demo crashes. > > > Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7e6095c7 ESP:0033f0b4 EBP:0033f1ec EFLAGS:00010246( - 00 -RIZP1) EAX:00ec1b28 EBX:7e6bbc54 ECX:0000014c EDX:00000000 ESI:00000048 EDI:00000000 Stack dump: 0x0033f0b4: 00000000 00000000 00000000 3f800000 0x0033f0c4: 0033f110 7d05e000 7c03d008 7c7aa346 0x0033f0d4: 00000000 00000003 7e6bc7a0 7e69ee95 0x0033f0e4: 7e69e648 00000001 0000000c 00000010 0x0033f0f4: 795a5f68 7d09c0ac 0002d008 00ebd44c 0x0033f104: 00eba698 00ebd7a8 00000000 00000007 Backtrace: =>0 0x7e6095c7 drawStridedSlow+0x697(iface=0xeba698, sd=0xebd44c, NumVertexes=72, glPrimType=4, idxData=0x31dca00, idxSize=2, minIndex=0, startIdx=0) [/home/david/wine/dlls/wined3d/drawprim.c:307] in wined3d (0x0033f1ec) 1 0x7e60ea1b drawPrimitive+0x101b(iface=0xeba698, PrimitiveType=4, NumPrimitives=24, numberOfVertices=24, StartIdx=0, idxSize=<is not available>, idxData=(nil), minIndex=0) [/home/david/wine/dlls/wined3d/drawprim.c:1024] in wined3d (0x0033f55c) 2 0x7e5e41f9 IWineD3DDeviceImpl_DrawIndexedPrimitive+0xe9(iface=0xeba698, PrimitiveType=WINED3DPT_TRIANGLELIST, minIndex=0, NumVertices=24, startIndex=0, primCount=24) [/home/david/wine/dlls/wined3d/device.c:5314] in wined3d (0x0033f5cc) 3 0x7e6d43b6 IDirect3DDevice8Impl_DrawIndexedPrimitive+0x96(iface=<register ESI not in topmost frame>, PrimitiveType=D3DPT_TRIANGLELIST, MinVertexIndex=0, NumVertices=24, startIndex=0, primCount=24) [/home/david/wine/dlls/d3d8/device.c:1419] in d3d8 (0x0033f5fc) 0x7e6095c7 drawStridedSlow+0x697 [/home/david/wine/dlls/wined3d/drawprim.c:307] in wined3d: flds 0x0(%ecx) 307 m = &stateBlock->transforms[WINED3DTS_WORLDMATRIX((indices ? indices[0] : 0))].u.m[0][0]; Modules:

3 4