March 2009 - Wine-devel - list.winehq.org

Re: msacm32: acmFormatEnum - implementing ACM_FORMATENUMF_SUGGEST (2nd try)
by James McKenzie 03 Mar '09

03 Mar '09

Stefano Guidoni wrote: > This patch implements ACM_FORMATENUMF_SUGGEST and fixes bug 16394. > > >From MSDN: "The WAVEFORMATEX structure pointed to by the pwfx > member > of > the ACMFORMATDETAILS structure is valid. The enumerator will > enumerate > all suggested destination formats for the given pwfx > format.". > Since > the WAVEFORMATEX structure is valid, there is no need > to cycle through > all the standard formats (moreover the WAVEFORMATEX > format could be not > a standard one). > _________________________ > S. Guidoni > ------------------------------------------------------------------------ > > > Can you please use standard compression programs with standard extensions. Your file extension, .bin will not work here. James McKenzie

3 2

Re: [2/2] comctl32: replace nonprintable characters with spaces on SB_SETTEXT
by Alexandre Julliard 03 Mar '09

03 Mar '09

Nikolay Sivov <bunglehead(a)gmail.com> writes: > @@ -775,6 +777,16 @@ STATUSBAR_SetTextT (STATUS_INFO *infoPtr, INT nPart, WORD style, > strcpyW (ntext, text); > } else ntext = 0; > > + /* replace nonprintable characters with spaces */ > + if (ntext) { > + idx = ntext; > + while (*idx) { > + if(!isprintW(*idx)) > + *idx = space; > + idx++; This would need some test cases with various invalid chars to confirm that isprintW is the right check to use. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winmm: Initialize Memory in mciSendStringA
by Alexandre Julliard 03 Mar '09

03 Mar '09

Rico Schüller <kgbricola(a)web.de> writes: > @@ -1498,7 +1498,10 @@ DWORD WINAPI mciSendStringA(LPCSTR lpstrCommand, LPSTR lpstrRet, > MultiByteToWideChar( CP_ACP, 0, lpstrCommand, -1, lpwstrCommand, len ); > if (lpstrRet) > { > - lpwstrRet = HeapAlloc(GetProcessHeap(), 0, uRetLen * sizeof(WCHAR)); > + /* Use HEAP_ZERO_MEMORY, otherwise WideCharToMultiByte could crash if mciSendStringW fails, > + * because the length is taken from the uninizialized data! > + */ > + lpwstrRet = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, uRetLen * sizeof(WCHAR)); That's just hiding the bug. The string shouldn't be converted at all if we failed to retrieve it. -- Alexandre Julliard julliard(a)winehq.org

2 1

wine on mac leopard
by Adam Brown 03 Mar '09

03 Mar '09

Hi, I am running wine 1.1.16 on a mac with leopard. Everything is working great except for my dvd drive. Wine cannot seem to recognize it. Is there any special settings I need to adjust in order for it to function correctly?

1 0

Re: wine shirts
by Hervÿffffe9 Chanal 03 Mar '09

03 Mar '09

It's far from being finished (and I don't know if I will finish it), but Dan what do you think of that for your shirt : http://img522.imageshack.us/img522/8526/wines2.jpg > That's a nice, simple design, but something's missing. > > Oddly, the original drunken penguin shirts, or ripoffs thereof, seem > to still be available at > http://www.ixsoft.de/software/products/CWTSHIRTDP-L.html > Original artwork is at > ftp://wine.codeweavers.com/pub/wine/logos/ > I would kind of like a shirt that had the penguin opening the bottle > on the front (text: Support the Wine Project), and the drunken > penguin on the back (text: I did my part, or something like that) > but I'd have to think a bit more on the text. > Other old links: > Martin's design: > http://cross-lfs.org/~mlankhorst/t-shirt.png > Ismael Barros put some effort into this before: > http://www.winehq.org/pipermail/wine-devel/2008-December/070894.html > but nobody could think up good text. > - Dan

2 2

Re: ole32/tests: Add a few CoGetMalloc tests.
by Rob Shearman 03 Mar '09

03 Mar '09

2009/3/3 Huw Davies <huw(a)codeweavers.com>: > diff --git a/dlls/ole32/tests/compobj.c b/dlls/ole32/tests/compobj.c > index a332d27..9720e52 100644 > --- a/dlls/ole32/tests/compobj.c > +++ b/dlls/ole32/tests/compobj.c > @@ -1162,6 +1162,28 @@ static void test_CoInitializeEx(void) > OleUninitialize(); > } > > +static void test_CoGetMalloc(void) > +{ > + IMalloc *malloc; > + HRESULT hr; > + void *ptr; > + DWORD i, size; > + > + OleInitialize(NULL); > + hr = CoGetMalloc(1, &malloc); > + ok(hr == S_OK, "got %x\n", hr); > + for(i = 0; i < 10; i++) > + { > + ptr = IMalloc_Alloc(malloc, i); > + ok(ptr != NULL, "got NULL for size %d\n", i); > + size = IMalloc_GetSize(malloc, ptr); > + ok(size == i, "got %d expected %d\n", size, i); Has this been tested on Win9x? Since HeapSize on those versions of Windows doesn't return the same size as allocated, IMalloc_GetSize might not either. > + IMalloc_Free(malloc, ptr); > + } > + IMalloc_Release(malloc); > + OleUninitialize(); > +} -- Rob Shearman

2 2

Re: mshtml: Implement IHTMLStyle get/put borderStyle
by Rico Schüller 03 Mar '09

03 Mar '09

Alistair Leslie-Hughes schrieb: >+ hres = IHTMLStyle_get_borderStyle(style, &sDefault); >+ ok(hres == S_OK, "put_borderStyle failed: %08x\n", hres); Should probably be "get_borderStyle failed:...". Cheers Rico

1 0

Re: iphlpapi/tests: skip over unimplemented funtionality
by Francois Gouget 03 Mar '09

03 Mar '09

On Sun, 1 Mar 2009, Austin English wrote: > There's already one skip() in the file for some unimplemented stuff, > so basing these fixes on that (only skipping on ERROR_NOT_SUPPORTED). > If that's not what we should be doing (and just let it fail instead), > feel free to ignore. I asked on #winehackers but couldn't get a clear > answer as to what skip() should be used for... [...] > apiReturn = gGetIfEntry(&row); > + if (apiReturn == ERROR_NOT_SUPPORTED) > + { > + skip("GetIfEntry is not supported\n"); > + return; > + } If there are Windows versions that export these functions but don't implement them so that they systematically return ERROR_NOT_SUPPORTED, then a win_skip() is justified. If there are legitimate reasons for Wine to return ERROR_NOT_SUPPORTED, besides 'we did not implement it yet for this platform', then a skip() is justified. So you would use a skip() if the graphics card does not support the 3D features you want to test for instance. Or to skip over the sound capture tests if the sound card has no capture capability. However you should not add a skip() just to hide platform-specific test failures, or failures caused by unimplemented or partially implemented features. In this case it's not totally clear cut but it does look like it would just hide unimplemented functionality. Note that Alexandre has been reworking this area quite a bit recently so maybe your original impetus for adding these is gone. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

1 0

Re: include/port.h: fix a compiler warning on OpenSolaris
by Francois Gouget 03 Mar '09

03 Mar '09

On Sun, 1 Mar 2009, Austin English wrote: > OpenSolaris defines _FILE_OFFSET_BITS as well, causing a conflict. _FILE_OFFSET_BITS modifies the behavior of the Unix headers. So if it's set already, then it's wrong to redefine it and continue to include other Unix headers because you'll end up with inconsistent definitions. I think what this means is that there are places that include port.h after they have included Unix headers and that's wrong. It's these files that should be fixed. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

1 0

Re: ntdll: fix a couple compiler warnings on OpenSolaris
by Francois Gouget 03 Mar '09

03 Mar '09

> + wine_set_fs( thread_data->fs ); > + wine_set_gs( thread_data->gs ); > +#endif > + > /* get %fs and %gs at time of the fault */ > #ifdef FS_sig > *fs = LOWORD(FS_sig(sigcontext)); Isn't it a problem to move wine_set_{fs,gs}() just before code that purports to 'get %fs and %gs at time of the fault'? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0