April 2009 - Wine-devel - list.winehq.org

[6/7] [wined3d] force constant reload for NP2 fixup in shader_arb_select (review)
by Tobias Jakobi 22 Apr '09

22 Apr '09

-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a

1 0

[5/7] [wined3d] remove comment about np2fixup not implemented for ARB mode (review)
by Tobias Jakobi 22 Apr '09

22 Apr '09

-- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

1 0

[4/7] [wined3d] implement shader_arb_load_np2fixup_constants (review)
by Tobias Jakobi 22 Apr '09

22 Apr '09

-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a

1 0

[3/7] [wined3d] shader_hw_sample: add NP2 fixup code (review)
by Tobias Jakobi 22 Apr '09

22 Apr '09

-- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

1 0

[2/7] [wined3d] shader_generate_arb_declarations: add NP2 fixup code (review)
by Tobias Jakobi 22 Apr '09

22 Apr '09

-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a

1 0

Re: [4/4] (Try2) msi/tests: Fix package test when run on a different drive than C:\.
by James Hawkins 22 Apr '09

22 Apr '09

On Wed, Apr 22, 2009 at 12:05 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Try2: Use helper function added in second patch, as suggested by James. > > This one finally fixes current relative path test to expect correct > value. > This version isn't using a helper function. Please thoroughly go over your patches before submitting them. Your subject says try2, but I know it's been more than that, so we've seen at least 12-16 emails/patches for this set now. -- James Hawkins

2 2

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader
by Henri Verbeet 22 Apr '09

22 Apr '09

2009/4/21 Tobias Jakobi <liquid.acid(a)gmx.net>: > +struct ps_np2fixup_t { > + unsigned char idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ > + GLfloat* const_cache; /* constant cache for fast reloading (without readback) */ > + WORD swz; /* bitfield used to determine if we have to swizzle the constant */ > + WORD num_consts; > +}; > + - I'm sure I mentioned this before, but please don't add code without using it. - Why is this in struct ps_compiled_shader? This really looks like something that should be internal to the backend. - What is the point of const_cache? - Writing "GLfloat* const_cache;" is legal C, but really doesn't make a lot of sense. The * is part of the declarator rather than the base type. An example like "int* p, q;" should make this more obvious. - swz is redundant. "prog->np2Fixup_data->swz & (1 << i)" really isn't more efficient than "idx & 1"

3 7

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader
by Stefan Dösinger 22 Apr '09

22 Apr '09

Am Dienstag, 21. April 2009 23:37:51 schrieb Tobias Jakobi: > + unsigned char idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ I don't remember how you plan to use the ps_np2fixup_t structure in the ARB backend, but an unsigned char might turn out to be too limited if you end up storing ARB constant numbers in there, since cards can have more than 256 constants. For your GLSL code it is good enough because you just store values from 1-8.

2 2

Re: [1/2] comctl32/listview: Additional tests for LVM_GETSUBITEMRECT
by Paul Vriens 22 Apr '09

22 Apr '09

Nikolay Sivov wrote: > Changelog: > - Additional tests for LVM_GETSUBITEMRECT > >>From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 22 Apr 2009 13:05:56 -0400 > Subject: Additional tests for LVM_GETSUBITEMRECT > > --- > dlls/comctl32/tests/listview.c | 41 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 41 insertions(+), 0 deletions(-) > > diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c > index 6f205fd..fba7a01 100644 > --- a/dlls/comctl32/tests/listview.c > +++ b/dlls/comctl32/tests/listview.c > @@ -847,6 +847,7 @@ static void test_create(void) > LONG_PTR ret; > LONG r; > LVCOLUMNA col; > + RECT rect; > WNDCLASSEX cls; > cls.cbSize = sizeof(WNDCLASSEX); > ok(GetClassInfoEx(GetModuleHandle(NULL), "SysListView32", &cls), "GetClassInfoEx failed\n"); > @@ -976,6 +977,31 @@ static void test_create(void) > ok(IsWindow(hHeader), "Header should be created\n"); > ok(hHeader == GetDlgItem(hList, 0), "Expected header as dialog item\n"); > DestroyWindow(hList); > + > + /* requesting header info with LVM_GETSUBITEMRECT doesn't create it */ > + hList = CreateWindow("SysListView32", "Test", LVS_REPORT, 0, 0, 100, 100, NULL, NULL, > + GetModuleHandle(NULL), 0); > + ok(!IsWindow(hHeader), "Header shouldn't be created\n"); > + ok(NULL == GetDlgItem(hList, 0), "NULL dialog item expected\n"); > + > + rect.left = LVIR_BOUNDS; > + rect.top = 1; > + rect.right = rect.bottom = -10; > + r = SendMessage(hList, LVM_GETSUBITEMRECT, -1, (LPARAM)&rect); > +todo_wine > + ok(r != 0, "Expected not-null LRESULT\n"); > + > + hHeader = (HWND)SendMessage(hList, LVM_GETHEADER, 0, 0); > + ok(!IsWindow(hHeader), "Header shouldn't be created\n"); > + ok(NULL == GetDlgItem(hList, 0), "NULL dialog item expected\n"); > + > + expect(0, rect.left); > +todo_wine { > + expect(0, rect.right); > + expect(0, rect.top); These first 3 seems to fail on everything from W2K downwards. Could you have a look? -- Cheers, Paul.

2 3

Remote named pipes and stuff.
by Kai Blin 22 Apr '09

22 Apr '09

Hi folks, I'm at SambaXP again, and so of course the cifs Kernel driver folks talked to me about the named pipe implementation. It seems like they are still trying to figure out how this could be implemented in the cleanest way. However, Jeff Layton asked me about a use case, and I have to admit I can't think of one off the top of my head. So, what application do we have that fails to work due to the lack of remote named pipes? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1