April 2009 - Wine-devel - list.winehq.org

Re: [2/2] wininet: HTTP_HttpAddRequestHeadersW should ignore 0-lengthheaders
by Dmitry Timoshkov 24 Apr '09

24 Apr '09

"Paul TBBle Hampson" <Paul.Hampson(a)Pobox.com> wrote: > + if (strlenW(lpszStart)==0) > + { > + /* Skip 0-length headers */ > + lpszStart = lpszEnd; > + bSuccess = TRUE; > + continue; > + } Instead of 'if (strlenW(lpszStart)==0)' it's much simpler to do 'if (!*lpszStart)', and move the fix to HTTP_InterpretHttpHeader(). -- Dmitry.

2 1

Re: [1/2] D3D: Limit d3d8 and d3d9 vshader constants to 256
by Henri Verbeet 24 Apr '09

24 Apr '09

Not my preferred fix, but I suppose it works. > @@ -359,6 +359,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDeviceCaps(LPDIRECT3DDEVICE8 iface > if(pCaps->VertexShaderVersion > D3DVS_VERSION(1,1)){ > pCaps->VertexShaderVersion = D3DVS_VERSION(1,1); > } > + pCaps->MaxVertexShaderConst = min(256, pCaps->MaxVertexShaderConst); I think you should use D3D8_MAX_VERTEX_SHADER_CONSTANTF here.

2 1

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)
by Henri Verbeet 24 Apr '09

24 Apr '09

2009/4/23 Tobias Jakobi <Liquid.Acid(a)gmx.net>: > ps_np2fixup_t is still stored in ps_compiled_shader and I have no intention to change this, since the ARB code is going to use the exact same structure. NAK

3 5

Re: Dan's dotest reports
by chris ahrendt 24 Apr '09

24 Apr '09

André Hentschel wrote: > chris ahrendt schrieb: >> Are the Wine Developers using this report? >> >> Chris >> >> >> >> >> >> >> >> >> > If you are talking about the testsuite(test.winehq.org) then it is not > the only source of information for developers but an important one. > > yes that is what I am talking about... just wanted to make sure that by running the tests on linux the results get used...

2 1

Dan's dotest reports
by chris ahrendt 24 Apr '09

24 Apr '09

Are the Wine Developers using this report? Chris

2 1

Re: [1/4] Resend: ws2_32/tests: add tests for Inet_Ntop and inet_ntoa
by Alexandre Julliard 24 Apr '09

24 Apr '09

Jeff Latimer <lats(a)yless4u.com.au> writes: > @@ -55,6 +55,9 @@ > ok ( cond tmp, msg, GetCurrentThreadId(), err); \ > } while (0); > > +/* Function pointers */ > +static HMODULE hws2_32 = 0; > +static PCTSTR (WINAPI *pInetNtop)(int,LPVOID,LPTSTR,ULONG) = 0; There's no point in resending if you don't fix the reason it was rejected the first time. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [3/5] wined3d: The first shader token should be the version token.
by Stefan Dösinger 24 Apr '09

24 Apr '09

Am Freitag, 24. April 2009 09:21:23 schrieb Henri Verbeet: Did you test this? What if the shader starts with a comment?

2 1

Re: Extensive ScrollDC investigation (resubmit)
by Alexandre Julliard 24 Apr '09

24 Apr '09

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -120,13 +122,58 @@ BOOL CDECL X11DRV_ScrollDC( HDC hdc, INT dx, INT dy, const RECT *lprcScroll, > if( TRACE_ON( scroll)) dump_region( "Destination scroll region: ", DstRgn); > /* if there are any, do it */ > if( res > NULLREGION) { > - RECT rect ; > + RECT rect; > + HRGN UpdateClip = CreateRectRgn(0,0,0,0); > + /* Scroll Window does not scroll any already invalid areas */ > + if (GetUpdateRgn(WindowFromDC(hdc),UpdateRgn,FALSE)!=NULLREGION) > + { > + HRGN SrcMask; > + /* Apparently special case. If the update Rgn fills the entire > + DstRgn windows appears to ignore it */ This looks very wrong. Retrieving the update region from a DC doesn't seem right in the first place, and it you have to ignore it in some cases it shows that there's something else going on here. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Redirector code in Wine?
by Dan Kegel 24 Apr '09

24 Apr '09

Kai wrote: > I'm trying to figure out where the wine server actually decides if a file > actually is a file on disk, a local or a remote pipe. Any pointers? Search for FileFsDeviceInformation in ntdll/file.c, maybe.

2 1

Re: richedit: Null terminate streamed out rich text.
by Massimo Del Fedele 24 Apr '09

24 Apr '09

Dylan Smith ha scritto: > This can easily be tested by saving a rich text document in wordpad. The > rich text will always be null terminated, unlike plain text files which > will not have a terminating null byte. > > I noticed in a bug 14827 that AutoCAD 2005 looked for this NULL byte to > determine the length of the rich text in its EditStreamCallback function > given to EM_STREAMOUT, instead of using the cb parameter that provides > the length. > --- > dlls/riched20/writer.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > The patch is right (IMHO) but AutoCAD bug 14827 is still present, I guess it's another issue probably related to \fonttbl streaming out. Ciao Max

1 0