April 2009 - Wine-devel - list.winehq.org

XI2 DirectInput mouse implementation RFC (Tarballed)
by Paul TBBle Hampson 02 Jun '09

02 Jun '09

(Resend, the first email never arrived. I didn't realise one of my patches was 33k >_<) I've thrown together a rather-rough-but-working-in-a-limited-sense implementation of XInput2-based DirectInput. It's got a fair few problems, I'm mainly interested in feedback on the approach, although obviously any code or style criticisms are welcome. Current limitations: * Doesn't check for XInput2.h, so it won't build without it. (Laziness) It will _run_ without XInput2, falling back to the current dinput WndProc hooks even if compiled with XInput2 support. * Doesn't send button-ups; XI2 can't distinguish button up from down * Doesn't send events after button-down until after button-up on a window. I'm pretty sure this is an XI2 bug, but it might be a design feature. * Doesn't support exclusive mode. XI2 bug (grabs not yet implemented) Hopefully this can be implemented entirely within the dinput code in winex11drv (ie disabling and hiding the mouse on acquire. dinput already takes care of unacquiring when we are no longer the foreground app) * Mouse buttons aren't remapped nicely downwards. Need to look harder at this, my mouse reports buttons 1, 2, 3, 4, 5, 8, 9, 10, 11 and 12 under X. 4 and 5 are scroll, 6 and 7 might be horizontal scroll in which case if this is always the case we can just remap downwards. Might need to implement device querying to confirm mouse button mapping... * Only supports the Mouse. Adding keyboard support should be really trivial compared to actually getting the framework right. * Doesn't detect capabilities... A mouse with a horizontal scroll wheel'd have four axes. I haven't looked to see if DirectInput can support that, or if our dinput code can easily accomodate more axes or buttons than the current 3/8 setup. This the point we'd need another callthrough from gdimouse to the graphics driver. * Assumes a process will only try and acquire the mouse once. I'm not sure that this is a bad assumption, and it might be that dinput makes this a valid assumption for us. * Assumes no one else wants GenericEvents. Some day we'll need a GenericEvent handler system inside WineX11, particularly if wintab gets converted to XInput 2 support. Easy enough to do now if wanted. * gdimouse uses Wine Mouse GUID value. I'm not sure where these come from, if anywhere. Trivial to fix before submission. If this format is fine, then the first patch is basically ready to go, the latter two patches may need to be re-split or merged more sensibly. In the libs folder I've also attached a couple of fixes for the XI2 stuff if anyone wants to try it. One only affects 64-bit builds, and one fixes XCB locking assertions which you could probably otherwise ignore. So they're both kinda optional in the Wine context. Also one more patch, against the xinput utility from whot's git tree, to fix a compile failure in the XI2 test functionality. -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com Shorter .sig for a more eco-friendly paperless office.

4 13

Need help writing test
by Igor Tarasov 20 May '09

20 May '09

Hi! I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, but I have some problems. I see that there is bug, when I test it with control spy. But when I repeat it in testcase, it won't work. Here is how you can reproduce it: TB_SETBITMAPSIZE 20,20 TB_SETBUTTONSIZE 30,30 TB_SETBITMAPSIZE 10,10 Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin comctl will return 17,16. Native - 30,16. But when I write something like this: rebuild_toolbar_with_buttons(&hToolbar); himl = ImageList_LoadImage(GetModuleHandle(NULL), MAKEINTRESOURCE(IDB_BITMAP_80x15), 20, 2, CLR_NONE, IMAGE_BITMAP, LR_DEFAULTCOLOR); ok(SendMessageA(hToolbar, TB_SETIMAGELIST, 0, (LRESULT)himl) == 0, "TB_SETIMAGELIST failed\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(20, 20)); SendMessageA(hToolbar, TB_SETBUTTONSIZE, 0, MAKELONG(30, 30)); ok(SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0) == MAKELONG(30, 30), "Unexpected button size\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(10, 10)); compare((int)SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0), MAKELONG(30, 16), "%x"); This test fails, when I test it with native comctl32 (the size is 17,16). Why could this happen or what am I doing wrong? -- Igor

2 2

Office 2007 MSI Crash - Null dereference @ MsiViewExecute
by Mike Kaplinskiy 04 May '09

04 May '09

I was looking at the trace of the crash from bug 17600, and it looks like a custom action is calling MsiViewExecute with a null hRec. I (sadly) don't know much about the wine MSI architecture, but the msiobj_lock on line 484 should fail since rec will never be fetched (null). I think the intention was to make it query->hdr (as it is released later). Sorry if I'm dead wrong - just my 2c

3 5

Re: IE and MSN Messenger 7.0
by Ben Klein 03 May '09

03 May '09

2009/5/1 Cissyvonwinckelmann <cissyvonwinckelmann(a)planet.nl>: > hartelijk dank Benm ja ik moet snel een andere pc hebben, want dit is een > hele ouwe dan krijg je de moeilijkheden, > groetjes cissy > I have to use Google Language Tools to translate your text, so I apologise if I misunderstand you. The "old problems" with Messenger (you actually didn't say which Messenger it is, Yahoo or MSN?) in Wine are not likely to go away without a lot of work. As this is the developers' mailing list, we would welcome patches/modifications to Wine to make it work better. Without a discussion on the development side, your questions are better directed to wine-users mailing list or the forum, or some other user-oriented support path. Regardless, it is strongly recommended that you look into using a native client (i.e. something you don't need Wine to run) such as Pidgin.

2 2

Dib Engine: some update
by Massimo Del Fedele 01 May '09

01 May '09

I put on bug's 421 page an update of my dib engine. It implements AlphaBlend, StretchBlt and has many color fixes. If you want to try it, just follow instructions on above page. Ciao Max

3 5

Wine + Mono + application = library not found?
by Seth Shelnutt 01 May '09

01 May '09

Hello all, I'm trying to see if I can get a folding monitor, http://code.google.com/p/hfm-net/ working in Wine. I've installed the latest wine, 1.1.20, and the latest mono for windows 2.4. It seems however that either mono or Wine, I think wine, is not seeing the library file from gtk. However it is in my lib folder. Does anyone have any idea where wine is looking for the lib to be at? This is on a Debian "testing" (Squeeze I guess, but I keep my repos under the "testing" and no name, I use the wine "sid" repo) install. shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ wine HFM.exe Unhandled Exception: System.TypeInitializationException: An exception was thrown by the type initializer for System.Windows.Forms.MimeIconEngine ---> System.DllNotFoundException: libgdk-x11-2.0.so.0 at (wrapper managed-to-native) System.Windows.Forms.GnomeUtil:gdk_init_check (intptr,intptr) at System.Windows.Forms.GnomeUtil.Init () [0x00000] at System.Windows.Forms.GnomeUtil.GetIcon (System.String icon, Int32 size) [0x00000] at System.Windows.Forms.GnomeHandler.AddGnomeIcon (System.String internal_mime_type, System.String name) [0x00000] at System.Windows.Forms.GnomeHandler.CreateUIIcons () [0x00000] at System.Windows.Forms.GnomeHandler.Start () [0x00000] at System.Windows.Forms.MimeIconEngine..cctor () [0x00000] --- End of inner exception stack trace --- at System.Windows.Forms.WinFileSystem..ctor () [0x00000] at System.Windows.Forms.MWFVFS..ctor () [0x00000] at System.Windows.Forms.FileDialog..ctor () [0x00000] at System.Windows.Forms.OpenFileDialog..ctor () [0x00000] at (wrapper remoting-invoke-with-check) System.Windows.Forms.OpenFileDialog:.ctor () at HFM.Forms.frmMain.InitializeComponent () [0x00000] at HFM.Forms.frmMain..ctor () [0x00000] at (wrapper remoting-invoke-with-check) HFM.Forms.frmMain:.ctor () at HFM.Program.Main (System.String[] argv) [0x00000] shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ locate libgdk-x11-2.0.so.0 /home/shelnutt/opt/gps/lib/libgdk-x11-2.0.so.0 /usr/lib/libgdk-x11-2.0.so.0 /usr/lib/libgdk-x11-2.0.so.0.1600.1 Thanks, Seth Shelnutt

2 1

IE and MSN Messenger 7.0
by Cissyvonwinckelmann 01 May '09

01 May '09

dag, bestaat er voor mij nog een mogelijkheid om messenger 7.0 te downloaden. Heb dus nog Windows Me, heel graag antwoord, groet cissy cissyvonwinckelmann(a)planet.nl

3 2

Re: Wine + Mono + application = library not found?
by Hin-Tak Leung 30 Apr '09

30 Apr '09

I use wine + win32 mono quite regularly (my .net app does some gdi some p/invoke stuff). Wine or mono takes extra dll's from $PATH, and also from the application's directory. The windows version of the gtk library is actually in .wine/drive_c/Program\ Files/Mono-2.4/bin/ . The way I would run your application would be: cd .wine/drive_c/Program\ Files/Mono-2.4/bin/ \ && wine ./mono.exe H:/Downloads/HFM Release 0.1.1.10/HFM.exe (note the "H:" for home dir under windows). There are probably other ways of doing it, but I think mine is guaranteed to work. --- On Fri, 1/5/09, Seth Shelnutt <shelnutt2(a)gmail.com> wrote: > Hello all, > > I'm trying to see if I can get a folding monitor, http://code.google.com/p/hfm-net/ > working in Wine. I've installed the latest wine, 1.1.20, > and the latest mono for windows 2.4. It seems however that > either mono or Wine, I think wine, is not seeing the library > file from gtk. However it is in my lib folder. Does anyone > have any idea where wine is looking for the lib to be at? > This is on a Debian "testing" (Squeeze I guess, > but I keep my repos under the "testing" and no > name, I use the wine "sid" repo) install. > > > > > shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ wine > HFM.exe > > Unhandled Exception: System.TypeInitializationException: An > exception was thrown by the type initializer for > System.Windows.Forms.MimeIconEngine ---> > System.DllNotFoundException: libgdk-x11-2.0.so.0 > > > at (wrapper managed-to-native) > System.Windows.Forms.GnomeUtil:gdk_init_check > (intptr,intptr) > at System.Windows.Forms.GnomeUtil.Init () [0x00000] > at System.Windows.Forms.GnomeUtil.GetIcon (System.String > icon, Int32 size) [0x00000] > > > at System.Windows.Forms.GnomeHandler.AddGnomeIcon > (System.String internal_mime_type, System.String name) > [0x00000] > at System.Windows.Forms.GnomeHandler.CreateUIIcons () > [0x00000] > at System.Windows.Forms.GnomeHandler.Start () [0x00000] > > > > at System.Windows.Forms.MimeIconEngine..cctor () > [0x00000] > --- End of inner exception stack trace --- > at System.Windows.Forms.WinFileSystem..ctor () [0x00000] > > at System.Windows.Forms.MWFVFS..ctor () [0x00000] > > > at System.Windows.Forms.FileDialog..ctor () [0x00000] > at System.Windows.Forms.OpenFileDialog..ctor () > [0x00000] > at (wrapper remoting-invoke-with-check) > System.Windows.Forms.OpenFileDialog:.ctor () > at HFM.Forms.frmMain.InitializeComponent () [0x00000] > > > at HFM.Forms.frmMain..ctor () [0x00000] > at (wrapper remoting-invoke-with-check) > HFM.Forms.frmMain:.ctor () > at HFM.Program.Main (System.String[] argv) [0x00000] > > shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ locate > libgdk-x11-2.0.so.0 > > > /home/shelnutt/opt/gps/lib/libgdk-x11-2.0.so.0 > /usr/lib/libgdk-x11-2.0.so.0 > /usr/lib/libgdk-x11-2.0.so.0.1600.1 > > > Thanks, > > Seth Shelnutt > > > > -----Inline Attachment Follows----- > > >

1 0

New Icons are very good, but not yet perfect
by Joel Holdsworth 30 Apr '09

30 Apr '09

Hi All, Great stuff with the new Tango icons for Wine - they're a definite improvement. One observation: it looks like the icons that I have installed do not have versions that have been tuned for small size: 16x16 and especially 22x22. If I understand correctly, the scaled icons were drawn for 48x48, which means that when the icon is drawn at size 22x22 in my gnome menu, there will be line width of 0.46px which looks too faint next to the other icons which have been tuned for small sizes, and have 1px lines. Does anyone know anything about this? Thanks Joel Holdsworth

3 2

Re: [PATCH] This patch fixes context menu crashes for edit controls asapparent in vb apps.
by Dmitry Timoshkov 30 Apr '09

30 Apr '09

And what is the reason of the crash? Please add a test case replicating the problem first. -- Dmitry.

1 0