April 2009 - Wine-devel - list.winehq.org

Re: gdiplus: partially implement GdipBitmapSetPixel
by Nikolay Sivov 29 Apr '09

29 Apr '09

Massimo Del Fedele wrote: > This one implements GdipBitmapSetPixel() besides unhandled alpha channel. > > Ciao > > Max + SetPixel(hdc, x, y, ((color << 16) & 0xff0000) | (color & 0x00ff00) | ((color >> 16) & 0x0000ff)); Use ARGB2COLORREF(ARGB color) from gdiplus.c for that.

1 0

Re: [clusapi] Don't print an out parameter
by Hans Leidekker 29 Apr '09

29 Apr '09

On Wednesday 29 April 2009 10:08:56 am Paul Vriens wrote: > Was going through some logs on Bugzilla and noticed this. > > Changelog > Don't print an out parameter The spec entry for ClusterEnum also needs a fix. -Hans

1 0

Re: [3/7] gdiplus: add blend information to linear gradient brushes
by Vincent Povirk 28 Apr '09

28 Apr '09

Don't commit this one. It leaks the gdi brush when GdipCreateLineBrush fails. Vincent Povirk On Tue, Apr 28, 2009 at 6:39 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

re: The DIB engine... does anyone know how to get it into Wine?
by Dan Kegel 28 Apr '09

28 Apr '09

Max's work has been great in that a) he has found and fixed bugs that affect Autocad, and gotten those bugfixes into the trunk, and b) he is slowly working his way towards a DIB engine prototype that actually greatly improves speed on some important apps without hurting other apps. If I recall correctly, previous efforts stalled partly because they didn't actually provide a real speedup. So I'm really glad Max is doing what he's doing, even if it's not destined for the trunk, because he is nevertheless paving the way in some sense. - Dan

5 10

Re: [2/5] WineD3D: Improve the GLSL spam filter
by Henri Verbeet 28 Apr '09

28 Apr '09

2009/4/28 Stefan Dösinger <stefan(a)codeweavers.com>: > I think this is getting pretty rediculous. I think we should either just always print the infolog, or give the infolog its own debug channel and make this a WARN.

2 3

Re: [3/5] WineD3D: Implement texldd
by Henri Verbeet 28 Apr '09

28 Apr '09

2009/4/28 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* What good are texrect grad functions? I don't know, but GL_EXT_gpu_shader4 defines them. > + * There is no GL_ARB_shader_texture_lod spec yet, so I don't know if they're defined there > + */ So how are you using the extension without a spec? > +static void pshader_glsl_texldd(const struct wined3d_shader_instruction *ins) Please call this "shader_glsl_texldd".

2 3

Re: Ubuntu no longer works correctly without pulseaudio
by Susan Cragin 28 Apr '09

28 Apr '09

http://bugs.winehq.org/show_bug.cgi?id=18133. >The alsadriver settings that freeze during training are as follows (and they are the ones that used to work): > >wave-out devices: dmix:Generic (there were three of these) >wave-in devices: dsnoop:Generic (ditto) > >My working mixer device was HD-Audio-Generic. >(I had three cards, the other mixers were HDA Intel and iMic USB audio system) > >Now, to get the program to work at all without freezing, I re-install the kernel. Then only the USB works properly. The settings I see are as follows. > >wave-out devices: ALC660-VD Analog > USB Audio > >wave-in devices: (same) Good news. By changing in winecfg alsa to oss, I was able to get USB and my on-board cards (including Creative X-fi) to work, and to work VERY well. No freezing during training. Smooth recognition. And very fast. (My new souped-up real-time kernel may have something to do with that.) I cannot control the volume by the program (I have to use alsamixer). OSS Driver wave out devices / wave in devices / mixer devices all show these three: Realtek ALC660-VD USB Mixer Creative CA0110-IBG

2 1

Romanian translation
by Dimitriu Petru 28 Apr '09

28 Apr '09

Good day. I'm a Romanian ReactOS translator. (For those who don't know, ReactOS is an operating system which seeks to be 100% compatible and similar to Windows NT.) Many translations from Wine are passed to the ReactOS project when synchronizing the source code. That leads to the fact that I can't directly translate and/or update any translation of ReactOS files that are in sync with Wine. Some translations are already done here on the Wine project but some of them are wrong (For example Basic colours is translated incorrectly as Culori de basă when the correct translation is Culori de bază), others don't fit with the rest of the translations (The translations of ReactOS should retain the terminology used in Windows. In Windows, Cancel is translated to Revocare, in Wine the translation is Renunţă which is the imperative form of the verb a renunţa - to give up). I was told I should speak to you if I want to change these translations but the problem is that many Linux distributions are translated in Romanian using Renunţă as Cancel etc and if I try to change the translation in Wine, then the Romanian Linux-users will strongly disagree ... Now that's a problem! What do you suggest I should do?

7 9

Re: [PATCH 2/2] [Kernel32]: fix the management of input records withENHANCED_KEY set
by Dmitry Timoshkov 28 Apr '09

28 Apr '09

"Eric Pouech" <eric.pouech(a)orange.fr> wrote: > --- a/dlls/kernel32/editline.c > +++ b/dlls/kernel32/editline.c > @@ -818,7 +818,7 @@ WCHAR* CONSOLE_Readline(HANDLE hConsoleIn) > /* EPP WCEL_Dump(&ctx, "before func"); */ > ofs = ctx.ofs; > /* mask out some bits which don't interest us */ > - ks = ir.Event.KeyEvent.dwControlKeyState & ~(NUMLOCK_ON|SCROLLLOCK_ON|CAPSLOCK_ON|ENHANCED_KEY); > + ks = ir.Event.KeyEvent.dwControlKeyState & ~(NUMLOCK_ON|SCROLLLOCK_ON|CAPSLOCK_ON); This reverts the following commit http://www.winehq.org/pipermail/wine-cvs/2008-October/049124.html which was a fix for the bug 4558. -- Dmitry.

1 0

Re: [1/4] ws2_32/tests: Resend: IPv6 tests for WSAAddressToStringA
by Detlef Riekenberg 27 Apr '09

27 Apr '09

On Mo, 2009-04-27 at 20:48 +1000, Jeff Latimer wrote: > - ok( len == sizeof( expect4 ), "Got size %d\n", len); > + ok( len == sizeof( expect4 ), "Expected size to be %d, got %d\n", > sizeof( expect4 ), len); Do not use sizeof() in a test. > + /*check to see it IPv6 is available */ > + v6 = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP); > + if (v6 == INVALID_SOCKET) { > + skip("Could not create IPv6 socket (LastError: %d; %d > expected if IPv6 not available).\n", > + WSAGetLastError(), WSAEAFNOSUPPORT); > + goto end; There is no reason, that the reader must guess from the log, if the result is a failure or an expected behavior. You should detect, that IPv6 is not available and handle that case nice. if ((v6 == INVALID_SOCKET) && (WSAGetLastError() == WSAEAFNOSUPPORT)) { skip("IPv6 not supported on this system\n"); goto end; } ok(v6 !== INVALID_SOCKET, "create an IPv6 socket failed with %d\n", WSAGetLastError()); if (v6 == INVALID_SOCKET) { skip("No IPv6 socket\n"); goto end; } I know, that the same message is already in the current logs. That should be handled the same way. Thanks for pick up IPv6 -- By by ... Detlef

2 1