April 2009 - Wine-devel - list.winehq.org

Re: i have itunes 7.60 successfully running on f10 kde 4.2
by EA Durbin 11 Apr '09

11 Apr '09

On Mon, Apr 6, 2009 at 1:05 PM, AllenDavidNiven <AllenDavidNiven <at> globalfone.biz> wrote: > who can i pay to make this on the wine that i have > is $100 ok ? > >That's generous of you, but also humorous. I can't remember the last >estimate we had of how much work it would take, but it's on the order >of tens of thousands of dollars. That's assuming it's not impossible >to get the ipod touch/iphone driver working in Wine. >-- >James Hawkins I don't know how many people I've shown linux who would convert if only it ran iTunes, I've demonstrated the operating system to dozens and it's a comon feedback I hear. Itunes is a major application and a huge inhibitor of linux adoption. But unless we get tens of thousands of dollars up front we shouldn't focus development effort on a huge attraction to the Linux operating system and lets ridicule someone when they do offer monetary support because it isn't significant enough. After all we don't want to vastly increase our potential customer base and potentially get several $70 per crossover professional license or $40 per standard license fees, but rather wait until someone writes a hefty check to port it up front. If you build it they will come. _________________________________________________________________ Quick access to your favorite MSN content and Windows Live with Internet Explorer 8. http://ie8.msn.com/microsoft/internet-explorer-8/en-us/ie8.aspx?ocid=B037MS…

6 7

Re: try2 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice
by Paul Vriens 11 Apr '09

11 Apr '09

Guy Albertelli wrote: > Enhance QueryDosDevice test for attempting to return all devices. > Add tests for GetVolumeInformationA testing the different root dir formats. > --- > dlls/kernel32/tests/volume.c | 134 +++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 131 insertions(+), 3 deletions(-) > > > > ------------------------------------------------------------------------ > > + char Root_Dir3[]="C:\\Windows\\System\\"; .. + Root_Dir3[0] = windowsdir[0]; This won't work on all systems as the windows directory can be different (and can be changed during installation). You could use GetSystemDirectory() instead of GetWindowsDirectory() to find out the drive letter and in the same go use the output from GetSystemDirectory() to fill Root_Dir3. As you're actually interested in an existing directory you could even use the output from GetWindowsDirectory() to fill Root_Dir3. -- Cheers, Paul.

2 1

Adding new flags?
by Igor Tarasov 10 Apr '09

10 Apr '09

Hi there! I try to implement as precise as possible one undocumented feature in comctl32, this all deals with one structure field. After lots of testing I know the following: 1. Default value for that field returned by getter is 0. 2. By default it is ignored in behavior. 3. If you change value by the setter, even to 0, behavior changes. 4. Negative values, such as (-1) also produce different behavior and cannot be used as "field not changed" flag. So, does that mean that I have to add new flag to the structure that would be set only if that field is changed, or there is another way to do that? -- Igor

3 5

Re: wined3d: don't update the screen when gdi back buffers are unlocked
by Henri Verbeet 10 Apr '09

10 Apr '09

2009/4/8 Vincent Povirk <vincent(a)codeweavers.com>: > This should fix bug 15789. > > Stefan tells me that we're supposed to update the screen when the front buffer is unlocked, as that means it could have changed. Instead, we do it when any buffer in the swapchain is unlocked. This makes for a lot of unnecessary copies. > > He also told me to make this change to fix it. I don't really understand the surrounding code. > > And he tells me that he's too busy to send the change in, and I should do it if I want it to happen soon. > For what it's worth, I think this patch makes sense. Not that the mail makes a very convincing case though :-/

1 0

Re: [2/2] wine.inf: Add HKCU\Keyboard Layout\Preload key.
by Alexandre Julliard 10 Apr '09

10 Apr '09

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -546,6 +546,7 @@ HKLM,System\CurrentControlSet\Control\Session Manager,,,"" > HKLM,System\CurrentControlSet\Control\VMM32Files,,,"" > HKCU,Software\Microsoft\Protected Storage System Provider,,,"" > HKCU,Software\Wine\MSHTML,"GeckoUrl",,"http://source.winehq.org/winegecko.php" > +HKCU,Keyboard Layout\Preload,,,"" This should be done somewhere in the keyboard layout code, not in wine.inf. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/4] msi/tests: Fix test when content indexing is disabled.
by Alexandre Julliard 10 Apr '09

10 Apr '09

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -2308,7 +2308,7 @@ static void test_setpropertyfolder(void) > > r = MsiInstallProductA(msifile, NULL); > ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r); > - if (GetFileAttributesA(path) == FILE_ATTRIBUTE_DIRECTORY) > + if (GetFileAttributesA(path) & FILE_ATTRIBUTE_DIRECTORY) > { > ok(delete_pf("msitest\\added\\maximus", TRUE), "File not installed\n"); > ok(delete_pf("msitest\\added", FALSE), "File not installed\n"); You most likely need to check for GetFileAttributesA failure first. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/4] (Try2) msi/tests: Fix package test when run on root drive directory.
by James Hawkins 10 Apr '09

10 Apr '09

On Thu, Apr 9, 2009 at 7:43 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Try2: This time with the patch. > > Tested on Win2k/WinXP. Marked two tests as todo_wine. > If you're having to add todo_wine, then you're changing the current tests, which is bad if all you're trying to do is handle another case (running on root drive directory). Adding more tests to reveal an existing problem is fine. -- James Hawkins

2 1

Re: [4/8] WineD3D: Support the full amount of constants in GLSL
by Henri Verbeet 10 Apr '09

10 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > if(pshader) { > - max_constantsF = GL_LIMITS(pshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 2; > - max_constantsF = min(This->baseShader.limits.constant_float, max_constantsF); > + /* No indirect addressing here */ > + max_constantsF = GL_LIMITS(pshader_constantsF); > } else { Actually, can't at least 2.x pixel shaders do relative addressing as well?

2 1

implement PS_USERSTYLE handling - obviously not correct ;)
by Hans Breuer 10 Apr '09

10 Apr '09

Hi, just read again http://www.winehq.org/sending_patches and noticed that my first wine patch may fall in the category of not deserving an answer at all (to your standards). The one thing I noticed is my mail client putting line-wrapping into the patch, which should be easy to correct. But before resending it, I would appreciate some feedback if something else is 'obviously' wrong with it. To me it seems to be very difficult for the issue at hand to fall into the category of being "Obvious(ly) Correct". Although the X11 and win32 concepts of extended line styles are very similar, at least I did not know the scaling issues involved without trying it out. One thing which may be considered critical is my selection of the test program. As noted it is Dia for win32 (ported by me [1]) through gdk-win32-drawing code (PS_USERSTYLE usage implemented by me [2]). So if I have misunderstood something there seven years ago, that two bugs could compensate each other ;) Another issue might be the unconditional implementation of PS_USERSTYLE. After all it is only available with NT-based windows. Should x11drv check for the version being emulated to also reproduce the failing behaviour? Or would that be too much compatibility? What can I do to increase the probability of the patch being accepted? Thanks, Hans [1] http://hans.breuer.org/dia/ [2] http://svn.gnome.org/viewvc/gtk%2B?view=revision&revision=6330 [3] http://hans.breuer.org/dia/dia-wine.htm -------- Original-Nachricht -------- Betreff: implement PS_USERSTYLE handling, tested with Dia(win32) Datum: Sun, 29 Mar 2009 19:45:05 +0200 Von: Hans Breuer <hans(a)breuer.org> An: wine-patches(a)winehq.org From b89af7d06fc8cbf5210c61fd58ed62caeddad968 Mon Sep 17 00:00:00 2001 From: Hans Breuer <hans(a)breuer.org> Date: Sun, 29 Mar 2009 18:27:29 +0200 Subject: implement PS_USERSTYLE handling, tested with Dia(win32) - see http://hans.breuer.org/dia/dia-wine.htm --- dlls/winex11.drv/pen.c | 31 +++++++++++++++++++++++++++---- 1 files changed, 27 insertions(+), 4 deletions(-) diff --git a/dlls/winex11.drv/pen.c b/dlls/winex11.drv/pen.c index 49fe74c..039798e 100644 --- a/dlls/winex11.drv/pen.c +++ b/dlls/winex11.drv/pen.c @@ -54,12 +54,33 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) elp = HeapAlloc( GetProcessHeap(), 0, size ); GetObjectW( hpen, size, elp ); - /* FIXME: add support for user style pens */ logpen.lopnStyle = elp->elpPenStyle; logpen.lopnWidth.x = elp->elpWidth; logpen.lopnWidth.y = 0; logpen.lopnColor = elp->elpColor; - + /* support for user style pens */ + if (MAX_DASHLEN < elp->elpNumEntries) + { + FIXME("PS_USERSTYLE: len(dashes)>MAX_DASHLEN %d,%d\n", elp->elpNumEntries, MAX_DASHLEN); + physDev->pen.dash_len = 0; + } + else + { + BOOL overflow = FALSE; + physDev->pen.dash_len = elp->elpNumEntries; + for (i = 0; i < elp->elpNumEntries; ++i) + { + if (elp->elpStyleEntry[i] > 255) + { + overflow = TRUE; /* can't fit the type */ + physDev->pen.dashes[i] = 255; + } + else + physDev->pen.dashes[i] = (char)elp->elpStyleEntry[i]; + } + if (overflow) + FIXME("PS_USERSTYLE: dashes clipped (type overflow)\n"); + } HeapFree( GetProcessHeap(), 0, elp ); } else @@ -108,14 +129,16 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) memcpy(physDev->pen.dashes, PEN_alternate, physDev->pen.dash_len); break; case PS_USERSTYLE: - FIXME("PS_USERSTYLE is not supported\n"); + /* handled above */ + break; /* fall through */ default: physDev->pen.dash_len = 0; break; } if(physDev->pen.ext && physDev->pen.dash_len && - (logpen.lopnStyle & PS_STYLE_MASK) != PS_ALTERNATE) + (logpen.lopnStyle & PS_STYLE_MASK) != PS_ALTERNATE && + (logpen.lopnStyle & PS_STYLE_MASK) != PS_USERSTYLE) for(i = 0; i < physDev->pen.dash_len; i++) physDev->pen.dashes[i] *= (physDev->pen.width ? physDev->pen.width : 1); -- 1.6.0.6 -------- Hans "at" Breuer "dot" Org ----------- Tell me what you need, and I'll tell you how to get along without it. -- Dilbert

3 3

Re: [3/8] WineD3D: Deal with reserved shader constants in the backend
by Henri Verbeet 10 Apr '09

10 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > + unsigned max_constantsF; This is valid C, of course, but would the extra 4 characters for "int " really hurt?

1 0