April 2009 - Wine-devel - list.winehq.org

RE: advapi32/tests
by Andreas Rosenberg 09 Apr '09

09 Apr '09

Paul Vriens wrote: >And the subject of the mail should be a bit more than just "advapi32/tests". Oops, sry. Read the second mail after resending in the patch containing your first suggestions. But I'm a bit confused about the meaning of todo_wine. todo_wine discards output from failed tests, if I understood that correctly. Formerly I thought the output from tests should show things that fail on Wine, which are things that should be fixed in Wine. What is the difference of test wrapped by todo_wine and test not wrapped? Regards Andreas

2 1

i have itunes 7.60 successfully running on f10 kde 4.2
by AllenDavidNiven 09 Apr '09

09 Apr '09

i have itunes 7.60 successfully running on f10 kde 4.2 but when i plug my ipod touch into the usb port it just shows icon with arrow connecting to itunes but nothing happens even if i press button and on itunes itself the sync menu item is greyed out any patches i need to apply someplace ? may i re-imburse you for your time with paypal or western union thx -- Allen David Niven CEO GlobalFone 405 Lexington Avenue, 26th floor Chrysler Building New York, NY 10174 +1-646-428-0700 office AllenDavidNiven(a)GlobalFone.biz http://www.GlobalFone.biz INSTANT MESSAGING CONTACTS - NEVER EMAIL ME AT INSTANT MESSAGE ADDRESSES - ONLY USE GLOBALFONE ADDRESS msn id: AllenDavidNiven6(a)Hotmail.com yahoo id: AllenDavidNiven6(a)Yahoo.com aol-aim id: AllenDavidNiven6 gmail id: AllenDavidNiven(a)Gmail.com skype id: AllenDavidNiven

6 13

Re: [2/2] [wined3d] GLSL: enable load_np2fixup_constants (fixed)
by Stefan Dösinger 09 Apr '09

09 Apr '09

Am Donnerstag, 9. April 2009 01:47:33 schrieb Tobias Jakobi: > Fixed patch according to stefand's suggestions. > > Please disregard the old one and use this patch instead. Looks ok to me I guess

1 0

Re: advapi32/tests
by Paul Vriens 09 Apr '09

09 Apr '09

Andreas Rosenberg wrote: > Added a test to verify result of LookupAccountSid > > > > ------------------------------------------------------------------------ > > The test fails here: security.c:1599: Test failed: LookupAccountSidA() Expected account name: paul got: INTERACTIVE I guess this is the test I recommended you to add. If so and if it's meant to show the bug you should add a todo_wine for failing tests on Wine. -- Cheers, Paul.

1 0

Re: [3/6] d3d9: Store the FVF in the d3d9 vertex buffer
by Henri Verbeet 09 Apr '09

09 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -197,7 +197,6 @@ static HRESULT WINAPI IDirect3DVertexBuffer9Impl_GetDesc(LPDIRECT3DVERTEXBUFFER9 > pDesc->Usage = desc.Usage; > pDesc->Pool = desc.Pool; > pDesc->Size = desc.Size; > - pDesc->FVF = desc.FVF; > pDesc->Type = D3DRTYPE_VERTEXBUFFER; > } I think you're missing something here.

2 1

re: win87em: always return that a 8087 coprocessor is present. (try 2)
by Christian Costa 09 Apr '09

09 Apr '09

Installed variable has always the same value. What about removing it instead ? Bye, Christian > Message du 09/04/09 07:10 > De : "Rein Klazes" > A : "wine-patches" > Copie à : > Objet : win87em: always return that a 8087 coprocessor is present. (try 2) > > > --- > dlls/win87em.dll16/win87em.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/win87em.dll16/win87em.c b/dlls/win87em.dll16/win87em.c > index 35a04c4..d3fc96a 100644 > --- a/dlls/win87em.dll16/win87em.c > +++ b/dlls/win87em.dll16/win87em.c > @@ -45,7 +45,7 @@ struct Win87EmInfoStruct > */ > /* FIXME: Still rather skeletal implementation only */ > > -static BOOL Installed = 0; > +static BOOL Installed = 1; /* 8087 is installed */ > static WORD RefCount = 0; > static WORD CtrlWord_1 = 0; > static WORD CtrlWord_2 = 0; > -- > 1.6.2.1 > > > > >

1 0

Re: [5/6] d3d: Remove the format from index buffers
by Henri Verbeet 09 Apr '09

09 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > + hr = IWineD3DDevice_SetIndices(This->wineD3DDevice, This->indexbuffer, > + WINED3DFMT_R16_UINT /* d3d7 uses uints */); The comment is inconsistent with the code (and probably redundant to begin with).

1 0

possible NULL dereference?
by Joris Huizer 09 Apr '09

09 Apr '09

Looking at git commit dcb3e52e2dfd0d6e494164932fb2b684d463a005, it seems, passing a NULL size pointer to GetUserNameEx[AW] is likely to crash. You may want to test whether Windows versions crash on it, and check for it if needed. HTH, Joris

2 1

Re: Added PulseAudio sound driver
by Michael Stefaniuc 09 Apr '09

09 Apr '09

NACK. remi.assailly(a)free.fr wrote: > I'm submitting the PulseAudio patch from Arthur Talyor. Guys, stop doing that as it doesn't increases the chance of the patch being accepted; quite the contrary. > As most distros have PulseAudio by default Wine should provide upstream > support. No, not really. winealsa.drv works just fine with PulseAudio too. > Both Fedora and Mandriva have included this work and it is reported to > work very well. As well as the ALSA driver. > I used latest patch from http://art.ified.ca/?page_id=40 > I just did a autoconf and autoheader. > > This feature has been confirmed by popular vote at > http://bugs.winehq.org/show_bug.cgi?id=10495 They should stop voting for a redundant feature. If they want to have it they should help make the patch *PERFECT*. That's about the only chance the patch has to get in. Just taking and old version of the winealsa.drv and replacing "ALSA" with "PULSE" doesn't cut it. And the patch already bitrotted. bye michael

3 4

Re: [2/3] ntdll: don't treat DOS paths starting with / as Unix paths
by Chris Robinson 09 Apr '09

09 Apr '09

On Monday 06 April 2009 6:58:31 pm Vincent Povirk wrote: > On Mon, Apr 6, 2009 at 8:53 PM, Chris Robinson <chris.kcat(a)gmail.com> wrote: > > Isn't that the python test's fault, then? Why can't c:\bin\sh exist? > > On a real windows system, it won't. It won't by default, but can't a user create it?

15 25