May 2009 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] ole32/tests: Add tests to show the WdtpInterfacePointer marshal data looks like the result of CoMarshalInterface.
by Paul Vriens 19 May '09

19 May '09

Huw Davies wrote: > --- > dlls/ole32/tests/usrmarshal.c | 38 +++++++++++++++++++++----------------- > 1 files changed, 21 insertions(+), 17 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, Could you have a look at the test results are test.winehq.org> This patch and the other one against usrmarshall.c introduced some test failures on several platforms. -- Cheers, Paul.

1 1

Re: [PATCH 8/8] urlmon: Added binding with MIME filter tests.
by Alexandre Julliard 19 May '09

19 May '09

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/tests/url.c | 782 > ++++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 636 insertions(+), 146 deletions(-) This is failing here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:2939: Test failed: mon should be destroyed here url.c:2940: Test failed: bctx should be destroyed here make: *** [url.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [wintrust/tests] Add some basic CryptCATOpen tests
by Detlef Riekenberg 19 May '09

19 May '09

On Mo, 2009-05-18 at 16:07 +0200, Paul Vriens wrote: > + hcat = pCryptCATOpen(emptyW, 0, 0, 0, 0); > + todo_wine > + { > + ok(hcat != NULL && hcat != INVALID_HANDLE_VALUE, "Expected a > correct handle\n"); > + ok(GetLastError() == ERROR_SUCCESS, > + "Expected ERROR_SUCCESS, got %08x\n", GetLastError()); > + } MSDN documents INVALID_HANDLE_VALUE on failure. When NULL is valid result, then a comment about the MSDN error would be nice. Did you have an application, that need ERROR_SUCCESS? The result of GetLastError() should only be tested, when the function failed, or when GetLastError is documented to be valid on success. -- By by ... Detlef

2 1

Re: winspool.drv: implement semi-stub of EnumJobsW
by Detlef Riekenberg 18 May '09

18 May '09

On Mo, 2009-05-18 at 19:30 +0400, Vitaly Perov wrote: > --- > dlls/winspool.drv/info.c | 36 +++++++++++++++++++++++++++++++++++- > 1 files changed, 35 insertions(+), 1 deletions(-) The correct location for an implementation is localspl.dll For which Application did you changed the stub? The important thing to decide first, what Wine is allowed to return: a) Informations from Wine and from Host-OS b) Informations from Wine only (will be empty most of the time) The current code is using "b", but your Patch added: c) Informations from the Host-OS only which is not correct. I'm fine to migrate from "b" to "a". Thanks for working on printing. -- By by ... Detlef

1 0

Re: [2/3] d3dx9: Add utility functions for loading files and resources into memory
by Stefan Dösinger 18 May '09

18 May '09

Am Montag, 18. Mai 2009 17:44:17 schrieb Tony Wasserka: > +HRESULT LoadFileIntoMemoryA(LPCSTR filename, LPVOID *buffer, DWORD *length) Do you need this function? Woudn't it be better to wrap A->W at the API level and have all internal functions W only? > + handle = CreateFileW(filename, GENERIC_READ, FILE_SHARE_READ, 0, OPEN_EXISTING, 0, 0); > + if(handle == INVALID_HANDLE_VALUE) return D3DERR_INVALIDCALL; > + > + *length = GetFileSize(handle, NULL); >+ if(*length == INVALID_FILE_SIZE) return D3DERR_INVALIDCALL; > + > + *buffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, *length); Is there a particular reason not to use mmap, or whatever the Windows equivalent is?

1 0

Re: [shell32] Improve the Dutch 'about' message box
by Reece Dunn 18 May '09

18 May '09

2009/5/12 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > Changed the sizes of the buttons and window to be the same as in > English. This make sure the 'Wine license' button can be fully read in > Dutch. > > - DEFPUSHBUTTON "OK", IDOK, 153, 133, 50, 12, WS_TABSTOP > + DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP According to Windows guidelines, command buttons (http://msdn.microsoft.com/en-us/library/aa511453.aspx) should be 50 x 14 DLUs (they can be wider than 50 DLUs, but only if the text is bigger than that, which it shouldn't for OK buttons) and have a 4 DLU spacing between other controls. This is so they look good in the presence of themes. - Reece

5 9

Re: [4/4]msctf: starting implementation of ITfContext::RequestEditSession and ITextStoreACPSink::OnLockGranted
by Alexandre Julliard 18 May '09

18 May '09

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/msctf/context.c | 68 > ++++++++++++++++++++++++++++++++++-- > dlls/msctf/tests/inputprocessor.c | 29 +++++++++++----- > include/textstor.idl | 2 + > 3 files changed, 86 insertions(+), 13 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M msctf.dll -T ../../.. -p msctf_test.exe.so inputprocessor.c && touch inputprocessor.ok inputprocessor.c:155: Test succeeded inside todo block: GetStatus called too many times make[2]: *** [inputprocessor.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)
by Alexandre Julliard 18 May '09

18 May '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > Not sure if we need to set these values in all error paths, > but definitely not in the NULL lpwhr. (lpwhdr?) There's no reason to have NULL checks in internal functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

[Article] WINE and the importance of application compatibility
by nn 17 May '09

17 May '09

WINE and the importance of application compatibility http://community.zdnet.co.uk/blog/0,1000000567,10012751o-2000630136b,00.htm Need a Holiday? Win a $10,000 Holiday of your choice. Enter now.http://us.lrd.yahoo.com/_ylc=X3oDMTJxN2x2ZmNpBF9zAzIwMjM2MTY2MTMEdG1fZG…

3 2

SoC 2009 / Application Test Suite Update
by Austin English 17 May '09

17 May '09

Howdy all, I've been working on the test suite. I've got a few basic tests set up with notepad, and I'm currently working on setting up the framework, using AutoHotKey to both run all the tests and parse the logs for failures/passing todo's. For those interested, here's the first 'real' script I've written. It sets up a test directory (C:\appinstall), downloads sha1sum.exe (if it doesn't exist), verifies its own sha1sum, downloads winscp.exe (portable version), sets up winscp.ini with its settings (I was going to use keyboard/mouse control, but ftp.winehq.org times out to quickly, and adjusting that setting with mouse/keyboard would be a lot more trouble), runs winscp, downloads welcome.msg, closes winscp, sha1sum's welcome.msg, and finally, deletes welcome.msg and winscp.ini. It already found one bug :-): http://bugs.winehq.org/show_bug.cgi?id=18455. On windows, when selecting the file to download, winscp pops up a dialog to allow you to put in an alternate path to save the file. On windows, it's already selected, so one can simply type a different path. On Wine, it's not selected, breaking the script. It's an easy work around (sending {HOME}, followed by {SHIFT}{END}), it's interesting that the script allows us to find such subtle bugs. Back to work... -- -Austin

3 4