May 2009 - Wine-devel - list.winehq.org

Handle Types: Big flaw in wine
by Daniel Santos 22 May '09

22 May '09

As I've been working with user32, adding tests & such, I've noticed that gdi32 also suffers from the same drawbacks: it appears to have no mechanism to track object types with handles. Thus, the functions (that I've examined thus far) simply assume that the caller responsibly passed a handle to the correct object type and proceeds with that assumption. This is the cause of at least one bug that I know of (18371). Right now, I'm trying to determine the best way to implement a solution and I'm still green to wine's architecture. My initial thought was a handle type table in user32 that would just contain a handle's type as a byte (or possibly two types packed in one byte since there are less than 16) using a huge ugly 64k table that directly mapped handle to entry (ugly but correct) and something more efficient later. But I'm wondering if it wouldn't be more appropriate to put something like that in kernel32's global arena table. Input appreciated. Daniel

1 0

Using TlsGetValue internally
by Daniel Santos 22 May '09

22 May '09

I'm playing with user32/cursoricon.c and winex11.drv/mouse.c and have noticed that one of the TODOs is that SetCursor (and probably lots others) clear the last error when they do not do so in windows. I tracked down the cause and winex11.drv's primary function for retrieving its per-thread data, x11drv_thread_data() calls the public kernel32 function TlsGetValue, which must set the last error to zero by specification. So, should we be using some internal function to get the TLS data that does not alter SetLastError or should we just save the last error in winex11.drv, call TlsGetValue and then restore the last error state? The later seems hack-ish, but the former sounds like a pain. Thanks, Daniel

1 0

Re: Change BITS_IBackgroundCopyJob_SetPriority to a stub so the EvE-Online patcher works.
by Ricardo Filipe 21 May '09

21 May '09

2009/5/20 Tim Wright <timw(a)splhi.com> > The EvE-online updater blows up because it's trying to set the download > priority in BITS (qmgr) and that isn't implemented. Simply stubbing it to > return S_OK is sufficient to allow it to work. > > Third attempt at sending. For some reason, it isn't being posted from > git-send-email even though the Cc: arrives just fine at another account. > Patch against git repository. This is bug 18528/12312. > > > > --- > dlls/qmgr/job.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c > index 3baa893..09693a3 100644 > --- a/dlls/qmgr/job.c > +++ b/dlls/qmgr/job.c > @@ -334,8 +334,8 @@ static HRESULT WINAPI > BITS_IBackgroundCopyJob_SetPriority( > IBackgroundCopyJob2 *iface, > BG_JOB_PRIORITY Val) > { > - FIXME("Not implemented\n"); > - return E_NOTIMPL; > + FIXME("(%p,0x%08x) stub\n", iface, Val); > + return S_OK; > } > > static HRESULT WINAPI BITS_IBackgroundCopyJob_GetPriority( > -- > 1.6.0.4 > > > > > your previous patch was already commited. check git page the next day when you send patches. http://source.winehq.org/git/wine.git/?a=commit;h=cb26244adb4e15ab60e4d02b5… ;)

2 1

Re: Bugzilla upgrade - opening attachments in browser
by Austin English 21 May '09

21 May '09

On Wed, May 20, 2009 at 6:05 AM, Igor Tarasov <tarasov.igor(a)gmail.com> wrote: > attachment.cgi shows that it relies on allow_attachment_display > parameter in bugzilla configuration. It has to be set to true. > > -- > Igor > Can a bugzilla admin please enable this? -- -Austin

3 4

Re: shell32: for FO_COPY, if the destination is an empty string, SHFileOperation should use the current directory.
by Alexandre Julliard 21 May '09

21 May '09

lionel_debroux(a)yahoo.fr writes: > @@ -1179,6 +1181,15 @@ static HRESULT copy_files(FILE_OPERATION *op, const FILE_LIST *flFrom, FILE_LIST > const FILE_ENTRY *entryToCopy; > const FILE_ENTRY *fileDest = &flTo->feFiles[0]; > > + /* If the destination is empty, SHFileOperation should use the current directory */ > + if (!fileDest) > + { > + WCHAR currd[MAX_PATH]; > + GetCurrentDirectoryW(MAX_PATH, currd); > + parse_file_list(flTo, currd); > + fileDest = &flTo->feFiles[0]; > + } This can't possibly work. parse_file_list requires a null-terminated list, and you will be overwriting the previous data. This needs more thought. -- Alexandre Julliard julliard(a)winehq.org

2 2

DIB Engine - Mostly fixed against test suite
by Massimo Del Fedele 21 May '09

21 May '09

Remaining bugs are related to : 1) Some color on monochrome bitmaps.... here I guess nobody knows how to do it right. I fixed some todo wine (most) but have 2 failures which wine does right. Seldom used anyways, and happens only on weird palettes. I guess not ever Microsoft knows what they did on this respect :-) 2) an AlphaBlend() call which should fail and doesn't. Here I really don't know why it should fail..... Uninfluent, anyways. 3) GetDIBits on a source DIB with BPP <= 8 fails to retrieve the original DIB palette, and synthesizes a new one instead. For the moment I found no simple way to grab the palette from inside GetDIBits without maintaining a linked list of HBITMAP <--> internal bitmaps. Not worth the effort for the moment anyways. If somebody notices weird colors due to it, I'll try to fix..... There are still some missing/buggy features rarely used that aren't spotted by testsuite; by now I've no time to fix them, anyways no one felt into them up to now :-) Austin, could you please retest it against test suite ? (code on Bug421 page) Ciao Max

6 9

Need help writing test
by Igor Tarasov 20 May '09

20 May '09

Hi! I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, but I have some problems. I see that there is bug, when I test it with control spy. But when I repeat it in testcase, it won't work. Here is how you can reproduce it: TB_SETBITMAPSIZE 20,20 TB_SETBUTTONSIZE 30,30 TB_SETBITMAPSIZE 10,10 Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin comctl will return 17,16. Native - 30,16. But when I write something like this: rebuild_toolbar_with_buttons(&hToolbar); himl = ImageList_LoadImage(GetModuleHandle(NULL), MAKEINTRESOURCE(IDB_BITMAP_80x15), 20, 2, CLR_NONE, IMAGE_BITMAP, LR_DEFAULTCOLOR); ok(SendMessageA(hToolbar, TB_SETIMAGELIST, 0, (LRESULT)himl) == 0, "TB_SETIMAGELIST failed\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(20, 20)); SendMessageA(hToolbar, TB_SETBUTTONSIZE, 0, MAKELONG(30, 30)); ok(SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0) == MAKELONG(30, 30), "Unexpected button size\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(10, 10)); compare((int)SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0), MAKELONG(30, 16), "%x"); This test fails, when I test it with native comctl32 (the size is 17,16). Why could this happen or what am I doing wrong? -- Igor

2 2

Re: gdiplus: implement partially transparent solid fill brushes
by Vincent Povirk 20 May '09

20 May '09

Don't commit this one. I forgot to pre-multiply the alpha. Vincent Povirk On Wed, May 20, 2009 at 11:33 AM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

Re: [PATCH] Add missing classes for DOMDocument in msxml, and add test-cases back it up.
by Austin English 20 May '09

20 May '09

On Tue, May 19, 2009 at 3:07 PM, Judy Devyak <judycarol(a)ameritech.net> wrote: > > > > You forgot the patch. -- -Austin

1 0

Re: [PATCH 7/8] urlmon: Added MIME filter handling in BindProtocol tests.
by Paul Vriens 20 May '09

20 May '09

Jacek Caban wrote: > --- > dlls/urlmon/tests/protocol.c | 723 > +++++++++++++++++++++++++++++++++++------- > 1 files changed, 608 insertions(+), 115 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, This introduces extra failures on what seems to be mostly on IE7 and higher; see test.winehq.org. Could you have a look? -- Cheers, Paul.

2 1