May 2009 - Wine-devel - list.winehq.org

Unused functions in fusion.dll
by Francois Gouget 11 May '09

11 May '09

CompareAssemblyIdentity() and GetAssemblyIdentityFromFile() have stubs in fusion.c, but they are not used and not exported in any way. Is there any point in keeping them in their current state? Where/how should they be exported? A look at the fusion.dll export table on my Windows XP turned up nothing... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

1 0

Re: wined3d: Fix ATI dx10 cards max varying quirk
by Stefan Dösinger 11 May '09

11 May '09

Am Montag, 11. Mai 2009 02:51:29 schrieb Robert Key: > Changelog: > * This adds a quirk to change the default max varying value from > 68 to 48 on ATI dx10 cards that use fglrx because a declaration > of 17 varying vec4s causes shaders not to render and using > 48 (12 varyings vec4s) works for HD2000 to HD4000 ATI cards. > > Fixes bug #17437 I'm fine with putting the quirk in until fglrx is fixed. The ATI developers confirmed the bug and recommended this workaround for now. (I somewhere heard that their driver shipping latency is > 3 months for some reason) Looking at the code again I saw a few details I don't like though: +static BOOL match_fglrx_r600_to_700(const WineD3D_GL_Info *gl_info) { + if(gl_info->gl_vendor != VENDOR_ATI) return FALSE; + if(strstr(gl_info->gl_renderer, "DRI")) return FALSE; + if(gl_info->max_glsl_varyings == 68) return TRUE; + return FALSE; +} Maybe its better to compare max_glsl_varyings to > 44. 44 is the amount advertised on dx9 cards(and I think we fix this up somewhere already). The main question is if we want this quirk to disable itself as soon as the driver is fixed, or if we want to disable it manually. The other thing that bothers me is the replacement value 48 or 52: According to an ATI dev[1] the correct value is 64, which would match the dx10 limit of 16 varyings. Assuming we subtract 8 for the builtin primary and secondary color we're still at 56, not 52 or even 48. There's probably the fog color or the gl_ClipVertex "varying", but we're not using the clip vertex position currently. I think we should figure out where the 48 comes from. Can you play a bit with the attached program and see how many varyings you can declare, and if the builtin color varyings, fog coord or gl_ClipPos change anything? 1: http://ati.cchtml.com/show_bug.cgi?id=1462

1 0

Re: Simplify dlls/comctl32/rebar.c (RESEND)
by Dmitry Timoshkov 11 May '09

11 May '09

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > static LRESULT > -REBAR_GetPalette (const REBAR_INFO *infoPtr, WPARAM wParam, LPARAM lParam) > +REBAR_GetPalette () > { (void) is mandatory, please don't omit it. -- Dmitry.

1 0

Re: regedit: remember settings state
by Dmitry Timoshkov 11 May '09

11 May '09

"André Hentschel" <nerv(a)dawncrow.de> wrote: > LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) > { > +HKEY hKey; > +LPWSTR lpKeyPath; > switch (message) { > case WM_CREATE: Indentation is weird. And an empty line after variables won't hurt. -- Dmitry.

1 0

Re: comctl32: add ListView_SetCheckState and ListView_GetCheckState withtests(try4)
by Dmitry Timoshkov 11 May '09

11 May '09

"André Hentschel" <nerv(a)dawncrow.de> wrote: > now with LVITEMW and SNDMSGW You are still casting to LPLVITEMA in ListView_SetCheckState while using LVITEMW and SNDMSGW. As been said by using SNDMSGW/LVITEMW you are making these macros incompatible with PSDK ones, and breaking compatibility if someone will try to compile a non-unicode application with Wine headers. -- Dmitry.

1 0

RFC: Removing the --use-cached-creds parameter from ntlm_auth
by Kai Blin 11 May '09

11 May '09

Hi Rob, I've done some digging about using cached credentials from winbindd, and this currently breaks with how we use this from Wine. Specifically, it's not possible to get the session key from winbindd. This breaks our later attempts to do signing/sealing. It might be possible to change winbindd to include this information, but in order to not leak user password information, winbindd can only do so for NTLMv2 and NTLM2. In any case, --use-cached-creds will make things break in new and interesting ways for users who actually are running winbindd. I propose to stop setting that parameter until we figure out how to make this work. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: wined3d: Fix ATI dx10 cards max varying quirk
by Henri Verbeet 11 May '09

11 May '09

2009/5/11 Robert Key <hpestilence(a)gmail.com>: > Changelog: > * This adds a quirk to change the default max varying value from > 68 to 48 on ATI dx10 cards that use fglrx because a declaration > of 17 varying vec4s causes shaders not to render and using > 48 (12 varyings vec4s) works for HD2000 to HD4000 ATI cards. > R600 and r700 are supposed to be actively supported. But you know, I don't actually care anymore.

1 0

Re: Shuttleworth on Wine
by nn 11 May '09

11 May '09

And the slashdot thread: Shuttleworth Says Ubuntu Can't Just Be Windows http://linux.slashdot.org/article.pl?sid=09/05/05/1546230 --- On Wed, 6/5/09, nn <saturn_systems(a)yahoo.com> wrote: > From: nn <saturn_systems(a)yahoo.com> > Subject: Shuttleworth on Wine > To: wine-devel(a)winehq.org > Received: Wednesday, 6 May, 2009, 9:04 AM > > Shuttleworth on Wine > http://www.osnews.com/story/21438/Shuttleworth_on_Wine > > > Yahoo!7 recommends that you update > your browser to the new Internet Explorer 8.Get it now. > > > The new Internet Explorer 8 optimised for Yahoo!7: Faster, Safer, Easier.

9 26

New icons for 1.1.21
by Scott Ritchie 10 May '09

10 May '09

Hey everyone, I just wanted to say that the icon discussion I started a couple weeks back has born even more fruit, and I'm really happy with the current state of the icons that I'm now using in the 1.1.21 Ubuntu packages. I've attached them, and will be sending them as patches soon as well. I'm still not quite done with them, and they will likely change a bit after I get some UI feedback at the Ubuntu Developer Summit at the end of the month, but in the meantime I think they're quite better than what we have. Unlike the ubuntustudio icons I found (and packaged with 1.1.20 as an experiment), these should be a bit more visible (and fully tango-compliant). In particular, the stem of the glass is no longer two semitransparent pixels at normal 48x48 size, but instead has a full Tango border/inner brush stroke. Smaller icons for the other standard sizes are being worked on as well, however they have to be retouched individually to maintain the 1 pixel border/brush stroke in the Tango style. Eventually I'll submit a patch for our website's mini icon as well. Anyway, please feel free to give way too much feedback :) Thanks, Scott Ritchie

4 8

Re: dlls/ddraw/executebuffer.c: silence compiler warnings
by Stefan Dösinger 10 May '09

10 May '09

> executebuffer.c:230: warning: comparison between 'D3DRENDERSTATETYPE' and > 'enum _D3DTRANSFORMSTATETYPE' executebuffer.c:232: warning: comparison > between 'D3DRENDERSTATETYPE' and 'enum _D3DTRANSFORMSTATETYPE' > executebuffer.c:234: warning: comparison between 'D3DRENDERSTATETYPE' and > 'enum _D3DTRANSFORMSTATETYPE' Does the attached patch fix the warning?

1 0