May 2009 - Wine-devel - list.winehq.org

Re: notepad: Use the explicit W-form of the types.
by Reece Dunn 07 May '09

07 May '09

2009/5/7 Michael Stefaniuc <mstefani(a)redhat.de>: > LoadString(Globals.hInstance, STRING_ERROR, szTitle, SIZEOF(szTitle)); > FormatMessage( > FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, > - NULL, error, 0, > - (LPTSTR) &lpMsgBuf, 0, NULL); > + NULL, error, 0, (LPWSTR)&lpMsgBuf, 0, NULL); Shouldn't you be using FormatMessageW here? Also, should the LoadString call be fixed as well? - Reece

2 1

Getting my test for DrawIcon and DrawIconEx included
by Joel Holdsworth 07 May '09

07 May '09

Is there a reason why my patch (attached) hasn't been included yet? This is my first patch, so maybe someone can help me get it in. Joel

2 1

Re: (resubmit: need a hint) user32: when needed, recalculate menu size of menu bar before tracking starts.
by Austin English 07 May '09

07 May '09

On Thu, May 7, 2009 at 1:52 AM, Rein Klazes <wijn(a)online.nl> wrote: > Fixes bug 10845 > > Changes from previous patch: menu position calculations moved to > nonclient.c. Can you add a testcase? -- -Austin

4 3

Re: [4/5] WineD3D: Work around a bad crash in fglrx
by Henri Verbeet 06 May '09

06 May '09

2009/5/5 Stefan Dösinger <stefan(a)codeweavers.com>: > + * quirk only enables point sprites on the first texture unit. This keeps point sprites working in > + * most games, but avoids the crash ...and on the other ones it will create hard to diagnose / explain bugs. Just disabling the extension if it's broken also avoids the crash, and will at least have predictable behaviour. I also *still* think us working around AMD's bugs is the wrong approach. Of course it would also help if AMD took these kind of things seriously, or at least replied to my posts (http://www.phoronix.com/forums/showpost.php?p=63527&postcount=107)

6 8

Wine on Solaris 10 and SXCE
by Vit Hrachovy 06 May '09

06 May '09

Hi people, Apostolos provided me links to download Sun packages of latest Wine (1.1.20) at sunfreepacks. Could someone responsible please update WineHQ page with the following info: http://winehq.org Run Windows applications on Linux, BSD, Solaris and Mac OS X. http://winehq.org/download/ Solaris http://www.sunfreepacks.com/listing/?limit=1000&offset=0 Solaris 10 http://www.sunfreepacks.com/pkgpool/ASwine-1.1.20.pkg.7z Solaris SXCE http://www.sunfreepacks.com/pkgpool/ASwine-SXCE-1.1.20.pkg.7z OpenSolaris package wine in repository http://pkg.opensolaris.org/contrib Thank you very much! Regards Vit Hrachovy -------- Original Message -------- Subject: Re: wine web pages update Date: Fri, 1 May 2009 11:31:53 -0700 (PDT) From: Apostolos Syropoulos <asyropoulos(a)yahoo.com> To: Vít Hrachový <vit.hrachovy(a)sandbox.cz> Hello there, We have exchanged a couple of messages back in March about the inclusion of Solaris/OpenSolaris download link in the wine pages, but still there is no progress. If you visit the following URL http://www.sunfreepacks.com/listing/?limit=10&offset=20 you will be able to download binary packages for both platforms. Could you please update your web pages? Kind regards, Apostolos ---------------------- Apostolos Syropoulos Xanthi, Greece

4 7

Re: Severity levels
by James Mckenzie 06 May '09

06 May '09

Darragh Bailey wrote on May 5th: > >On Mon, May 04, 2009 at 11:24:58AM -0700, James Mckenzie wrote: >> Ben Klein wrote on May 4th: >> > >> >Final post from me. >> > >> >2009/5/5 Nicklas Börjesson <Nicklas.Borjesson(a)ws.se>: >> >> b) I thought that priority was developer priority and severity was >> >> severity for the users. >> > >> >Nope. Both for the benefit of developers, hence why they're both on bugzilla. >> > >> > >> One question: Does Bugzilla have a place for user's to place the Impact on their ability to use a Windows program? This is much different than the priority and severity fields. >> >> James McKenzie > >In catching up on this long discussion, this is the first post that I've >seen that actually comes close to pin-pointing what is being requested. > >Current: >Severity = messure of bug impact on wine > >Requested: >Severity = message of bug impact on application running in wine > > >IMHO the bugzilla severity field is not the right place to measure >impact to other applications of bugs in the current development. >Attempting to track that type of information in the severity field >will always lead to confusion and problems. > As a reminder, Bugzilla is for developers to work in user discovered issues. The Severity field, as it is, is correct for developer/triage evaluation of discovered issues. It should not be changed. However, a developer should be aware of the impact on the user experience and the user's determined severity of a problem. Users should not be determining this through the use of the severity and priority fields. I have discussed the use of an impact field to have the user state what impact the problem has on their ability to use/install a particular application. Some problems have a more severe impact on certain applications. The use of metabugs to follow what applications are affected is HIGHLY discouraged. The users of Wine should be able to state, in one place, what the bug is, what its impact to them is and the status of repair and/or workaround(s) for the bug is. The Applications Database is the location where a user can input what they found through use of Wine by Linux/UNIX version/distribution and Wine version. Bug reports should reside in Bugzilla and users should be able to input bug reports quickly (<10 minutes for a non-English speaking user.) This seems to not be happening at the present time and users are confused by the Bugzilla interface and fields presented to them. We should not rely on the ability for users to read and understand what field does what but only present to them fields needed to be filled out by users when they submit a bug report. Since the severity and priority fields are developer only, they should not be present. The proposed impact field should be a drop down list only and present common impacts encountered by users, such as "Unable to Install Application", "Unable to run application","Screen is unreadable","Text not appearing on screen","Graphics are garbled". This allows the user to provide input and allow the triage team to provide feedback to the user as well as assign appropriate severity and priorities to bug reports. Please advise if this is what the project desires to do. Again, this is to improve the user experience for the unexperienced (nOOb) Wine user. Experienced users do not have these difficulties but this takes time away from developers and triage teams to provide user education. James McKenzie

3 2

Re: [2/5] WineD3D: Keep track of used float constants
by Henri Verbeet 06 May '09

06 May '09

> + reg_maps->constf = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + sizeof(*reg_maps->constf) * (constf_size / (sizeof(*reg_maps->constf) * 8) + 1)); This is flawed, it will allocate too much memory. You essentially want "(bit_count + 31) / 32" to calculate the number of DWORDs. > static void shader_record_register_usage(IWineD3DBaseShaderImpl *This, struct shader_reg_maps *reg_maps, > - DWORD register_type, UINT register_idx, BOOL has_rel_addr, BOOL pshader) > + DWORD register_type, UINT register_idx, BOOL has_rel_addr, BOOL pshader, unsigned char size) I don't think this is very nice, it's better to just call shader_record_register_usage() multiple times for the appropriate instructions. I.e., handle this the same way all the other opcodes are handled.

1 0

Shuttleworth on Wine
by nn 06 May '09

06 May '09

Shuttleworth on Wine http://www.osnews.com/story/21438/Shuttleworth_on_Wine Yahoo!7 recommends that you update your browser to the new Internet Explorer 8.Get it now.

4 4

Re: Severity levels
by James Mckenzie 05 May '09

05 May '09

Ben Klein wrote on May 4th: > >Final post from me. > >2009/5/5 Nicklas Börjesson <Nicklas.Borjesson(a)ws.se>: >> b) I thought that priority was developer priority and severity was >> severity for the users. > >Nope. Both for the benefit of developers, hence why they're both on bugzilla. > > One question: Does Bugzilla have a place for user's to place the Impact on their ability to use a Windows program? This is much different than the priority and severity fields. James McKenzie

7 7

winedbg and exceptions
by Christopher Harvey 05 May '09

05 May '09

Hi, I'm having trouble with winedbg and seh exceptions. I've got a program that throws TONS of unhanded exceptions that don't seem to affect behavior at all, but there is one exception that I'm after, it's an access violation exception that's crashing a program. I can "run" the program by holding enter in winedbg and telling it to cont on all exceptions, but I've never managed to read the exception I want this way. Basically I just need a backtrace from the violation. Chris.

2 1