May 2009 - Wine-devel - list.winehq.org

Re: DIB engine
by chris ahrendt 29 May '09

29 May '09

On 05/29/2009 11:14 AM, Austin English wrote: > On Fri, May 29, 2009 at 10:10 AM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> Question on this debate: >> >> Has AJ documented anywhere what the architectural issues are so they can >> be addressed? >> I have not seen this in the thread and was just wondering. >> If we have them documented then its a relatively easy task to address >> each of them. >> Yes it may be a hack but you would be surprised at how much of Windows >> is a hack internally. >> >> Do we even have an architectural document or guidelines to reference? >> > If you read the entire thread, you'll see that the DIB design is not a > puzzle that can be carved out and dropped in. The DIB engine must be > designed from scratch. Designing the DIB architecture is half of the > work itself, since that involves planning a lot of the code/testing, > etc. > > He pointed out a few things he didn't like about Massimo's design, but > not a full 'here's the spec, do this exactly'. > > For more details, read the full thread and past discussions. > > -- > -Austin > > > Right Austin, I have... thats why I asked the question why not sit down and say here is what we want from the DIB engine here is the Spec do this .. I have seen the here is what I don't like. But nothing showing what exactly is needed. This would be the first step in resolving this circular argument / discussion which is what I am trying to facilitate =D. Until that is done all we can do is have this same circular argument / discussion =D chris

3 2

Re: PowerPC MacOSX work...
by mghughes＠embarqmail.com 29 May '09

29 May '09

No No No People... Please read the messages before replying. I know the difference betweeen my 6502, 6800, Z80, 68k, x86, 7400. I know Wine is focused on running MSWindows based software on x86 processors. I also know there exists PowerPC code in the wine project because people were interested in bridging the gap to running x86 code via emulation... For the record... I am not looking to run another full out emulation. The best example of what I have in mind is what Apple did when they moved their processor base from 68K to PPC. And I am wondering if the same could be done for Wine. By the looks of things some of the framework to make that happen are already there in the form of thunk code... Apple used what they called trampolines iirc. I am not sure that WineLib is what I am looking to use as the wine script & loader seems to achieve much of what I am already looking to do. My understanding is that Wine has run on PowerPC at some time via native and Qemu/Qemu-user. Since the Darwine (PowerPC work) project went dormant, I have not been able to find much of the information I am looking for... What was the last known Wine/Darwine version known to work on PowerPC? I some had thoughts of getting that version and progressing forward to see what and where things break. Am I mistaken that the connection between wine/server appears to be broken? My previous statements in my first message still apply. Michael

5 5

Re: patch wined3d
by James McKenzie 29 May '09

29 May '09

Pavel Prochazka wrote: >static HRESULT WINAPI IWineGDISwapChainImpl_Present(IWineD3DSwapChain *iface, CONST RECT *pSourceRect, CONST RECT *pDestRect, HWND hDestWindowOverride, CONST >RGNDATA *pDirtyRegion, DWORD dwFlags) { > IWineD3DSwapChainImpl *This = (IWineD3DSwapChainImpl *) iface; >- IWineD3DSurfaceImpl *front, *back; >+ IWineD3DSurfaceImpl *front, *back,*hlp1,*hlp2;; You need to keep the same spacing as the remainder of the line. - { - HDC tmp; - tmp = front->hDC; + { Get rid of the trailing whitespace, it is not needed nor necessary. - - tmp = front->resource.allocatedMemory; + Same here. You should go through your additions and make sure that no trailing whitespace exists on any line. Also, you should combine all of your fixes into one patch until it is accepted. Lastly, a description should describe what your patch does: [wine3d] Create swapchains to eliminate problems with backbuffers (bug XXX {there are at least five bugs with backbuffer problems}) Also, provide test cases to prove that your patch actually does something that Windows(TM) does and to show that you did your homework. Again, as one of the people with the backbuffer problem causing FPS slowness, I am very interested in these patches. However, they need to be cleaned up so that we can use them. James McKenzie

1 0

Re: [PATCH] _Present
by Stefan Dösinger 29 May '09

29 May '09

Am Donnerstag, 28. Mai 2009 13:01:23 schrieb Pavel Prochazka: Don't send patches on top of unapplied patches - just always send the a patch against the current wine git code. Besides that, Henri and I pointed out a few other problems in the first version of the patch. Things won't get better if you just resend the same code without addressing the issues that were pointed out.

1 0

DIB Engine : passing all tests
by Massimo Del Fedele 28 May '09

28 May '09

I posted on bug 421 page (as usual) latest update of my engine. It suld pass all tests in wine suite.... also all bitmap's todo_wines, so expect some "false positive" signaled by tests. Austin, could you please re-run it on your test machines ? Ciao Max

21 48

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.
by Nikolay Sivov 28 May '09

28 May '09

Sergey Khodych wrote: > From a2bf101f7ede3937373b7b8f9e2a8ea032b7790d Mon Sep 17 00:00:00 2001 > From: Sergey Khodych <khodych(a)gmail.com> > Date: Mon, 25 May 2009 02:21:39 +0300 > Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. > > --- > dlls/comctl32/rebar.c | 12 ++++++++---- > dlls/comctl32/tests/rebar.c | 2 +- > 2 files changed, 9 insertions(+), 5 deletions(-) Where did you test that it isn't stored?

2 6

Need a temporary list moderator
by Luke Bratch 28 May '09

28 May '09

Hi all In a couple of weeks I'm going to be travelling around India for about a month, from 14th June - 17th July, so I'll need somebody to cover list moderation during that period. It's a simple task; you just need to bring up a web page for each list a couple of times per day, and single out any genuine messages that are awaiting approval, discarding the rest. You'll need to do it almost every day for the whole month, otherwise people will start to wonder where their mail is getting to... :) If you are interested, please email me directly. Thanks, Luke.

1 0

Re: [1/2] comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. (try 2)
by Nikolay Sivov 28 May '09

28 May '09

Sergey Khodych wrote: > From 37cd774e71f8d260d94bd672715b1eab879c4b2d Mon Sep 17 00:00:00 2001 > From: Sergey Khodych <khodych(a)gmail.com> > Date: Thu, 28 May 2009 04:52:45 +0300 > Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. > > --- > dlls/comctl32/rebar.c | 12 ++++++++---- > dlls/comctl32/tests/rebar.c | 9 +++++++++ > 2 files changed, 17 insertions(+), 4 deletions(-) Commented already. You're testing one part and changing another. Add simple get/set text tests first.

1 0

Changing default severity in Bugzilla to Normal
by Ken Sharp 28 May '09

28 May '09

"It seems the default severity, enhancement, invites people to select a REALLY SEVERE sounding level instead. I suggest changing the default severity to normal in the hopes of cutting down on the yelling." http://bugs.winehq.org/show_bug.cgi?id=13363 Any thoughts on this?

2 1

Re: [PATCH] _Present
by Francois Gouget 28 May '09

28 May '09

On Thu, 28 May 2009, Pavel Prochazka wrote: > > + IWineD3DSurfaceImpl *front,*hlp1,*hlp2; > + IWineD3DSurfaceImpl back; //must be copy of struct C++ comments are not allowed in Wine. There are a few others further down. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

1 0