May 2009 - Wine-devel - list.winehq.org

Re: comctl32/ipaddress: Use ok() test instead of assert()
by Paul Vriens 27 May '09

27 May '09

Nikolay Sivov wrote: > This test fails to create window sometimes on Win95, > let's turn it into general failure. > > Changelog: > - replace assert() with ok() test > >>From b63fc6defb497505ecaab4921449327e875ab252 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 27 May 2009 14:26:37 +0400 > Subject: Use ok() test instead of assert() > > --- > dlls/comctl32/tests/ipaddress.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/comctl32/tests/ipaddress.c b/dlls/comctl32/tests/ipaddress.c > index d04223c..b8f30e4 100644 > --- a/dlls/comctl32/tests/ipaddress.c > +++ b/dlls/comctl32/tests/ipaddress.c > @@ -33,8 +33,6 @@ static HWND create_ipaddress_control (void) > handle = CreateWindowEx(0, WC_IPADDRESS, NULL, > WS_BORDER|WS_VISIBLE, 0, 0, 0, 0, > NULL, NULL, NULL, NULL); > - assert(handle); > - > return handle; > } > > @@ -45,6 +43,7 @@ static void test_get_set_text(void) > INT r; > > hwnd = create_ipaddress_control(); > + ok(hwnd != NULL, "Expected window to be created\n"); > Shouldn't you insert a return here when hwnd is NULL. The following tests will fail as well I guess. -- Cheers, Paul.

2 5

Re: [mshtml/tests] Fix 2 test failures on IE8
by Jacek Caban 27 May '09

27 May '09

Hi Paul, Paul Vriens wrote: > Changelog > Fix 2 test failures on IE8 > - ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp); + ok(disp == (void*)0xdeadbeef || + disp == NULL, /* IE8 */ This test does no longer make sense. It would be better to remove it and preferably change implementation to match IE8. Thanks, Jacek

2 2

Re: d3d9/tests: add simple test to show that QualityLevels is not zero, when we call CheckDeviceMultiSampleType with D3DMULTISAMPLE_NONE
by Jeff Zaroyko 26 May '09

26 May '09

On Wed, May 27, 2009 at 7:47 AM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > This test shows second bug in > http://www.winehq.org/pipermail/wine-bugs/2009-May/177221.html > > I tested this on my laptop (under windows) with an ATI-card, my desktop > computer (that has nvidia) only runs Linux, so i could not test it on nvidia > under windows, if anyone could do that that would be nice. > No failures on Vista, nv9800, 180.81.

1 0

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Hib Eris 26 May '09

26 May '09

On Tue, May 26, 2009 at 8:57 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Hib Eris <hib(a)hiberis.nl> writes: > >> I have looked at my new code and it does not seem wrong to me, but >> maybe it is somewhere else. Unfortunately, as I cannot reproduce this >> failure, I have no idea how to debug it. Does this fail for other >> people as well? >> >> Just a wild guess... could it have something to do with 64-bit vs. >> 32-bit? I am running on 32-bit. Alexandre, did you run the test on 32 >> or 64 bit? > > 32-bit of course, nothing works on 64-bit <g> > > It's heap corruption, you forgot to allocate space for the terminating > null in msi_import_stream_filename. And you should probably use strdupW > instead. Ahhh, I see! I will create a new patch. Thanks. A question about using strdupW: In my patch I use msi_alloc and msi_realloc to allocate memory for the returned string and use msi_free to free it again. If I would use stdupW to create a string copy instead of msi_alloc, would it then still be okay to use msi_realloc and msi_free? According to http://source.winehq.org/WineAPI/StrDupW.html I should use LocalFree to free the memory? I've seem some more places where msi_free and StdDupW were mixed, so I guess it will work. But is it considered good practice? Hib

2 1

[PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Hib Eris 26 May '09

26 May '09

Hi all, hmm, I've tested it again with current git, and it still works fine here. I have looked at my new code and it does not seem wrong to me, but maybe it is somewhere else. Unfortunately, as I cannot reproduce this failure, I have no idea how to debug it. Does this fail for other people as well? Just a wild guess... could it have something to do with 64-bit vs. 32-bit? I am running on 32-bit. Alexandre, did you run the test on 32 or 64 bit? So, I can only ask for someone to please also try http://www.winehq.org/pipermail/wine-patches/2009-May/073272.html and see if it works for him/her. Hib On Tue, May 26, 2009 at 3:30 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Hib Eris <hib(a)hiberis.nl> writes: > >> --- >> dlls/msi/database.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++--- >> dlls/msi/msipriv.h | 3 +- >> dlls/msi/record.c | 2 +- >> dlls/msi/tests/db.c | 12 +++++----- >> 4 files changed, 68 insertions(+), 12 deletions(-) > > This doesn't work here: > > ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok > wine: Unhandled page fault on write access to 0x00000004 at address 0x7bc4460e (thread 0019), starting debugger... > Unhandled exception: page fault on write access to 0x00000004 in 32-bit code (0x7bc4460e). > Register dump: > CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b > EIP:7bc4460e ESP:0032f770 EBP:0032f7e8 EFLAGS:00010202( R- -- I - - - ) > EAX:00000000 EBX:7bc94448 ECX:00110014 EDX:00000000 > ESI:0012dcc8 EDI:0012dc48 > Stack dump: > 0x0032f770: 0032f784 00110014 00000020 0012dd00 > 0x0032f780: 0032f794 4d430002 0032f7bc 0012dc58 > 0x0032f790: 0032f7a4 00110014 00000070 4d430003 > 0x0032f7a0: 00000000 4d430003 00000000 00000000 > 0x0032f7b0: 00000000 00000000 00000000 4d430000 > 0x0032f7c0: 0012dc58 00000070 00000000 00000000 > Backtrace: > =>0 0x7bc4460e HEAP_CreateFreeBlock+0x3be(subheap=0x110014, ptr=0x12dc48, size=128) [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll (0x0032f7e8) > 1 0x7bc44847 HEAP_MakeInUseBlockFree+0x57(subheap=0x110014, pArena=<is not available>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:586] in ntdll (0x0032f838) > 2 0x7bc44b3c RtlFreeHeap+0x18c(heap=0x110000, flags=2, ptr=0x12dcc8) [/home/julliard/wine/wine/dlls/ntdll/heap.c:1480] in ntdll (0x0032f898) > 3 0x6081aa8e free_table+0x3e(table=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/msipriv.h:1059] in msi (0x0032f8b8) > 4 0x6081abae free_cached_tables+0x2e(db=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/../../include/wine/list.h:133] in msi (0x0032f8c8) > 5 0x607d3ec2 MSI_CloseDatabase+0x42(arg=0x12b7e8) [/home/julliard/wine/wine/dlls/msi/database.c:66] in msi (0x0032f8e8) > 6 0x607e6b58 msiobj_release+0x48(info=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/handle.c:257] in msi (0x0032f918) > 7 0x607e6ccf MsiCloseHandle+0xbf(handle=<is not available>) [/home/julliard/wine/wine/dlls/msi/handle.c:311] in msi (0x0032f948) > 8 0x6066abda test_binary_import+0x33a() [/home/julliard/wine/wine/dlls/msi/tests/db.c:1991] in msi_test (0x0032fca8) > 9 0x60677d7e func_db+0x264e() [/home/julliard/wine/wine/dlls/msi/tests/db.c:7672] in msi_test (0x0032fde8) > 10 0x60749a80 run_test+0x130(name="db.c") [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:456] in msi_test (0x0032fe28) > 11 0x60749c6f main+0x11f(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:505] in msi_test (0x0032fed8) > 12 0x6074a484 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032ff08) > 13 0x7b878660 start_process+0x130(arg=(nil)) [/home/julliard/wine/wine/dlls/kernel32/process.c:941] in kernel32 (0x0032ffe8) > 14 0x6002bc07 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) > 0x7bc4460e HEAP_CreateFreeBlock+0x3be [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll: movl %eax,0x4(%edx) > 98 elem->next->prev = elem->prev; > > > -- > Alexandre Julliard > julliard(a)winehq.org >

2 2

Re: patch wined3d
by Stefan Dösinger 26 May '09

26 May '09

Am Dienstag, 26. Mai 2009 18:13:49 schrieb Pavel Prochazka: Is there any reason why we'd want 32 backbuffer swapchains? The currentl limit comes from d3d9(no more than 3 backbuffers allowed). We can certainly change it, but I doubt that any Windows driver supports that in ddraw. If there is no limit in ddraw(provide a test), we should remove the limit and make it dynamic.

1 0

Re: patch wined3d
by Henri Verbeet 26 May '09

26 May '09

2009/5/26 Pavel Prochazka <prochapa(a)inf.upol.cz>: > +»······int i=1; > + > +»······/*it moves all backbuffers by 1 to left form id = 1, > +»······the backbuffer swap to frontbuffer and frontbuffer swaps to the end of chain > +»······Something like this: > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······------------^»··»······· > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······|»······»·······»·······| > +»······|FrontBuffer| |BackBuffer0|BackBuffer1|Backbuffer2|....|BackbufferN| > +»······ »····»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······^ > +»······»·······|---------------------------------------------------------------| > +»······»·······^ > +»······»·······|---------------------| > + > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»······· > +»······*/ > + > +»······for(;i<This->presentParms.BackBufferCount-1;i++)· > +»······{ > +»······»·······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······»·······hlp2 = (IWineD3DSurfaceImpl *)This->backBuffer[i+1]; > +»······»·······hlp1->hDC = hlp2->hDC; > +»······»·······hlp1->dib.DIBsection = hlp2->dib.DIBsection; > +»······»·······hlp1->dib.bitmap_data = hlp2->dib.bitmap_data; > +»······»·······hlp1->resource.allocatedMemory = hlp2->resource.allocatedMemory; > +»······»·······hlp1->dib.client_memory = hlp2->dib.client_memory; > +»······} > + > +»······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······hlp1->hDC = front->hDC; > +»······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······hlp1->dib.DIBsection = front->dib.DIBsection; > +»······hlp1->dib.bitmap_data = front->dib.bitmap_data; > +»······hlp1->resource.allocatedMemory = front->resource.allocatedMemory; > +»······hlp1->dib.client_memory = front->dib.client_memory; > +»······ > +··· Style issues aside, that's not a very efficient way to implement a swapchain.

1 0

Re: [1/4] comctl32/listview: Basic LVM_GETVIEWRECT tests
by Paul Vriens 26 May '09

26 May '09

Nikolay Sivov wrote: > Changelog: > - Basic LVM_GETVIEWRECT tests > > + todo_wine expect(104, rect.right); > + expect(0, rect.top); > + expect(73, rect.bottom); The first and last one of these 3 introduces errors on several boxes (see test.winehq.org) I guess these numbers can't be hardcoded and need to be calculated somehow? Could you have a look? -- Cheers, Paul.

2 1

Problem Running Winetricks
by Michael 26 May '09

26 May '09

Hi, When I run winetricks, it consistently loops through and creates output files winetricks.1 , winetricks.2 , etc ... until I break the terminal. And doesn't do much more. Each of these files shows:

2 1

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Alexandre Julliard 26 May '09

26 May '09

Hib Eris <hib(a)hiberis.nl> writes: > --- > dlls/msi/database.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++--- > dlls/msi/msipriv.h | 3 +- > dlls/msi/record.c | 2 +- > dlls/msi/tests/db.c | 12 +++++----- > 4 files changed, 68 insertions(+), 12 deletions(-) This doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok wine: Unhandled page fault on write access to 0x00000004 at address 0x7bc4460e (thread 0019), starting debugger... Unhandled exception: page fault on write access to 0x00000004 in 32-bit code (0x7bc4460e). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7bc4460e ESP:0032f770 EBP:0032f7e8 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:7bc94448 ECX:00110014 EDX:00000000 ESI:0012dcc8 EDI:0012dc48 Stack dump: 0x0032f770: 0032f784 00110014 00000020 0012dd00 0x0032f780: 0032f794 4d430002 0032f7bc 0012dc58 0x0032f790: 0032f7a4 00110014 00000070 4d430003 0x0032f7a0: 00000000 4d430003 00000000 00000000 0x0032f7b0: 00000000 00000000 00000000 4d430000 0x0032f7c0: 0012dc58 00000070 00000000 00000000 Backtrace: =>0 0x7bc4460e HEAP_CreateFreeBlock+0x3be(subheap=0x110014, ptr=0x12dc48, size=128) [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll (0x0032f7e8) 1 0x7bc44847 HEAP_MakeInUseBlockFree+0x57(subheap=0x110014, pArena=<is not available>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:586] in ntdll (0x0032f838) 2 0x7bc44b3c RtlFreeHeap+0x18c(heap=0x110000, flags=2, ptr=0x12dcc8) [/home/julliard/wine/wine/dlls/ntdll/heap.c:1480] in ntdll (0x0032f898) 3 0x6081aa8e free_table+0x3e(table=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/msipriv.h:1059] in msi (0x0032f8b8) 4 0x6081abae free_cached_tables+0x2e(db=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/../../include/wine/list.h:133] in msi (0x0032f8c8) 5 0x607d3ec2 MSI_CloseDatabase+0x42(arg=0x12b7e8) [/home/julliard/wine/wine/dlls/msi/database.c:66] in msi (0x0032f8e8) 6 0x607e6b58 msiobj_release+0x48(info=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/handle.c:257] in msi (0x0032f918) 7 0x607e6ccf MsiCloseHandle+0xbf(handle=<is not available>) [/home/julliard/wine/wine/dlls/msi/handle.c:311] in msi (0x0032f948) 8 0x6066abda test_binary_import+0x33a() [/home/julliard/wine/wine/dlls/msi/tests/db.c:1991] in msi_test (0x0032fca8) 9 0x60677d7e func_db+0x264e() [/home/julliard/wine/wine/dlls/msi/tests/db.c:7672] in msi_test (0x0032fde8) 10 0x60749a80 run_test+0x130(name="db.c") [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:456] in msi_test (0x0032fe28) 11 0x60749c6f main+0x11f(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:505] in msi_test (0x0032fed8) 12 0x6074a484 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032ff08) 13 0x7b878660 start_process+0x130(arg=(nil)) [/home/julliard/wine/wine/dlls/kernel32/process.c:941] in kernel32 (0x0032ffe8) 14 0x6002bc07 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x7bc4460e HEAP_CreateFreeBlock+0x3be [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll: movl %eax,0x4(%edx) 98 elem->next->prev = elem->prev; -- Alexandre Julliard julliard(a)winehq.org

1 0