June 2009 - Wine-devel - list.winehq.org

Re: urlmon: [Patch 1] Implement CreateZoneEnumerator, GetZoneAt, DestroyZoneEnumerator [try 3]
by Jacek Caban 22 Jun '09

22 Jun '09

Hi Detlef, Detlef Riekenberg wrote: > This time, we don't care about dwEnum. > That value is returned from CreateZoneEnumerator and > checked only in GetZoneAt and DestroyZoneEnumerator. > > Windows has only the Zones "0" upto "4" since IE4.0 > and no UI to add or remove a Zone. > Did you test what happens if you add zone registries manually via regedit? Thanks, Jacek

1 0

Appinstall update
by Austin English 22 Jun '09

22 Jun '09

Howdy, James has asked me to send y'all an update on my Summer of Code project, Appinstall. I've got a dozen or so app tests committed already, and several more that I'm putting the final touches on. I just finished a wrapper script to make it easy to test daily, and have begun uploading results to http://www.austinenglish.com/logs/. The logs are a bit verbose, so I've committed a fix to make the sha1sum silent on success, which should cut down the noise a lot. To get a quick look, just check summary.txt daily, which will complain if there are any failing tests or 'TODO_FIXED', the equivalent of todo_wine passing (while testing applications I often find bugs, so I've written the tests to automatically check for those bugs and report if they're fixed). The tests should now be run daily on my machine, searching for regressions and bugs that have been fixed. I've also added a couple example test scripts, to make it easier for those unfamiliar with AutoHotKey to write tests for their favorite applications. (http://winezeug.googlecode.com/svn/trunk/appinstall/examples/) Source is available on winezeug: http://code.google.com/p/winezeug/ http://winezeug.googlecode.com/svn/trunk/appinstall/ -- -Austin

1 0

Re: [PATCH 2/2] mshtml: Fixed tests on IE8 and change Wine behavior to IE8.
by Paul Vriens 22 Jun '09

22 Jun '09

Jacek Caban wrote: > --- > dlls/mshtml/dispex.c | 2 ++ > dlls/mshtml/htmllocation.c | 2 +- > dlls/mshtml/mshtml_private.h | 2 ++ > dlls/mshtml/omnavigator.c | 2 +- > dlls/mshtml/tests/dom.c | 36 ++++++++++++++++++++++++++++++------ > 5 files changed, 36 insertions(+), 8 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Thanks for looking into the IE8 test failures. This piece however doesn't look correct: +static void _test_disp2(unsigned line, IUnknown *unk, const IID *diid, const IID *diid2) +{ + IID iid; + + if(_test_get_dispid(line, unk, &iid)) + ok_(__FILE__,line) (IsEqualGUID(&iid, diid) || broken(IsEqualGUID(&iid, diid)), + "unexpected guid %s\n", dbgstr_guid(&iid)); You are comparing twice against diid. -- Cheers, Paul.

2 1

Wine translation statistics sources
by Mikołaj Zalewski 22 Jun '09

22 Jun '09

Hi, I didn't update the translation statistics (http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my server is a bit broken and I can't run the scripts from cron but have remember to do it manually from a different computer. I have plans to fix it, but in the mean time, as some people may want fresh data, I have finished the changes I've been working on and uploaded the sources. It should be very easy to run them on ones machine and check the tree one has on disk - there is a README with explanations. The archive is available at http://www.mikolaj.zalewski.pl/dl/wine-transl.tgz . It is the latest version that adds support for dumping/diffing dialogs. Mikolaj Zalewski

8 17

Problems with ~/.wine/dosdevices symlinks on samba servers
by Dan Kegel 22 Jun '09

22 Jun '09

According to http://groups.google.com/group/Google-Labs-Picasa-for-Linux/browse_thread/t… a user is having trouble because the symlinks in ~/.wine/dosdevices don't work when on a Samba share. It's unfortunate at this late date to realize that one of the key choices Wine made isn't compatible with the cifs/samba combination... but I guess nobody expected home directories to be served with that network filesystem. If this turns out to be a real problem, what are our options? The first thing that comes to mind is to notice the problem and fall back to underscore instead of colon somehow...

2 3

Re: [PATCH 1/4] jscript: Added implementation of Date constructor with more then one argument
by Alexandre Julliard 22 Jun '09

22 Jun '09

Piotr Caban <piotr.caban(a)gmail.com> writes: > @@ -221,6 +253,62 @@ static inline DOUBLE week_day(DOUBLE time) > return ret; > } > > +static inline DOUBLE convert_time(int year, SYSTEMTIME st) > +{ > + DOUBLE time; > + int set_week_day; > + > + time = time_from_year(year); > + time += (DOUBLE)day_from_month(st.wMonth-1, in_leap_year(time)) * MS_PER_DAY; > + > + set_week_day = st.wDayOfWeek-week_day(time); > + if(set_week_day < 0) > + set_week_day += 7; > + time += set_week_day * MS_PER_DAY; > + > + time += (DOUBLE)(st.wDay-1) * 7 * MS_PER_DAY; > + if(month_from_time(time) != st.wMonth-1) > + time -= 7 * MS_PER_DAY; > + > + time += st.wHour * MS_PER_HOUR; > + time += st.wMinute * MS_PER_MINUTE; > + > + return time; > +} You should use SystemTimeToFileTime or some similar function, no need to reinvent the wheel. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Test patch
by Austin English 22 Jun '09

22 Jun '09

On Sat, Jun 20, 2009 at 9:37 PM, Joshua Reisenauer<kd7tck(a)gmail.com> wrote: > I am sending this test patch to see if I used the correct formatting. I > would like feedback on what the wine dev community likes and doesn't like in > patches. For example do you prefer .txt or .patch? .txt please, much easier to read in browser. Please avoid tabs. Many of the changes you made aren't needed, aren't appropriate. E.g., 'etc.' is right, 'etc...' is not (unless that's a British thing I don't know about). Some of the places you capitalized aren't needed. The 'patch file' listed in the README should be deleted, since it's no longer provided. -- -Austin

2 1

Re: Pavel Procházka's commit
by Stefan Dösinger 22 Jun '09

22 Jun '09

Hi, Please send one patch per email. If you have 3 patches, like in this case, please send 3 emails All the patches have trailing whitespaces in some places, and mix tabs and 4-space indentation. Please avoid trailing whitespaces and use 4 spaces for indentation everywhere. In the test: Please define BACKBUFFERCOUNT somewhere close or in TestMultibuffering I recommend to perform one flip, then check the colors, perform another flip and check again. Flipping an arbitrary amount of times and then checking the colors once makes it hard to see what is going on. The 15 flips may also by chance sum up to a no-op or lead to a wrong conclusion. > + if(!StartMultibuffering()) > + { > + skip("An error when initializing multibuffering!, skipping . . . \n"); > + return; > + } I recommend not to skip the D3D tests if the multibuffering test fails to initialize for some reason(ie, remove the return) > +LPDIRECTDRAW lpDD = NULL; The rest of the test uses IDirectDraw *DD instead of LPDIRECTDRAW for COM interfaces The infinite amount of back buffers patch: We currently don't have a test for this, but msdn says that d3d8 and d3d9 have this limit on the amount of backbuffers. If you remove it from wined3d, please add the verification to d3d8.dll and d3d9.dll to make sure they still enforce this limit. Or write a d3d9 test to prove msdn wrong. There is already a test for swapchains in dlls/d3d9/tests/device.c, test_swapchain(). It should be fairly easy to test a too high backbuffer count there. The third patch(_Present relevant to windows implementation Making multibuffering working well when flip): > back = *((IWineD3DSurfaceImpl *)This->backBuffer[0]); /*this value can not be pointer*/ I don't like this, this copies too much data. Please just backup the fields you need > { >- HDC tmp; > - tmp = front->hDC; > - front->hDC = back->hDC; > - back->hDC = tmp; > + front->hDC = back.hDC; > } This will leave this code: { front->hDC = back.hDC; } Since you're not declaring any local variable any longer, please remove the {}

1 0

W-related helper functions for our tests
by Paul Vriens 22 Jun '09

22 Jun '09

Hi, I was wondering if it would make sense to introduce several helper functions that could be used by all our tests. The main ones needed are the ones to cope with Win9x missing several W-functions. Another one used quite often in the tests is something like wine_dbgstr_w. Yet another one compares a W with an A-string. Ideas, remarks, suggestions? -- Cheers, Paul.

4 5

Re: msi: add dummy thread just to initialize an MTA; fixes bug 18070
by Hans Leidekker 21 Jun '09

21 Jun '09

Hi Dan, > +/* Dummy thread just to initialize an MTA for the benefit of custom action DLLs */ > +static HANDLE dummy_thread_event = NULL; > +static HANDLE dummy_thread_handle = NULL; > + > +DWORD WINAPI dummy_thread_proc(void *arg) It appears that calling CreateThread in DLL_PROCESS_ATTACH can cause deadlocks: http://blogs.msdn.com/mgrier/archive/2005/06/21/431378.aspx It might work if you move it to somewhere near ACTION_CallDllFunction, and wait for the thread to start up, but this remains a hack of course. Another blog explains that inheritance of an existing MTA is just a side effect of starting the custom action in a different process, one that happens to have initialized an MTA already. -Hans

2 2