June 2009 - Wine-devel - list.winehq.org

disabled mail on bouncing bugzilla accounts
by Jan Zerebecki 21 Jun '09

21 Jun '09

Thanks to Jeff Zaroyko, who went through the bounce mail, I just disabled sending bug mail to a few bugzilla accounts. Anyone who is affected by this and has fixed his mail reception can ask an bugzilla admin to enable it again (e.g. by mailing me directly). Jan

1 0

Re: msi: add dummy thread just to initialize an MTA; fixes bug 18070
by Austin English 21 Jun '09

21 Jun '09

On Sat, Jun 20, 2009 at 11:23 PM, Dan Kegel<dank(a)kegel.com> wrote: > This gets Photoshop CS4 installer to start up. > Per the suggestion in > http://bugs.winehq.org/show_bug.cgi?id=18070#c6 > > I am not worthy... +DWORD WINAPI dummy_thread_proc(void *arg) +{ + DWORD dwWaitResult; + + CoInitializeEx(0, COINIT_MULTITHREADED); + + // Just wait forever for DLL to be unloaded. Dan, you of all people should know, no C++ ;-). -- -Austin

1 0

Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
by Henri Verbeet 21 Jun '09

21 Jun '09

2009/6/20 Gerald Pfeifer <gerald(a)pfeifer.com>: > This makes it more clear that ! applies to the overall condition, > not just to the first part which is then and-ed. > I happened to have the same patch. Note that this does fix a real bug, ! has higher precedence than &.

1 0

Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
by Kai Blin 20 Jun '09

20 Jun '09

On Saturday 20 June 2009 17:17:53 Gerald Pfeifer wrote: Hi Gerald, not really about this patch in specific, but would you mind sticking to the established practice of prefixing your patches with the area of wine you're affecting? That makes it easier to skim the wine-patches list for the dlls I know and care about. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: Fix error checking in dlls/ddraw/executebuffer.c
by Paul Vriens 20 Jun '09

20 Jun '09

Gerald Pfeifer wrote: > I believe, after looking at the ranges of D3DLIGHTSTATETYPE, that > the below is the actual intention of this code (to ensure we are > in range). > > Gerald > > ChangeLog: > Fix error checking in IDirect3DExecuteBufferImpl_Execute(). > > diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c > index 73e0657..6d6d304 100644 > --- a/dlls/ddraw/executebuffer.c > +++ b/dlls/ddraw/executebuffer.c > @@ -249,7 +249,7 @@ IDirect3DExecuteBufferImpl_Execute(IDirect3DExecuteBufferImpl *This, > > TRACE("(%08x,%08x)\n", ci->u1.dlstLightStateType, ci->u2.dwArg[0]); > > - if (!ci->u1.dlstLightStateType && (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) > + if (!ci->u1.dlstLightStateType || (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) > ERR("Unexpected Light State Type\n"); Would: if ((ci->u1.dlstLightStateType < D3DLIGHTSTATE_MATERIAL) || (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) be easier to read? (Matter of taste I guess). -- Cheers, Paul.

2 1

Re: Simplify code in dlls/imm32/tests/imm32.c
by Paul Vriens 20 Jun '09

20 Jun '09

Gerald Pfeifer wrote: > Not sure how to else handle this; possibly remove this whole subtest? > > Gerald > > ChangeLog: > Simplify code in dlls/imm32/tests/imm32.c (and avoid false warning). > > diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c > index 1951242..3e35ac1 100644 > --- a/dlls/imm32/tests/imm32.c > +++ b/dlls/imm32/tests/imm32.c > @@ -210,7 +210,7 @@ static void test_ImmNotifyIME(void) { > > /* behavior differs between win9x and NT */ > ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr)); > - ok(ret || !ret, "You'll never read this.\n"); > + ok(TRUE, "You'll never read this.\n"); > We could use broken() to make sure we follow the wanted behaviour for Wine. From the patch that changed that item it should be: ok(!ret || broken(ret), .....) If you look however at test.winehq.org it looks like hardly any box meets the proper requirements to run these tests at all. So I'd say: ok(!ret, "After being cancelled the composition string is empty.\n"); (Tested on my W2K3 and Vista boxes). -- Cheers, Paul.

1 0

Simplify code in dlls/imm32/tests/imm32.c
by Joris Huizer 20 Jun '09

20 Jun '09

Hello Gerald Pfeifer, You did, /* behavior differs between win9x and NT */ ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr)); - ok(ret || !ret, "You'll never read this.\n"); + ok(TRUE, "You'll never read this.\n"); Wouldn't it be better to do something like: ok(ret || broken(!ret), "You'll never read this.\n"); or marking the other case broken()? Note that broken() should be interpreted as, "unwanted functionality for Wine" HTH, Joris

1 0

Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.
by Steven Edwards 20 Jun '09

20 Jun '09

On Fri, Jun 19, 2009 at 9:27 AM, Alexandre Julliard<julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: ccbf959969e32c9d71d2b4c46dbfe4db1ad2ab3f > URL: http://source.winehq.org/git/wine.git/?a=commit;h=ccbf959969e32c9d71d2b4c46… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Jun 18 21:35:51 2009 +0200 > > configure: Don't accept mingw32 as target name, we need an explicit CPU specification. I don't think this change is right. It is a very common convention to use mingw32 as a generic convention for 32bit x86. It seems the best practice would be if mingw32 is passed then to assume a sensible lowest common default. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

4 5

Re: winex11: Get rid of glext.h in remaining locations [try 2]
by James Mckenzie 19 Jun '09

19 Jun '09

Austin English <austinenglish(a)gmail.com> wrote about Re: winex11: Get rid of glext.h in remaining locations [try 2] > >On Fri, Jun 19, 2009 at 9:02 AM, Detlef Riekenberg<wine.dev(a)web.de> wrote: >> Already removed from dlls/opengl/* by Roderick. >> winex11 on linux works without GL/glext.h (OSX untested) >> >> Now with configure.ac > >Works fine on OS X. Sorry I forgot to do this myself. > Thank you. I have not set up my build system, yet. James McKenzie

1 0

Re: winex11: Get rid of glext.h in remaining locations [try 2]
by Austin English 19 Jun '09

19 Jun '09

On Fri, Jun 19, 2009 at 9:02 AM, Detlef Riekenberg<wine.dev(a)web.de> wrote: > Already removed from dlls/opengl/* by Roderick. > winex11 on linux works without GL/glext.h (OSX untested) > > Now with configure.ac Works fine on OS X. Sorry I forgot to do this myself. -- -Austin

1 0