June 2009 - Wine-devel - list.winehq.org

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures
by Henri Verbeet 16 Jun '09

16 Jun '09

2009/6/14 Stefan Dösinger <stefan(a)codeweavers.com>: > +static void surface_allocate_surface(IWineD3DSurfaceImpl *This, GLenum internal, GLsizei width, GLsizei height, GLenum format, GLenum type, > + DWORD client_store_flag) { I think that's ugly. More importantly, I don't see how client storage can be enabled for one texture but not the other.

2 5

Re: [2/4] [wined3d] add ps_np2fixup_info_t structure
by Stefan Dösinger 16 Jun '09

16 Jun '09

Am Montag, 15. Juni 2009 20:23:05 schrieb Tobias Jakobi: >+ * This structure is shared between the GLSL and the ARB backend.*/ > +typedef struct ps_np2fixup_info_s { > + WORD idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ > + WORD active; /* bitfield indicating if we can apply the fixup */ > + WORD num_consts; > +} ps_np2fixup_info_t; Please don't use a typedef, just use "struct ps_np2_fixup_info" in the code. We stopped using these typedefs a while ago and are removing them as we go. Other than that, the backend specific compiled shader structs and per-shader private data make it easier to use backend specific structures which use the correct data types. I'm not sure if I remember correctly, but I think the WORD was not entirely correct for ARB, it would rather use a GLuint there(and GLSL is happy with a smaller unsigned char)

1 0

Re: wined3d: Reserve two varyings for ATI DX10 cards
by Henri Verbeet 15 Jun '09

15 Jun '09

2009/6/15 Robert Key <hpestilence(a)gmail.com>: > Changelog: > * This reserves 2 varyings for gl_FrontColor and gl_FrontSecondaryColor > for ATI DX10 cards. This should fix bug #17437 once the new fglrx > drivers get released this week. > That doesn't look quite right. gl_FrontColor and gl_FrontSecondaryColor should only be used as a fallback when we're already out of regular varyings to use. What does the shader that triggers this look like?

2 3

Trouble cloning git via http
by Juan Lang 15 Jun '09

15 Jun '09

Anyone else cloning git via http? I'm behind an annoying proxy server, and when I try to clone, I get: error: Unable to find afce86b4bc6198575bbe6046d12fd77efe01cd46 under http://source.winehq.org/git/wine.git Cannot obtain needed object afce86b4bc6198575bbe6046d12fd77efe01cd46 Just curious if anyone else has seen this or knows what I could try. Thanks, --Juan

2 2

Wine Direct Input Issue
by MD.IMAM HOSSAIN 15 Jun '09

15 Jun '09

Dear Wine Developers, The latest WINE 1.1.23 has a small regression about Direct Input. The game HITMAN 3 CONTRACTS has a problem with mouse clicking. By WINE 1.1.23 and HITMAN 3 CONTRACTS mouse clicking does not work. It is worked fine with wine 1.1.11. Since the game is a third person shooter it is not playable anymore. One final thing, latest WINE has broadened Linux Gaming Field. It now supports many old games then before which did not run before. I have tested these games: 1. Knight Rider 2 [ fully working ]. 2. Turok 2 [ fully working ]. 3. Need For Speed 4 [ fully working ]. 4. Driver [ fully working ]. 5. London Racer 2 [ fully working ]. 6. Midtown Madness 2 [ fully working ]. Thank you very much for great work. Your sincerely, MD. IMAM HOSSAIN

2 1

re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Dan Kegel 15 Jun '09

15 Jun '09

Brent wrote: >This was causing some apps to crash with invalid read from address 0x4. Which apps? Is there a bug report for this? - Dan

2 1

Duplicates page: Permission denied
by Ken Sharp 15 Jun '09

15 Jun '09

Since the upgrade of Bugzilla, the duplicates page reports permission denied. http://bugs.winehq.org/duplicates.cgi Can anyone with the relevant access check the permissions? This is http://bugs.winehq.org/show_bug.cgi?id=18665

2 1

Re: winapi: Fix a $blevel / $plevel mismatch.
by Francois Gouget 15 Jun '09

15 Jun '09

Ignore this one, I patched the wrong place. On Mon, 15 Jun 2009, Francois Gouget wrote: [...] > } elsif(s/^\}//) { > $blevel--; > - if($blevel <= 0) { > + if($plevel <= 0) { > $self->_parse_c_error($_, $line, $column, "file", "} without {"); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

1 0

Re: [1/5] WineD3D: Unroll loops in ARB if needed (try 2)
by Henri Verbeet 15 Jun '09

15 Jun '09

2009/6/14 Stefan Dösinger <stefan(a)codeweavers.com>: > A few fixes from the first version: > > *) Copypaste index issues fixed > *) aL is incremeted at the end of the loop, not at the beginning > *) emulated c[aL + offset] indexing works > > The loop codepath is now tested as well, not just the rep stuff - I have a > test for aL constant indexing, its deeper down in my send queue > Since I replied to the original version of this patch... Why does get_int_const() (still) return a pointer to a static int array?

1 0

Request for comments on patch
by Erich Hoover 15 Jun '09

15 Jun '09

In an effort to come up with a (hopefully palatable) solution to a couple of bugs I've put together the attached patch. Only the first of the two issues is currently handled, though the patch paves the way for the second issue. 1) Bug #15839: (not this title) Wine does not report the manufacturer driver (for example, "nv4_disp.dll" for nVidia users) 2) Wine does not always report the correct amount of video RAM (not sure if there is a bug number for this) The approach handles graphics requests like this: "manufacturer" driver --> "OS" driver (normally winex11.drv) Where the manufacturer driver (at present) forwards all requests to the OS driver. Later additions could provide driver-specific code for returning information such as the correct amount of video RAM. Also, the manufacturer driver is skipped (reverting to the current behavior) unless "HKEY_CURRENT_USER\Software\Wine\Drivers\ReportNativeVideoDriver" is set to "Y". Note: patch makes changes to configure.ac, so cover your bases: autoheader && autoconf && ./configure && make depend && make I'm particularly interested in comments related to how the driver is selected (__wine_get_video_driver in gdi32), but all feedback is welcome. Erich Hoover ehoover(a)mines.edu

5 16