June 2009 - Wine-devel - list.winehq.org

Unused code in dmime.dll
by Francois Gouget 14 Jun '09

14 Jun '09

So DMUSIC_CreateDirectMusicobjImpl() is unused. What's troubling about that is that, if my analysis is correct, it means that none of the code in dlls/dmime/tool.c is used. It seems like all that's missing is something that would let applications actually get at the IDirectMusicTool8 implementation. Could someone familiar with DCOM and/or dmime look into it? It would be a shame to strip all that unused code :-( -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

1 0

Command for creating git patches - possible discrepancy in Wine doc pages
by Frédéric Delanoy 14 Jun '09

14 Jun '09

Hi, I'm about to generate my first wine patches and saw 2 pages in the Wine wiki giving two different commands : - on http://wiki.winehq.org/GitWine , section 3.6. Generating a patchset to submit, it says git format-patch --stdout --keep-subject origin - on http://www.winehq.org/site/sending_patches - Generating a patch for WineHQ with Git, it says git format-patch --stdout --keep-subject --attach origin (note the additional "--attach"). Being a fresh (couple of days) git user, I just wonder : which command should I use? Frédéric Delanoy

2 1

dotests script
by chris ahrendt 14 Jun '09

14 Jun '09

Does anyone have the dotests script they could send me ... I moved to a new machine and lost the script. Went to the wiki and it fails to find it when I click on the link. I get an error stating that I am unable to add an attachment (even after logging in). Chris

3 3

Re: [PATCH] wined3d: mirror d3dresourcetype
by Stefan Dösinger 14 Jun '09

14 Jun '09

Am Sonntag, 14. Juni 2009 14:26:53 schrieb Marcus Meissner: > Hi, > > gcc 4.5trunk warned that we do not handle case 7 (D3DRTYPE_INDEXBUFFER), > so add it here too. There's a reason why this doesn't exist - WineD3D has index and vertex buffers merged, so there is no such thing as a specialized index buffer. Where does this warning occur? The code that maps D3DRTYPE to WINED3DRTYPE or vice versa should be fixed to map INDEXBUFFER to BUFFER, and take care for the reverse conversion

4 5

Re: [5/5] WineD3D: Use flags instead of bools to control shader_hw_sample
by Stefan Dösinger 14 Jun '09

14 Jun '09

Am Sonntag, 14. Juni 2009 18:34:13 schrieb Tobias Jakobi: > Why not use an enum instead of the defines? Because as far as I can see the other places that deal with flags use defines to define them, not an enum type. Specifically, I looked at the WINED3D_GLSL_SAMPLE_* flags, which have the equivalent job in glsl_shader.c Besides that, using an enum for OR-able flags seems not quite right to me. If you have something like enum flags { flag1 = 1; flag2 = 2; flag3 = 4; } "flag1 | flag3" gives a value(=5) that does not exist in the enum.

1 0

winetest data generation
by André Hentschel 14 Jun '09

14 Jun '09

I need to have a look into the sourcecode of the scripts behind "test.winehq.org". Where can i find it?

2 1

user32: Test request (cursoricon)
by Daniel Santos 13 Jun '09

13 Jun '09

I've tested this on XP, but I would like to get somebody to test on 9x and maybe even vista please and thank you. These tests are the prelude to cursoricon patches including Griswold's animated cursors & themed cursors and my fixes for LOTRO (mostly handling invalid calls properly). Thanks, Daniel

2 1

Insane git output
by Dan Kegel 13 Jun '09

13 Jun '09

I did a git pull today, and saw this: copy programs/clock/rsrc.rc => dlls/d3dx9_36/tests/resources.h (57%) copy {programs/clock => dlls/d3dx9_36/tests}/rsrc.rc (57%) create mode 100644 dlls/d3dx9_36/tests/texture.c create mode 100644 dlls/d3dx9_36/util.c create mode 100644 dlls/msctf/compartmentmgr.c create mode 100644 dlls/oleacc/oleacc_De.rc create mode 100644 dlls/windowscodecs/Makefile.in rename programs/clock/rsrc.rc => dlls/windowscodecs/main.c (57%) Wha? Those are some crazy renames/copies...

2 1

Posting deletions on AppDB
by Vitaliy Margolen 13 Jun '09

13 Jun '09

I'm having a problem with these posts delition by Ken Sharp. I do not see anything wrong there. 'wine start file.msi' is _the_ correct way to "run" msi files (that's what happenes when you double click). Even if there was something wrong, removing post is a bad thing to do. Please just explain in replay why it's wrong. Or just ignore it. Vitaliy. Subject: [AppDB] Comment for Steam All Versions deleted From: AppDB <appdb-noreply(a)winehq.org> Date: Sat, 13 Jun 2009 09:41:07 -0500 To: appdb-noreply(a)winehq.org Comment for Steam All Versions deleted ------------------------------------------------------- http://appdb.winehq.org/objectManager.php?sClass=version&iId=1554 This comment was made on 2009-06-13 by Felix Zielcke Subject: can't install Steam With current git HEAD (45629dc050f46988c23ded35ad18bbd8c63e4e65) I can't install steam: $ wine start SteamInstall.msi fixme:ntoskrnl:KeInitializeSpinLock stub: 0x657d74 fixme:exec:SHELL_execute flags ignored: 0x00000100 fz(a)fz:/win2/downloads/spiele$ fixme:msi:MSI_OpenDatabaseW open failed r = 80030050 for L"C:\\windows\\temp\\msi339.tmp" ~/.wine/drive_c/windows/temp/ does exist. The action was performed by Ken Sharp Reasons given Learn how to use Wine! wine msiexec /i blah.msi Best regards. The AppDB team http://appdb.winehq.org/ If you don't want to receive any other e-mail, please change your preferences: http://appdb.winehq.org/preferences.php Subject: [AppDB] Comment for Steam All Versions deleted From: AppDB <appdb-noreply(a)winehq.org> Date: Sat, 13 Jun 2009 11:17:37 -0500 To: appdb-noreply(a)winehq.org Comment for Steam All Versions deleted ------------------------------------------------------- http://appdb.winehq.org/objectManager.php?sClass=version&iId=1554 This comment was made on 2009-06-13 by Felix Zielcke Subject: The action was performed by Ken Sharp Reasons given Learn how to use Wine! wine msiexec /i blah.msi I suggest you learn how to read >From THIS page: HOWTO: Installing and Running Steam 3. # Download Steam installer from http://www.steampowered.com and run it with wine start SteamInstall.msi and even your wine msiexec /i didn't work: $ wine msiexec /i SteamInstall.msi fixme:msi:MSI_OpenDatabaseW open failed r = 80030050 for L"C:\\windows\\temp\\msi120.tmp" The action was performed by Ken Sharp Reasons given Don't bother posting nonsense. Best regards. The AppDB team http://appdb.winehq.org/ If you don't want to receive any other e-mail, please change your preferences: http://appdb.winehq.org/preferences.php

2 4

CreateFileA with /dev/random as WinNT filename
by Karl Vogel 13 Jun '09

13 Jun '09

In ran into a problem with a game, Dark Age of Camelot, where it locked up after logging into the game. After some tracing it became apparent that the game was trying to read bytes from /dev/random, but due to me working remotely on the computer, not enough entropy was generated which stalled the game. I was just wondering if it would be acceptable to specifically check for /dev/random in wine_nt_to_unix_file_name() and turn that into /dev/urandom ?! Small snippet of the login.dll executable code: .text:0042C150 sub_42C150 proc near ; CODE XREF: sub_4267E0+5B0C p .text:0042C150 .text:0042C150 arg_0 = dword ptr 8 .text:0042C150 arg_4 = dword ptr 0Ch .text:0042C150 .text:0042C150 push esi .text:0042C151 push offset aRb ; "rb" .text:0042C156 push offset aDevRandom ; "/dev/random" .text:0042C15B call _fopen .text:0042C160 mov esi, eax .text:0042C162 add esp, 8 .text:0042C165 test esi, esi .text:0042C167 jz short loc_42C185 .text:0042C169 push 0 ; size_t .text:0042C16B push 4 ; int .text:0042C16D push 0 ; char * .text:0042C16F push esi ; FILE * .text:0042C170 call _setvbuf .text:0042C175 add esp, 10h .text:0042C178 test eax, eax .text:0042C17A jz short loc_42C189 .text:0042C17C push esi ; FILE * .text:0042C17D call _fclose .text:0042C182 add esp, 4 .text:0042C185 .text:0042C185 loc_42C185: ; CODE XREF: sub_42C150+17 j .text:0042C185 xor eax, eax .text:0042C187 pop esi .text:0042C188 retn

2 2