June 2009 - Wine-devel - list.winehq.org

Re: wldap32: fix a compiler warning on Mac OS X
by Stefan Leichter 10 Jun '09

10 Jun '09

Am Tuesday 09 June 2009 23:46:51 schrieb Austin English: > Cast was removed by d576c2d9342e769c01fb99c0cc200a0bc4b9cded, but > causes a compiler warning on OS X. The same cast is used ~20 lines > later. You forgot the patch -- Stefan

3 2

Re: windowscodecs: add stub implementation of IWICImagingFactory
by Vincent Povirk 10 Jun '09

10 Jun '09

This is wrong. Don't commit it. Vincent Povirk On Wed, Jun 10, 2009 at 3:08 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > > > >

1 0

Re: [4/4] ddraw: Add lock/unlock test.
by Stefan Dösinger 10 Jun '09

10 Jun '09

Am 10.06.2009 um 11:06 schrieb Rico Schüller: > > +/* See comment in dlls/d3d9/tests/visual.c for general guidelines */ I guess this was copied from dlls/ddraw/tests/visual.c, but doesn't make sense for tests that don't read back rendering results. Otherwise the patches look ok to me.

2 1

dlls/winedos/int10.c
by Gerald Pfeifer 10 Jun '09

10 Jun '09

In dlls/winedos/int10.c we currently have the following code VGA_SetBright((BL_reg(context) & 0x10) && 1); which I am not sure I understand. Is the purpose of this to only pass one of 0 or 1 to VGA_SetBright? If so, I guess I'd find "... ? 1 : 0" more intuitive, and it's only three characters more, or "!= 0" at least. Thoughts? Gerald

1 0

Default Bugzilla search does not show resolved bugs
by Ken Sharp 10 Jun '09

10 Jun '09

From http://bugs.winehq.org/show_bug.cgi?id=18790 "The default search (the search box at the top of this page) does not include closed bugs (rightly so), but it also does not include resolved bugs. This leads to duplicates that could be avoided." "This is for admin to configure in Administration->Parameters->Query Defaults->defaultquery. Add to the front of it: bug_status=RESOLVED&" Anyone with admin access that can make this change? Thanks, Ken.

3 2

Add stable Wine versions back to the AppDB
by Ken Sharp 10 Jun '09

10 Jun '09

See http://bugs.winehq.org/show_bug.cgi?id=15419 The AppDB is currently set up to query Bugzilla for its six latest Wine versions. Unfortunately this does not include the latest stable version of Wine (currently 1.0.1, and in the future 1.2 will also be omitted). A change to how the AppDB works is needed to add 1.0.1 back to the list. As 1.0.1 is listed as "stable", it would make sense that distros (Ubuntu for example) will provide support for this version only. As discussed in the bug, not having this version in the AppDB does not stop users from submitting test results anyway using any version they feel like selecting, and therefore reporting, often incorrectly (due to regressions), that apps run fine on later versions of Wine. As also discussed, if an Admin catches such test results in the queue before they are accepted, they can be rejected, but maintainers can submit whatever results they wish without admin approval. Test results are rejected daily, so this is a problem. Attached is a patch that hopefully looks something like what needs to be added to the AppDB code. This was made by me, who has never used PHP before and have given myself about an hour's "training" to figure it out. It is probably wrong. Could anybody offer some help with this issue? Thanks, Ken.

2 2

Re: (resend, 2nd) kernel32: Implement QueryFullProcessImageNameA (3rd try)
by Alexandre Julliard 10 Jun '09

10 Jun '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > Am Thursday 04 June 2009 12:49:58 schrieb Alexandre Julliard: >> >> I'd expect that error to be a side effect of WideCharToMultiByte, which >> is most likely what you want to use here. Also you have to handle buffer >> overflows correctly, with test cases. > > If you like to see more test cases for the buffer overflow, please tell me > what you like to see tested The test isn't very convincing. For instance to show that the size is not modified you should set it to something that's clearly different, not to the same length you got in the previous call. Also you should check that the length matches the contents of the buffer, with/without terminating null as the case may be. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: fix a compiler warning on Mac OS X
by Roderick Colenbrander 10 Jun '09

10 Jun '09

Actually I need to fix opengl32 properly. For some reason opengl32 is opengl 1.2 while it should be 1.1. Then GL_GLEXT_PROTOTYPES is not needed at all for compiling opengl32. Roderick On Wed, Jun 10, 2009 at 12:18 AM, Austin English<austinenglish(a)bordeauxgroup.com> wrote: > GL_GLEXT_PROTOTYPES is defined in GL/gl.h on Mac. Other #ifdef methods > end up breaking compilations elsewhere. > > -- > -Austin > > > >

2 2

Re: user32/tests: Add more intensive tests for SetCursor.
by Austin English 09 Jun '09

09 Jun '09

On Tue, Jun 9, 2009 at 5:13 PM, Daniel Santos<javatroubadour(a)yahoo.com> wrote: > > Hello! This is a prelude to other cursor patches to follow (both Griswold's & my work). As requested, I have replaced the __FILE_SPOT with the standard ok_(file,line) mechanism (looks much better to me). I've removed the windows version checking from tests and last error checking on success, although I have reservations about it (mostly the later). Forgot patch. -- -Austin

1 0

Re: gdiplus: Add stubs for GdipGetVisibleClipBoundsI, GdipDrawDriverString & GdipMeasureDriverString
by Nikolay Sivov 09 Jun '09

09 Jun '09

Ken Sharp wrote: > These stubs stop three crashes in Photoshop CS4. > >From 4e5dd892a7a577001072fd7701467c262c483b1f Mon Sep 17 00:00:00 2001 > From: Ken Sharp <kennybobs(a)o2.co.uk> > Date: Tue, 9 Jun 2009 21:48:05 +0100 > Subject: [PATCH] gdiplus: Add stubs for GdipGetVisibleClipBoundsI, GdipDrawDriverString & GdipMeasureDriverString > > This fixes three crashes in Photoshop CS4. > --- > dlls/gdiplus/gdiplus.spec | 6 +++--- > dlls/gdiplus/graphics.c | 35 ++++++++++++++++++++++++++++++++++- > 2 files changed, 37 insertions(+), 4 deletions(-) > +GpStatus WINGDIPAPI GdipMeasureDriverString(GpGraphics *graphics, GDIPCONST UINT16 *text, INT length, > + GDIPCONST GpFont *font, GDIPCONST PointF *positions, > + INT flags, GDIPCONST GpMatrix *matrix, RectF *boundingBox) > +{ > + FIXME("(%p %p %d %p %p %d %p %p): stub\n", graphics, text, length, font, positions, flags, matrix, boundingBox); > + return FALSE; > +} > + You should return NotImplemented.

1 0