June 2009 - Wine-devel - list.winehq.org

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

On 06/05/2009 09:16 PM, Austin English wrote: > On Fri, Jun 5, 2009 at 8:03 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> On 06/05/2009 08:15 PM, Austin English wrote: >> >>> On Fri, Jun 5, 2009 at 7:11 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: >>> >>> >>>> Tried it several times.. and different iterations of the registry keys >>>> (you will find them attached) and both cases it fails the same way any >>>> of the d3d tests will fail or the machine locks up. >>>> >>>> >>> >> ???????? >> > Use that attached .reg file. > > > Which one I attached two and neither of them worked at all.. Chris

1 0

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

Tried it several times.. and different iterations of the registry keys (you will find them attached) and both cases it fails the same way any of the d3d tests will fail or the machine locks up.

2 1

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

On 06/05/2009 05:10 PM, Roderick Colenbrander wrote: > Check the useful registry keys page at wiki.winehq.org (it is > Direct3D/OffscreenRenderingMethod) > > Roderick > > On Fri, Jun 5, 2009 at 10:41 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> On 06/05/2009 04:32 PM, Roderick Colenbrander wrote: >> >>> As of Wine 1.1.23 wined3d made FBOs the default offscreen rendering >>> method. If you are using a non-nvidia card (those in general have >>> buggier drivers) that could explain all the failures. Setting >>> OffscreenRenderingMethod to backbuffer restores the old behavior. >>> >>> Roderick >>> >>> On Fri, Jun 5, 2009 at 10:04 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: >>> >>> >>>> Something majorly changed and is wrong with the latest GIT tree. >>>> Between the comits yesterday and today 90% of the tests get exceptions >>>> or fail. >>>> All of the d3d tests get a process exception and fail with a dialog box. >>>> >>>> >>>> Ideas? >>>> >>>> Chris >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >> where do I set that? >> >> >> >> >> >> >> >> >> > > Added the registry key and no go... still failure... Chris

1 0

Re: Alexandre Julliard : winegcc: Create a stub main to work around the lack of Unicode support in Mingw.
by Steven Edwards 05 Jun '09

05 Jun '09

On Fri, Jun 5, 2009 at 9:56 AM, Alexandre Julliard<julliard(a)winehq.org> wrote: > winegcc: Create a stub main to work around the lack of Unicode support in Mingw. Thank you. The mingw developers policy opposing adding this entry point baffles me. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

On 06/05/2009 04:32 PM, Roderick Colenbrander wrote: > As of Wine 1.1.23 wined3d made FBOs the default offscreen rendering > method. If you are using a non-nvidia card (those in general have > buggier drivers) that could explain all the failures. Setting > OffscreenRenderingMethod to backbuffer restores the old behavior. > > Roderick > > On Fri, Jun 5, 2009 at 10:04 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> Something majorly changed and is wrong with the latest GIT tree. >> Between the comits yesterday and today 90% of the tests get exceptions >> or fail. >> All of the d3d tests get a process exception and fail with a dialog box. >> >> >> Ideas? >> >> Chris >> >> >> >> >> >> >> >> >> >> >> > > where do I set that?

2 1

Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

Something majorly changed and is wrong with the latest GIT tree. Between the comits yesterday and today 90% of the tests get exceptions or fail. All of the d3d tests get a process exception and fail with a dialog box. Ideas? Chris

2 1

Regression in "ntdll: Free old memory"
by Niklas Hambüchen 05 Jun '09

05 Jun '09

There is something wrong with commit 13a33b73c349530b17347d3ec6a1f5bb268cc917 (ntdll: Free old memory block when reallocating to a large block.). Having this this patch applied (as it is in wine-1.1.22), some applications show a strange behavior, for example Guild Wars does not start up (it keeps "repairing" on and on). git revert 13a33b73c349530b17347d3ec6a1f5bb268cc917 does the trick, but most probably this is not the solution. The regression test was: 13a33b73c349530b17347d3ec6a1f5bb268cc917 is first bad commit commit 13a33b73c349530b17347d3ec6a1f5bb268cc917 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat May 16 11:33:06 2009 +0200 ntdll: Free old memory block when reallocating to a large block. :040000 040000 e210ab3f16dee6da3a6b6b34d375737b103d5951 25abcf5a437d9a494593e654553dd2797066f616 M dlls Thank you!

2 2

Re: mpr: Added an implementation of test cases
by Stefan Leichter 05 Jun '09

05 Jun '09

Am Friday 05 June 2009 17:27:32 schrieb Vitaly Perov: You need to check if GetProcAddress succeeded. If GetProcAddress failed call win_skip and don't try to execute WNetGetUniversalNameW -- Stefan

2 1

Re: [08/10] wined3d: Use FBOs for offscreen rendering by default.
by paulo lesgaz 05 Jun '09

05 Jun '09

The point is that the tests are uncorrect: Here is I obtain in a real windows Vista box: http://test.winehq.org/data/8d0cb61bc7760c4ab254c3a5bb751bded3a6f4ed/vista_… visual.c:183: Driver string: "nvd3dum.dll" visual.c:184: Description string: "NVIDIA GeForce Go 7600" visual.c:185: Device name string: "\\.\DISPLAY1" visual.c:186: Driver version 7.15.11.7692 visual.c:8868: Tests skipped: D3DFMT_R16F textures not supported visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:9690: Test failed: Input 0xff000000: Got color 0x00008700 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x004bff1c for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00b30000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xff0000ff: Got color 0x000030e1 for pixel 2/1, expected 0x004bffff, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x00ffff00: Got color 0x00ffd01c for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x0000ffff: Got color 0x004bffff for pixel 2/1, expected 0x000030e1, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xffff00ff: Got color 0x00b300e1 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2 So, something is wrong in wined3d implementation. David --- En date de : Ven 5.6.09, Alexandre Julliard <julliard(a)winehq.org> a écrit : De: Alexandre Julliard <julliard(a)winehq.org> Objet: Re: [08/10] wined3d: Use FBOs for offscreen rendering by default. À: "Henri Verbeet" <hverbeet(a)codeweavers.com> Cc: wine-devel(a)winehq.org Date: Vendredi 5 Juin 2009, 14h38 Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Alexandre Julliard wrote: >> It doesn't work here: >> >> ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok >> visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests >> visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY >> visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY >> visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY >> visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY >> visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_UYVY >> visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00ffffff for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY >> visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_UYVY >> [...many more...] >> make: *** [visual.ok] Error 72 >> > Does the attached patch make it any better? Yes, that fixes it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] msi: Initialize some variables.
by Austin English 05 Jun '09

05 Jun '09

On Thu, Jun 4, 2009 at 3:12 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > diff --git a/dlls/msi/registry.c b/dlls/msi/registry.c > index 3ba34d1..f22c01f 100644 > --- a/dlls/msi/registry.c > +++ b/dlls/msi/registry.c > @@ -1822,7 +1822,7 @@ static UINT msi_check_product_patches(LPCWSTR prodcode, LPCWSTR usersid, > LPWSTR patch, LPWSTR targetprod, MSIINSTALLCONTEXT *targetctx, > LPWSTR targetsid, DWORD *sidsize, LPWSTR *transforms) > { > - MSIPATCHSTATE state; > + MSIPATCHSTATE state = MSIPATCHSTATE_INVALID; > LPWSTR ptr, patches = NULL; > HKEY prod, patchkey = 0; > HKEY localprod = 0, localpatch = 0; > diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c > index a9eef76..3263ec1 100644 > --- a/dlls/msi/tests/package.c > +++ b/dlls/msi/tests/package.c > @@ -939,6 +939,7 @@ static void test_settargetpath(void) > sz = sizeof tempdir - 1; > r = MsiGetTargetPath( hpkg, "TARGETDIR", tempdir, &sz ); > sprintf( file, "%srootfile.txt", tempdir ); > + buffer[0] = 0; > query_file_path( hpkg, "[#RootFile]", buffer ); > ok( r == ERROR_SUCCESS, "failed to get target path: %d\n", r); > ok( !lstrcmp(buffer, file), "Expected %s, got %s\n", file, buffer ); > @@ -11057,8 +11058,8 @@ static void test_access(void) > > static void test_emptypackage(void) > { > - MSIHANDLE hpkg, hdb, hsuminfo; > - MSIHANDLE hview, hrec; > + MSIHANDLE hpkg = 0, hdb = 0, hsuminfo = 0; > + MSIHANDLE hview = 0, hrec = 0; > MSICONDITION condition; > CHAR buffer[MAX_PATH]; > DWORD size; > > > Howdy Hans, One of your recent msi patches (I suspect this one), causes several hundred failures/succeeding todo's on my previously passing box. Could you have a look: http://test.winehq.org/data/1a0a47d60c337ca096c26da291adf82e49770f34/wine_a… -- -Austin

2 2