June 2009 - Wine-devel - list.winehq.org

wine question
by Anna Rogov 03 Jun '09

03 Jun '09

Dear Sir, I am trying to call Win32 Dll (that is built in VS 2003) from C++ Linux application ( in Ubuntu ) through wine shared object without rebuild the application with wine. I'll be glad if you can help me with this task. Looking forward for hearing from you, Thank you, Best Regards, Anna Udolovitch ( Papernova ), Cel.: 972-544-910623

1 0

Re: jscript: Fix parse_double_literal implementation
by Alexandre Julliard 03 Jun '09

03 Jun '09

Piotr Caban <piotr.caban(a)gmail.com> writes: > @@ -382,13 +383,23 @@ static int parse_double_literal(parser_ctx_t *ctx, LONG int_part, literal_t **li > } > > d = int_part; > - while(ctx->ptr < ctx->end && isdigitW(*ctx->ptr)) > - d = d*10 + *(ctx->ptr++) - '0'; > + while(ctx->ptr < ctx->end && isdigitW(*ctx->ptr)) { > + hlp = d*10 + *(ctx->ptr++) - '0'; > + if(d > LLONG_MAX/10 || hlp<0) > + exp++; > + else > + d = hlp; > + } LLONG_MAX is not portable, you'll have to provide your own definition. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mlang/tests: [Patch 4] Add tests for LcidToRfc1766
by Paul Vriens 03 Jun '09

03 Jun '09

Detlef Riekenberg wrote: > > > ------------------------------------------------------------------------ > > Hi Detlef, This patch introduces test failures on what seems: - all Win95 boxes - some Win98 boxes - some W2K boxes See: http://test.winehq.org/data/tests/mlang:mlang.html There is one XP both with a lot of failures in this test but not because of these newly added ones. Could you have a look? -- Cheers, Paul.

1 0

Re: jscript: Added NAN definition (1/10)
by Alexandre Julliard 03 Jun '09

03 Jun '09

Piotr Caban <piotr.caban(a)gmail.com> writes: > diff --git a/dlls/jscript/jscript_main.c b/dlls/jscript/jscript_main.c > index 37266e5..740bb06 100644 > --- a/dlls/jscript/jscript_main.c > +++ b/dlls/jscript/jscript_main.c > @@ -38,6 +38,21 @@ static const CLSID CLSID_JScriptAuthor = > static const CLSID CLSID_JScriptEncode = > {0xf414c262,0x6ac0,0x11cf,{0xb6,0xd1,0x00,0xaa,0x00,0xbb,0xbb,0x58}}; > > +#ifndef NAN > +DOUBLE NAN; > + > +static inline void set_jsnan(void) > +{ > + VARIANT v; > + V_UI8(&v) = (ULONGLONG)0x7ff80000<<32; > + NAN = V_R8(&v); > +} > +#else > +static inline void set_jsnan(void) > +{ > +} > +#endif > + > DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > > static HINSTANCE jscript_hinstance; > @@ -110,6 +125,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) > return FALSE; /* prefer native version */ > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls(hInstDLL); > + set_jsnan(); > jscript_hinstance = hInstDLL; > break; The previous implementation was better, having to explicitly initialize the constant on startup is ugly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Tests passing on one more platform!
by Dan Kegel 03 Jun '09

03 Jun '09

I just had a look at http://test.winehq.org and it seems that as of a couple days ago, a Win2000 machine has started passing all the tests! That's three OSs now: Win2000, Win2003, and WinXP. (Not all systems with those OSs pass the tests, but still, having even one box per OS pass them is a nice milestone.) Congratulations and thanks to all the people (notably Paul Vriens and of course Alexandre) who have been cleaning up the tests! - Dan

3 2

Extending winemenubuilder to create Application Bundles on OS X
by Steven Edwards 03 Jun '09

03 Jun '09

Hi, Recently I've been doing a lot of hacking on my local tree for OS X projects. The lack of support in winemenubuilder to generate application bundles for installed applications from ShellLinks like we do for FreeDesktop items has been killing me. I've just been building simple wrapper scripts which is fine but very ugly. I've recently spoken with Sveinbjorn Thordarson who wrote the Platypus App Bundler (which is a very kick-ass utility) and he has allowed me to use his code under LGPL to extend winemenubuilder. Some nice things about Platypus is that while its written in Objective C, its very modular and already has an optional cli interface. I'm pretty sure I can isolate out all of the stuff we don't need in short order and extend winemenubuilder a bit with its code as a reference. I'm going to file a detailed bug report describing how we need to extend winemenubuilder, what application bundles are, and what else we will need. If anyone is interested in jumping in and helping, we still need to do conversion from *.ico to a *.icns icons which requires a bit of hacking. Currently I'm doing something like the following 1. hacked winemenubuilder converts and export the icon (*.ico file) to png 2. convert from png to tiff sips -s format tiff [png file] --out [(converted file).tiff] 3. Convert tiff to icns tiff2icns -noLarge [tiff file] [icns file] I kind of doubt Alexandre will want a patch doing all of this conversion for simple icons and I'm sure someone has to have documented icns somewhere. The iPhone App bundles seem to support *.png icons but from my reading it does not seem that standard OS X applications do. Maybe this will change in Snow Leopard, I've tried to hack my test bundles and make them use normal png images without much luck. If your interested in helping, researching this and if needed, adding exporting the icon resources straight to icns would be a good place to start. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo ---------- Forwarded message ---------- From: Sveinbjorn Thordarson <sveinbjornt(a)simnet.is> Date: Sat, May 30, 2009 at 9:13 AM Subject: Re: Web Email Form: Developing a Platypus-lite for Wine To: winehacker(a)gmail.com Hello there, I would be happy to relicense parts of the Platypus code under the LGPL. Please feel free to use it as you like under those terms. All the best, Sveinbjorn Thordarson On 30 May 2009, at 04:22, winehacker(a)gmail.com wrote: > Hi, > I am writing because I am wondering if you would be willing to relicense some code I might need under the LGPL. > > I am interested in adding support to Wine's menubuilding application which creates FreeDesktop menus and desktop launchers under Linux for Windows based applications. Currently it parses either a *.lnk or a given executable to generate a *.desktop file for use under Gnome or KDE. When running Wine under OS X, it for the most part sucks because we cannot generate menus of any type. I'd like to take platypus, rip out everything I don't need and just use parts of it in winemenubuilder. > > The only problem is Wine is LGPL and your project is GPL. Since I know NOTHING of Obj-C and am new to OS X development in general your tool would save me a lot of time as a frame of reference but I do not wish to violate your copyright in any way. > > Would it be acceptable for me to use parts of your code under the LGPL in this fashion? > > Thanks > Steven >

1 0

Re: gdiplus: Add test cases for GdipDrawCurve
by Vincent Povirk 03 Jun '09

03 Jun '09

+ /* make a graphics object and pen object */ + status = GdipCreateFromHDC(hdc, &graphics); + expect(Ok, status); + ok(hdc != NULL, "Expected HDC to be initialized\n"); + + status = GdipCreateFromHDC(hdc, &graphics); + expect(Ok, status); + ok(graphics != NULL, "Expected graphics to be initialized\n"); You're creating two graphics objects here and leaking the first one. Vincent Povirk On Tue, Jun 2, 2009 at 10:39 PM, Andrew Eikum<andrew(a)brightnightgames.com> wrote: > Tested on WinXP Professional SP3 and Win7 Ultimate RC1, all pass. > > --- > dlls/gdiplus/tests/graphics.c | 64 +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 64 insertions(+), 0 deletions(-) > > > >

3 2

Re: (resend) [1/2] kernel32/tests: Add tests for CreateFile errors and opening volumes
by Alexandre Julliard 02 Jun '09

02 Jun '09

Guy Albertelli <galberte(a)neo.rr.com> writes: > + hFile = CreateFileA( filename, GENERIC_READ | GENERIC_WRITE, > + FILE_SHARE_READ | FILE_SHARE_WRITE, > + NULL, OPEN_EXISTING, > + p[i].options, NULL ); > + if (p[i].todo_flag) > + todo_wine ok((hFile == INVALID_HANDLE_VALUE && p[i].err == GetLastError()) || > + (hFile != INVALID_HANDLE_VALUE && p[i].err == ERROR_SUCCESS), > + "CreateFileA failed on %s, hFile %p, err=%u, should be %u\n", > + filename, hFile, GetLastError(), p[i].err); > + else > + ok((hFile == INVALID_HANDLE_VALUE && p[i].err == GetLastError()) || > + (hFile != INVALID_HANDLE_VALUE && p[i].err == ERROR_SUCCESS), > + "CreateFileA failed on %s, hFile %p, err=%u, should be %u\n", > + filename, hFile, GetLastError(), p[i].err); You need to handle access denied errors here too. You can't assume that you can always open a drive for read/write access. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Alexandre Julliard : rpcrt4: Change the allocation of delegated stub methods so that we never need to free them .
by Steven Edwards 02 Jun '09

02 Jun '09

On Tue, Jun 2, 2009 at 9:44 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > +#define MAX_BLOCKS 64 /* 64k methods should be enough for anybody */ lol, best. comment. ever! -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

HICON Patches - Request for reviews
by Joel Holdsworth 02 Jun '09

02 Jun '09

Hi All, I've been working on alpha support in HICONs and HIMAGELISTs. This patch set includes my earlier test patch (plus modifications as per the comments), and fixes up DrawIcon, DrawIconEx and CURSORICON_CreateIconFromBMI. I've tested the test patch on 2k, XP, and Vista - but any other test platforms would be welcome, and any comments on the other 4 patches before I submit them. Best Regards Joel Holdsworth

1 0