June 2009 - Wine-devel - list.winehq.org

Re: [2/7] [wined3d] add arb_ps_np2fixup_info structure (resend)
by Stefan Dösinger 30 Jun '09

30 Jun '09

Am Monday 29 June 2009 21:41:33 schrieb Tobias Jakobi: Is there a particular reason why you reordered many elements in struct arb_ps_np2fixup_info?

3 2

Re: server/fd.c: Prevent using uninitialized pointers
by Matteo Bruni 30 Jun '09

30 Jun '09

I'm quite sure that C standards guarantee global variables are initialized to 0. 2009/6/30 Daniel Santos <javatroubadour(a)yahoo.com>: > Some pointers are getting used prior to initialization. It would appear that the current compilers are initializing them to zero or we've been lucky. > > > > > >

1 0

Fw: Re: Removing active maintainers
by James Mckenzie 30 Jun '09

30 Jun '09

Sent to Rosanne only, meant to send it to the list as a comment to this thread. James McKenzie -----Forwarded Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: Jun 29, 2009 6:36 PM >To: Rosanne DiMesio <dimesio(a)earthlink.net> >Subject: Re: Removing active maintainers > >Rosanne DiMesio <dimesio(a)earthlink.net> Subject: Re: Removing active maintainers >> >>On Mon, 29 Jun 2009 14:56:23 +0200 >>Remco <remco47(a)gmail.com> wrote: >> >>> On Mon, Jun 29, 2009 at 2:22 PM, Rosanne DiMesio<dimesio(a)earthlink.net> wrote: >>> > That would still leave the test results sitting there unprocessed for weeks, which leaves a pretty bad impression on the users who submitted them. Test results for apps without maintainers get processed by the admins within 24 hours. >>> >>> How about mailing admins after 24 hours? Maintainers are useful to >>> offload tasks of admins. If they are away for a while, admins just get >>> the mail as if there were no maintainer. If you have to remove a >>> maintainer every time he can't respond in 24 hours, you won't have >>> many left after a while. >>> >>> Remco >> >>Nobody's suggesting a 24 hour time limit for maintainers. >> >>As for emailing the admins, I know I turned off emails from the AppDB to avoid having my mailbox overwhelmed with hundreds of useless notices every day, >>and I doubt I'm the only one who did this. http://bugs.winehq.org/show_bug.cgi?id=14755 needs to be fixed first for any solution that involves emailing >>admins to be viable. > >I see several good ideas here: > >1. Maintainers should be able to mark themselves as not available. No reason should be required. >2. Admins should have the ability to suspend a maintainer for non-response. There are several reasons for not responding and most of them would be considered an emergency. >3. Any maintainer who fails, after three suspensions, to properly carry out the functions of being a maintainer, should be banned for a specific period of time, increases to a complete ban. >4. What maintainers have to do to maintain their status should be posted on the Maintainers page when you sign up and a reminder message every 90 days or so should be sent out to keep maintainers honest. >5. Maintainers should be given the option of gracefully resigning when they no longer can perform the duties of their position. > >James McKenzie > >> >>-- >>Rosanne DiMesio <dimesio(a)earthlink.net> >> >>

2 1

Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree
by Detlef Riekenberg 30 Jun '09

30 Jun '09

On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: > With this patch, they are treated like other programs, e.g., winhlp32, > and installed, so one can use: > $ wine view > and get the same effect. That parts of configure.ac are created by tools/make_makefiles tools/make_makefiles-50-# Programs that we don't want to install at all tools/make_makefiles-51-my %dont_install = tools/make_makefiles-52-( tools/make_makefiles:53: "cmdlgtst" => 1, tools/make_makefiles-54- "view" => 1, tools/make_makefiles-55- "winetest" => 1, tools/make_makefiles-56-); -- By by ... Detlef

3 3

Re: oleaut32: Build language resource files separately
by Michael Stefaniuc 30 Jun '09

30 Jun '09

Hello Nikolay, Nikolay Sivov wrote: > Michael Stefaniuc wrote: >> instead of including them from an other rc file. >> --- >> > What is the purpose of these changes? I'm not talking it's wring :), > just interested. Well, Alexandre did the first patch for programs/clock http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342… so it must be right ;). It increases the resilience as errors in one language rc file do not propagate to the other languages. There might be some other reason but I forgot. Alexandre asked me if I could do it as it is an easy search and replace style janitorial job. bye michael

4 5

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.
by Paul Vriens 30 Jun '09

30 Jun '09

Huw Davies wrote: > --- > dlls/gdi32/tests/metafile.c | 80 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 80 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, Could you use CreateEnhMetaFileA here: + SetRect(&rc, 1000,2000, 3000, 6000); + emf_dc = CreateEnhMetaFileW(display_dc, NULL, &rc, NULL); The W-version is not implemented on Win9x so this test would crash. -- Cheers, Paul.

2 1

Removing active maintainers
by Joerg-Cyril.Hoehle＠t-systems.com 30 Jun '09

30 Jun '09

Hi, so far I found that Remco made the best suggestions. >From a quality of service point of view, unmaintained apps provide a more pleasing experience to the test data submiter: data is generally accepted within a fraction of a day. Not so for maintained apps. Why? Simple: there's a (large?) pool of general admins, so response time is low. OTOH, what response time can you expect from a single maintainer? My suggestion variant is: Delegate submissions after no more than 3 days from the maintainer to the general pool. Or what Remco suggested: accept by default pool, still notify maintainers so they can edit it afterwards. Easy to understand; easy to implement; best response time. Why look elsewhere? Find something else for removing people who volunteered(!) to maintain something. E.g. I'll be on vacation for 3 weeks, I'll never leave a ~/.vacation to please spammers, so I find the "8day response or be kicked" pretty tough. Regards, Jörg Höhle

1 0

Re: gdiplus: implement horizontal alignment in GdipDrawString
by Vincent Povirk 29 Jun '09

29 Jun '09

Whoops, forgot to check that format is not NULL. Don't commit this. Vincent Povirk On Mon, Jun 29, 2009 at 4:39 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > > > >

1 0

Remove FIXME keyword from bugzilla
by Austin English 29 Jun '09

29 Jun '09

It serves no purpose, after all, 'FIXME's are not bugs'. -- -Austin

2 1

Re: appwiz.cpl: updated French translation
by Paul Vriens 29 Jun '09

29 Jun '09

Frédéric Delanoy wrote: > Some adaptation to English dialog too: "Add/Remove" button was renamed to "Remove", since its only purpose is to uninstall apps. > > > ------------------------------------------------------------------------ > > Hi Frédéric But the message clear says "or to modify its installed components". So I guess a more appropriate text on the button would be "Modify/Remove" (or something alike). -- Cheers, Paul.

4 5