June 2009 - Wine-devel - list.winehq.org

Direct3D Shader
by MD.IMAM HOSSAIN 29 Jun '09

29 Jun '09

Dear Developers, Is there any possibilities to use nVidia Cg Library for Wine's Direct3D pixel and vertex shader. It will help Linux Intel On Board Graphics Card owners. Because nVidia's Cg support all graphics card. best regards, MD. IMAM HOSSAIN

1 0

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by Dmitry Timoshkov 29 Jun '09

29 Jun '09

"Christoph von Wittich" <Christoph(a)ApiViewer.de> wrote: > When you would have a look at the winetests you would have noticed two > failures about passing in negative values... Which winetests should I look at? The WideCharToMultiByte ones? Then the patch is wrong. That's unusual to expect that somebody reads your mind. -- Dmitry.

1 0

Re: user32: GetTitleBarInfo: Handle hwnd and tbi when passing NULL (try 3)
by Frédéric Delanoy 29 Jun '09

29 Jun '09

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo <...> > > Andras Kovacs Not so problematic, but you can simplify 'if (IsWindow(hwnd) == FALSE)' with 'if (! IsWindow(hwnd))' Frédéric

1 0

XI2 DirectInput/RawInput/WH_*_LL hooks
by Paul TBBle Hampson 28 Jun '09

28 Jun '09

I've been thinking about the XI2 a fair bit since the last time we discussed it on the mailing list, and a few things have come to mind, which I think need sanity checking before I explore any harder. I'm assuming we want one X11 connection turning XI2 events into WH_*_LL events, RawInput events, and DirectInput events, simply because WH_*_LL events are actually sent out by wineserver to all processes, so we only want one of those per XI2 event. This leads me to retaining the current WH_*_LL-based implementation of DI, but with cursor management and control (ie all the stuff Exclusive mode brings to the table) handling via a graphics driver hook or similar. However, the mechanism for feeding the XI2 events to the wineserver as WH_*_LL events is a little tricky. XI2 events need their own thread and hence X connection, as we cannot rely on a WinMain loop hitting X11DRV_MsgWaitForMultipleObjectsEx in a timely manner, or in fact all. The three possibilities I see are: *) Most recent foreground application catches XI2 events in its own spawned thread. Need to elect a replacement on process exit. Easiest to co-ordinate with non-XI2 hook-feeding code. *) Wineserver gains an X11 connection, for XI2 use only. This is generally bad, only here for completeness. *) A new process (ala services.exe) which grabs XI2 events from X11 via its own connection and feeds them to the wineserver. I'm inclined to think the latter one is the best option of the three, and it requires simply that the winex11.drv detect XI2 presence and if found, it disable its own WH_*_LL feeding code and spawn the XI2 process if it is not already running. It avoids the complicated coordination dance you would need for the first option to avoid losing messages. Mind you, I've been thinking this away from the codebase, so it's mostly mindwork right now. But unless I get any better suggestions or criticism, I'll prolly knock up a sample implementation of the third option next time I play with this, and see if I can get the DI keyboard interface implemented. -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Marcus Brigstocke http://www.marcusbrigstocke.com/pacman.asp License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

4 4

Re: [2/2] GetTitleBarInfo tests for NULL values
by Nikolay Sivov 28 Jun '09

28 Jun '09

Kovács András wrote: > Hi, > > GetTitleBarInfo tests for NULL values. > > > Best Regards, > > Kovács András > What about this one: --- ret = GetTitleBarInfo(NULL, NULL); --- What error code will come first?

1 0

Re: [1/2] Handle hwnd and tbi when passing NULL
by Nikolay Sivov 28 Jun '09

28 Jun '09

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs > --- TRACE("(%p %p)\n", hwnd, tbi); .... + TRACE("tbi is NULL.\n"); --- That's a duplication you don't really need. This one isn't very useful too: --- + TRACE("Invalid hwnd.\n"); ---

1 0

Re: [1/2] Handle hwnd and tbi when passing NULL
by Austin English 28 Jun '09

28 Jun '09

2009/6/28 Kovács András <andras(a)csevego.net>: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs Not a big deal, but in the future, please add the component at the beginning of your e-mail's subject, e.g.: user32: Handle hwnd and tbi when passing NULL in GetTitleBarInfo it's much easier to know what the purpose of the patch is without reading it that way (for those people that only read certain sections of the code). -- -Austin

1 0

Re: [1/1] Handle hwnd and tbi when passing NULL
by Nikolay Sivov 28 Jun '09

28 Jun '09

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs > I think IsWindow() will be enough here. Also add tests for that please.

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > Il giorno dom, 28/06/2009 alle 17.43 +0400, Nikolay Sivov ha scritto: > >> Davide Pizzetti wrote: >> >>> I've got another question: i've created some new files and translated >>> them into italian. How can i submit them as a patch? I made a git diff >>> but these files i created don't appear there >>> >>> >> As I told you. Do 'git add <new file path relative to tree>'. This will >> add it to your local repo. >> >> > i used 'git add' but i can't understand how i can submit the new files > as a patch, since i get only a diff for the list of the current > languages > Do 'git commit -a' and 'git format-patch' will do what you want after that.

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > I've got another question: i've created some new files and translated > them into italian. How can i submit them as a patch? I made a git diff > but these files i created don't appear there > As I told you. Do 'git add <new file path relative to tree>'. This will add it to your local repo.

1 0