August 2009 - Wine-devel - list.winehq.org

Re: wine.inf: Add the HKCU\Volatile Environment\APPDATA value.
by Alexandre Julliard 06 Aug '09

06 Aug '09

Andrew Nguyen <arethusa26(a)gmail.com> writes: > The VirtuaGirl installer explicitly queries for the APPDATA value > under HKCU\Volatile Environment. This most likely needs to be a volatile key created at startup. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Latency as of yesterday
by Susan Cragin 06 Aug '09

06 Aug '09

Current Ubuntu sound bugs relating to wine OSS 409395. ALSA 407970 -----I got this response on the Ubuntu list------ This is probably due to a libasound2-plugins and pulseaudio/rtkit skew; the latest libasound2-plugins needs at least pulseaudio 1:0.9.16~test3 and rtkit 0.3. Karmic has an older version of pulseaudio (1:0.9.15) at the moment. -------------------------------------------------------------- After further checking I determined that the current kernel changes are supposed to make the regular kernel capable of running at real-time (right now, for outgoing sound only) by activating a switch on the regular kernel. This functionality, of course, needs pulseaudio. Despite the optimism expressed above, pulseaudio 1:0.9016~test4 and the latest rtkit did not solve my problem. Wine still has no functioning sound. Stay tuned.

1 0

Re: mshtml: Implement IHTMLStyle4 get/put textOverflow
by Alistair Leslie-Hughes 06 Aug '09

06 Aug '09

Forget this patch, missed the todo_wine "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:4A7AA9A2.9060301(a)hotmail.com... > Hi, > > Changelog: > mshtml: Implement IHTMLStyle4 get/put textOverflow > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From 4f121dd9918252af3f1a46eeb1c1826a4830d0a8 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 18 Feb 2009 22:43:39 +1100 > Subject: [PATCH] Implement IHTMLStyle4 get/put textOverflow > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/htmlstyle.c | 3 +++ > dlls/mshtml/htmlstyle.h | 1 + > dlls/mshtml/htmlstyle3.c | 18 ++++++++++++++---- > dlls/mshtml/tests/dom.c | 30 ++++++++++++++++++++++++++++++ > 4 files changed, 48 insertions(+), 4 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index f036077..82ddf58 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -111,6 +111,8 @@ static const WCHAR attrTextAlign[] = > {'t','e','x','t','-','a','l','i','g','n',0}; > static const WCHAR attrTextDecoration[] = > {'t','e','x','t','-','d','e','c','o','r','a','t','i','o','n',0}; > +static const WCHAR attrTextOverflow[] = > + {'t','e','x','t','-','o','v','e','r','f','l','o','w',0}; > static const WCHAR attrTop[] = > {'t','o','p',0}; > static const WCHAR attrVerticalAlign[] = > @@ -166,6 +168,7 @@ static const struct{ > {attrPosition, DISPID_IHTMLSTYLE2_POSITION}, > {attrTextAlign, DISPID_IHTMLSTYLE_TEXTALIGN}, > {attrTextDecoration, DISPID_IHTMLSTYLE_TEXTDECORATION}, > + {attrTextOverflow, DISPID_IHTMLSTYLE4_TEXTOVERFLOW}, > {attrTop, DISPID_IHTMLSTYLE_TOP}, > {attrVerticalAlign, DISPID_IHTMLSTYLE_VERTICALALIGN}, > {attrVisibility, DISPID_IHTMLSTYLE_VISIBILITY}, > diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h > index 307824e..b6bdcab 100644 > --- a/dlls/mshtml/htmlstyle.h > +++ b/dlls/mshtml/htmlstyle.h > @@ -73,6 +73,7 @@ typedef enum { > STYLEID_POSITION, > STYLEID_TEXT_ALIGN, > STYLEID_TEXT_DECORATION, > + STYLEID_TEXT_OVERFLOW, > STYLEID_TOP, > STYLEID_VERTICAL_ALIGN, > STYLEID_VISIBILITY, > diff --git a/dlls/mshtml/htmlstyle3.c b/dlls/mshtml/htmlstyle3.c > index 505e91e..84b914b 100644 > --- a/dlls/mshtml/htmlstyle3.c > +++ b/dlls/mshtml/htmlstyle3.c > @@ -399,15 +399,25 @@ static HRESULT WINAPI HTMLStyle4_Invoke(IHTMLStyle4 > *iface, DISPID dispIdMember, > static HRESULT WINAPI HTMLStyle4_put_textOverflow(IHTMLStyle4 *iface, BSTR > v) > { > HTMLStyle *This = HTMLSTYLE4_THIS(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); > - return E_NOTIMPL; > + static const WCHAR styleEllipsis[] = > {'e','l','l','i','p','s','i','s',0}; > + static const WCHAR styleClip[] = {'c','l','i','p',0}; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + > + /* textOverflow can only be one of the following */ > + if(!v || strcmpiW(styleEllipsis, v) == 0 || strcmpiW(styleClip, v) > == 0) > + { > + return set_nsstyle_attr(This->nsstyle, STYLEID_TEXT_OVERFLOW, v, > 0); > + } > + > + return E_INVALIDARG; > } > > static HRESULT WINAPI HTMLStyle4_get_textOverflow(IHTMLStyle4 *iface, BSTR > *p) > { > HTMLStyle *This = HTMLSTYLE4_THIS(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, p); > + return get_nsstyle_attr(This->nsstyle, STYLEID_TEXT_OVERFLOW, p); > } > > static HRESULT WINAPI HTMLStyle4_put_minHeight(IHTMLStyle4 *iface, VARIANT > v) > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 4846848..1d283e4 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -2654,6 +2654,8 @@ static void test_style4(IHTMLStyle4 *style4) > HRESULT hres; > VARIANT v; > VARIANT vdefault; > + BSTR sdefault; > + BSTR str; > > hres = IHTMLStyle4_get_minHeight(style4, &vdefault); > ok(hres == S_OK, "get_minHeight failed: %08x\n", hres); > @@ -2672,6 +2674,34 @@ static void test_style4(IHTMLStyle4 *style4) > hres = IHTMLStyle4_put_minHeight(style4, vdefault); > ok(hres == S_OK, "put_minHeight failed: %08x\n", hres); > VariantClear(&vdefault); > + > + /* textOverflow */ > + hres = IHTMLStyle4_get_textOverflow(style4, &sdefault); > + ok(hres == S_OK, "get_minHeight failed: %08x\n", hres); > + > + str = a2bstr("invalid"); > + hres = IHTMLStyle4_put_textOverflow(style4, str); > + ok(hres == E_INVALIDARG, "put_textOverflow passed: %08x\n", hres); > + SysFreeString(str); > + > + str = a2bstr("ellipsis"); > + hres = IHTMLStyle4_put_textOverflow(style4, str); > + ok(hres == S_OK, "put_textOverflow failed: %08x\n", hres); > + SysFreeString(str); > + > + str = a2bstr("clip"); > + hres = IHTMLStyle4_put_textOverflow(style4, str); > + ok(hres == S_OK, "put_textOverflow failed: %08x\n", hres); > + SysFreeString(str); > + > + hres = IHTMLStyle4_get_textOverflow(style4, &str); > + ok(hres == S_OK, "get_textOverflow failed: %08x\n", hres); > + todo_wine ok( !strcmp_wa(str, "clip"), "expect clip got (%s)\n", > dbgstr_w(str)); > + SysFreeString(str); > + > + hres = IHTMLStyle4_put_textOverflow(style4, sdefault); > + ok(hres == S_OK, "put_textOverflow failed: %08x\n", hres); > + SysFreeString(sdefault); > } > > static void test_default_style(IHTMLStyle *style) > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Re: [7/8] WineD3D: Catch invalid getDC calls in d3d9
by Henri Verbeet 06 Aug '09

06 Aug '09

I don't feel very strong about this, but perhaps this should be handled by the format info table (in combination with the create flag).

2 2

Re: gdi32: Fix the type of a few return values.
by Michael Stefaniuc 06 Aug '09

06 Aug '09

Hello Andrew, Andrew Nguyen wrote: > It does not make sense to return a boolean for a pointer type. > diff --git a/dlls/gdi32/opengl.c b/dlls/gdi32/opengl.c > index 022fc2c..204fc2b 100644 > --- a/dlls/gdi32/opengl.c > +++ b/dlls/gdi32/opengl.c > @@ -168,7 +168,7 @@ static HDC WINAPI wglGetPbufferDCARB(void *pbuffer) > > TRACE("(%p)\n", pbuffer); > > - if (!dc) return FALSE; > + if (!dc) return 0; > > /* The display driver has to do the rest of the work because > * we need access to lowlevel datatypes which we can't access here > @@ -338,7 +338,7 @@ PROC WINAPI wglGetProcAddress(LPCSTR func) > > /* Retrieve the global hDC to get access to the driver. */ > dc = OPENGL_GetDefaultDC(); > - if (!dc) return FALSE; > + if (!dc) return NULL; > > if (!dc->funcs->pwglGetProcAddress) FIXME(" :stub\n"); > else ret = dc->funcs->pwglGetProcAddress(func); any reason why you use both "0" and "NULL" to represent a null pointer? For consistency sake just pick one. thanks bye michael

1 0

Re: [Bug 19522] Team Fortress 2 (TF2) missing menu fonts
by Vitaliy Margolen 06 Aug '09

06 Aug '09

> --- Comment #3 from Alexandre Julliard <julliard at winehq.org> 2009-08-04 13:19:16 --- > Please don't suggest that people use the --enable-maintainer-mode flag, that's > not meant for normal users. > Then how can we be sure user have all requirements installed? --verbose doesn't complain about everything which makes it kind of useless. Vitaliy.

2 1

Re: [4/8] WineD3D: Set the default psizemin in d3d8, avoid the version check
by Henri Verbeet 06 Aug '09

06 Aug '09

I think the create flags would be more robust here.

1 0

Re: [3/8] WineD3D: Get rid of a version check
by Henri Verbeet 06 Aug '09

06 Aug '09

2009/8/5 Stefan Dösinger <stefan(a)codeweavers.com>: > +void fixup_caps(WINED3DCAPS *pWineCaps) > +{ > + /* D3D8 doesn't support SM 2.0 or higher, so clamp to 1.x */ > + if(pWineCaps->PixelShaderVersion > D3DPS_VERSION(1,4)){ > + pWineCaps->PixelShaderVersion = D3DPS_VERSION(1,4); > + } > + if(pWineCaps->VertexShaderVersion > D3DVS_VERSION(1,1)){ > + pWineCaps->VertexShaderVersion = D3DVS_VERSION(1,1); > + } > + pWineCaps->MaxVertexShaderConst = min(D3D8_MAX_VERTEX_SHADER_CONSTANTF, pWineCaps->MaxVertexShaderConst); > + > + pWineCaps->StencilCaps &= ~WINED3DSTENCILCAPS_TWOSIDED; > +} Please use proper white space and naming conventions. I could live with the missing space between the control statement and the brace, if you really prefer that, but at least put *some* sort of whitespace between the closing brace and the accolade. And "pWineCaps" is just horrible.

1 0

Re: Interesting find with cppcheck..
by chris ahrendt 06 Aug '09

06 Aug '09

Austin English wrote: > On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang<juan.lang(a)gmail.com> wrote: > >>> If the group wants I can run this daily when I run wine test as well.. >>> and post it here.... just let me know >>> >> Probably not. Most of the remaining leaks are in the tests or the >> tools. Since these are short-lived programs, the leaks will get >> plugged as soon as the programs end anyway. The only exception is the >> ntdll one, and it only happens when ntdll can't connect to the >> wineserver, and the process is dying anyway. >> > > Still wouldn't hurt to fix them. > > It may not be worth running daily, but perhaps weekly and see if > anything new pops up. > > Ok will run it weekly then on fridays or want me to do it on major release's? chris

3 2

Latency as of yesterday
by Susan Cragin 06 Aug '09

06 Aug '09

I got a new kernel and a new git yesterday. One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. 2.6.31-5-generic is the new kernel. Just for "fun" I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. Susan (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.)

3 2